September 2025 - Wine-gitlab

Re: [PATCH v4 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Nikolay Sivov (＠nsivov) 15 Sep '25

15 Sep '25

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > + ok(attr_out != NULL, "removeAttributeNode expected to set attr_out, but got NULL pointer\n"); > +} > + if (attr_out) > + { > + /* remove the same attribute again returns invalid arg */ > + hr = IXMLDOMElement_removeAttributeNode( element, attr, NULL ); > + ok(hr == E_INVALIDARG, "removeAttributeNode removed an already removed node, unexpected hr %#lx.\n", hr); > + > + /* readd removed attribute to recover previous state */ > + hr = IXMLDOMElement_setAttributeNode(element, attr_out, NULL); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + IXMLDOMAttribute_Release(attr_out); > + } > + IXMLDOMAttribute_Release(attr); > + } Please get rid of this nesting, no need to check for nulls for something that's not expected to be null. The 'attr_out' check should stay of course, until it's implemented in wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115883

1 0

[PATCH 0/1] MR8973: winex11.drv: Remove a no longer valid assert().
by Dmitry Timoshkov (＠dmitry) 15 Sep '25

15 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8973

2 1

[PATCH 0/5] MR8394: Draft: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński 15 Sep '25

15 Sep '25

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

2 16

[PATCH 0/3] MR8972: win32u: Validate the drawable surface window before reusing.
by Rémi Bernon 15 Sep '25

15 Sep '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58491 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8972

1 3

[PATCH v3 0/1] MR8971: make_unicode: Add some halfwidth mapping exceptions.
by Bernhard Kölbl 15 Sep '25

15 Sep '25

The nls files need regeneration, in order to get the test working. -- v3: make_unicode: Add some halfwidth mapping exceptions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8971

1 3

[PATCH v12 0/5] MR8890: windows.devices.enumeration: Add support for parsing AQS filter strings.
by Vibhav Pant (＠vibhavp) 15 Sep '25

15 Sep '25

-- v12: maintainers: Add a section for Windows.Devices.Enumeration. windows.devices.enumeration: Support parsing AQS filters in IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. https://gitlab.winehq.org/wine/wine/-/merge_requests/8890

2 7

[PATCH v9 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Maotong Zhang (＠xiaotong) 15 Sep '25

15 Sep '25

If the read ProgID only has a CurVer key and no CLSID key, it will directly return CO_E_CCLASSSTRING, causing the program to fail to continue running. Add the key value for finding CurVer. -- v9: combase:clsid_from_string_reg() add read of CurVer key value. ole32/tests:add the find CurVer test in CLSIDFromProgID. https://gitlab.winehq.org/wine/wine/-/merge_requests/7539

3 4

[PATCH v2 0/1] MR8971: make_unicode: Add some halfwidth mapping exceptions.
by Bernhard Kölbl 15 Sep '25

15 Sep '25

Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> -- v2: make_unicode: Add some halfwidth mapping exceptions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8971

2 3

[PATCH v6 0/5] MR8862: mmdevapi/tests: Rewrite capturing tests, part 1/4.
by Giovanni Mascellani (＠giomasce) 15 Sep '25

15 Sep '25

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916) and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- v6: mmdevapi/tests: Check that the received packet isn't larger than the padding. mmdevapi/tests: Check that GetBuffer() returns a packet of the expected size. mmdevapi/tests: Check that GetBuffer() fails when no packet is available. mmdevapi/tests: Introduce a helper to read many packets when capturing. https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

3 7

Re: [PATCH v5 0/4] MR8941: nsi: Explicitly add loopback entries to ipv4 forward table on Linux. - approved
by Huw Davies (＠huw) 15 Sep '25

15 Sep '25

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8941

1 0