- Wine-gitlab - list.winehq.org

[PATCH v3 0/11] MR9520: VMR7 fixes
by Matteo Bruni (＠Mystral) 04 Dec '25

04 Dec '25

For Resident Evil 2 Classic. These are relatively small and simple patches, but I can certainly cut at 5 or so for a first MR. -- v3: quartz/tests: Add some VMR7 tests for unsupported formats. quartz/tests: Test VMR7 AllocateSurface with a BITMAPV4HEADER. quartz/tests: Test allocating BI_BITFIELDS pixel format. quartz/tests: Test allocating a surface with different bit depth from the primary. quartz/vmr7: Validate BITMAPINFOHEADER size. quartz/vmr7: Create a ddraw object if necessary to check for FourCC support. quartz/vmr7: Reject unsupported FOURCC formats. quartz/vmr7: Implement IVMRSurfaceAllocatorNotify::SetDDrawDevice(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9520

4 13

[PATCH v2 0/2] MR9571: winegstreamer: Implement media_object_Get{Input,Output}CurrentType.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

-- v2: winegstreamer: Implement media_object_Get{Input,Output}CurrentType. mf/tests: Test Get{Input,Output}CurrentType. https://gitlab.winehq.org/wine/wine/-/merge_requests/9571

4 9

[PATCH 0/1] MR9669: winegstreamer: Fix SetOutputType of the wma decoder DMO.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

In 60d5afc914e6e5aaee96022834a7f0d5f6a38e94 I moved transform creation to before the decoder->output_type is set, resulting in the decoder trying to create wg_transform with an empty type. bug introduced in !9570. 😖 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9669

4 3

[PATCH v14 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v14: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 7

[PATCH 0/1] MR9648: dlls/wmp: Implement the OLEIVERB_SHOW needed by the software Alldup
by pan hui (＠panhui) 04 Dec '25

04 Dec '25

The software "Alldup" uses OLEIVERB_SHOW, but OLEIVERB_SHOW is not implemented in oleobj.c, resulting in errors when running the Alldup via Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9648

3 2

[PATCH v13 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v13: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolhelp32Snapshot if possible. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. kernel32: Fix CreateToolhelp32Snapshot on old WoW64. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Handle ERROR_BAD_LENGTH from CreateToolhelp32Snapshot. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 8

[PATCH v12 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v12: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 9

[PATCH v11 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 04 Dec '25

04 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v11: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

3 17

[PATCH 0/1] MR9673: dlls/sane.ds: Workaround for LineArt mode in some SANE backends
by Bernd Herd (＠herdsoft) 04 Dec '25

04 Dec '25

If value for bytes_per_line is not reasonable in 1 bit per pixel mode, calculate a new value. The sane backend for the HP Officejet Pro 8600 N911a printer/scanner is has the bug that it specified a wrong value for the number of bytes per scan line in lineart mode (1 bit per pixel). Debugging seems to indicate that the faulty value is coming from the firmware of that 11 years old printer/scanner device. Some Sane frontends ignore the bytes_per_line values. This who use it do not work with that device, notable when scanning with Libreoffice Writer. So the problem is obviously caused by the sane backend, not by the sane.ds code. This merge requests offers a workaround by calculating a new value from the scan width in pixels if the given value is not plausible. This makes scanning in LineArt mode possible for that device. It is unclear if any other devices are also effected. It is unclear if the wine project wants to add workrounds like this to the code base, so I see it as a proposal for a discussion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9673

3 3

[PATCH v10 0/4] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) 04 Dec '25

04 Dec '25

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- v10: dlls/twaindsm: Recursively search in C:\Windows\twain_xx for installed data sources dlls/twaindsm: Add DG_CONTROL/DAT_CALLBACKx/MSG_REGISTER_CALLBACK to support TWAIN 2.x protocol https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

3 5