- Wine-gitlab - list.winehq.org

[PATCH v8 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Florian Kübler 20 Oct '22

20 Oct '22

This change is adding DWARF (CFI) unwind information to the hand-written assembly of the `__wine_syscall_dispatcher` function. This enables unwinding through the dispatcher from the Linux stack into (and through) the Windows stack. The general idea is that the `syscall_frame` struct contains the content of the callee-save registers before the function call (in particular the stack pointer and the return address). At any point of the execution, we have a pointer into the `syscall_frame` in $rcx, $rbp or $rsp. For the CFI codes the general idea is that we are defining the computations of the callee-save registers based on the `syscall_frame` using DWARF’s `breg` instruction, rather than relative to CFA. This change adds a bunch of convenience macros, to (hopefully) improve readability of the CFI instructions. Note: Those change was used with great success for unwinding through the dispatcher using a modified LLDB shown in the [“how-wine-works-101”](https://werat.dev/blog/how-wine-works-101/) blog post as well as for in the [Orbit profiler](https://github.com/google/orbit), that has mixed-callstack unwinding support. Test: Inspect callstacks reported by the Orbit profiler while running some Windows targets using the modified wine, as well as verify debugging reports correct callstacks when stepping with our modified LLDB through the dispatcher itself (so that we are able to unwind through the dispatcher at any instruction). -- v8: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64) https://gitlab.winehq.org/wine/wine/-/merge_requests/1065

3 8

[PATCH 0/1] MR1055: gdi32: Don't stackoverflow if substitute doesn't change anything
by Fabian Maurer (＠DarkShadow44) 20 Oct '22

20 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53787 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1055

5 13

[PATCH v3 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Ziqing Hui (＠zhui) 20 Oct '22

20 Oct '22

More font links are added to avoid issues related to missing font links. Data comes from: https://testbot.winehq.org/JobDetails.pl?Key=125079 Test program in the tests above: [font_link_reg.c](/uploads/9d4a722450f0dd88344a2b098770aaa0/font_link_reg.c) -- v3: win32u: Add font links for MS Gothic. win32u: Add font links for MingLiU. win32u: Add font links for Microsoft JhengHei. win32u: Add locale_dependent member to struct system_link_reg. https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

4 6

[PATCH 0/1] MR1113: include: Add _putenv_s.
by Alex Henrie (＠alexhenrie) 20 Oct '22

20 Oct '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

4 3

[PATCH 0/3] MR1118: tests: Add dummy flaky test count.
by Rémi Bernon 20 Oct '22

20 Oct '22

Fixes "Use of uninitialized value $Flaky" message in testbot reports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1118

1 3

[PATCH 0/1] MR1092: nls: Explicitly specify locales that use native digits.
by Nikolay Sivov (＠nsivov) 20 Oct '22

20 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53770 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1092

4 4

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > + len = link_reg->link_jp_len; > + break; > + case 936: > + link = link_reg->link_sc; > + len = link_reg->link_sc_len; > + break; > + case 949: > + link = link_reg->link_kr; > + len = link_reg->link_kr_len; > + break; > + case 950: > + link = link_reg->link_tc; > + len = link_reg->link_tc_len; > + break; > + default: > + break; You should be able to remove the `default` label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11470

1 0

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > { > const struct system_link_reg *link_reg = &default_system_link[i]; > > - switch (ansi_cp.CodePage) > + link = link_reg->link_non_cjk; > + len = link_reg->link_non_cjk_len; > + > + if ((link_reg->locale_related)) You shouldn't need the inner brackets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11469

1 0

Re: [PATCH v2 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Huw Davies (＠huw) 20 Oct '22

20 Oct '22

Huw Davies (@huw) commented about dlls/win32u/font.c: > static const struct system_link_reg > { > const WCHAR *font_name; > + BOOL locale_related; How about `locale_dependent` ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11468

1 0

[PATCH 0/4] MR1103: shell32: Remove strdupW function.
by Alex Henrie (＠alexhenrie) 20 Oct '22

20 Oct '22

I was really confused about whether strdupW or wcsdup is preferred in shell32. Since strdupW is deprecated, let's just get rid of it so that no one else has to wonder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1103

4 6