- Wine-gitlab - list.winehq.org

[PATCH v4 0/5] MR30: hlsl: Texture and UAV loads.
by Zebediah Figura (＠zfigura) 19 Oct '22

19 Oct '22

-- v4: vkd3d-shader/hlsl: Parse UAV types. vkd3d-shader/hlsl: Parse texture index expressions. vkd3d-shader/hlsl: Cast array indices inside of add_array_load(). tests: Add a basic shader test for typed UAV loads. tests: Add a basic shader test for compute shaders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/30

3 6

[PATCH v5 0/4] MR1090: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 19 Oct '22

19 Oct '22

_mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbctolowe… More information about application crash: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v5: msvcrt: Add _mbsupr_s_l partial implementation. msvcrt: Add _mbslwr_s_l partial implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

3 5

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:37 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9163_9194) Done in v3 of the patch for the tests. Should be in the next version of the implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11313

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Tue Oct 18 10:04:56 2022 +0000, Matteo Bruni wrote: > This should presumably copy data to an offset inside "raw", right? > Actually, this poses an issue with preserving the existing contents over > the part that's skipped over. It does. In the current version of patch 1, I just take the returned pointer and add the offset to it. Writing far enough will cause a C0000005 under win10, so I don't bother checking the returned pointer anymore. (I haven't submitted that version yet because I need to finish fixing the current test failures on it. And I will need to amend the commit to do so.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11312

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:28 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_8977_8977) Done in v3 of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11311

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Tue Oct 18 10:04:58 2022 +0000, Matteo Bruni wrote: > Can you reorder the fields such that the values to set are all at the > start and the expected values all at the end? E.g.: > ```suggestion:-10+0 > struct test_set_raw_data_value > { > const char *param_name; > D3DXPARAMETER_TYPE param_type; > const void *data; > unsigned int data_size; > unsigned int offset; > HRESULT expected_hr; > const void *expected_data; > unsigned int expected_data_size; > }; > ``` Done in v3 of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11310

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:31 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9024_9004) Converted the index to decimal in v3 of the patch. (Also fixed the log messages.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11309

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Tue Oct 18 10:05:01 2022 +0000, Matteo Bruni wrote: > You forgot to increment the "byte" pointer, you're only printing the > first byte. > BTW, I'd just get rid of this function and related machinery entirely. > The hex prints do the job just fine. Fixed the increment. Thanks for pointing it out, I was running in circles trying to fix the SetRawValue() implementation because of that. I'll remove the function in the final version of the patch. (It's helpful to me while working on it.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11308

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:39 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9173_9199) Done in v3 of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11307

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:41 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9180_9216) Done in v3 of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11306

1 0