- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 10 Jul '22

10 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/ntdll/tests/pipe.c: > Sleep(100); > memset(&iosb, 0x55, sizeof(iosb)); > res = pNtCancelSynchronousIoFile(thread, NULL, &iosb); > - todo_wine { > ok(res == STATUS_SUCCESS, "Failed to cancel I/O\n"); > ok(U(iosb).Status == STATUS_SUCCESS, "iosb.Status got changed to %lx\n", U(iosb).Status); > ok(U(iosb).Information == 0, "iosb.Information got changed to %Iu\n", U(iosb).Information); > - CloseHandle(ctx.pipe); > WaitForSingleObject(thread, INFINITE); > CloseHandle(thread); > + CloseHandle(ctx.pipe); Any reason why the call to `CloseHandle` is being moved? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3837

1 0

[PATCH 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) 09 Jul '22

09 Jul '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414

2 3

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 09 Jul '22

09 Jul '22

@julliard does this look ok? there anything i should change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3831

1 0

[PATCH 0/4] MR413: ntoskrnl: Enumerate child devices on a separate thread.
by Zebediah Figura (＠zfigura) 09 Jul '22

09 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/413

2 4

[PATCH 0/1] MR412: wineusb.sys: Fix memory leak on control transfer.
by Jinoh Kang (＠iamahuman) 09 Jul '22

09 Jul '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/412

3 5

[PATCH v8 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo (#53289).
by Jinoh Kang (＠iamahuman) 09 Jul '22

09 Jul '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo. https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 2

[PATCH v2 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.
by Piotr Caban (＠piotr) 09 Jul '22

09 Jul '22

On macOS si_code is always set to TRAP_BRKPT. -- v2: ntdll: Fix x64 single step exception detection on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/408

3 2

[PATCH 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.
by Piotr Caban (＠piotr) 09 Jul '22

09 Jul '22

On macOS si_code is always set to TRAP_BRKPT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/408

3 3

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Paul Gofman (＠gofman) 09 Jul '22

09 Jul '22

Thanks for all the detailed comments. But I suppose before going into these details and improving the neats it would be great to hear from Zebediah or Alexandre if this MR is a go in principle. As it is not apparent to me from the initial Zeb's comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3817

1 0

Re: [PATCH 0/4] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Jinoh Kang (＠iamahuman) 09 Jul '22

09 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/socket.c: > wait_handle = wine_server_ptr_handle( reply->wait ); > options = reply->options; > nonblocking = reply->nonblocking; > + fixup_type = reply->fixup_type; > } > SERVER_END_REQ; > > + if (fixup_type == SOCK_PROT_FIXUP_ICMP_OVER_DGRAM && async->count > + && (!status || status == STATUS_ALERTED || status == STATUS_PENDING)) We can just write `!NT_ERROR(status)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_3813

1 0