- Wine-gitlab - list.winehq.org

[PATCH 0/3] MR10047: winemac, winewayland, winex11: Register clipboard format with NtUserRegisterWindowMessage.
by Rémi Bernon (＠rbernon) 07 Feb '26

07 Feb '26

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10047

2 3

[PATCH v4 0/33] MR9928: Draft: dsound: Speed up resampling.
by Anton Baskanov (＠baskanov) 07 Feb '26

07 Feb '26

This implements a number of optimizations, in particular: - Swapping around the resampling loops in case of downsampling, allowing the FIR step to stay fixed regardless of the resampling ratio. - Rearranging the FIR array elements to make the access sequential. - Adding SSE versions of the resampling functions. Together, these amount to more than a 5x reduction of `cp_fields_resample` execution time. The quality of the resampling should be the same, or even improve slightly, due to a more precise `rem` calculation and removal of the FIR step rounding, although I haven't yet conducted any measurements. -- v4: dsound: Get all channel samples in one go. dsound: Put all channel samples in one go. dsound: Get rid of get_aux and call the functions directly. dsound: Get rid of put_aux and call the functions directly. dsound: Add a 32-bit AVX+FMA3 version of downsample. dsound: Add a 32-bit AVX+FMA3 version of upsample. dsound: Add a 32-bit SSE version of downsample. dsound: Add a 32-bit SSE version of upsample. dsound: Use #define for fir.h contants. dsound: Use a 0.32 fixed point number to represent the resampling ratio. dsound: Replace multiplications by fir_step and fir_width with bit shifts. dsound: Premultiply the input value by firgain and the interpolation weights in downsample. dsound: Transpose the FIR array to make the element access sequential. dsound: Calculate firgain more accurately. dsound: Calculate required_input more accurately. dsound: Swap around the two nested loops in downsample. dsound: Don't invert the remainder twice in upsample. dsound: Use a fixed upsampling loop boundary. dsound: Don't pass dsbfirstep to upsample. dsound: Don't apply firgain in upsample. dsound: Split resample into separate downsample and upsample functions. dsound: Factor out resampling. dsound: Remove asserts from the resampling loop. dsound: Resample into a temporary buffer. dsound: Resample one channel at a time. dsound: Get rid of fir_copy. dsound: Use signed int to calculate indices during resampling. dsound: Multiply by dsbfirstep after calculating the modulus. dsound: Use the modulus operator instead of divide-multiply-subtract. dsound: Do the subtraction before converting to float to improve rem precision. dsound: Don't use double-precision arithmetic in the resampler. dsound: Remove the unused freqneeded field. dsound: Use a better FIR filter generated with Parks-McClellan algorithm. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/9928

2 3

[PATCH 0/2] MR9597: Iphlpapi: Implement GetOwnerModuleFromTcpEntry, GetOwnerModuleFromTcp6Entry.
by Paul Gofman (＠gofman) 07 Feb '26

07 Feb '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9597

3 3

[PATCH v3 0/4] MR9756: mmdevapi: Allow querying I{Simple,Channel}AudioVolume from IAudioSessionControl.
by Matteo Bruni (＠Mystral) 07 Feb '26

07 Feb '26

Ancillary MR for !9755. -- v3: mmdevapi: Add some session_wrapper traces. mmdevapi: Add some traces around session retrieval. mmdevapi: Allow querying I{Simple,Channel}AudioVolume from IAudioSessionControl. https://gitlab.winehq.org/wine/wine/-/merge_requests/9756

3 6

[PATCH v2 0/1] MR10022: gdiplus: Allow GdipBitmapLockBits without read/write flags.
by Bernhard Übelacker (＠bernhardu) 07 Feb '26

07 Feb '26

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59362 [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161700) -- v2: gdiplus: Allow GdipBitmapLockBits without read/write flags. https://gitlab.winehq.org/wine/wine/-/merge_requests/10022

2 1

[PATCH v4 0/3] MR9915: mmedvapi: Device name changes.
by Bernhard Kölbl (＠besentv) 07 Feb '26

07 Feb '26

The test in the last commit would still need an implementation, which turned out to be more complicated than the possible benefits. -- v4: mmdevapi: Adjust device names. https://gitlab.winehq.org/wine/wine/-/merge_requests/9915

4 6

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + if (system_lang_id != LANG_ENGLISH) > + { > + winetest_skip("Skipping font family tests on non English setups\n"); > + return; > + } > + > + hdc = GetDC(NULL); > + > + memset(&lf, 0, sizeof(lf)); > + > + for (i = 0; i < ARRAY_SIZE(td); ++i) > + { > + lf.lfPitchAndFamily = td[i].family; > + lf.lfHeight = td[i].font_height; > + lf.lfCharSet = td[i].charset; > + hfont = NULL; Unnecessary initialisation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129010

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + hfont = CreateFontIndirectW(&lf); > + ok(!!hfont, "Failed to create font.\n"); > + > + old = SelectObject(hdc, hfont); > + > + memset(&metric, 0, sizeof(metric)); > + GetTextMetricsW(hdc, &metric); > + > + todo_wine_if(td[i].todo) ok((metric.tmPitchAndFamily & 0x70) == (td[i].family & 0x70), > + "got unexpected font family %2x, needed %2x\n", metric.tmPitchAndFamily & 0x70, td[i].family & 0x70); > + > + memset(font_name, 0, sizeof(font_name)); > + GetTextFaceW(hdc, ARRAY_SIZE(font_name), font_name); > + > + todo_wine ok(!wcscmp(font_name, td[i].expected_font), > + "Got unexpected font %s for height %lu, expected %s\n", debugstr_w(font_name), td[i].font_height, debugstr_w(td[i].expected_font)); What's going on here? Why is this always failing with Wine? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129012

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + { > + lf.lfPitchAndFamily = td[i].family; > + lf.lfHeight = td[i].font_height; > + lf.lfCharSet = td[i].charset; > + hfont = NULL; > + > + hfont = CreateFontIndirectW(&lf); > + ok(!!hfont, "Failed to create font.\n"); > + > + old = SelectObject(hdc, hfont); > + > + memset(&metric, 0, sizeof(metric)); > + GetTextMetricsW(hdc, &metric); > + > + todo_wine_if(td[i].todo) ok((metric.tmPitchAndFamily & 0x70) == (td[i].family & 0x70), > + "got unexpected font family %2x, needed %2x\n", metric.tmPitchAndFamily & 0x70, td[i].family & 0x70); Does the returned tmPitchAndFamily have the high bit set at all? It would be nicer to just mask that with `0xf0`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129011

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/win32u/font.c: > { > const char * const *defaults; > > - if ((pitch_and_family & FIXED_PITCH) || (pitch_and_family & 0xf0) == FF_MODERN) > + if ((pitch_and_family & FIXED_PITCH) || (pitch_and_family & FF_MODERN) == FF_MODERN) This doesn't look right. The `FF_` constants are not bit-fields. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129013

1 0