http://bugs.winehq.org/show_bug.cgi?id=60156 --- Comment #15 from Wehrwolfmann <wehrwolfmann@gmail.com> --- (In reply to Rafał Mużyło from comment #10) The counters are pointless, you're right -- nothing ever reads the values. source_count is dead weight outright: render_ret only ever becomes a failure code when there was an output pin to render in the first place, so "if (!rendered && FAILED(render_ret))" says the same thing with a single flag. I'll cut both counters. On the semantics I did mean "at least one", though. Without AMMSF_RENDERALLSTREAMS the pins go through RenderEx with AM_RENDEREX_RENDERTOEXISTINGRENDERERS, so a pin that has no matching renderer already in the graph is supposed to fail -- that is the ordinary case for a file carrying streams the application never asked for. Failing the whole call there would break OpenFile for exactly the files this is meant to fix. The old code leaned the same way: it mapped VFW_S_PARTIAL_RENDER to S_OK. Where your question does bite is AMMSF_RENDERALLSTREAMS. There the application is asking for everything, so a pin that fails to connect is arguably a real failure and should surface. I have not tested that against Windows and no test covers it, so I left the behaviour alone rather than guess. Happy to pin it down if you think it is worth it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.