http://bugs.winehq.org/show_bug.cgi?id=59928 --- Comment #21 from Renzo de Paoli <depaoli.renzo@gmail.com> --- (In reply to Bernhard Übelacker from comment #20) Good morning Bernhard. There are 2 aspects here - testing to confirm the confirm the root cause, and - the patching to bug fix 1) (In reply to Bernhard Übelacker from comment #20)
As far as I understand, the 59928-workaround.patch affects just the two functions that cause gcc-mingw to crash during compilation. The regression test confirms that 508a30f0d3 is where things started to go wrong.
But there might be - other problems masked by it - knock-on effects/dependencies I tested the reverse application of 508a30f0d3 with the latest Wine 11.12 and did not see either, but it would be good to have another confirmation. 2) (In reply to Bernhard Übelacker from comment #20)
Reverting 508a30f0d3 affects the whole 32-bit build, with not emmiting sse2 instructions for all binaries. Correct, but as said, I am not proposing reverting 508a30f0d3 as a solution right now. (It is worth noting though that going by the check-in note of 508a30f0d3 it apparently isn't addressing any particular problem/bug/performance issue.)
For a bug fix, I think there is the matter of coding guidelines/standards for Wine? Is it permitted to have compiler checks and settings in source code or should those be handled by the configure script(s)? Thanks Bernhard. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.