[Bug 33634] [UWIN] simple ls -l from the UWIN gives a lot of warnings

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=33634

--- Comment #11 from Janne <[e-mail]> ---
Created attachment 81673
  --> http://bugs.winehq.org/attachment.cgi?id=81673
netapi32 patch

Hello,

In the UWIN source code, there is a location that can get caught in an infinite
loop when running on Wine:
https://github.com/att/uwin/blob/master/src/uwin/serv/ums.c#L771

I created a test application to confirm this issue.

Test app behavior on Windows:
> sha1sum NQDI_tst.exe
> 76fd1fa2e2571c69f0b2e3ea4ff85ac52a574966 *NQDI_tst.exe
> ./NQDI_tst.exe
> Calling NetQueryDisplayInformation with dwIndex:0
> dwResult=0 dwIndex=0 dwEntriesRead=5 userinfo:18965112
> usri1_name[0]:DefaultAccount
> usri1_next_index[0]:1
> usri1_name[1]:Admin
> usri1_next_index[1]:2
> usri1_name[2]:test
> usri1_next_index[2]:3
> usri1_name[3]:Guest
> usri1_next_index[3]:4
> usri1_name[4]:WDAGUtilityAccount
> usri1_next_index[4]:5
> Calling NetQueryDisplayInformation with dwIndex:5
> dwResult=0 dwIndex=5 dwEntriesRead=0 userinfo:0
> over

Test app behavior on unpatched Wine:
> sha1sum NQDI_tst.exe 
> 76fd1fa2e2571c69f0b2e3ea4ff85ac52a574966  NQDI_tst.exe
> wine NQDI_tst.exe 
> Calling NetQueryDisplayInformation with dwIndex:0
> 0024:fixme:netapi32:NetQueryDisplayInformation Level 1 partially implemented
> dwResult=0 dwIndex=0 dwEntriesRead=3 userinfo:2465464
> usri1_name[0]:test
> usri1_next_index[0]:0
> usri1_name[1]:Administrator
> usri1_next_index[1]:0
> usri1_name[2]:Guest
> usri1_next_index[2]:0
> Calling NetQueryDisplayInformation with dwIndex:0
> 0024:fixme:netapi32:NetQueryDisplayInformation Level 1 partially implemented
> dwResult=0 dwIndex=0 dwEntriesRead=3 userinfo:2465464
> usri1_name[0]:test
> usri1_next_index[0]:0
> usri1_name[1]:Administrator
> usri1_next_index[1]:0
> usri1_name[2]:Guest
> usri1_next_index[2]:0
> Calling NetQueryDisplayInformation with dwIndex:0
> 0024:fixme:netapi32:NetQueryDisplayInformation Level 1 partially implemented
> dwResult=0 dwIndex=0 dwEntriesRead=3 userinfo:2465464
> ....

I created a patch that sets usri1_next_index correctly and 
check if given Index is greater or equal to record count if it is function
returns zero/null. 

With the patch applied, the test app output is:
> sha1sum NQDI_tst.exe 
> 76fd1fa2e2571c69f0b2e3ea4ff85ac52a574966  NQDI_tst.exe
> ~/wine11.12_win32/wine NQDI_tst.exe 
> Calling NetQueryDisplayInformation with dwIndex:0
> 0024:fixme:netapi32:NetQueryDisplayInformation Level 1 partially implemented
> dwResult=0 dwIndex=0 dwEntriesRead=3 userinfo:2465544
> usri1_name[0]:test
> usri1_next_index[0]:1
> usri1_name[1]:Administrator
> usri1_next_index[1]:2
> usri1_name[2]:Guest
> usri1_next_index[2]:3
> Calling NetQueryDisplayInformation with dwIndex:3
> dwResult=0 dwIndex=3 dwEntriesRead=0 userinfo:0
> over

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.