http://bugs.winehq.org/show_bug.cgi?id=59436 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com --- Comment #4 from Stian Low <wineryyyyy@gmail.com> --- Unable to reproduce for wine-11.9-68dd9ef2cb5 for latest trial version Roon downloaded for Windows 10 via: https://roon.app/en/downloads Please advise how to launch because the window currently has issues opening to confirm the bug. winetricks needed to workaround other bugs? renderer=vulkan rendering too dark seems related to this bug (renderer=gl too bright): https://bugs.winehq.org/show_bug.cgi?id=45364#c14 Merge request for that bug is still under development pending more tests but patch includes call to glDisable(GL_FRAMEBUFFER_SRGB) which was necessary to fix gl graphics rendering too bright after fixing bug causing vk to render too dark. diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 4c20587b81d..d2f540c547e 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -645,8 +645,10 @@ static void swapchain_gl_present(struct wined3d_swapchain *swapchain, wined3d_texture_load_location(back_buffer, 0, context, back_buffer->resource.draw_binding); - swapchain_blit(swapchain, context, src_rect, dst_rect); + if (gl_info->supported[ARB_FRAMEBUFFER_SRGB]) + gl_info->gl_ops.gl.p_glDisable(GL_FRAMEBUFFER_SRGB); Next patch push will include a better placed call to glDisable(GL_FRAMEBUFFER_SRGB) per @hverbeet suggestion: https://gitlab.winehq.org/wine/wine/-/merge_requests/10567/#note_139947 diff --git a/dlls/wined3d/texture_gl.c b/dlls/wined3d/texture_gl.c index 311ee954c23..68a731f3710 100644 --- a/dlls/wined3d/texture_gl.c +++ b/dlls/wined3d/texture_gl.c @@ -913,6 +913,12 @@ static void texture2d_blt_fbo(struct wined3d_device *device, struct wined3d_cont gl_info->gl_ops.gl.p_glDisable(GL_SCISSOR_TEST); context_invalidate_state(context, STATE_RASTERIZER); + if (gl_info->supported[ARB_FRAMEBUFFER_SRGB]) + { + gl_info->gl_ops.gl.p_glDisable(GL_FRAMEBUFFER_SRGB); + context_invalidate_state(context, STATE_SHADER(WINED3D_SHADER_TYPE_PIXEL)); + } + Unclear if Roon uses d3d as rendering backend until I'm able to launch but if so then Frostpunk bug/patch which also includes calls to glDisable(GL_FRAMEBUFFER_SRGB) may be related to this bug/patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.