http://bugs.winehq.org/show_bug.cgi?id=55198 --- Comment #7 from Dmitry Timoshkov <dmitry@baikal.ru> --- (In reply to Alex Henrie from comment #4)
6135b38d7d60e7bceb36a57630cad72d3e7e4b2e is the first bad commit commit 6135b38d7d60e7bceb36a57630cad72d3e7e4b2e Author: Zebediah Figura <z.figura12@gmail.com> Date: Tue Jul 10 12:08:46 2018 +0200
msi: Avoid connecting to the RPC server more than once.
The commit has changed how the rpc_handle is released. Before this commit __wine_msi_call_dll_function() managed creation/destruction of the rpc_handle on its entry/return. Now releasing rpc_handle is done in MSI_FreePackage(), and it's the source of this bug. When "Finish" button is pressed the installer executes "QBPostFinishDlgActions" action which calls MsiInstallProductA("SupportSoftAssistedService.msi", ""), this leads to calling MSI_OpenPackageW()/msiobj_release(), and in turn this destroys rpc_handle and effectively breaks any further RPC calls from the custom action handler. Probably releasing rpc_handle should be moved from MSI_FreePackage() to a different place. I'd propose reverting the offending commit, however it mentions nested custom actions, and that would break them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.