[Bug 60474] New: shell32: IShellLinkDataList::RemoveDataBlock is a stub (E_NOTIMPL)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60474

            Bug ID: 60474
           Summary: shell32: IShellLinkDataList::RemoveDataBlock is a stub
                    (E_NOTIMPL)
           Product: Wine
           Version: 11.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
  Target Milestone: ---
      Distribution: Debian

Symptom:
Programs that build a shortcut through IShellLink and then remove one of its
data blocks fail with "The method or operation is not implemented" (.NET:
NotImplementedException from IShellLinkDataList.RemoveDataBlock).

Affected application: 
   CODESYS V3.5 SP22 Patch 4. 
   PackageManagerCLI.exe (3.5.22.40

Description:
When package installer (PackageManagerCLI.exe) creates "Start menu" links for
Executables from add-on packages, it's calling RemoveDataBlock(EXP_SZ_ICON_SIG)
on each link. The package installation stops at the first link, or without
--cancelOnException. The links are not created.

On Windows IShellLinkDataList::RemoveDataBlock removes the extra data block
with the given signature from the link (S_FALSE when there is none). In WINE it
returns E_NOTIMPL.

Trace (WINEDEBUG=fixme+shell):

fixme:shell:ShellLink_RemoveDataBlock (...)->(2684354567): stub

2684354567 = 0xA0000007 (EXP_SZ_ICON_SIG).

Code: dlls/shell32/shelllink.c

Additional information, fix
   See: https://github.com/Re-CODESYS/codesys-wine for details.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60474] shell32: IShellLinkDataList::RemoveDataBlock is a stub (E_NOTIMPL)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60474

--- Comment #1 from Peter Popovics <[e-mail]> ---
Created attachment 82305
  --> http://bugs.winehq.org/attachment.cgi?id=82305
Installer log

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60474] shell32: IShellLinkDataList::RemoveDataBlock is a stub (E_NOTIMPL)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60474

--- Comment #2 from Peter Popovics <[e-mail]> ---
Created attachment 82345
  --> http://bugs.winehq.org/attachment.cgi?id=82345
Self-checking test, source (0BSD)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60474] shell32: IShellLinkDataList::RemoveDataBlock is a stub (E_NOTIMPL)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60474

--- Comment #3 from Peter Popovics <[e-mail]> ---
Created attachment 82346
  --> http://bugs.winehq.org/attachment.cgi?id=82346
Test package: source, exe, Windows 11 and wine-devel 11.19 logs, SHA256SUMS

As CODESYS installation and check requires way more effort than the bug
fix/improvement itself, please consider the attached test application.
Windows 11: 16 passed, 0 failed - wine-devel 11.19: 7 failed (see the logs in
the package).

Correction to my report: on Windows 11, RemoveDataBlock on a block that is not
present returns S_OK, not S_FALSE.

Thanks in advance for your kind efforts, 
P.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.