[Bug 44382] New: Overcooked: Right shift is detected as left shift instead

https://bugs.winehq.org/show_bug.cgi?id=44382

            Bug ID: 44382
           Summary: Overcooked: Right shift is detected as left shift
                    instead
           Product: Wine
           Version: 3.0-rc6
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winemac.drv
          Assignee: wine-bugs(a)winehq.org
          Reporter: paradigmsort(a)gmail.com

Created attachment 60304
  --> https://bugs.winehq.org/attachment.cgi?id=60304
wine stdout and stderr

In the Steam version of Overcooked, pressing right shift is interpreted as left
shift instead.

$ gsha1sum ~/.wine/drive_c/Program\
Files/Steam/steamapps/common/Overcooked/Overcooked.exe 
23c37601e4b4a85b3e8fb6dc74393693dd805137 
/Users/paradigmsort/.wine/drive_c/Program
Files/Steam/steamapps/common/Overcooked/Overcooked.exe

This occurs with built-in Macbook Pro 2015 keyboard, as well as with both
external USB keyboards I own.

Right shift is registered correctly in mac application on my system.

I reproduced with both devel 3.0-rc6 and stable 3.0.

Left shift is also reported as right shift in other windows applications, for
example this simple key press display app:
http://www.dcmembers.com/skrommel/download/showoff/#
$ gsha1sum ShowOff.exe 
3357fa8259c79d4fcdfa7c14309edefe6622a074  ShowOff.exe

It does NOT occur (in either application) when I set the key "graphics"
HKCU/Software/Wine/Drivers to "x11" and use X11 graphics instead.

I don't believe this is a duplicate of 33142; that was about right shift key
having no functionality at all (and is from 2013 and a very old version of
wine).

Running MacOS Sierra 10.12.6

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44382] Overcooked: Right shift is detected as left shift instead

https://bugs.winehq.org/show_bug.cgi?id=44382

--- Comment #1 from paradigmsort(a)gmail.com ---
As additional data: with 

WINEDEBUG=trace+key

I see the following with the winemac.drv when I press right shift:

0037:trace:key:macdrv_send_keyboard_input hwnd 0x60060 vkey=00a1 scan=0036
flags=0000

With winex11.drv I see instead:

0009:trace:key:X11DRV_send_keyboard_input hwnd 0x30066 vkey=00a1 scan=0036
flags=0001


ie. x11 is setting the KEYEVENTF_EXTENDEDKEY flag, whereas mac is not

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44382] Overcooked: Right shift is detected as left shift instead

https://bugs.winehq.org/show_bug.cgi?id=44382

paradigmsort(a)gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paradigmsort(a)gmail.com

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44382] Overcooked: Right shift is detected as left shift instead

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=44382

marie jeong <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from marie jeong <[e-mail]> ---
still happening with crossover 26.3 on macOS 26, and i think i found why.

the server picks VK_LSHIFT vs VK_RSHIFT purely from KEYEVENTF_EXTENDEDKEY
(server/queue.c, queue_keyboard_message). winemac's default_map has
kVK_RightShift as plain 0x36, so right shift never gets the extended flag
and GetKeyState/GetAsyncKeyState report it as VK_LSHIFT. the WM_KEYDOWN
lParam is fine (scan 0x36), which is probably why some apps work and
others don't.

winex11 hit the exact same thing this summer (bug 59980), fixed by
reporting right shift as extended again (!11467). looks like winemac just
never got the same change.

i tested by changing that table entry to 0x36 | 0x100 (same as right
control / right command already do). with a tiny test app, right shift
now shows up as VK_RSHIFT in both GetKeyState and GetAsyncKeyState, left
shift is unchanged, and EZ2ON REBOOT : R (unity + rewired, uses lshift /
rshift for tab switching) works fine now.

one thing: like !11479 on the x11 side, GetKeyNameText(0x00360000)
probably needs a tweak so plain 0x36 still maps to "Right Shift".

happy to open an MR if that helps.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.