[Bug 52128] New: Hog4PC 3.17 installer VBScript custom action wants scrrun:filesys_MoveFolder implementation
https://bugs.winehq.org/show_bug.cgi?id=52128 Bug ID: 52128 Summary: Hog4PC 3.17 installer VBScript custom action wants scrrun:filesys_MoveFolder implementation Product: Wine Version: 6.22 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: scrrun Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, as it says. --- snip --- $ wine msiexec -i Hog_4_PC_3.17.0.3327.msi ... 0184:trace:scrrun:filesys_FolderExists 0362A084 L"C:\\users\\focht\\AppData\\Roaming" 02F0F970 ... 0184:fixme:scrrun:filesys_MoveFolder 0362A084 L"C:\\users\\focht\\AppData\\Roaming" L"C:\\users\\focht\\AppData\\Roaming" ... 0184:err:msi:MsiActiveScriptSite_OnScriptError script error: L"Object doesn't support this action" ... 0184:trace:msi:ScriptThread custom action (184) returned 1603 --- snip --- VBScript custom action scriptlet: --- snip --- Function renamePersistentDir() Dim appDataEnv appDataEnv = shell.expandEnvironmentStrings("%APPDATA%") Dim roamingDir roamingDir = appDataEnv + "\Flying Pig Systems" If ( fso.FolderExists(roamingDir) ) Then fso.MoveFolder roamingDir, appDataEnv + "\High End Systems" fso.MoveFolder appDataEnv + "\High End Systems\Hog 4PC", appDataEnv + "\High End Systems\Hog 4 PC" End If End Function --- snip --- Wine source: https://source.winehq.org/git/wine.git/blob/f03933fbb73152c7a54383fba411a611... --- snip --- 3616 static HRESULT WINAPI filesys_MoveFolder(IFileSystem3 *iface,BSTR Source, 3617 BSTR Destination) 3618 { 3619 FIXME("%p %s %s\n", iface, debugstr_w(Source), debugstr_w(Destination)); 3620 3621 return E_NOTIMPL; 3622 } --- snip --- Stable download link via Internet Archive: https://web.archive.org/web/20211128125004/https://cdn.etcconnect.com/Hog_4_... $ sha1sum Hog_4_PC_3.17.0.3327.msi.zip f98421bbbb0590df0e65ac18903471dd5fb61b6a Hog_4_PC_3.17.0.3327.msi.zip $ du -sh Hog_4_PC_3.17.0.3327.msi.zip 361M Hog_4_PC_3.17.0.3327.msi.zip $ sha1sum Hog_4_PC_3.17.0.3327.msi 0d22bf13c5a9bb682820ee6f690a866c1b320d9b Hog_4_PC_3.17.0.3327.msi $ wine --version wine-6.22-204-gf03933fbb73 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52128 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://web.archive.org/web | |/20211128125004/https://cdn | |.etcconnect.com/Hog_4_PC_3. | |17.0.3327.msi.zip Summary|Hog4PC 3.17 installer |Hog4PC 3.17 installer |VBScript custom action |VBScript custom action |wants |needs |scrrun:filesys_MoveFolder |scrrun:filesys_MoveFolder |implementation |implementation Keywords| |download, Installer -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52128 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sloper42(a)yahoo.com --- Comment #1 from Robert Wilhelm <sloper42(a)yahoo.com> --- Created attachment 71213 --> https://bugs.winehq.org/attachment.cgi?id=71213 Implement filesys_MoveFolder -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52128 temp82(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |temp82(a)luukku.com --- Comment #2 from temp82(a)luukku.com --- this bug might already be fixed. https://gitlab.winehq.org/wine/wine/-/merge_requests/343/diffs?commit_id=91a... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52128 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #3 from Robert Wilhelm <sloper42(a)yahoo.com> --- Updated patches are in https://gitlab.winehq.org/wine/wine/-/merge_requests/391 But currently they are not yet approved and therefore not merged to main branch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52128 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |53542 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52128 Matthijs Kooijman <matthijs(a)stdin.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthijs(a)stdin.nl --- Comment #4 from Matthijs Kooijman <matthijs(a)stdin.nl> --- I've also seen the same issue with Hog4 PC 3.21.2, running on wine 9.0. The installer also hangs, not sure if it is related to this issue. Also, I saw there is a new MR addressing this: https://gitlab.winehq.org/wine/wine/-/merge_requests/9104 The PR was actually merged a week ago, so hopefully this will be fixed in the next wine release. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52128 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ff187dc851c1d9f992049688a7e | |7190b83250ae4 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Robert Wilhelm <sloper42(a)yahoo.com> --- After patch was merged, know there no more script error in installer and it seems installer is successful. I am not sure wether software actually works, as the exe files want to open hardlock driver to check for copy protection dongle. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52128 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52128 --- Comment #7 from Matthijs Kooijman <matthijs@stdin.nl> --- I just tried wine 11.0 (Ubuntu package from upstream) with Hog_4_PC_3.21.2.3662.msi and can confirm that this issue is indeed fixed. In a clean wine environment, the installer completes as expected (in an older wine environment I had, the installer would refuse because I did not have win10, fixed that with `wine winecfg -v win10` but then the installer hanged, so I switched to clean install). Actually starting Hog 4 PC after the installation does not work though (it just quits without showing any UI, without any clear error message), so I will be sticking to Windows for now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla