[Bug 59278] New: Adobe Express Photos installation fails, requires KERNEL32.dll.PackageFullNameFromId
http://bugs.winehq.org/show_bug.cgi?id=59278 Bug ID: 59278 Summary: Adobe Express Photos installation fails, requires KERNEL32.dll.PackageFullNameFromId Product: Wine Version: 11.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@list.winehq.org Reporter: asdfghrbljzmkd@outlook.com Distribution: --- ``` wine: Call from 7BD38138 to unimplemented function KERNEL32.dll.PackageFullNameFromId, aborting wine: Unimplemented function KERNEL32.dll.PackageFullNameFromId called at address 7BD38138 (thread 174c), starting debugger... ``` I'll add proper steps for install Adobe Creative Cloud in the first place soon, but basically it boils down to adding the necessary application overrides (https://gist.github.com/qwertychouskie/636ae7a2796c749dae1ba5595d722945), installing WebView2, then installing Adobe Creative Cloud. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Vijay Kamuju <infyquest@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com --- Comment #1 from Vijay Kamuju <infyquest@gmail.com> --- if you can add a simple installer which fails for packagefullnameforid, this can be implemented. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Zeb Figura <z.figura12@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com --- Comment #2 from Zeb Figura <z.figura12@gmail.com> --- (In reply to Vijay Kamuju from comment #1)
if you can add a simple installer which fails for packagefullnameforid, this can be implemented.
The name of the application is right there...? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Louis Lenders <xerox.xerox2000x@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox.xerox2000x@gmail.com --- Comment #3 from Louis Lenders <xerox.xerox2000x@gmail.com> --- It looks like this is already implemented in bleeding edge proton: https://github.com/ValveSoftware/wine/blob/bleeding-edge/dlls/kernelbase/ver... I guess author of that patch could just send it upstream? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Louis Lenders <xerox.xerox2000x@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |pgofman@codeweavers.com URL| |https://ccmdls.adobe.com/Ad | |obeProducts/StandaloneBuild | |s/ACCC/ESD/6.8.1/865/win64/ | |ACCCx6_8_1_865.zip Ever confirmed|0 |1 Keywords| |download --- Comment #4 from Louis Lenders <xerox.xerox2000x@gmail.com> --- Confirming. @Paul Gofman: Hope you don't mind I added you to this bugreport. It seems you wrote the patch for PackageFullNameFromId***. Any chance you could send this upstream? It's enough to fix this bug. ***:https://github.com/ValveSoftware/wine/blob/bleeding-edge/dlls/kernelbase/ver... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #5 from Paul Gofman <pgofman@codeweavers.com> --- (In reply to Louis Lenders from comment #4)
Confirming.
@Paul Gofman: Hope you don't mind I added you to this bugreport. It seems you wrote the patch for PackageFullNameFromId***. Any chance you could send this upstream? It's enough to fix this bug.
***:https://github.com/ValveSoftware/wine/blob/bleeding-edge/dlls/kernelbase/ version.c#L1781
The reason I so far never bothered to send those Proton patches upstream is that they were not particularly useful without real package database (i. e., those functions returning some meaningful data). That Proton patchset helps what it was made for because there is a part which hardcodes some package data for VC redists (which won't be accepted upstream). So I wonder if that patch alone helps anything (or, rather, it needs some work maintaining package database in the first place)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #6 from Vijay Kamuju <infyquest@gmail.com> --- If the patch is applied, the installer can proceed further as per the error log here. But it can fail further, which has to be checked. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #7 from Paul Gofman <pgofman@codeweavers.com> --- Sure, it will proceed somewhere further if won't crash on that stub, the question is whether it really can proceed without proper package database (i. e., the function really working) or that only turns an obvious crash into less obvious failure resulting from missing package info. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Qwerty Chouskie <asdfghrbljzmkd@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Ubuntu CC| |asdfghrbljzmkd@outlook.com Component|-unknown |kernel32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #8 from Qwerty Chouskie <asdfghrbljzmkd@outlook.com> --- (In reply to Paul Gofman from comment #5)
(In reply to Louis Lenders from comment #4)
Confirming.
@Paul Gofman: Hope you don't mind I added you to this bugreport. It seems you wrote the patch for PackageFullNameFromId***. Any chance you could send this upstream? It's enough to fix this bug.
***:https://github.com/ValveSoftware/wine/blob/bleeding-edge/dlls/kernelbase/ version.c#L1781
The reason I so far never bothered to send those Proton patches upstream is that they were not particularly useful without real package database (i. e., those functions returning some meaningful data). That Proton patchset helps what it was made for because there is a part which hardcodes some package data for VC redists (which won't be accepted upstream). So I wonder if that patch alone helps anything (or, rather, it needs some work maintaining package database in the first place)?
While I do see some hardcoded stuff around VC redists, it doesn't look like that affects PackageFullNameFromId, unless I'm missing something? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 zefkerr <zefkerrigan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zefkerrigan@gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Gijs Vermeulen <gijsvrm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adobe Express Photos |Adobe Express Photos |installation fails, |installer crashes on |requires |unimplemented function |KERNEL32.dll.PackageFullNam |KERNEL32.dll.PackageFullNam |eFromId |eFromId -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #9 from Qwerty Chouskie <asdfghrbljzmkd@outlook.com> --- (In reply to Qwerty Chouskie from comment #8)
(In reply to Paul Gofman from comment #5)
(In reply to Louis Lenders from comment #4)
Confirming.
@Paul Gofman: Hope you don't mind I added you to this bugreport. It seems you wrote the patch for PackageFullNameFromId***. Any chance you could send this upstream? It's enough to fix this bug.
***:https://github.com/ValveSoftware/wine/blob/bleeding-edge/dlls/kernelbase/ version.c#L1781
The reason I so far never bothered to send those Proton patches upstream is that they were not particularly useful without real package database (i. e., those functions returning some meaningful data). That Proton patchset helps what it was made for because there is a part which hardcodes some package data for VC redists (which won't be accepted upstream). So I wonder if that patch alone helps anything (or, rather, it needs some work maintaining package database in the first place)?
While I do see some hardcoded stuff around VC redists, it doesn't look like that affects PackageFullNameFromId, unless I'm missing something?
Alternatively, if the PackageFullNameFromId implementation can't be upstreamed, could it at least be included in Staging? The problem with relying on Proton is that it doesn't include other fixes in current upstream Wine needed for the Adobe suite to function properly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #10 from Paul Gofman <pgofman@codeweavers.com> ---
Alternatively, if the PackageFullNameFromId implementation can't be upstreamed, could it at least be included in Staging? The problem with relying on Proton is that it doesn't include other fixes in current upstream Wine needed for the Adobe suite to function properly.
The same question is probably more important for Staging than upstream, does the installer really works with that implementation in isolation? FWIW I don't think that PackageFullNameFromId can't be upstreamed or stubbed upstream, just for me personally given I don't know if it is much useful without real underlying package info implementation, it falls into rather low priority category. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Austin English <austinenglish@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Qwerty Chouskie <asdfghrbljzmkd@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |59407 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 --- Comment #13 from Qwerty Chouskie <asdfghrbljzmkd@outlook.com> --- (In reply to Qwerty Chouskie from comment #12)
However, with the patched Wine and vcrun2022 installed, Adobe Bridge is now able to install, and I believe this was originally failing with the KERNEL32.dll.PackageFullNameFromId unimplemented error. So, it definitely appears that implementing KERNEL32.dll.PackageFullNameFromId in Wine is beneficial.
Hmm, it seems I mixed up Bridge and Fresco. Bridge does *not* need PackageFullNameFromId, it installs just fine on unmodified Staging 11.2. Fresco needs PackageFullNameFromId, though with it, it fails later in the same way as Express Photos.
Implementing PackageFullNameFromId is still a step in the right direction for multiple Adobe applications, but it doesn't look like PackageFullNameFromId is the only thing needed for them to fully install.
I just opened https://bugs.winehq.org/show_bug.cgi?id=59407 for appx/appxbundle installation support, and marked this bug as a blocker (obviously it's not necessarily a blocker for all apps attempting to install a msix/msixbundle, but it certainly is for the Adobe apps that are msix/msixbundle packages). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Nikolay Sivov <bunglehead@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ef6c413c68f4c6ae877b659e866 | |4fc1c3cb04cfb Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #14 from Nikolay Sivov <bunglehead@gmail.com> --- This is partially implemented in ef6c413c68f4c6ae877b659e8664fc1c3cb04cfb. Missing part is publisher id calculation. It doesn't seem to be very useful to have at this point. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59278 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla