[Bug 60290] New: Mouse button handling regressions in several games when launched through Steam
http://bugs.winehq.org/show_bug.cgi?id=60290 Bug ID: 60290 Summary: Mouse button handling regressions in several games when launched through Steam Product: Wine Version: unspecified Hardware: x86-64 URL: https://store.steampowered.com/app/208670/Blades_of_Ti me/ OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@list.winehq.org Reporter: gyebro69@gmail.com CC: rbernon@codeweavers.com Target Milestone: --- Regression SHA1: 44a822d2374c71ee74fa8dc930b63f5a8e9ae256 Distribution: ArchLinux The regression starts with commit 44a822d2374c71ee74fa8dc930b63f5a8e9ae256 winex11: Listen to raw mouse button events on the root window. The commit causes mouse button handling regressions in at least 6 Steam games: Blades of Time: A normal left click no longer activates menu items or in-game actions. Left click only works while the right mouse button is held down. Mata Hari (point and click adventure): Clicking an inventory action/dialogue plays the click sound, but the selected action is not activated. https://store.steampowered.com/app/18480/Mata_Hari/ Hotel Collectors Edition (legacy version): Right-clicking should open the inventory at the bottom of the screen, but it now appears only momentarily and immediately closes.Only the legacy version is affected, have to select this version in Steam when launching the game. https://store.steampowered.com/app/288750/Brightstone_Mysteries_Paranormal_H... Disney Epic Mickey 2: Left click no longer works in the menu. In-game, a short right click should release one shot of paint, but after pressing the right mouse button the game behaves as if it remains held down and continuously sprays paint until the paint bucket is empty. https://store.steampowered.com/app/245300/Disney_Epic_Mickey_2__The_Power_of... STAR WARS™ Knights of the Old Republic™ I and II: A single left click on an inventory item or on an entry in the Load Game menu is interpreted as if it were a double click. As a result, the selected item or menu entry is activated immediately with just one click. https://store.steampowered.com/app/208580/STAR_WARS_Knights_of_the_Old_Repub... The regression is reproducible in both fullscreen and Wine virtual desktop mode under X11. Reverting the commit cleanly on current Wine git restores the previous mouse button behavior. Blades of Time also has a DRM-free demo available through Steam. Interestingly, the Blades of Time issue only occurs when the game is launched through Steam. If the demo executable is launched directly without Steam, mouse buttons work correctly. I also own the GOG versions of Star Wars: Knights of the Old Republic I and II. The mouse regression does NOT occur in the GOG versions. It only occurs with the Steam versions. This is similar to Blades of Time, where the mouse issue occurs when the game is launched through Steam, but not when the DRM-free demo executable is started directly without Steam. Sorry about the wall of text :\ wine-11.16-348-g9ce1651515d XFCE 4.20 X.Org X Server 1.21.1.24 Arch Linux -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #1 from Rémi Bernon <rbernon@codeweavers.com> --- Hmm, could this be the same as bug 60256? I haven't looked into this but could you check whether it's fixed already after last batch of commits? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #2 from Béla Gyebrószki <gyebro69@gmail.com> --- (In reply to Rémi Bernon from comment #1)
Hmm, could this be the same as bug 60256? I haven't looked into this but could you check whether it's fixed already after last batch of commits?
I tested with the latest Wine git available after today's commit batch (wine-11.16-348-g9ce1651515d), and the issue is still present there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #3 from Béla Gyebrószki <gyebro69@gmail.com> --- One additional note that may be relevant: I have seen very similar mouse button handling problems in Wine-Staging for at least the past two or three years. At the time, one of the Staging rawinput patches caused issues in several games, and four of the games affected by the current vanilla Wine regression were already on my notes from those tests. I did not report it back then and later I switched to vanilla Wine and forgot about the problem, since these games worked correctly there. After today's Wine git commit batch, I was surprised to see essentially the same type of mouse button problems appear in vanilla Wine in the same games. This is what prompted me to report the regression now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #4 from Rémi Bernon <rbernon@codeweavers.com> --- Created attachment 82035 --> http://bugs.winehq.org/attachment.cgi?id=82035 Fix Looks like things are badly broken indeed... multiple threads listening to raw events at the same time, which wasn't immediately apparent with raw input but it got even worse with buttons. I think the attached patch should help, it seems to fix the double clicks in SWKOTOR for me at least, not sure about the other games which I haven't tried (yet). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #5 from Béla Gyebrószki <gyebro69@gmail.com> --- (In reply to Rémi Bernon from comment #4)
Created attachment 82035 [details] Fix
Looks like things are badly broken indeed... multiple threads listening to raw events at the same time, which wasn't immediately apparent with raw input but it got even worse with buttons.
I think the attached patch should help, it seems to fix the double clicks in SWKOTOR for me at least, not sure about the other games which I haven't tried (yet). I tested the proposed patch with Wine 11.17 under XFCE/X11 on all six affected games. In normal fullscreen mode the patch fixes the mouse button regression in all six games. There is still one remaining issue with Blades of Time, but only when using Wine virtual desktop mode: If I start the Steam client inside the virtual desktop and then launch Blades of Time from Steam, the original problem is still present initially: a left click by itself does not activate menu items, and I have to hold the right mouse button while clicking the left button. However, if I Alt-Tab away from the game to the terminal and then Alt-Tab back to the game, normal single left-clicking starts working correctly and remains fixed (until restarting the game).
The same behavior is reproducible with the Blades of Time demo when launched through Steam. So the patch completely fixes the issue in fullscreen mode for all six games, but Blades of Time still seems to hit a focus/raw-input initialization issue when first launched from Steam inside a Wine virtual desktop. An Alt-Tab focus cycle fixes it for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 Béla Gyebrószki <gyebro69@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |11.17 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #6 from Béla Gyebrószki <gyebro69@gmail.com> --- Created attachment 82037 --> http://bugs.winehq.org/attachment.cgi?id=82037 screencast showing mouse button behaviour in Steam when using a VD I found another issue with the proposed patch, again only in Wine virtual desktop mode. This does not occur with unpatched vanilla Wine 11.17. Steps to reproduce: 1. Start the Steam client inside a Wine virtual desktop. 2. In the Library, single-click different game entries with the left mouse button. At this point everything works normally: one click only selects the game. 3. Click the Wine virtual desktop window title bar so that the virtual desktop window becomes active. 4. Go back to the Steam Library and single-click a game entry. After activating the virtual desktop window a single left click in Steam is interpreted as a double click. For games that are not installed, Steam immediately opens the Install dialog. I attached a video demonstrating the behavior. So the proposed patch appears to introduce a separate double-click/raw-button issue in the Steam client itself after the virtual desktop window receives focus. The issue is reproducible without launching any game. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 Rémi Bernon <rbernon@codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82035|0 |1 is obsolete| | --- Comment #7 from Rémi Bernon <rbernon@codeweavers.com> --- Created attachment 82049 --> http://bugs.winehq.org/attachment.cgi?id=82049 Possible fix Thanks, looks like it needs a bit of tweaking for the virtual desktop mode. Hopefully this updated patch should do the trick? Fwiw I have extra fixups on top of it for bug 60291, that involves issues with buttons, maybe worth checking with the patch attached to https://bugs.winehq.org/show_bug.cgi?id=60291#c3 rather than just this one. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #8 from Béla Gyebrószki <gyebro69@gmail.com> --- (In reply to Rémi Bernon from comment #7) > Created attachment 82049 [details] > Possible fix > > Thanks, looks like it needs a bit of tweaking for the virtual desktop mode. > Hopefully this updated patch should do the trick? > > Fwiw I have extra fixups on top of it for bug 60291, that involves issues > with buttons, maybe worth checking with the patch attached to > https://bugs.winehq.org/show_bug.cgi?id=60291#c3 rather than just this one. I tested the two patches separately on top of clean Wine 11.17. The updated patch attached here still leaves the two virtual desktop issues unchanged: - Blades of Time initially does not accept a normal single left click - In the Steam Library a single left click on a game is interpreted as a double click I then tested the patch attached to bug #60291c#3 instead. That patch fixes both remaining virtual desktop issues. With the patch from bug #60291 mouse button behavior is correct in all six affected games and in the Steam client in both fullscreen and virtual desktop mode. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 --- Comment #9 from Rémi Bernon <rbernon@codeweavers.com> --- Awesome, thanks for the help! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 Béla Gyebrószki <gyebro69@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |24309da4c30a57283f4779ab218 | |f5f2ecdada1e2 Resolution|--- |FIXED --- Comment #10 from Béla Gyebrószki <gyebro69@gmail.com> --- The issues reported here are completely fixed after https://gitlab.winehq.org/wine/wine/-/commit/24309da4c30a57283f4779ab218f5f2... Thank you. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60290 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla