[Bug 59980] New: Final Fantasy XI Online: Unexpected Right Shift behaviour.
http://bugs.winehq.org/show_bug.cgi?id=59980 Bug ID: 59980 Summary: Final Fantasy XI Online: Unexpected Right Shift behaviour. Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Keywords: regression Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@list.winehq.org Reporter: chiitoo@gentoo.org Target Milestone: --- Regression SHA1: b8266e743e3477968208802c8b6b73f520f91396 Distribution: Gentoo After b8266e743e3 [1], right shift gains odd behaviour in Final Fantasy XI Online. Normally when either shift is being held down with an in-game menu open, pressing the arrow keys will move the camera. Without shift, the arrow keys will change the selection of the menu. It is also possible to get the key "stuck" when trying to do this, resulting in similar behaviour to when the Caps Lock is enabled, although sometimes neither of the shift keys will have effect on the casing after this starts. Repeating the actions, at least sometimes, restore the casing and the effect of either shift on the case, but in all cases it seems to be impossible to move the camera with the right shift pressed. I have not had the chance to test this on native Windows environment yet, nor Wayland, but I'd certainly be very surprised if this was the intended behaviour. Thank you! https://gitlab.winehq.org/wine/wine/-/commit/b8266e743e3477968208802c8b6b73f... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #1 from Chiitoo <chiitoo@gentoo.org> --- As an additional note, I noticed that when I get the "stuck" behaviour, holding down a key for repeated input will sometimes result in a lower case letter, if the input is stuck in the "shift down" mode, or vice versa. That is, perhaps a few times within a second, the case is different, and holding down shift myself at this time will simply reverse case in that case. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|b8266e743e3477968208802c8b |b8266e743e3477968208802c8b6 |6b73f520f91396 |b73f520f91396 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #2 from Chiitoo <chiitoo@gentoo.org> --- Looks like after https://gitlab.winehq.org/wine/wine/-/commit/339f3c7355832a15d05144bb2fcaa46... just changing the code back to 0x131 doesn't help, though a bunches of other things changed there too so maybe that's to be expected. One thing I can see when comparing before and after on the 'key' channel: before the change (pressing down right shift) 0168:trace:key:X11DRV_KeyEvent keycode 62 converted to vkey 0x1A1 scan 36 0168:trace:key:X11DRV_send_keyboard_input hwnd 0x7002a vkey=00a1 scan=0036 flags=0001 after the change (again pressing down right shift) 0168:trace:key:X11DRV_KeyEvent keycode 62 converted to vkey 0xA1 scan 0036 0168:trace:key:X11DRV_send_keyboard_input hwnd 0x4005a vkey=00a1 scan=0036 flags=0000 So 'scan' is 36 already regardless, but 'vkey' does differ, and there is a 0001 in 'flags'. That written, the 'vkey' seems to be the same in 'send_keyboard_input', so unsure if these differences can be of any hint towards what is going on. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Chiitoo <chiitoo@gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |11.13 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Ken Sharp <imwellcushtymelike@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com --- Comment #3 from Ken Sharp <imwellcushtymelike@gmail.com> --- commit b8266e743e3477968208802c8b6b73f520f91396 Author: Matteo Bruni <mbruni@codeweavers.com> Date: Thu Jun 18 19:26:48 2026 +0200 winex11: Fix Right Shift scancode. Shortly we're going to get rid of the array entirely, but I guess having this as a separate patch is a tiny bit better for bisection. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #4 from Matteo Bruni <matteo.mystral@gmail.com> --- Thanks for the detailed bug report! If I recall, setting up this game is quite the ordeal; I'll probably ask you to test a few patches first, in case we're lucky. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #5 from Chiitoo <chiitoo@gentoo.org> --- (In reply to Matteo Bruni from comment #4)
Thanks for the detailed bug report! If I recall, setting up this game is quite the ordeal; I'll probably ask you to test a few patches first, in case we're lucky.
Indeed, the online account bureaucracy is a bit much just for testing purposes (and well, maybe outside that, too), and sometimes getting the free trial codes can be less than successful, with the only other option being paying for it... While the installation media can be downloaded for free, and the PlayOnline Viewer part (launcher of sorts) can be run without an account, I have unfortunately been unable to re-produce this there so far... but am always happy to test patches in any case! Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #6 from Matteo Bruni <matteo.mystral@gmail.com> --- Created attachment 81452 --> http://bugs.winehq.org/attachment.cgi?id=81452 Restore the extended flag for rshift I took a large and complicated detour but I eventually concluded that dropping the extended flag for right shift was probably wrong. This should restore the previous behavior; if it doesn't or if you see more keyboard-related weirdness, please attach a +pid,timestamp,keyboard,key,event,win,msg,hook,x11drv log. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #7 from Chiitoo <chiitoo@gentoo.org> --- So far I couldn't re-produce the "caps-lock behaviour", in that capitalisation worked as expected, but I still can not use the shift key with arrow keys to move the camera. Will send a log soon. It will contain my log-in credentials to the game, so will want to make sure that part is not included. :] Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #8 from Matteo Bruni <matteo.mystral@gmail.com> --- Created attachment 81506 --> http://bugs.winehq.org/attachment.cgi?id=81506 Further get rid of the extended flag for rshift Inspired by the todo we have in the tests, I've been experimenting with a bunch of changes related to right shift. This is basically going in the opposite direction vs the previous patch; try it in place of the old patch and let me know what happens. A log would be very useful. You can limit the attachment to just the tail end (making sure that it contains the part where the bug reproduces). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #9 from Matteo Bruni <matteo.mystral@gmail.com> --- (In reply to Matteo Bruni from comment #8)
Created attachment 81506 [details] Further get rid of the extended flag for rshift
Inspired by the todo we have in the tests, I've been experimenting with a bunch of changes related to right shift. This is basically going in the opposite direction vs the previous patch; try it in place of the old patch and let me know what happens.
A log would be very useful. You can limit the attachment to just the tail end (making sure that it contains the part where the bug reproduces).
JK, the code this patch is touching isn't upstream yet, please disregard. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #10 from Chiitoo <chiitoo@gentoo.org> --- Created attachment 81513 --> http://bugs.winehq.org/attachment.cgi?id=81513 log with: +pid,timestamp,keyboard,key,event,win,msg,hook,x11drv Apologies it took me a while to get back to this! Yeah, I usually use the file node trick to be able to control when to save output, especially with this application, as it takes a while to get to the game and some channels are pretty chatty... I was paranoid enough that I wanted to verify that both of the shift keys do what I think they always did in a native Windows environment still as well, and I luckily still had an installation on a drive from some other testing a few years back. Un-luckily it wasn't co-operating in that the launcher part silently crashed after the splash screen, with no hint other than a code possibly referring to access violation. What happened next with that... After removing nvidia drivers, I saw an additional reference to 'd3d10warp.dll', which I had seen in a virtual machine before, and I did the same thing as I did there, rename/remove said dll, and the application would start, albeit run very slowly. So that pointed me more towards the graphics stack, but I had not changed anything since the last time... except the monitor was different! I realised Windows was sticking to the previous monitor's resolution, which was 1440p, and this one is natively 1080p... though I did not notice anything funky. Worked right up once I set it to 1080p... after only about 6 hours since the start. Back to this issue... With the first patch, I have still been unable to see the weird things with capitalisation "sticking" and all that, but it still doesn't allow me to move the camera around while a menu is open. And indeed, I did manage to, eventually, confirm that the shift keys work the same on Windows, that is, using either of them, I can move the camera like with Wine before. Some other places where the difference pops up, are at the very launch of the game where an opening movie plays. This is skipped by pressing pretty much any key, even shift alone, but with the changes in Wine, the right shift no longer does that. It also prevents moving the selection in the title screen menus, when held down. I'll still attach the log snippet from going through right-shift-arrow-keys in a menu where it should move the camera, and with left-shift after that, in case it still might be helpful with what is being planned. Thanks again! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #11 from Matteo Bruni <matteo.mystral@gmail.com> --- Thanks for the log, unfortunately I don't see anything suspicious about right shift or the arrow keys while keeping the right shift key pressed down. Maybe a similar log from before the regression for comparison might be helpful? (In reply to Chiitoo from comment #10)
Some other places where the difference pops up, are at the very launch of the game where an opening movie plays. This is skipped by pressing pretty much any key, even shift alone, but with the changes in Wine, the right shift no longer does that.
That suggests that there is some issue with the right shift key even by itself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #12 from Chiitoo <chiitoo@gentoo.org> --- Created attachment 81522 --> http://bugs.winehq.org/attachment.cgi?id=81522 log before the regression commit Attached is a log of similar business at commit: 3f4bff72fa8edb1b72846e8a02fbebc7c4a2c521 Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #13 from Matteo Bruni <matteo.mystral@gmail.com> --- My initial patch (from attachment #81452) is now upstream as b9a96e7b142bbcafcfce60cd345820e74348e0bd, so now this is partially fixed. I'm pretty stumped about the remaining issues though, I can't find any significant difference between good and bad logs. Can you take a new log with some additional channels? Let's try +pid,process,timestamp,keyboard,key,event,win,msg,message,hook,x11drv,server this time. The log is going to get quite a bit larger, feel free to compress it as needed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #14 from Matteo Bruni <matteo.mystral@gmail.com> --- Could you please also add +imm for good measure? Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #15 from Chiitoo <chiitoo@gentoo.org> --- Can do, hopefully a bit later today (UTC). I had thought of this before, but forgot to test it out, but just did now and it seems you might be easily able to test this too to some extent because the related benchmark program https://appdb.winehq.org/objectManager.php?sClass=version&iId=4879 has a similar thing to the opening cutscene where "any key" will stop it from running, including 'shift', and indeed, right-shift does not do it there either now. Adding download links to the appdb side soon, but here's one of them: https://gdl.square-enix.com/ffxi/download/taru/FFXiB3Setup.exe A couple of other sources also here: https://www.playonline.com/ff11eu/download/media/benchmark03.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #16 from Matteo Bruni <matteo.mystral@gmail.com> --- Thanks a lot for the benchmark link! I've been having a hard time with (some?) 32-bit executables and recent-ish Wine, but I managed to run it in the end. It looks like right shift does work for me from the branch with the whole kitchen sink (i.e. all my pending patches for the rest of the keyboard layouts rework). I just confirmed that right shift doesn't terminate the cutscene for me with current Wine either, so in theory I can bisect into my branch and find out what's fixing the game - and why it's currently broken. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Matteo Bruni <matteo.mystral@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81506|0 |1 is obsolete| | --- Comment #17 from Matteo Bruni <matteo.mystral@gmail.com> --- Created attachment 81580 --> http://bugs.winehq.org/attachment.cgi?id=81580 Possible fix The benchmark was very helpful! I'm attaching a patch that fixes the benchmark for me, let me know if it works for the actual game as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #18 from Chiitoo <chiitoo@gentoo.org> --- Most excellent. Indeed, all seems good with the patch and the game as well! Funny I remember staring at that exact code block, but did not get to actually trying changing it. Many thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 --- Comment #19 from Chiitoo <chiitoo@gentoo.org> --- It seems I had missed something in my testing, and at least some of the issues are still present, but they seem to be related to a different commit, which is discussed in bug 60059 [1]. That is, the business with the weird capitalisation, which appears to have been around for quite a while longer, and unrelated to the commits discussed here. Aside from that, all is well with regards to the shift issue here, and the fix for it. 1. https://bugs.winehq.org/show_bug.cgi?id=60059 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Chiitoo <chiitoo@gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Chiitoo <chiitoo@gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://web.archive.org/web | |/20260727150955/https://www | |.playonline.com/ff11eu/down | |load/media/benchmark03.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Chiitoo <chiitoo@gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |20d8e4ec5a3e46a8cccc66e1410 | |817e94d3b05ad Resolution|--- |FIXED --- Comment #20 from Chiitoo <chiitoo@gentoo.org> --- Marking fixed per current git master. Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59980 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla