[Bug 60064] New: Wine version selected by users is ignored on resubmit
http://bugs.winehq.org/show_bug.cgi?id=60064 Bug ID: 60064 Summary: Wine version selected by users is ignored on resubmit Product: WineHQ Apps Database Version: unspecified Hardware: x86-64 URL: https://appdb.winehq.org/objectManager.php?sClass=vers ion&iId=20882&iTestingId=117598 OS: Linux Status: NEW Keywords: download, source Severity: major Priority: P2 Component: appdb-unknown Assignee: wine-bugs@list.winehq.org Reporter: imwellcushtymelike@gmail.com Target Milestone: --- Distribution: --- A user reported via IRC that his test result keeps getting rejected with "Select the correct Wine version" (or similar). The user provided a video showing that he selects the Wine version and resubmits, but the AppDB records "main" ("main" is another issue needing fixing). This reoccurs no matter how many times he resubmits. I created a new account and attempted to do the same, but it worked correctly on resubmission. I therefore do not know how to trigger this. Thanks to Hugo Osvaldo Barrera for finding this. https://appdb.winehq.org/objectManager.php?sClass=version&iId=20882&iTesting... As a admin/maintainer I can change the Wine version and accept the submission, but there is no way to know which Wine version is intended unless the user states it in the test result itself. The only option is reject and ask the user to mention the Wine version in the comments. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 Hugo Osvaldo Barrera <hugo@whynothugo.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hugo@whynothugo.nl --- Comment #1 from Hugo Osvaldo Barrera <hugo@whynothugo.nl> --- Videos of me making the submission is too large to attach here (14.1 MB). It's available at https://mirror.whynothugo.nl/t/mbiYnKZR6elr/Recording_2026-07-25_142329_.mp4 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #2 from Hugo Osvaldo Barrera <hugo@whynothugo.nl> --- Created attachment 81572 --> http://bugs.winehq.org/attachment.cgi?id=81572 Video of me picking wine 11.5 and wine-staging -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com --- Comment #3 from Stian Low <wineryyyyy@gmail.com> --- I'll take a look since it may be related my changes to AppDB to use Bugzilla for listing wine versions which was meant to help solve some site traffic issues at the time: - https://bugs.winehq.org/show_bug.cgi?id=56706 - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/13 If related then this would be the first bug reported that I'm aware of since merged a year ago. Video seems to show wine versions listed correctly for client-side which MR-13 primarily focused. Maybe something changed causing server-side validation issues and error message. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #4 from Ken Sharp <imwellcushtymelike@gmail.com> --- This is one of a myriad of bugs in the AppDB since the changes were made. The AppDB is very broken. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #5 from Stian Low <wineryyyyy@gmail.com> --- Is this a blocker and Hugo is still able to reproduce? (In reply to Ken Sharp from comment #4)
This is one of a myriad of bugs in the AppDB since the changes were made. The AppDB is very broken.
Many bugs were found while working on the merge. Those found to be unrelated by my merge were left unfixed. My goal was to help solve the traffic problems which seemed highest priority and then switch focus to wine dev vs AppDB dev whose bugs seemed better resolved via a CMS vs custom app similar to how Bugzilla supports reports and Gitlab supports devs. I'll collect AppDB bugs and report what is and is not caused by my merge. As for this bug, error message from video seems to indicate its an issue with distribution/OS vs version: Error details: Error message: Uncaught mysqli_sql_exception. Table 'appdb.distribution' doesn't exist in appdb/include/query.php:37 Stack trace: #0 appdb/include/query.php(37): mysql->query() #1 appdb/include/query.php(143): query_appdb() #2 appdb/include/distribution.php(281): query_parameters() #3 appdb/include/testData_queue.php(59): distribution->ReQueue() #4 appdb/include/objectManager.php(1435): testData_queue->reQueue() #5 appdb/objectManager.php(81): ObjectManager->processForm() #6 {main} thrown Has "Alpine Linux" shown in video been approved as a distribution yet? The only change to distribution.php by me was a removal of versions table from the query: - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/13/diffs#b4bc5b676f4... If that query did not break it then this bug may have already existed. I'll try to reproduce and retest without any of my changes to confirm. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #6 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #5)
As for this bug, error message from video seems to indicate its an issue with distribution/OS vs version:
Version "main" has been removed from Bugzilla: https://bugs.winehq.org/enter_bug.cgi?product=Wine Maybe validation is failing that checks versions submitted match Bugzilla to protect against bogus data being submitted otherwise. I'll check. Distribution error may be a separate bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #7 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #3)
If related then this would be the first bug reported that I'm aware of since merged a year ago.
To clarify I meant this would be the first report of version logic breaking since the merge. Most if not all other types of bugs caused by the initial merge were addressed and fixed around that time last year. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #8 from Stian Low <wineryyyyy@gmail.com> --- Submitting merge which may fix: appdb: Fix update query table typo 'distribution' vs 'distributions' modified include/distribution.php @@ -278,7 +278,7 @@ class distribution { if(query_parameters("UPDATE testResults SET state = '?' WHERE testingId = '?'", 'queued', $this->iTestingId)) { - if(query_parameters("UPDATE distribution SET state = '?' WHERE distributionId = '?'", + if(query_parameters("UPDATE distributions SET state = '?' WHERE distributionId = '?'", 'queued', $this->iDistributionId)) { $this->sState = 'queued'; Bug introduced by initial repo commit 20 years ago. Happy anniversary :) https://gitlab.winehq.org/winehq/appdb/-/blob/9364f5bc5af39943297ae4af503f26... 9364f5bc5af39943297ae4af503f26c68ca6ebc0 Author: Chris Morgan <cmorgan@alum.wpi.edu> AuthorDate: Fri Jul 21 04:21:04 2006 +0000 Commit: WineHQ <wineowner@winehq.org> CommitDate: Fri Jul 21 04:21:04 2006 +0000 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #9 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #8)
Submitting merge which may fix:
https://gitlab.winehq.org/winehq/appdb/-/merge_requests/30 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #10 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #8)
Bug introduced by initial repo commit 20 years ago. Happy anniversary :)
Just graduated high school. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #11 from Stian Low <wineryyyyy@gmail.com> --- Bug seems hardly major if previously unreported and not fixed by now. If it's still considered major then I do not have merge approval privileges to expedite. I'm exhausted from wine dev work and starved so hopefully this is enough AppDB dev work for now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #12 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #6)
Version "main" has been removed from Bugzilla: https://bugs.winehq.org/enter_bug.cgi?product=Wine
Correction: version "main" still exists for Bugzilla for this link which AppDB uses for versions list: - https://bugs.winehq.org/query.cgi?format=advanced Version "main" seems unrelated to this bug and fix so it will be addressed by a separate bug if necessary. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #13 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #12)
Correction: version "main" still exists for Bugzilla for this link which
Version "main" and "unspecified" will be corrected along with other misordered versions via: https://bugs.winehq.org/show_bug.cgi?id=58510#c10 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #14 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Ken Sharp from comment #4)
This is one of a myriad of bugs in the AppDB since the changes were made. The AppDB is very broken.
MR-30 has been closed superseded by MR-32 via a separate branch instead of master to better separate multiple incoming AppDB fixes by me to address some of the myriad of bugs including long standing bugs like this bug and a few caused since my changes last year: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 --- Comment #15 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #14)
MR-32 merged. If Hugo was still able to reproduce the error then please try again. Please let me know if there are any other issues. Otherwise this bug may be fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 Ken Sharp <imwellcushtymelike@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Ken Sharp <imwellcushtymelike@gmail.com> --- Can be reopened if it isn't fixed. Triggering this wasn't obvious to start with. Thankyou for fixing this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 Ken Sharp <imwellcushtymelike@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2df161a02e6e5e332206418cd24 | |ab428fba1f489 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60064 Ken Sharp <imwellcushtymelike@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #17 from Ken Sharp <imwellcushtymelike@gmail.com> --- Closing bugs marked as fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla