[Bug 59815] New: damavand/vk vsir_program_remap_output_signature input_mask check fails too early causing much less rendering than able just by continuing
http://bugs.winehq.org/show_bug.cgi?id=59815 Bug ID: 59815 Summary: damavand/vk vsir_program_remap_output_signature input_mask check fails too early causing much less rendering than able just by continuing Product: vkd3d Version: 2.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: vkd3d-shader Assignee: wine-bugs@list.winehq.org Reporter: wineryyyyy@gmail.com Distribution: --- Created attachment 81073 --> http://bugs.winehq.org/attachment.cgi?id=81073 Screenshots of Witcher mostly blackscreen vs mostly rendered by not failing too early Allowing vsir_program_remap_output_signature() to proceed instead of returning for unhandled input_masks often results in much more rendering. Witcher screenshots attached showcase this which has also been encountered for other games: https://bugs.winehq.org/show_bug.cgi?id=54372#c9 https://bugs.winehq.org/show_bug.cgi?id=50182 Failing early makes errors much more obvious for unhandled cases which may useful for dev purposes on the one hand but on the other hand seems more misleading and less informative than continuing rendering which often reveals more about what actually is failing such as the case of the witcher which clearly shows that the menu is actually what is unhandled rather than most of the rest of the game which renders nearly consistent with WINED3D/gl. Often splash screens, intro videos, and/or start menus are only unhandled but unclear those in particular have bugs when everything is rendered the same blackscreen. Having DAMAVAND/vk renderer able to render as much as it is able allows it to be used more reliably as a dev tool for comparison with WINED3D/gl when debugging game bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 --- Comment #1 from Stian Low <wineryyyyy@gmail.com> --- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2059 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 --- Comment #2 from Henri Verbeet <hverbeet@gmail.com> --- Well, the idea was to implement/fix these things when they're found/reported. I've sent https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2063, does that help? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 --- Comment #3 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Henri Verbeet from comment #2)
Well, the idea was to implement/fix these things when they're found/reported. I've sent https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2063, does that help?
MR 2063 produces practically same results and logs for witcher as MR 2059 with no obvious diffs so definitely helps. So long as it continues attempting rendering instead of failing early for input_mask mismatches, it produces much better results for many games and makes it clearer which parts are still broken for bug reporting. Closing as this bug as fixed and MR 2059 superseded by MR 2063. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Stian Low <wineryyyyy@gmail.com> --- . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 Zeb Figura <z.figura12@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com Resolution|FIXED |DUPLICATE --- Comment #5 from Zeb Figura <z.figura12@gmail.com> --- Nothing was committed yet. That said, I don't think we need a separate bug for this; we have application-specific bugs already. *** This bug has been marked as a duplicate of bug 59303 *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 reelix@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reelix@gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59815 --- Comment #6 from Henri Verbeet <hverbeet@gmail.com> --- Committed as 2d2b02426363c8fb3bb02388a1d945ec2e4b7353. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla