November 2007 - Wine-Commits

Maarten Lankhorst : dsound: Use a 2 stage mixing/normalization for sound.
by Alexandre Julliard Nov. 9, 2007

Nov. 9, 2007

Module: wine Branch: master Commit: 4d1129f7859b6c777f0e281548d05e8ba5d5b3b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4d1129f7859b6c777f0e28154… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Wed Nov 7 20:32:22 2007 +0100 dsound: Use a 2 stage mixing/normalization for sound. --- dlls/dsound/dsound.c | 5 +- dlls/dsound/dsound_private.h | 9 ++- dlls/dsound/mixer.c | 109 +++++++++++++++-------------------------- dlls/dsound/primary.c | 21 ++++++++- 4 files changed, 69 insertions(+), 75 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4d1129f7859b6c777f0e2…

1 0

Juan Lang : crypt32: Fix a couple leaks in test.
by Alexandre Julliard Nov. 9, 2007

Nov. 9, 2007

Module: wine Branch: master Commit: f6bfa45970c8712a679cb0548acdbc70f27391ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6bfa45970c8712a679cb0548… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Nov 8 08:45:58 2007 -0800 crypt32: Fix a couple leaks in test. --- dlls/crypt32/tests/encode.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c index 82d0344..1b1462d 100644 --- a/dlls/crypt32/tests/encode.c +++ b/dlls/crypt32/tests/encode.c @@ -4296,6 +4296,7 @@ static void test_decodeCRLToBeSigned(DWORD dwEncoding) "Wrong issuer size %d\n", info->Issuer.cbData); ok(!memcmp(info->Issuer.pbData, encodedCommonName, info->Issuer.cbData), "Unexpected issuer\n"); + LocalFree(buf); } /* a real CRL from verisign that has extensions */ ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, @@ -4359,6 +4360,7 @@ static void test_decodeCRLToBeSigned(DWORD dwEncoding) "Unexpected issuer\n"); ok(info->cExtension == 1, "Expected 1 extensions, got %d\n", info->cExtension); + LocalFree(buf); } ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, v2CRLWithExt, sizeof(v2CRLWithExt), CRYPT_DECODE_ALLOC_FLAG,

1 0

Maarten Lankhorst : dsound: Add support for 24/32 bits input sound buffers.
by Alexandre Julliard Nov. 9, 2007

Nov. 9, 2007

Module: wine Branch: master Commit: fa3663d6c79601cac7663c0c477bec5ba089c944 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa3663d6c79601cac7663c0c4… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Wed Nov 7 20:31:53 2007 +0100 dsound: Add support for 24/32 bits input sound buffers. --- dlls/dsound/Makefile.in | 1 + dlls/dsound/dsound_convert.c | 184 ++++++++++++++++++++++++++++++++++++++++++ dlls/dsound/dsound_private.h | 6 +- dlls/dsound/mixer.c | 84 +++++-------------- 4 files changed, 211 insertions(+), 64 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=fa3663d6c79601cac7663…

1 0

Maarten Lankhorst : dsound: Add mixing and normalization functions.
by Alexandre Julliard Nov. 9, 2007

Nov. 9, 2007

Module: wine Branch: master Commit: a938f693606faa0ca569cce9cbbee60b56eb8301 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a938f693606faa0ca569cce9c… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Wed Nov 7 20:32:09 2007 +0100 dsound: Add mixing and normalization functions. --- dlls/dsound/dsound_convert.c | 132 ++++++++++++++++++++++++++++++++++++++++++ dlls/dsound/dsound_private.h | 4 + 2 files changed, 136 insertions(+), 0 deletions(-) diff --git a/dlls/dsound/dsound_convert.c b/dlls/dsound/dsound_convert.c index 6290a07..649bd78 100644 --- a/dlls/dsound/dsound_convert.c +++ b/dlls/dsound/dsound_convert.c @@ -182,3 +182,135 @@ const bitsconvertfunc convertbpp[4][4] = { { convert_24_to_8, convert_24_to_16, convert_24_to_24, convert_24_to_32 }, { convert_32_to_8, convert_32_to_16, convert_32_to_24, convert_32_to_32 }, }; + +static void mix8(int8_t *src, int32_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + while (len--) + /* 8-bit WAV is unsigned, it's here converted to signed, normalize function will convert it back again */ + *(dst++) += (int8_t)((uint8_t)*(src++) - (uint8_t)0x80); +} + +static void mix16(int16_t *src, int32_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 2; + while (len--) + { + *dst += le16(*src); + ++dst; ++src; + } +} + +static void mix24(int24_struct *src, int32_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 3; + while (len--) + { + uint32_t field; + field = ((unsigned)src->byte[2] << 16) + ((unsigned)src->byte[1] << 8) + (unsigned)src->byte[0]; + if (src->byte[2] & 0x80) + field |= 0xFF000000U; + *(dst++) += field; + ++src; + } +} + +static void mix32(int32_t *src, int64_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 4; + while (len--) + *(dst++) += le32(*(src++)); +} + +const mixfunc mixfunctions[4] = { + (mixfunc)mix8, + (mixfunc)mix16, + (mixfunc)mix24, + (mixfunc)mix32 +}; + +static void norm8(int32_t *src, int8_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + while (len--) + { + *dst = (*src) + 0x80; + if (*src < -0x80) + *dst = 0; + else if (*src > 0x7f) + *dst = 0xff; + ++dst; + ++src; + } +} + +static void norm16(int32_t *src, int16_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 2; + while (len--) + { + *dst = le16(*src); + if (*src <= -0x8000) + *dst = le16(0x8000); + else if (*src > 0x7fff) + *dst = le16(0x7fff); + ++dst; + ++src; + } +} + +static void norm24(int32_t *src, int24_struct *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 3; + while (len--) + { + if (*src <= -0x800000) + { + dst->byte[0] = 0; + dst->byte[1] = 0; + dst->byte[2] = 0x80; + } + else if (*src > 0x7fffff) + { + dst->byte[0] = 0xff; + dst->byte[1] = 0xff; + dst->byte[2] = 0x7f; + } + else + { + dst->byte[0] = *src; + dst->byte[1] = *src >> 8; + dst->byte[2] = *src >> 16; + } + ++dst; + ++src; + } +} + +static void norm32(int64_t *src, int32_t *dst, unsigned len) +{ + TRACE("%p - %p %d\n", src, dst, len); + len /= 4; + while (len--) + { + *dst = le32(*src); + if (*src <= -(int64_t)0x80000000) + *dst = le32(0x80000000); + else if (*src > 0x7fffffff) + *dst = le32(0x7fffffff); + ++dst; + ++src; + } +} + +const normfunc normfunctions[4] = { + (normfunc)norm8, + (normfunc)norm16, + (normfunc)norm24, + (normfunc)norm32, +}; diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index 21fcfe2..fbddefe 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -72,6 +72,10 @@ typedef struct DirectSoundCaptureDevice DirectSoundCaptureDevice; /* dsound_convert.h */ typedef void (*bitsconvertfunc)(const void *, void *); extern const bitsconvertfunc convertbpp[4][4]; +typedef void (*mixfunc)(const void *, void *, unsigned); +extern const mixfunc mixfunctions[4]; +typedef void (*normfunc)(const void *, void *, unsigned); +extern const normfunc normfunctions[4]; /***************************************************************************** * IDirectSoundDevice implementation structure

1 0

Alexander Nicolaysen Sørnes : objectManager: Support user-selected sorting in tables
by Chris Morgan Nov. 9, 2007

Nov. 9, 2007

Module: appdb Branch: master Commit: e7625791a07aec1d993fdf2a17b9b73329b00df2 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=e7625791a07aec1d993fdf2a… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Nov 8 17:32:00 2007 +0100 objectManager: Support user-selected sorting in tables --- include/application.php | 27 ++++++++----- include/application_queue.php | 11 ++++- include/objectManager.php | 61 +++++++++++++++++++++++++-- include/table.php | 91 ++++++++++++++++++++++++++++++++++++++++- objectManager.php | 1 + 5 files changed, 173 insertions(+), 18 deletions(-) Diff: http://source.winehq.org/git/appdb.git/?a=commitdiff;h=e7625791a07aec1d993f…

1 0

Alexander Nicolaysen Sørnes : version_queue: Only reject version when app is unqueued
by Chris Morgan Nov. 9, 2007

Nov. 9, 2007

Module: appdb Branch: master Commit: 7643ac8229388d7d01f63054505a03663643bcab URL: http://source.winehq.org/git/appdb.git/?a=commit;h=7643ac8229388d7d01f63054… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Nov 8 12:24:00 2007 +0100 version_queue: Only reject version when app is unqueued --- include/version_queue.php | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/version_queue.php b/include/version_queue.php index d2bb809..725f8b0 100644 --- a/include/version_queue.php +++ b/include/version_queue.php @@ -57,7 +57,10 @@ class version_queue function reject() { - $this->oVersion->reject(); + $oApp = new application($this->oVersion->iAppId); + + if($oApp->sQueued == "false") + $this->oVersion->reject(); if($this->oDownloadUrl->iId) $this->oDownloadUrl->reject();

1 0

Scott Ritchie : Update download-deb to reflect 64 bit packages for Debian Etch
by Jeremy Newman Nov. 8, 2007

Nov. 8, 2007

Module: website Branch: master Commit: 540ea75b8538ff47d70a28d18576f65fb2ed31db URL: http://source.winehq.org/git/website.git/?a=commit;h=540ea75b8538ff47d70a28… Author: Scott Ritchie <scott(a)open-vote.org> Date: Mon Nov 5 11:15:29 2007 -0800 Update download-deb to reflect 64 bit packages for Debian Etch Update download-deb to reflect 64 bit packages for Debian Etch Thanks, Scott Ritchie >From f866aa1fcd5ad34d537a79b42ff2e9b4be5eae5a Mon Sep 17 00:00:00 2001 From: Scott Ritchie <scott(a)open-vote.org> Date: Mon, 5 Nov 2007 11:12:58 -0800 Subject: Update download-deb to reflect 64 bit packages for Debian Etch --- templates/en/download-deb.template | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/templates/en/download-deb.template b/templates/en/download-deb.template index c716eb0..2cf6894 100644 --- a/templates/en/download-deb.template +++ b/templates/en/download-deb.template @@ -33,7 +33,7 @@ list of trusted APT keys by copy and pasting the following: sudo wget http://wine.budgetdedicated.com/apt/sources.list.d/edgy.list -O /etc/apt/sources.list.d/winehq.list For Ubuntu Dapper (6.06): *64-bit packages not available* sudo wget http://wine.budgetdedicated.com/apt/sources.list.d/dapper.list -O /etc/apt/sources.list.d/winehq.list -For Debian Etch (4.0): *64-bit packages not available* +For Debian Etch (4.0): sudo wget http://wine.budgetdedicated.com/apt/sources.list.d/etch.list -O /etc/apt/sources.list.d/winehq.list Then, you can install Wine from WineHQ like it were any other package, such as by

1 0

Jeremy Newman : Marcus Meissner <meissner@suse.de>
by Jeremy Newman Nov. 8, 2007

Nov. 8, 2007

Module: website Branch: master Commit: 9047e31004fc7116b38e75357fc23a71200174ad URL: http://source.winehq.org/git/website.git/?a=commit;h=9047e31004fc7116b38e75… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Thu Nov 8 16:55:53 2007 -0600 Marcus Meissner <meissner(a)suse.de> updated SUSE entry to match current versions --- templates/en/download.template | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/templates/en/download.template b/templates/en/download.template index 3b44af6..b2d73f8 100644 --- a/templates/en/download.template +++ b/templates/en/download.template @@ -39,7 +39,8 @@ for post-installation instructions. <img src="{$root}/images/distro/suse.png" width="50" height="50" alt="SUSE Linux" border="0"></a> </td> <td> <a href="http://en.opensuse.org/Wine#Repositories">SUSE</a> - release binary and source .rpms and daily snapshot RPMs for SUSE Linux 9.3, 10.0, 10.1, and openSUSE 10.2. + release binary and source .rpms and daily snapshot RPMs for SUSE Linux 10.0, 10.1, openSUSE 10.2 and 10.3. + Old versions available on <a href="http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=7…">SourceForge</a> </td> <td><a href="mailto:meissner(a)suse.de">Marcus Meissner</a></td> </tr>

1 0

Vitaliy Margolen : Fix SuSE download link
by Jeremy Newman Nov. 8, 2007

Nov. 8, 2007

Module: website Branch: master Commit: 4dbad523cdbde1c07b21a7011766ee020cc853e9 URL: http://source.winehq.org/git/website.git/?a=commit;h=4dbad523cdbde1c07b21a7… Author: Vitaliy Margolen <wine-devel(a)kievinfo.com> Date: Sat Oct 27 11:08:30 2007 -0600 Fix SuSE download link Did this fall through the cracks? Resending. Link on the SuSE logo leads to the old place. --- templates/en/download.template | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/templates/en/download.template b/templates/en/download.template index 7df2fb6..3b44af6 100644 --- a/templates/en/download.template +++ b/templates/en/download.template @@ -35,7 +35,7 @@ for post-installation instructions. </tr> <tr bgcolor="#ffffff"> - <td align=center><a href="http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=7…"> + <td align=center><a href="http://en.opensuse.org/Wine#Repositories"> <img src="{$root}/images/distro/suse.png" width="50" height="50" alt="SUSE Linux" border="0"></a> </td> <td> <a href="http://en.opensuse.org/Wine#Repositories">SUSE</a>

1 0

EA Durbin : d3dxof: Fix some return values.
by Alexandre Julliard Nov. 8, 2007

Nov. 8, 2007

Module: wine Branch: master Commit: 0bfba69c15d4da04fdef720798f6f047e356ee4b URL: http://source.winehq.org/git/wine.git/?a=commit;h=0bfba69c15d4da04fdef72079… Author: EA Durbin <ead1234(a)hotmail.com> Date: Wed Nov 7 22:55:01 2007 -0600 d3dxof: Fix some return values. --- dlls/d3dxof/d3dxof.c | 56 +++++++++++++++++++++++++------------------------- 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/dlls/d3dxof/d3dxof.c b/dlls/d3dxof/d3dxof.c index 0904f64..227e8c2 100644 --- a/dlls/d3dxof/d3dxof.c +++ b/dlls/d3dxof/d3dxof.c @@ -121,7 +121,7 @@ static HRESULT WINAPI IDirectXFileImpl_CreateEnumObject(IDirectXFile* iface, LPV *ppEnumObj = (LPDIRECTXFILEENUMOBJECT)object; - return S_FALSE; + return DXFILE_OK; } static HRESULT WINAPI IDirectXFileImpl_CreateSaveObject(IDirectXFile* iface, LPCSTR szFileName, DXFILEFORMAT dwFileFormat, LPDIRECTXFILESAVEOBJECT* ppSaveObj) @@ -130,7 +130,7 @@ static HRESULT WINAPI IDirectXFileImpl_CreateSaveObject(IDirectXFile* iface, LPC FIXME("(%p/%p)->(%s,%x,%p) stub!\n", This, iface, szFileName, dwFileFormat, ppSaveObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileImpl_RegisterTemplates(IDirectXFile* iface, LPVOID pvData, DWORD cbSize) @@ -139,7 +139,7 @@ static HRESULT WINAPI IDirectXFileImpl_RegisterTemplates(IDirectXFile* iface, LP FIXME("(%p/%p)->(%p,%d) stub!\n", This, iface, pvData, cbSize); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileVtbl IDirectXFile_Vtbl = @@ -165,7 +165,7 @@ HRESULT IDirectXFileBinaryImpl_Create(IDirectXFileBinaryImpl** ppObj) *ppObj = object; - return S_OK; + return DXFILE_OK; } /*** IUnknown methods ***/ @@ -219,7 +219,7 @@ static HRESULT WINAPI IDirectXFileBinaryImpl_GetName(IDirectXFileBinary* iface, FIXME("(%p/%p)->(%p,%p) stub!\n", This, iface, pstrNameBuf, pdwBufLen); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileBinaryImpl_GetId(IDirectXFileBinary* iface, LPGUID pGuid) @@ -228,7 +228,7 @@ static HRESULT WINAPI IDirectXFileBinaryImpl_GetId(IDirectXFileBinary* iface, LP FIXME("(%p/%p)->(%p) stub!\n", This, iface, pGuid); - return S_FALSE; + return DXFILEERR_BADVALUE; } /*** IDirectXFileBinary methods ***/ @@ -238,7 +238,7 @@ static HRESULT WINAPI IDirectXFileBinaryImpl_GetSize(IDirectXFileBinary* iface, FIXME("(%p/%p)->(%p) stub!\n", This, iface, pcbSize); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileBinaryImpl_GetMimeType(IDirectXFileBinary* iface, LPCSTR* pszMimeType) @@ -247,7 +247,7 @@ static HRESULT WINAPI IDirectXFileBinaryImpl_GetMimeType(IDirectXFileBinary* ifa FIXME("(%p/%p)->(%p) stub!\n", This, iface, pszMimeType); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileBinaryImpl_Read(IDirectXFileBinary* iface, LPVOID pvData, DWORD cbSize, LPDWORD pcbRead) @@ -256,7 +256,7 @@ static HRESULT WINAPI IDirectXFileBinaryImpl_Read(IDirectXFileBinary* iface, LPV FIXME("(%p/%p)->(%p, %d, %p) stub!\n", This, iface, pvData, cbSize, pcbRead); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileBinaryVtbl IDirectXFileBinary_Vtbl = @@ -338,7 +338,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetName(IDirectXFileData* iface, LPST FIXME("(%p/%p)->(%p,%p) stub!\n", This, iface, pstrNameBuf, pdwBufLen); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_GetId(IDirectXFileData* iface, LPGUID pGuid) @@ -347,7 +347,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetId(IDirectXFileData* iface, LPGUID FIXME("(%p/%p)->(%p) stub!\n", This, iface, pGuid); - return S_FALSE; + return DXFILEERR_BADVALUE; } /*** IDirectXFileData methods ***/ @@ -357,7 +357,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetData(IDirectXFileData* iface, LPCS FIXME("(%p/%p)->(%s,%p,%p) stub!\n", This, iface, szMember, pcbSize, ppvData); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_GetType(IDirectXFileData* iface, const GUID** pguid) @@ -366,7 +366,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetType(IDirectXFileData* iface, cons FIXME("(%p/%p)->(%p) stub!\n", This, iface, pguid); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_GetNextObject(IDirectXFileData* iface, LPDIRECTXFILEOBJECT* ppChildObj) @@ -375,7 +375,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetNextObject(IDirectXFileData* iface FIXME("(%p/%p)->(%p) stub!\n", This, iface, ppChildObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_AddDataObject(IDirectXFileData* iface, LPDIRECTXFILEDATA pDataObj) @@ -384,7 +384,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_AddDataObject(IDirectXFileData* iface FIXME("(%p/%p)->(%p) stub!\n", This, iface, pDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_AddDataReference(IDirectXFileData* iface, LPCSTR szRef, const GUID* pguidRef) @@ -393,7 +393,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_AddDataReference(IDirectXFileData* if FIXME("(%p/%p)->(%s,%p) stub!\n", This, iface, szRef, pguidRef); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataImpl_AddBinaryObject(IDirectXFileData* iface, LPCSTR szName, const GUID* pguid, LPCSTR szMimeType, LPVOID pvData, DWORD cbSize) @@ -402,7 +402,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_AddBinaryObject(IDirectXFileData* ifa FIXME("(%p/%p)->(%s,%p,%s,%p,%d) stub!\n", This, iface, szName, pguid, szMimeType, pvData, cbSize); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileDataVtbl IDirectXFileData_Vtbl = @@ -486,7 +486,7 @@ static HRESULT WINAPI IDirectXFileDataReferenceImpl_GetName(IDirectXFileDataRefe FIXME("(%p/%p)->(%p,%p) stub!\n", This, iface, pstrNameBuf, pdwBufLen); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileDataReferenceImpl_GetId(IDirectXFileDataReference* iface, LPGUID pGuid) @@ -495,7 +495,7 @@ static HRESULT WINAPI IDirectXFileDataReferenceImpl_GetId(IDirectXFileDataRefere FIXME("(%p/%p)->(%p) stub!\n", This, iface, pGuid); - return S_FALSE; + return DXFILEERR_BADVALUE; } /*** IDirectXFileDataReference ***/ @@ -505,7 +505,7 @@ static HRESULT WINAPI IDirectXFileDataReferenceImpl_Resolve(IDirectXFileDataRefe FIXME("(%p/%p)->(%p) stub!\n", This, iface, ppDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileDataReferenceVtbl IDirectXFileDataReference_Vtbl = @@ -591,7 +591,7 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetNextDataObject(IDirectXFileE *ppDataObj = (LPDIRECTXFILEDATA)object; - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetDataObjectById(IDirectXFileEnumObject* iface, REFGUID rguid, LPDIRECTXFILEDATA* ppDataObj) @@ -600,7 +600,7 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetDataObjectById(IDirectXFileE FIXME("(%p/%p)->(%p,%p) stub!\n", This, iface, rguid, ppDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetDataObjectByName(IDirectXFileEnumObject* iface, LPCSTR szName, LPDIRECTXFILEDATA* ppDataObj) @@ -609,7 +609,7 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetDataObjectByName(IDirectXFil FIXME("(%p/%p)->(%s,%p) stub!\n", This, iface, szName, ppDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileEnumObjectVtbl IDirectXFileEnumObject_Vtbl = @@ -687,7 +687,7 @@ static HRESULT WINAPI IDirectXFileObjectImpl_GetName(IDirectXFileObject* iface, FIXME("(%p/%p)->(%p,%p) stub!\n", This, iface, pstrNameBuf, pdwBufLen); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileObjectImpl_GetId(IDirectXFileObject* iface, LPGUID pGuid) @@ -696,7 +696,7 @@ static HRESULT WINAPI IDirectXFileObjectImpl_GetId(IDirectXFileObject* iface, LP FIXME("(%p/%p)->(%p) stub!\n", This, iface, pGuid); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileObjectVtbl IDirectXFileObject_Vtbl = @@ -772,7 +772,7 @@ static HRESULT WINAPI IDirectXFileSaveObjectImpl_SaveTemplates(IDirectXFileSaveO FIXME("(%p/%p)->(%d,%p) stub!\n", This, iface, cTemplates, ppguidTemplates); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileSaveObjectImpl_CreateDataObject(IDirectXFileSaveObject* iface, REFGUID rguidTemplate, LPCSTR szName, const GUID* pguid, DWORD cbSize, LPVOID pvData, LPDIRECTXFILEDATA* ppDataObj) @@ -781,7 +781,7 @@ static HRESULT WINAPI IDirectXFileSaveObjectImpl_CreateDataObject(IDirectXFileSa FIXME("(%p/%p)->(%p,%s,%p,%d,%p,%p) stub!\n", This, iface, rguidTemplate, szName, pguid, cbSize, pvData, ppDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static HRESULT WINAPI IDirectXFileSaveObjectImpl_SaveData(IDirectXFileSaveObject* iface, LPDIRECTXFILEDATA ppDataObj) @@ -790,7 +790,7 @@ static HRESULT WINAPI IDirectXFileSaveObjectImpl_SaveData(IDirectXFileSaveObject FIXME("(%p/%p)->(%p) stub!\n", This, iface, ppDataObj); - return S_FALSE; + return DXFILEERR_BADVALUE; } static const IDirectXFileSaveObjectVtbl IDirectXFileSaveObject_Vtbl =

1 0