June 2007 - Wine-Commits - list.winehq.org

Dmitry Timoshkov : include/msvcrt: Make sure that __int64 is properly defined on a 64-bit platform.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 70015ab5b47dcc28c92d74d5120631156b38a79d URL: http://source.winehq.org/git/wine.git/?a=commit;h=70015ab5b47dcc28c92d74d51… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Jun 6 20:12:57 2007 +0900 include/msvcrt: Make sure that __int64 is properly defined on a 64-bit platform. --- include/msvcrt/direct.h | 12 ++++++++---- include/msvcrt/io.h | 12 +++++++++--- include/msvcrt/malloc.h | 12 ++++++++---- include/msvcrt/mbstring.h | 12 ++++++++---- include/msvcrt/search.h | 12 ++++++++---- include/msvcrt/stddef.h | 8 ++++++++ include/msvcrt/stdio.h | 12 ++++++++---- include/msvcrt/stdlib.h | 10 +++++++++- include/msvcrt/string.h | 12 ++++++++---- include/msvcrt/sys/stat.h | 6 ------ include/msvcrt/sys/types.h | 12 ++++++++---- include/msvcrt/time.h | 12 ++++++++---- include/msvcrt/wchar.h | 12 ++++++++---- 13 files changed, 98 insertions(+), 46 deletions(-) diff --git a/include/msvcrt/direct.h b/include/msvcrt/direct.h index f0fce97..b0c4af8 100644 --- a/include/msvcrt/direct.h +++ b/include/msvcrt/direct.h @@ -24,14 +24,18 @@ typedef unsigned short wchar_t; #endif #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/io.h b/include/msvcrt/io.h index 55444f0..6009fe9 100644 --- a/include/msvcrt/io.h +++ b/include/msvcrt/io.h @@ -20,9 +20,15 @@ typedef unsigned short wchar_t; #endif #endif -#ifndef _MSC_VER -# ifndef __int64 -# define __int64 long long +#if defined(__x86_64__) && !defined(_WIN64) +#define _WIN64 +#endif + +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long # endif #endif diff --git a/include/msvcrt/malloc.h b/include/msvcrt/malloc.h index 8f904b3..25ae615 100644 --- a/include/msvcrt/malloc.h +++ b/include/msvcrt/malloc.h @@ -34,14 +34,18 @@ #define _FREEENTRY 0 #define _USEDENTRY 1 -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/mbstring.h b/include/msvcrt/mbstring.h index 7e82ce8..124d215 100644 --- a/include/msvcrt/mbstring.h +++ b/include/msvcrt/mbstring.h @@ -25,14 +25,18 @@ #include <pshpack8.h> -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/search.h b/include/msvcrt/search.h index 413b697..af648d5 100644 --- a/include/msvcrt/search.h +++ b/include/msvcrt/search.h @@ -23,14 +23,18 @@ #define __WINE_USE_MSVCRT #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/stddef.h b/include/msvcrt/stddef.h index 62bb850..eb45c87 100644 --- a/include/msvcrt/stddef.h +++ b/include/msvcrt/stddef.h @@ -27,6 +27,14 @@ #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _WCHAR_T_DEFINED #define _WCHAR_T_DEFINED #ifndef __cplusplus diff --git a/include/msvcrt/stdio.h b/include/msvcrt/stdio.h index 01ae243..b177664 100644 --- a/include/msvcrt/stdio.h +++ b/include/msvcrt/stdio.h @@ -17,14 +17,18 @@ #include <stdarg.h> #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + /* file._flag flags */ #define _IOREAD 0x0001 #define _IOWRT 0x0002 diff --git a/include/msvcrt/stdlib.h b/include/msvcrt/stdlib.h index 27e8dbe..269f279 100644 --- a/include/msvcrt/stdlib.h +++ b/include/msvcrt/stdlib.h @@ -28,8 +28,16 @@ typedef unsigned short wchar_t; #endif #endif +#if defined(__x86_64__) && !defined(_WIN64) +#define _WIN64 +#endif + #if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif #endif #define EXIT_SUCCESS 0 diff --git a/include/msvcrt/string.h b/include/msvcrt/string.h index bf3994f..327945e 100644 --- a/include/msvcrt/string.h +++ b/include/msvcrt/string.h @@ -18,14 +18,18 @@ typedef unsigned short wchar_t; #endif #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/sys/stat.h b/include/msvcrt/sys/stat.h index 9ab0edc..03b1a16 100644 --- a/include/msvcrt/sys/stat.h +++ b/include/msvcrt/sys/stat.h @@ -22,12 +22,6 @@ typedef unsigned short wchar_t; #endif #endif -#ifndef _MSC_VER -# ifndef __int64 -# define __int64 long long -# endif -#endif - #ifndef _DEV_T_DEFINED typedef unsigned int _dev_t; #define _DEV_T_DEFINED diff --git a/include/msvcrt/sys/types.h b/include/msvcrt/sys/types.h index 05a5ef1..663ad62 100644 --- a/include/msvcrt/sys/types.h +++ b/include/msvcrt/sys/types.h @@ -23,14 +23,18 @@ #define __WINE_USE_MSVCRT #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _DEV_T_DEFINED typedef unsigned int _dev_t; #define _DEV_T_DEFINED diff --git a/include/msvcrt/time.h b/include/msvcrt/time.h index 60ec444..deb17e1 100644 --- a/include/msvcrt/time.h +++ b/include/msvcrt/time.h @@ -32,14 +32,18 @@ typedef unsigned short wchar_t; #endif #endif -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef _SIZE_T_DEFINED #ifdef _WIN64 typedef unsigned __int64 size_t; diff --git a/include/msvcrt/wchar.h b/include/msvcrt/wchar.h index e298a70..611b738 100644 --- a/include/msvcrt/wchar.h +++ b/include/msvcrt/wchar.h @@ -37,14 +37,18 @@ typedef unsigned short wchar_t; #define WCHAR_MIN 0 #define WCHAR_MAX ((wchar_t)-1) -#if !defined(_MSC_VER) && !defined(__int64) -#define __int64 long long -#endif - #if defined(__x86_64__) && !defined(_WIN64) #define _WIN64 #endif +#if !defined(_MSC_VER) && !defined(__int64) +# ifdef _WIN64 +# define __int64 long +# else +# define __int64 long long +# endif +#endif + #ifndef DECLSPEC_ALIGN # if defined(_MSC_VER) && (_MSC_VER >= 1300) && !defined(MIDL_PASS) # define DECLSPEC_ALIGN(x) __declspec(align(x))

1 0

Alexandre Julliard : explorer.exe: Mark explorer as a system process.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: d45450deaf72c68738b2740d9d4e7ff0f44e801e URL: http://source.winehq.org/git/wine.git/?a=commit;h=d45450deaf72c68738b2740d9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 6 20:33:22 2007 +0200 explorer.exe: Mark explorer as a system process. --- programs/explorer/desktop.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index 0846dcd..7f2e23f 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -31,6 +31,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(explorer); #define DESKTOP_CLASS_ATOM ((LPCWSTR)MAKEINTATOM(32769)) #define DESKTOP_ALL_ACCESS 0x01ff +extern HANDLE __wine_make_process_system(void); + static BOOL using_root; /* window procedure for the desktop window */ @@ -198,6 +200,10 @@ void manage_desktop( char *arg ) /* run the desktop message loop */ if (hwnd) { + /* we don't use the system process event, the server + * posts a WM_CLOSE when the last desktop user is gone */ + CloseHandle( __wine_make_process_system() ); + WINE_TRACE( "desktop message loop starting on hwnd %p\n", hwnd ); while (GetMessageW( &msg, 0, 0, 0 )) DispatchMessageW( &msg ); WINE_TRACE( "desktop message loop exiting for hwnd %p\n", hwnd );

1 0

Alexandre Julliard : advapi32: Mark service processes as system processes, and exit when all user processes are done.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 9aa4235117455ce02c0089e3df0d7566112e4fab URL: http://source.winehq.org/git/wine.git/?a=commit;h=9aa4235117455ce02c0089e3d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 6 20:33:30 2007 +0200 advapi32: Mark service processes as system processes, and exit when all user processes are done. --- dlls/advapi32/service.c | 27 ++++++++++++++++++++++++--- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 7752b02..4808db1 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -89,6 +89,8 @@ static CRITICAL_SECTION service_cs = { &service_cs_debug, -1, 0, 0, 0, 0 }; static struct list service_list = LIST_INIT(service_list); +extern HANDLE __wine_make_process_system(void); + /****************************************************************************** * SC_HANDLEs */ @@ -774,18 +776,37 @@ static BOOL service_run_threads(void) TRACE("starting %d pipe listener threads\n", count); - handles = HeapAlloc(GetProcessHeap(), 0, sizeof(HANDLE)*count); + handles = HeapAlloc(GetProcessHeap(), 0, sizeof(HANDLE) * (count + 1)); + + handles[n++] = __wine_make_process_system(); LIST_FOR_EACH_ENTRY( service, &service_list, service_data, entry ) handles[n++] = CreateThread( NULL, 0, service_control_dispatcher, service, 0, NULL ); - assert(n==count); + assert(n == count + 1); LeaveCriticalSection( &service_cs ); /* wait for all the threads to pack up and exit */ - WaitForMultipleObjectsEx(count, handles, TRUE, INFINITE, FALSE); + while (n > 1) + { + DWORD ret = WaitForMultipleObjects( min(n,MAXIMUM_WAIT_OBJECTS), handles, FALSE, INFINITE ); + if (!ret) /* system process event */ + { + TRACE( "last user process exited, shutting down\n" ); + /* FIXME: we should maybe send a shutdown control to running services */ + ExitProcess(0); + } + if (ret < MAXIMUM_WAIT_OBJECTS) + { + CloseHandle( handles[ret] ); + memmove( &handles[ret], &handles[ret+1], (n - ret - 1) * sizeof(HANDLE) ); + n--; + } + else break; + } + while (n) CloseHandle( handles[--n] ); HeapFree(GetProcessHeap(), 0, handles); return TRUE;

1 0

Alexandre Julliard : server: Add support for system processes, that can be signaled to exit when all non-system processes are done.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 156b205eb527b57d6e9e9e859df77a42c2104603 URL: http://source.winehq.org/git/wine.git/?a=commit;h=156b205eb527b57d6e9e9e859… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 6 20:33:13 2007 +0200 server: Add support for system processes, that can be signaled to exit when all non-system processes are done. --- dlls/ntdll/ntdll.spec | 1 + dlls/ntdll/process.c | 18 ++++++++++++++++++ include/wine/server_protocol.h | 17 ++++++++++++++++- server/process.c | 40 ++++++++++++++++++++++++++++++++++++++-- server/process.h | 1 + server/protocol.def | 7 +++++++ server/request.h | 2 ++ server/trace.c | 12 ++++++++++++ 8 files changed, 95 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 535f375..b2b0cc0 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -1380,6 +1380,7 @@ @ cdecl wine_server_handle_to_fd(long long ptr ptr) @ cdecl wine_server_release_fd(long long) @ cdecl wine_server_send_fd(long) +@ cdecl __wine_make_process_system() # Codepages @ cdecl __wine_init_codepages(ptr ptr ptr) diff --git a/dlls/ntdll/process.c b/dlls/ntdll/process.c index 724c081..b059c94 100644 --- a/dlls/ntdll/process.c +++ b/dlls/ntdll/process.c @@ -71,6 +71,24 @@ PEB * WINAPI RtlGetCurrentPeb(void) return NtCurrentTeb()->Peb; } +/*********************************************************************** + * __wine_make_process_system (NTDLL.@) + * + * Mark the current process as a system process. + * Returns the event that is signaled when all non-system processes have exited. + */ +HANDLE __wine_make_process_system(void) +{ + HANDLE ret = 0; + SERVER_START_REQ( make_process_system ) + { + if (!wine_server_call( req )) ret = reply->event; + } + SERVER_END_REQ; + return ret; +} + + #define UNIMPLEMENTED_INFO_CLASS(c) \ case c: \ FIXME("(process=%p) Unimplemented information class: " #c "\n", ProcessHandle); \ diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 6b703a1..56574b0 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -4054,6 +4054,18 @@ struct get_next_device_request_reply }; + +struct make_process_system_request +{ + struct request_header __header; +}; +struct make_process_system_reply +{ + struct reply_header __header; + obj_handle_t event; +}; + + enum request { REQ_new_process, @@ -4275,6 +4287,7 @@ enum request REQ_create_device, REQ_delete_device, REQ_get_next_device_request, + REQ_make_process_system, REQ_NB_REQUESTS }; @@ -4501,6 +4514,7 @@ union generic_request struct create_device_request create_device_request; struct delete_device_request delete_device_request; struct get_next_device_request_request get_next_device_request_request; + struct make_process_system_request make_process_system_request; }; union generic_reply { @@ -4725,8 +4739,9 @@ union generic_reply struct create_device_reply create_device_reply; struct delete_device_reply delete_device_reply; struct get_next_device_request_reply get_next_device_request_reply; + struct make_process_system_reply make_process_system_reply; }; -#define SERVER_PROTOCOL_VERSION 305 +#define SERVER_PROTOCOL_VERSION 306 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/server/process.c b/server/process.c index d733031..623d2ae 100644 --- a/server/process.c +++ b/server/process.c @@ -52,7 +52,8 @@ /* process structure */ static struct list process_list = LIST_INIT(process_list); -static int running_processes; +static int running_processes, user_processes; +static struct event *user_process_event; /* signaled when all user processes have exited */ /* process operations */ @@ -224,6 +225,11 @@ static void set_process_startup_state( struct process *process, enum startup_sta static void process_died( struct process *process ) { if (debug_level) fprintf( stderr, "%04x: *process killed*\n", process->id ); + if (!process->is_system) + { + if (!--user_processes && user_process_event) + set_event( user_process_event ); + } release_object( process ); if (!--running_processes) close_master_socket(); } @@ -272,6 +278,7 @@ struct thread *create_process( int fd, struct thread *parent_thread, int inherit process->priority = PROCESS_PRIOCLASS_NORMAL; process->affinity = 1; process->suspend = 0; + process->is_system = 0; process->create_flags = 0; process->console = NULL; process->startup_state = STARTUP_IN_PROGRESS; @@ -616,7 +623,15 @@ static void process_killed( struct process *process ) void add_process_thread( struct process *process, struct thread *thread ) { list_add_tail( &process->thread_list, &thread->proc_entry ); - if (!process->running_threads++) running_processes++; + if (!process->running_threads++) + { + running_processes++; + if (!process->is_system) + { + if (!user_processes++ && user_process_event) + reset_event( user_process_event ); + } + } grab_object( thread ); } @@ -1143,3 +1158,24 @@ DECL_HANDLER(get_process_idle_event) release_object( process ); } } + +/* make the current process a system process */ +DECL_HANDLER(make_process_system) +{ + struct process *process = current->process; + + if (!user_process_event) + { + if (!(user_process_event = create_event( NULL, NULL, 0, 1, 0 ))) return; + make_object_static( (struct object *)user_process_event ); + } + + if (!(reply->event = alloc_handle( current->process, user_process_event, EVENT_ALL_ACCESS, 0 ))) + return; + + if (!process->is_system) + { + process->is_system = 1; + if (!--user_processes) set_event( user_process_event ); + } +} diff --git a/server/process.h b/server/process.h index b2a6849..3054943 100644 --- a/server/process.h +++ b/server/process.h @@ -66,6 +66,7 @@ struct process int priority; /* priority class */ int affinity; /* process affinity mask */ int suspend; /* global process suspend count */ + int is_system; /* is it a system process? */ unsigned int create_flags; /* process creation flags */ struct list locks; /* list of file locks owned by the process */ struct list classes; /* window classes owned by the process */ diff --git a/server/protocol.def b/server/protocol.def index 8a7e5a8..df6b8d3 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2912,3 +2912,10 @@ enum message_type data_size_t out_size; /* needed output size */ VARARG(next_data,bytes); /* input data of the next ioctl */ @END + + +/* Make the current process a system process */ +(a)REQ(make_process_system) +(a)REPLY + obj_handle_t event; /* event signaled when all user processes have exited */ +(a)END diff --git a/server/request.h b/server/request.h index 90a0c6c..10b6cbe 100644 --- a/server/request.h +++ b/server/request.h @@ -329,6 +329,7 @@ DECL_HANDLER(create_device_manager); DECL_HANDLER(create_device); DECL_HANDLER(delete_device); DECL_HANDLER(get_next_device_request); +DECL_HANDLER(make_process_system); #ifdef WANT_REQUEST_HANDLERS @@ -554,6 +555,7 @@ static const req_handler req_handlers[REQ_NB_REQUESTS] = (req_handler)req_create_device, (req_handler)req_delete_device, (req_handler)req_get_next_device_request, + (req_handler)req_make_process_system, }; #endif /* WANT_REQUEST_HANDLERS */ diff --git a/server/trace.c b/server/trace.c index a340bad..312b68d 100644 --- a/server/trace.c +++ b/server/trace.c @@ -3530,6 +3530,15 @@ static void dump_get_next_device_request_reply( const struct get_next_device_req dump_varargs_bytes( cur_size ); } +static void dump_make_process_system_request( const struct make_process_system_request *req ) +{ +} + +static void dump_make_process_system_reply( const struct make_process_system_reply *req ) +{ + fprintf( stderr, " event=%p", req->event ); +} + static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_new_process_request, (dump_func)dump_get_new_process_info_request, @@ -3750,6 +3759,7 @@ static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_create_device_request, (dump_func)dump_delete_device_request, (dump_func)dump_get_next_device_request_request, + (dump_func)dump_make_process_system_request, }; static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { @@ -3972,6 +3982,7 @@ static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_create_device_reply, (dump_func)0, (dump_func)dump_get_next_device_request_reply, + (dump_func)dump_make_process_system_reply, }; static const char * const req_names[REQ_NB_REQUESTS] = { @@ -4194,6 +4205,7 @@ static const char * const req_names[REQ_NB_REQUESTS] = { "create_device", "delete_device", "get_next_device_request", + "make_process_system", }; static const struct

1 0

appdb/include util.php
by WineHQ June 7, 2007

June 7, 2007

ChangeSet ID: 31162 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/06/06 21:43:57 Modified files: include : util.php Log message: Chris Morgan <cmorgan(a)alum.wpi.edu> Programmatically fix up the bugzilla versions list. Sort the versions with the newest version first, limit the total number of versions to 6 by truncating the array and manually add the 'CVS' entry since we trim this entry off. This should make it easier for users to figure out which version to pick. Patch: http://cvs.winehq.org/patch.py?id=31162 Old revision New revision Changes Path 1.88 1.89 +39 -12 appdb/include/util.php Index: appdb/include/util.php diff -u -p appdb/include/util.php:1.88 appdb/include/util.php:1.89 --- appdb/include/util.php:1.88 7 Jun 2007 2:43:57 -0000 +++ appdb/include/util.php 7 Jun 2007 2:43:57 -0000 @@ -164,25 +164,52 @@ function make_bugzilla_version_list($var { $table = BUGZILLA_DB.".versions"; $where = "WHERE product_id=".BUGZILLA_PRODUCT_ID; - $sQuery = "SELECT value FROM $table $where ORDER BY value"; + $sQuery = "SELECT value FROM $table $where"; $hResult = query_bugzilladb($sQuery); if(!$hResult) return; + // NOTE: perform some version list pruning + // - Reverse the order, we want the newest entries first + // and we can't use 'order by' since we have no column + // to order by, but the entries should come out in the + // order they were added + // - Trim the list, we don't want every version of wine ever released + // - Add 'CVS' explicitly since we trim it out + // + // TODO: if we ever get a reasonable way to order the list replace this code + // with that + $aVersions = array(); + while(list($value) = mysql_fetch_row($hResult)) + { + // exclude unspecified versions + if($value != "unspecified") + $aVersions[] = $value; + } + + // now reverse the array order + $aVersions = array_reverse($aVersions); + + // now trim off all but the last X versions + $iVersionsToKeep = 6; + $aVersions = array_slice($aVersions, 0, $iVersionsToKeep); + + // explicitly add 'CVS' since we are eliminating that above + $aVersions[] = "CVS"; + + // DONE TRIMMING VERSIONS + ///////////////////////// + + + // build the selection array echo "<select name='$varname'>\n"; echo "<option value=\"\">Choose ...</option>\n"; - while(list($value) = mysql_fetch_row($hResult)) + foreach($aVersions as $sKey => $sValue) { - if($value == "unspecified") - { - // We do not unspecified versions!!! - } else - { - if($value == $cvalue) - echo "<option value=$value selected>$value\n"; - else - echo "<option value=$value>$value\n"; - } + if($sValue == $cvalue) + echo "<option value=$sValue selected>$sValue\n"; + else + echo "<option value=$sValue>$sValue\n"; } echo "</select>\n"; }

1 0

appdb/include application_queue.php
by WineHQ June 7, 2007

June 7, 2007

ChangeSet ID: 31161 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/06/06 21:40:51 Modified files: include : application_queue.php Log message: Chris Morgan <cmorgan(a)alum.wpi.edu> Add cellpadding to make the duplicates table look nicer Patch: http://cvs.winehq.org/patch.py?id=31161 Old revision New revision Changes Path 1.5 1.6 +1 -1 appdb/include/application_queue.php Index: appdb/include/application_queue.php diff -u -p appdb/include/application_queue.php:1.5 appdb/include/application_queue.php:1.6 --- appdb/include/application_queue.php:1.5 7 Jun 2007 2:40:51 -0000 +++ appdb/include/application_queue.php 7 Jun 2007 2:40:51 -0000 @@ -253,7 +253,7 @@ class application_queue $bCanMove = FALSE; } - echo "<table>"; + echo "<table cellpadding='5px'>"; echo html_tr($aHeader, "color4"); for($i = 0; $oRow = mysql_fetch_object($hResult); $i++)

1 0

appdb/include testData.php
by WineHQ June 7, 2007

June 7, 2007

ChangeSet ID: 31160 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/06/06 21:04:16 Modified files: include : testData.php Log message: Chris Morgan <cmorgan(a)alum.wpi.edu> Add a column to the test data queue to indicate whether a test result is for a application version that has maintainers. This lets admins defer processing test results to give appliction and version maintiners a chance to do so. Patch: http://cvs.winehq.org/patch.py?id=31160 Old revision New revision Changes Path 1.54 1.55 +7 -0 appdb/include/testData.php Index: appdb/include/testData.php diff -u -p appdb/include/testData.php:1.54 appdb/include/testData.php:1.55 --- appdb/include/testData.php:1.54 7 Jun 2007 2: 4:16 -0000 +++ appdb/include/testData.php 7 Jun 2007 2: 4:16 -0000 @@ -897,6 +897,7 @@ class testData{ "Application", "Version", "Release", + "Has maintainer", "Rating"); return $aCells; } @@ -911,12 +912,18 @@ class testData{ $oVersion = new version($this->iVersionId); $oApp = new application($oVersion->iAppId); $oUser = new user($this->iSubmitterId); + + // + $hMaintainers = maintainer::getMaintainersForAppIdVersionId(null, $this->iVersionId); + $bHasMaintainer = (mysql_num_rows($hMaintainers) == 0) ? false : true; + $aCells = array( print_date(mysqltimestamp_to_unixtimestamp($this->sSubmitTime)), $oUser->objectMakeLink(), $oApp->objectMakeLink(), $oVersion->objectMakeLink(), $this->sTestedRelease, + ($bHasMaintainer ? "YES" : "no"), $this->sTestedRating); if($this->canEdit() or $this->sQueued == "rejected")

1 0

Andrew Talbot : oleaut32: Fix some typos.
by Alexandre Julliard June 6, 2007

June 6, 2007

Module: wine Branch: master Commit: 1ab9649079fd13978717022d5051c9851c88db2a URL: http://source.winehq.org/git/wine.git/?a=commit;h=1ab9649079fd13978717022d5… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Jun 5 23:08:40 2007 +0100 oleaut32: Fix some typos. --- dlls/oleaut32/oleaut.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/oleaut32/oleaut.c b/dlls/oleaut32/oleaut.c index 1fe68b8..6778af1 100644 --- a/dlls/oleaut32/oleaut.c +++ b/dlls/oleaut32/oleaut.c @@ -691,8 +691,8 @@ HRESULT WINAPI OleTranslateColor( extern HRESULT OLEAUTPS_DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv); -extern void _get_STDFONT_CF(LPVOID); -extern void _get_STDPIC_CF(LPVOID); +extern void _get_STDFONT_CF(LPVOID *); +extern void _get_STDPIC_CF(LPVOID *); static HRESULT WINAPI PSDispatchFacBuf_QueryInterface(IPSFactoryBuffer *iface, REFIID riid, void **ppv) {

1 0

Andrew Talbot : msi: Constify some variables.
by Alexandre Julliard June 6, 2007

June 6, 2007

Module: wine Branch: master Commit: a0ae69a8d10a8be3344eeda35d17669668406802 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0ae69a8d10a8be3344eeda35… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Jun 5 18:53:43 2007 +0100 msi: Constify some variables. --- dlls/msi/helpers.c | 6 +++--- dlls/msi/insert.c | 6 +++--- dlls/msi/msi.c | 2 +- dlls/msi/msipriv.h | 12 ++++++------ dlls/msi/package.c | 2 +- dlls/msi/query.h | 4 ++-- dlls/msi/record.c | 4 ++-- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/dlls/msi/helpers.c b/dlls/msi/helpers.c index 7357bd7..36cbda4 100644 --- a/dlls/msi/helpers.c +++ b/dlls/msi/helpers.c @@ -793,7 +793,7 @@ void ui_actiondata(MSIPACKAGE *package, LPCWSTR action, MSIRECORD * record) msiobj_release(&row->hdr); } -BOOL ACTION_VerifyComponentForAction( MSICOMPONENT* comp, INSTALLSTATE check ) +BOOL ACTION_VerifyComponentForAction( const MSICOMPONENT* comp, INSTALLSTATE check ) { if (!comp) return FALSE; @@ -807,7 +807,7 @@ BOOL ACTION_VerifyComponentForAction( MSICOMPONENT* comp, INSTALLSTATE check ) return FALSE; } -BOOL ACTION_VerifyFeatureForAction( MSIFEATURE* feature, INSTALLSTATE check ) +BOOL ACTION_VerifyFeatureForAction( const MSIFEATURE* feature, INSTALLSTATE check ) { if (!feature) return FALSE; @@ -969,7 +969,7 @@ UINT register_unique_action(MSIPACKAGE *package, LPCWSTR action) return ERROR_SUCCESS; } -BOOL check_unique_action(MSIPACKAGE *package, LPCWSTR action) +BOOL check_unique_action(const MSIPACKAGE *package, LPCWSTR action) { INT i; diff --git a/dlls/msi/insert.c b/dlls/msi/insert.c index 623359f..48706ea 100644 --- a/dlls/msi/insert.c +++ b/dlls/msi/insert.c @@ -62,7 +62,7 @@ static UINT INSERT_fetch_int( struct tagMSIVIEW *view, UINT row, UINT col, UINT * Merge a value_list and a record to create a second record. * Replace wildcard entries in the valuelist with values from the record */ -MSIRECORD *msi_query_merge_record( UINT fields, column_info *vl, MSIRECORD *rec ) +MSIRECORD *msi_query_merge_record( UINT fields, const column_info *vl, MSIRECORD *rec ) { MSIRECORD *merged; DWORD wildcard_count = 1, i; @@ -234,7 +234,7 @@ static const MSIVIEWOPS insert_ops = INSERT_find_matching_rows }; -static UINT count_column_info( column_info *ci ) +static UINT count_column_info( const column_info *ci ) { UINT n = 0; for ( ; ci; ci = ci->next ) @@ -242,7 +242,7 @@ static UINT count_column_info( column_info *ci ) return n; } -UINT INSERT_CreateView( MSIDATABASE *db, MSIVIEW **view, LPWSTR table, +UINT INSERT_CreateView( MSIDATABASE *db, MSIVIEW **view, LPCWSTR table, column_info *columns, column_info *values, BOOL temp ) { MSIINSERTVIEW *iv = NULL; diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 34721df..927c47f 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -1413,7 +1413,7 @@ INSTALLSTATE WINAPI MsiUseFeatureA( LPCSTR szProduct, LPCSTR szFeature ) * MSI_ProvideQualifiedComponentEx [internal] */ static UINT WINAPI MSI_ProvideQualifiedComponentEx(LPCWSTR szComponent, - LPCWSTR szQualifier, DWORD dwInstallMode, LPWSTR szProduct, + LPCWSTR szQualifier, DWORD dwInstallMode, LPCWSTR szProduct, DWORD Unused1, DWORD Unused2, awstring *lpPathBuf, DWORD* pcchPathBuf) { diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 2d05d76..c43f484 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -587,7 +587,7 @@ extern UINT MSI_SetFeatureStates( MSIPACKAGE *package ); /* record internals */ extern UINT MSI_RecordSetIStream( MSIRECORD *, unsigned int, IStream *); extern UINT MSI_RecordGetIStream( MSIRECORD *, unsigned int, IStream **); -extern const WCHAR *MSI_RecordGetString( MSIRECORD *, unsigned int ); +extern const WCHAR *MSI_RecordGetString( const MSIRECORD *, unsigned int ); extern MSIRECORD *MSI_CreateRecord( unsigned int ); extern UINT MSI_RecordSetInteger( MSIRECORD *, unsigned int, int ); extern UINT MSI_RecordSetStringW( MSIRECORD *, unsigned int, LPCWSTR ); @@ -597,7 +597,7 @@ extern UINT MSI_RecordGetStringW( MSIRECORD * , unsigned int, LPWSTR, DWORD *); extern UINT MSI_RecordGetStringA( MSIRECORD *, unsigned int, LPSTR, DWORD *); extern int MSI_RecordGetInteger( MSIRECORD *, unsigned int ); extern UINT MSI_RecordReadStream( MSIRECORD *, unsigned int, char *, DWORD *); -extern unsigned int MSI_RecordGetFieldCount( MSIRECORD *rec ); +extern unsigned int MSI_RecordGetFieldCount( const MSIRECORD *rec ); extern UINT MSI_RecordSetStream( MSIRECORD *, unsigned int, IStream * ); extern UINT MSI_RecordDataSize( MSIRECORD *, unsigned int ); extern UINT MSI_RecordStreamToFile( MSIRECORD *, unsigned int, LPCWSTR ); @@ -634,7 +634,7 @@ extern UINT VIEW_find_column( MSIVIEW *, LPCWSTR, UINT * ); extern UINT MSI_SetInstallLevel( MSIPACKAGE *package, int iInstallLevel ); /* package internals */ -extern MSIPACKAGE *MSI_CreatePackage( MSIDATABASE *, LPWSTR ); +extern MSIPACKAGE *MSI_CreatePackage( MSIDATABASE *, LPCWSTR ); extern UINT MSI_OpenPackageW( LPCWSTR szPackage, MSIPACKAGE ** ); extern UINT MSI_SetTargetPathW( MSIPACKAGE *, LPCWSTR, LPCWSTR ); extern UINT MSI_SetPropertyW( MSIPACKAGE *, LPCWSTR, LPCWSTR ); @@ -770,14 +770,14 @@ extern void msi_free_action_script(MSIPACKAGE *package, UINT script); extern LPWSTR build_icon_path(MSIPACKAGE *, LPCWSTR); extern LPWSTR build_directory_name(DWORD , ...); extern BOOL create_full_pathW(const WCHAR *path); -extern BOOL ACTION_VerifyComponentForAction(MSICOMPONENT*, INSTALLSTATE); -extern BOOL ACTION_VerifyFeatureForAction(MSIFEATURE*, INSTALLSTATE); +extern BOOL ACTION_VerifyComponentForAction(const MSICOMPONENT*, INSTALLSTATE); +extern BOOL ACTION_VerifyFeatureForAction(const MSIFEATURE*, INSTALLSTATE); extern void reduce_to_longfilename(WCHAR*); extern void reduce_to_shortfilename(WCHAR*); extern LPWSTR create_component_advertise_string(MSIPACKAGE*, MSICOMPONENT*, LPCWSTR); extern void ACTION_UpdateComponentStates(MSIPACKAGE *package, LPCWSTR szFeature); extern UINT register_unique_action(MSIPACKAGE *, LPCWSTR); -extern BOOL check_unique_action(MSIPACKAGE *, LPCWSTR); +extern BOOL check_unique_action(const MSIPACKAGE *, LPCWSTR); extern WCHAR* generate_error_string(MSIPACKAGE *, UINT, DWORD, ... ); extern UINT msi_create_component_directories( MSIPACKAGE *package ); extern void msi_ui_error( DWORD msg_id, DWORD type ); diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 77dbaff..e93ee03 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -587,7 +587,7 @@ static MSIPACKAGE *msi_alloc_package( void ) return package; } -MSIPACKAGE *MSI_CreatePackage( MSIDATABASE *db, LPWSTR base_url ) +MSIPACKAGE *MSI_CreatePackage( MSIDATABASE *db, LPCWSTR base_url ) { static const WCHAR szLevel[] = { 'U','I','L','e','v','e','l',0 }; static const WCHAR szpi[] = {'%','i',0}; diff --git a/dlls/msi/query.h b/dlls/msi/query.h index 2bf8955..6cb7709 100644 --- a/dlls/msi/query.h +++ b/dlls/msi/query.h @@ -111,7 +111,7 @@ UINT WHERE_CreateView( MSIDATABASE *db, MSIVIEW **view, MSIVIEW *table, UINT CREATE_CreateView( MSIDATABASE *db, MSIVIEW **view, LPWSTR table, column_info *col_info, BOOL hold ); -UINT INSERT_CreateView( MSIDATABASE *db, MSIVIEW **view, LPWSTR table, +UINT INSERT_CreateView( MSIDATABASE *db, MSIVIEW **view, LPCWSTR table, column_info *columns, column_info *values, BOOL temp ); UINT UPDATE_CreateView( MSIDATABASE *db, MSIVIEW **, LPWSTR table, @@ -128,7 +128,7 @@ UINT STREAMS_CreateView( MSIDATABASE *db, MSIVIEW **view ); int sqliteGetToken(const WCHAR *z, int *tokenType); -MSIRECORD *msi_query_merge_record( UINT fields, column_info *vl, MSIRECORD *rec ); +MSIRECORD *msi_query_merge_record( UINT fields, const column_info *vl, MSIRECORD *rec ); UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, BOOL persistent, MSITABLE **table_ret); diff --git a/dlls/msi/record.c b/dlls/msi/record.c index fed7bf4..159f7d1 100644 --- a/dlls/msi/record.c +++ b/dlls/msi/record.c @@ -106,7 +106,7 @@ MSIHANDLE WINAPI MsiCreateRecord( unsigned int cParams ) return ret; } -unsigned int MSI_RecordGetFieldCount( MSIRECORD *rec ) +unsigned int MSI_RecordGetFieldCount( const MSIRECORD *rec ) { return rec->count; } @@ -393,7 +393,7 @@ UINT WINAPI MsiRecordGetStringA(MSIHANDLE handle, unsigned int iField, return ret; } -const WCHAR *MSI_RecordGetString( MSIRECORD *rec, unsigned int iField ) +const WCHAR *MSI_RecordGetString( const MSIRECORD *rec, unsigned int iField ) { if( iField > rec->count ) return NULL;

1 0

Jacek Caban : urlmon: Don't pass query part of URL to CreateUrlCacheEntryW.
by Alexandre Julliard June 6, 2007

June 6, 2007

Module: wine Branch: master Commit: daca693f30b2c4c96e570a4523ccc4c8bfb07b77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=daca693f30b2c4c96e570a452… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 6 04:01:13 2007 +0200 urlmon: Don't pass query part of URL to CreateUrlCacheEntryW. --- dlls/urlmon/umstream.c | 28 +++++++++++++--------------- 1 files changed, 13 insertions(+), 15 deletions(-) diff --git a/dlls/urlmon/umstream.c b/dlls/urlmon/umstream.c index 4a49b77..cd5e153 100644 --- a/dlls/urlmon/umstream.c +++ b/dlls/urlmon/umstream.c @@ -49,32 +49,30 @@ HRESULT UMCreateStreamOnCacheFile(LPCWSTR pszURL, { IUMCacheStream* ucstr; HANDLE handle; - LPWSTR ext; - LPCWSTR c; - LPCWSTR eloc = 0; + DWORD size; + LPWSTR url, c, ext = NULL; HRESULT hr; - for (c = pszURL; *c && *c != '#' && *c != '?'; ++c) + size = (strlenW(pszURL)+1)*sizeof(WCHAR); + url = HeapAlloc(GetProcessHeap(), 0, size); + memcpy(url, pszURL, size); + + for (c = url; *c && *c != '#' && *c != '?'; ++c) { if (*c == '.') - eloc = c + 1; - else if (*c == '/' || *c == '\\') - eloc = 0; + ext = c+1; + else if(*c == '/') + ext = NULL; } - if (!eloc) - eloc = c; - - ext = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (c - eloc + 1)); - memcpy(ext, eloc, sizeof(WCHAR) * (c - eloc)); - ext[c - eloc] = 0; + *c = 0; - if(!CreateUrlCacheEntryW(pszURL, dwSize, ext, pszFileName, 0)) + if(!CreateUrlCacheEntryW(url, dwSize, ext, pszFileName, 0)) hr = HRESULT_FROM_WIN32(GetLastError()); else hr = 0; - HeapFree(GetProcessHeap(), 0, ext); + HeapFree(GetProcessHeap(), 0, url); if (hr) return hr;

1 0