June 2007 - Wine-Commits - list.winehq.org

Ulrich Czekalla : ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: c2fdea600ab19822ecd23441838900fc6699c2ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=c2fdea600ab19822ecd234418… Author: Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> Date: Thu Jun 7 13:43:41 2007 -0400 ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath. --- dlls/ole32/filemoniker.c | 40 ++++++++++++++++++++++++++++++++++------ 1 files changed, 34 insertions(+), 6 deletions(-) diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c index 7578836..4ef7d59 100644 --- a/dlls/ole32/filemoniker.c +++ b/dlls/ole32/filemoniker.c @@ -1011,19 +1011,27 @@ FileMonikerImpl_CommonPrefixWith(IMoniker* iface,IMoniker* pmkOther,IMoniker** p int FileMonikerImpl_DecomposePath(LPCOLESTR str, LPOLESTR** stringTable) { static const WCHAR bSlash[] = {'\\',0}; - WCHAR word[MAX_PATH]; - int i=0,j,tabIndex=0; + LPOLESTR word; + int i=0,j,tabIndex=0, ret=0; LPOLESTR *strgtable ; int len=lstrlenW(str); TRACE("%s, %p\n", debugstr_w(str), *stringTable); - strgtable =CoTaskMemAlloc(len*sizeof(LPOLESTR)); + strgtable = CoTaskMemAlloc(len*sizeof(WCHAR)); if (strgtable==NULL) return E_OUTOFMEMORY; + word = CoTaskMemAlloc((len + 1)*sizeof(WCHAR)); + + if (word==NULL) + { + ret = E_OUTOFMEMORY; + goto lend; + } + while(str[i]!=0){ if(str[i]==bSlash[0]){ @@ -1031,7 +1039,10 @@ int FileMonikerImpl_DecomposePath(LPCOLESTR str, LPOLESTR** stringTable) strgtable[tabIndex]=CoTaskMemAlloc(2*sizeof(WCHAR)); if (strgtable[tabIndex]==NULL) - return E_OUTOFMEMORY; + { + ret = E_OUTOFMEMORY; + goto lend; + } strcpyW(strgtable[tabIndex++],bSlash); @@ -1048,7 +1059,10 @@ int FileMonikerImpl_DecomposePath(LPCOLESTR str, LPOLESTR** stringTable) strgtable[tabIndex]=CoTaskMemAlloc(sizeof(WCHAR)*(j+1)); if (strgtable[tabIndex]==NULL) - return E_OUTOFMEMORY; + { + ret = E_OUTOFMEMORY; + goto lend; + } strcpyW(strgtable[tabIndex++],word); } @@ -1057,7 +1071,21 @@ int FileMonikerImpl_DecomposePath(LPCOLESTR str, LPOLESTR** stringTable) *stringTable=strgtable; - return tabIndex; + ret = tabIndex; + +lend: + if (ret < 0) + { + for (i = 0; i < tabIndex; i++) + CoTaskMemFree(strgtable[i]); + + CoTaskMemFree(strgtable); + } + + if (word) + CoTaskMemFree(word); + + return ret; } /******************************************************************************

1 0

H. Verbeet : wined3d: Turn off filtering for FBO attachments, update the texture's states array.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 473e914c29ee1196f4f7ab024acb3f61d2f843c3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=473e914c29ee1196f4f7ab024… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Thu Jun 7 18:57:15 2007 +0200 wined3d: Turn off filtering for FBO attachments, update the texture's states array. --- dlls/wined3d/device.c | 28 ++++++++++++++++++++++++++-- 1 files changed, 26 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 769e188..3ede720 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -5169,6 +5169,7 @@ static void bind_fbo(IWineD3DDevice *iface, GLenum target, GLuint *fbo) { static void attach_surface_fbo(IWineD3DDeviceImpl *This, GLenum fbo_target, DWORD idx, IWineD3DSurface *surface) { const IWineD3DSurfaceImpl *surface_impl = (IWineD3DSurfaceImpl *)surface; + IWineD3DBaseTextureImpl *texture_impl; GLenum texttarget, target; GLint old_binding; @@ -5178,10 +5179,21 @@ static void attach_surface_fbo(IWineD3DDeviceImpl *This, GLenum fbo_target, DWOR IWineD3DSurface_PreLoad(surface); - glTexParameteri(target, GL_TEXTURE_MIN_FILTER, GL_LINEAR); - glTexParameteri(target, GL_TEXTURE_MAG_FILTER, GL_LINEAR); + glTexParameteri(target, GL_TEXTURE_MIN_FILTER, GL_NEAREST); + glTexParameteri(target, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glBindTexture(target, old_binding); + /* Update base texture states array */ + if (SUCCEEDED(IWineD3DSurface_GetContainer(surface, &IID_IWineD3DBaseTexture, (void **)&texture_impl))) { + texture_impl->baseTexture.states[WINED3DTEXSTA_MINFILTER] = WINED3DTEXF_POINT; + texture_impl->baseTexture.states[WINED3DTEXSTA_MAGFILTER] = WINED3DTEXF_POINT; + if (texture_impl->baseTexture.bindCount) { + IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SAMPLER(texture_impl->baseTexture.sampler)); + } + + IWineD3DBaseTexture_Release((IWineD3DBaseTexture *)texture_impl); + } + GL_EXTCALL(glFramebufferTexture2DEXT(fbo_target, GL_COLOR_ATTACHMENT0_EXT + idx, texttarget, surface_impl->glDescription.textureName, 0)); checkGLcall("attach_surface_fbo"); @@ -5393,6 +5405,7 @@ static void set_depth_stencil_fbo(IWineD3DDevice *iface, IWineD3DSurface *depth_ GL_EXTCALL(glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT, GL_DEPTH_ATTACHMENT_EXT, GL_RENDERBUFFER_EXT, depth_stencil_impl->current_renderbuffer->id)); checkGLcall("glFramebufferRenderbufferEXT()"); } else { + IWineD3DBaseTextureImpl *texture_impl; GLenum texttarget, target; GLint old_binding = 0; @@ -5407,6 +5420,17 @@ static void set_depth_stencil_fbo(IWineD3DDevice *iface, IWineD3DSurface *depth_ glTexParameteri(target, GL_DEPTH_TEXTURE_MODE_ARB, GL_LUMINANCE); glBindTexture(target, old_binding); + /* Update base texture states array */ + if (SUCCEEDED(IWineD3DSurface_GetContainer(depth_stencil, &IID_IWineD3DBaseTexture, (void **)&texture_impl))) { + texture_impl->baseTexture.states[WINED3DTEXSTA_MINFILTER] = WINED3DTEXF_POINT; + texture_impl->baseTexture.states[WINED3DTEXSTA_MAGFILTER] = WINED3DTEXF_POINT; + if (texture_impl->baseTexture.bindCount) { + IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SAMPLER(texture_impl->baseTexture.sampler)); + } + + IWineD3DBaseTexture_Release((IWineD3DBaseTexture *)texture_impl); + } + GL_EXTCALL(glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, GL_DEPTH_ATTACHMENT_EXT, texttarget, depth_stencil_impl->glDescription.textureName, 0)); checkGLcall("glFramebufferTexture2DEXT()"); }

1 0

Vitaliy Margolen : atl: Use CallWindowProc instead of calling old window proc directly.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: a2daceb7c2a7abd9c465771129bdd02ec85b5532 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a2daceb7c2a7abd9c46577112… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Thu Jun 7 06:51:42 2007 -0600 atl: Use CallWindowProc instead of calling old window proc directly. --- dlls/atl/atl_ax.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c index 4f0b7cb..8201d09 100644 --- a/dlls/atl/atl_ax.c +++ b/dlls/atl/atl_ax.c @@ -848,7 +848,7 @@ static LRESULT IOCS_OnWndProc( IOCS *This, HWND hWnd, UINT uMsg, WPARAM wParam, break; } - return OrigWndProc( hWnd, uMsg, wParam, lParam ); + return CallWindowProcW( OrigWndProc, hWnd, uMsg, wParam, lParam ); } static LRESULT CALLBACK AtlHost_wndproc( HWND hWnd, UINT wMsg, WPARAM wParam, LPARAM lParam ) @@ -862,9 +862,8 @@ static HRESULT IOCS_Attach( IOCS *This, HWND hWnd, IUnknown *pUnkControl ) /* su This->hWnd = hWnd; IUnknown_QueryInterface( pUnkControl, &IID_IOleObject, (void**)&This->control ); IOleObject_SetClientSite( This->control, THIS2IOLECLIENTSITE( This ) ); - This->OrigWndProc = (WNDPROC) GetWindowLongPtrW( This->hWnd, GWLP_WNDPROC ); SetWindowLongPtrW( hWnd, GWLP_USERDATA, (ULONG_PTR) This ); - SetWindowLongPtrW( hWnd, GWLP_WNDPROC, (ULONG_PTR) AtlHost_wndproc ); + This->OrigWndProc = (WNDPROC)SetWindowLongPtrW( hWnd, GWLP_WNDPROC, (ULONG_PTR) AtlHost_wndproc ); return S_OK; }

1 0

Alexandre Julliard : winmm: Get rid of the WINE_MM_IDATA global structure, there's only one instance anyway.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 1e178be8620eab61438542d4b9d8e1d09eba1ff1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1e178be8620eab61438542d4b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 7 17:50:28 2007 +0200 winmm: Get rid of the WINE_MM_IDATA global structure, there's only one instance anyway. --- dlls/winmm/mci.c | 65 +++++++++++++++++++++++------------------------ dlls/winmm/mmio.c | 22 +++++++++------- dlls/winmm/mmsystem.c | 2 - dlls/winmm/playsound.c | 47 ++++++++++++++++++++++------------ dlls/winmm/time.c | 31 +++++++++++++++------- dlls/winmm/winemm.h | 45 +++------------------------------ dlls/winmm/winmm.c | 35 ++++++++++++++------------ 7 files changed, 118 insertions(+), 129 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1e178be8620eab6143854…

1 0

Paul Vriens : comdlg32/tests: Skip some not implemented functions on win98.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: b4b88b055d760f809b267feac5c2fa74b8c702e0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b4b88b055d760f809b267feac… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Thu Jun 7 11:47:58 2007 +0200 comdlg32/tests: Skip some not implemented functions on win98. --- dlls/comdlg32/tests/filedlg.c | 24 ++++++++++++++++++------ 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/dlls/comdlg32/tests/filedlg.c b/dlls/comdlg32/tests/filedlg.c index 9ae0c40..03192ba 100644 --- a/dlls/comdlg32/tests/filedlg.c +++ b/dlls/comdlg32/tests/filedlg.c @@ -72,10 +72,16 @@ static void test_DialogCancel(void) ok(CDERR_INITIALIZATION == CommDlgExtendedError(), "expected %d, got %d\n", CDERR_INITIALIZATION, CommDlgExtendedError()); + SetLastError(0xdeadbeef); result = GetOpenFileNameW((LPOPENFILENAMEW) &ofn); - ok(0 == result, "expected %d, got %d\n", 0, result); - ok(0 == CommDlgExtendedError(), "expected %d, got %d\n", 0, - CommDlgExtendedError()); + if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) + skip("GetOpenFileNameW is not implemented\n"); + else + { + ok(0 == result, "expected %d, got %d\n", 0, result); + ok(0 == CommDlgExtendedError(), "expected %d, got %d\n", 0, + CommDlgExtendedError()); + } PrintDlgA(NULL); ok(CDERR_INITIALIZATION == CommDlgExtendedError(), "expected %d, got %d\n", @@ -90,10 +96,16 @@ static void test_DialogCancel(void) ok(CDERR_INITIALIZATION == CommDlgExtendedError(), "expected %d, got %d\n", CDERR_INITIALIZATION, CommDlgExtendedError()); + SetLastError(0xdeadbeef); result = GetSaveFileNameW((LPOPENFILENAMEW) &ofn); - ok(0 == result, "expected %d, got %d\n", 0, result); - ok(0 == CommDlgExtendedError(), "expected %d, got %d\n", 0, - CommDlgExtendedError()); + if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) + skip("GetSaveFileNameW is not implemented\n"); + else + { + ok(0 == result, "expected %d, got %d\n", 0, result); + ok(0 == CommDlgExtendedError(), "expected %d, got %d\n", 0, + CommDlgExtendedError()); + } }

1 0

Hans Leidekker : wininet: More lenient parsing of the passive mode server response.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 9a6ba225e264e59125d83d6359af60aaa8322c3d URL: http://source.winehq.org/git/wine.git/?a=commit;h=9a6ba225e264e59125d83d635… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Thu Jun 7 16:32:24 2007 +0200 wininet: More lenient parsing of the passive mode server response. --- dlls/wininet/ftp.c | 13 +++---------- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c index 604f383..d9291c2 100644 --- a/dlls/wininet/ftp.c +++ b/dlls/wininet/ftp.c @@ -2545,18 +2545,11 @@ static BOOL FTP_DoPassive(LPWININETFTPSESSIONW lpwfs) struct sockaddr_in dataSocketAddress; p = lpszResponseBuffer+4; /* skip status code */ + while (*p != '\0' && (*p < '0' || *p > '9')) p++; - /* do a very strict check; we can improve that later. */ - - if (strncmp(p, "Entering Passive Mode", 21)) - { - ERR("unknown response '%.*s', aborting\n", 21, p); - goto lend; - } - p += 21; /* skip string */ - if ((*p++ != ' ') || (*p++ != '(')) + if (*p == '\0') { - ERR("unknown response format, aborting\n"); + ERR("no address found in response, aborting\n"); goto lend; }

1 0

Francois Gouget : wined3d: Fix spelling of the state_separateblend() function.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 7d55f09e7515f3ca6f9e25d9022a7f10b524568a URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d55f09e7515f3ca6f9e25d90… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 7 11:48:30 2007 +0200 wined3d: Fix spelling of the state_separateblend() function. --- dlls/wined3d/state.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 6676cf3..54275c2 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -1452,7 +1452,7 @@ static void state_srgbwrite(DWORD state, IWineD3DStateBlockImpl *stateblock, Win FIXME("Render state WINED3DRS_SRGBWRITEENABLE not yet implemented\n"); } -static void state_seperateblend(DWORD state, IWineD3DStateBlockImpl *stateblock, WineD3DContext *context) { +static void state_separateblend(DWORD state, IWineD3DStateBlockImpl *stateblock, WineD3DContext *context) { TRACE("Stub\n"); if(stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]) FIXME("(WINED3DRS_SEPARATEALPHABLENDENABLE,%d) not yet implemented\n", stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]); @@ -3654,10 +3654,10 @@ const struct StateEntry StateTable[] = { /*203, WINED3DRS_WRAP13 */ STATE_RENDER(WINED3DRS_WRAP0), state_wrap }, { /*204, WINED3DRS_WRAP14 */ STATE_RENDER(WINED3DRS_WRAP0), state_wrap }, { /*205, WINED3DRS_WRAP15 */ STATE_RENDER(WINED3DRS_WRAP0), state_wrap }, - { /*206, WINED3DRS_SEPARATEALPHABLENDENABLE */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_seperateblend }, - { /*207, WINED3DRS_SRCBLENDALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_seperateblend }, - { /*208, WINED3DRS_DESTBLENDALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_seperateblend }, - { /*209, WINED3DRS_BLENDOPALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_seperateblend }, + { /*206, WINED3DRS_SEPARATEALPHABLENDENABLE */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_separateblend }, + { /*207, WINED3DRS_SRCBLENDALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_separateblend }, + { /*208, WINED3DRS_DESTBLENDALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_separateblend }, + { /*209, WINED3DRS_BLENDOPALPHA */ STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE), state_separateblend }, /* Texture stage states */ { /*0, 01, WINED3DTSS_COLOROP */ STATE_TEXTURESTAGE(0, WINED3DTSS_COLOROP), tex_colorop }, { /*0, 02, WINED3DTSS_COLORARG1 */ STATE_TEXTURESTAGE(0, WINED3DTSS_COLOROP), tex_colorop },

1 0

Francois Gouget : Assorted spelling fixes.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 96c337f0a143b9ee0391d0c1bea627f57656c596 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96c337f0a143b9ee0391d0c1b… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 7 11:48:55 2007 +0200 Assorted spelling fixes. --- dlls/comctl32/commctrl.c | 8 ++++---- dlls/comctl32/tests/toolbar.c | 2 +- dlls/dbghelp/type.c | 2 +- dlls/localspl/tests/localmon.c | 4 ++-- dlls/mciavi32/info.c | 4 ++-- dlls/odbccp32/tests/misc.c | 2 +- dlls/riched20/editor.c | 2 +- dlls/shell32/tests/shlexec.c | 4 ++-- dlls/shlwapi/tests/shreg.c | 12 +++++++----- dlls/version/info.c | 2 +- dlls/version/tests/info.c | 2 +- dlls/wined3d/device.c | 4 ++-- dlls/wined3d/state.c | 2 +- dlls/wined3d/surface.c | 10 +++++----- dlls/winedos/int10.c | 8 ++++---- include/wine/wined3d_interface.h | 2 +- 16 files changed, 36 insertions(+), 34 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=96c337f0a143b9ee0391d…

1 0

Maarten Lankhorst : winmm: Use unix fd' s instead of win32 events to sync internal events in timer.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 0383e4e4990e414a7dcaba51e6b81bf60499944a URL: http://source.winehq.org/git/wine.git/?a=commit;h=0383e4e4990e414a7dcaba51e… Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Tue Jun 5 19:32:20 2007 +0200 winmm: Use unix fd's instead of win32 events to sync internal events in timer. --- dlls/winmm/time.c | 67 ++++++++++++++++++++++++++++++++++++---------------- 1 files changed, 46 insertions(+), 21 deletions(-) diff --git a/dlls/winmm/time.c b/dlls/winmm/time.c index d392786..9329b27 100644 --- a/dlls/winmm/time.c +++ b/dlls/winmm/time.c @@ -24,6 +24,7 @@ #include "wine/port.h" #include <stdarg.h> +#include <errno.h> #include <time.h> #ifdef HAVE_SYS_TIME_H # include <sys/time.h> @@ -31,6 +32,12 @@ #ifdef HAVE_UNISTD_H # include <unistd.h> #endif +#ifdef HAVE_POLL_H +#include <poll.h> +#endif +#ifdef HAVE_SYS_POLL_H +#include <sys/poll.h> +#endif #include "windef.h" #include "winbase.h" @@ -44,9 +51,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(mmtime); static HANDLE TIME_hMMTimer; static LPWINE_TIMERENTRY TIME_TimersList; -static HANDLE TIME_hWakeEvent; static CRITICAL_SECTION TIME_cbcrst; static BOOL TIME_TimeToDie = TRUE; +static int TIME_fdWake[2] = { -1, -1 }; /* * Some observations on the behavior of winmm on Windows. @@ -219,7 +226,12 @@ static LPWINE_TIMERENTRY lpTimers; static DWORD CALLBACK TIME_MMSysTimeThread(LPVOID arg) { LPWINE_MM_IDATA iData = (LPWINE_MM_IDATA)arg; - DWORD rc; + int sleep_time, ret; + char readme[16]; + struct pollfd pfd; + + pfd.fd = TIME_fdWake[0]; + pfd.events = POLLIN; TRACE("Starting main winmm thread\n"); @@ -231,17 +243,21 @@ static DWORD CALLBACK TIME_MMSysTimeThread(LPVOID arg) while (! TIME_TimeToDie) { - int sleep_time = TIME_MMSysTimeCallback(iData); + sleep_time = TIME_MMSysTimeCallback(iData); if (sleep_time == 0) continue; - rc = WaitForSingleObject(TIME_hWakeEvent, (sleep_time == -1) ? INFINITE : (DWORD)sleep_time); - if (rc != WAIT_TIMEOUT && rc != WAIT_OBJECT_0) - { - FIXME("Unexpected error %d(%d) in timer thread\n", rc, GetLastError()); - break; - } + if ((ret = poll(&pfd, 1, sleep_time)) < 0) + { + if (errno != EINTR && errno != EAGAIN) + { + ERR("Unexpected error in poll: %s(%d)\n", strerror(errno), errno); + break; + } + } + + while (ret > 0) ret = read(TIME_fdWake[0], readme, sizeof(readme)); } TRACE("Exiting main winmm thread\n"); return 0; @@ -253,10 +269,17 @@ static DWORD CALLBACK TIME_MMSysTimeThread(LPVOID arg) void TIME_MMTimeStart(void) { if (!TIME_hMMTimer) { - TIME_TimersList = NULL; - TIME_hWakeEvent = CreateEventW(NULL, FALSE, FALSE, NULL); + TIME_TimersList = NULL; + if (pipe(TIME_fdWake) < 0) + { + TIME_fdWake[0] = TIME_fdWake[1] = -1; + ERR("Cannot create pipe: %s\n", strerror(errno)); + } else { + fcntl(TIME_fdWake[0], F_SETFL, O_NONBLOCK); + fcntl(TIME_fdWake[1], F_SETFL, O_NONBLOCK); + } TIME_TimeToDie = FALSE; - TIME_hMMTimer = CreateThread(NULL, 0, TIME_MMSysTimeThread, &WINMM_IData, 0, NULL); + TIME_hMMTimer = CreateThread(NULL, 0, TIME_MMSysTimeThread, &WINMM_IData, 0, NULL); SetThreadPriority(TIME_hMMTimer, THREAD_PRIORITY_TIME_CRITICAL); InitializeCriticalSection(&TIME_cbcrst); TIME_cbcrst.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": WINMM.TIME_cbcrst"); @@ -269,16 +292,17 @@ void TIME_MMTimeStart(void) void TIME_MMTimeStop(void) { if (TIME_hMMTimer) { + const char a='a'; TIME_TimeToDie = TRUE; - SetEvent(TIME_hWakeEvent); - - /* FIXME: in the worst case, we're going to wait 65 seconds here :-( */ - WaitForSingleObject(TIME_hMMTimer, INFINITE); - - CloseHandle(TIME_hMMTimer); - CloseHandle(TIME_hWakeEvent); - TIME_hMMTimer = 0; + write(TIME_fdWake[1], &a, sizeof(a)); + + WaitForSingleObject(TIME_hMMTimer, INFINITE); + close(TIME_fdWake[0]); + close(TIME_fdWake[1]); + TIME_fdWake[0] = TIME_fdWake[1] = -1; + CloseHandle(TIME_hMMTimer); + TIME_hMMTimer = 0; TIME_cbcrst.DebugInfo->Spare[0] = 0; DeleteCriticalSection(&TIME_cbcrst); TIME_TimersList = NULL; @@ -309,6 +333,7 @@ WORD TIME_SetEventInternal(UINT wDelay, UINT wResol, WORD wNewID = 0; LPWINE_TIMERENTRY lpNewTimer; LPWINE_TIMERENTRY lpTimer; + const char c = 'c'; TRACE("(%u, %u, %p, %08X, %04X);\n", wDelay, wResol, lpFunc, dwUser, wFlags); @@ -344,7 +369,7 @@ WORD TIME_SetEventInternal(UINT wDelay, UINT wResol, LeaveCriticalSection(&WINMM_IData.cs); /* Wake the service thread in case there is work to be done */ - SetEvent(TIME_hWakeEvent); + write(TIME_fdWake[1], &c, sizeof(c)); TRACE("=> %u\n", wNewID + 1);

1 0

Alexandre Julliard : winmm: Fix computation of sleep time until next timeout.
by Alexandre Julliard June 7, 2007

June 7, 2007

Module: wine Branch: master Commit: 90d94efe1061672265448d1b2071d4e357e9fd8a URL: http://source.winehq.org/git/wine.git/?a=commit;h=90d94efe1061672265448d1b2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 7 16:22:48 2007 +0200 winmm: Fix computation of sleep time until next timeout. --- dlls/winmm/time.c | 48 ++++++++++++++++++++---------------------------- 1 files changed, 20 insertions(+), 28 deletions(-) diff --git a/dlls/winmm/time.c b/dlls/winmm/time.c index 27a4e46..d392786 100644 --- a/dlls/winmm/time.c +++ b/dlls/winmm/time.c @@ -113,7 +113,7 @@ static void TIME_TriggerCallBack(LPWINE_TIMERENTRY lpTimer) /************************************************************************** * TIME_MMSysTimeCallback */ -static DWORD CALLBACK TIME_MMSysTimeCallback(LPWINE_MM_IDATA iData) +static int TIME_MMSysTimeCallback(LPWINE_MM_IDATA iData) { static int nSizeLpTimers; static LPWINE_TIMERENTRY lpTimers; @@ -121,14 +121,7 @@ static LPWINE_TIMERENTRY lpTimers; LPWINE_TIMERENTRY timer, *ptimer, *next_ptimer; int idx; DWORD cur_time; - DWORD delta_time; - DWORD ret_time = INFINITE; - DWORD adjust_time; - - - /* optimize for the most frequent case - no events */ - if (! TIME_TimersList) - return(ret_time); + int delta_time, ret_time = -1; /* since timeSetEvent() and timeKillEvent() can be called * from 16 bit code, there are cases where win16 lock is @@ -151,7 +144,8 @@ static LPWINE_TIMERENTRY lpTimers; for (ptimer = &TIME_TimersList; *ptimer != NULL; ) { timer = *ptimer; next_ptimer = &timer->lpNext; - if (cur_time >= timer->dwTriggerTime) + delta_time = timer->dwTriggerTime - cur_time; + if (delta_time <= 0) { if (timer->lpFunc) { if (idx == nSizeLpTimers) { @@ -180,23 +174,22 @@ static LPWINE_TIMERENTRY lpTimers; HeapFree(GetProcessHeap(), 0, timer); /* We don't need to trigger oneshots again */ - delta_time = INFINITE; + delta_time = -1; } else { /* Compute when this event needs this function to be called again */ - if (timer->dwTriggerTime <= cur_time) - delta_time = 0; - else - delta_time = timer->dwTriggerTime - cur_time; + delta_time = timer->dwTriggerTime - cur_time; + if (delta_time < 0) delta_time = 0; } - } - else - delta_time = timer->dwTriggerTime - cur_time; + } /* Determine when we need to return to this function */ - ret_time = min(ret_time, delta_time); + if (delta_time != -1) + { + if (ret_time == -1 || ret_time > delta_time) ret_time = delta_time; + } ptimer = next_ptimer; } @@ -209,15 +202,15 @@ static LPWINE_TIMERENTRY lpTimers; /* Finally, adjust the recommended wait time downward by the amount of time the processing routines actually took */ - adjust_time = GetTickCount() - cur_time; - if (adjust_time > ret_time) - ret_time = 0; - else - ret_time -= adjust_time; + if (ret_time != -1) + { + ret_time -= GetTickCount() - cur_time; + if (ret_time < 0) ret_time = 0; + } /* We return the amount of time our caller should sleep before needing to check in on us again */ - return(ret_time); + return ret_time; } /************************************************************************** @@ -226,7 +219,6 @@ static LPWINE_TIMERENTRY lpTimers; static DWORD CALLBACK TIME_MMSysTimeThread(LPVOID arg) { LPWINE_MM_IDATA iData = (LPWINE_MM_IDATA)arg; - DWORD sleep_time; DWORD rc; TRACE("Starting main winmm thread\n"); @@ -239,12 +231,12 @@ static DWORD CALLBACK TIME_MMSysTimeThread(LPVOID arg) while (! TIME_TimeToDie) { - sleep_time = TIME_MMSysTimeCallback(iData); + int sleep_time = TIME_MMSysTimeCallback(iData); if (sleep_time == 0) continue; - rc = WaitForSingleObject(TIME_hWakeEvent, sleep_time); + rc = WaitForSingleObject(TIME_hWakeEvent, (sleep_time == -1) ? INFINITE : (DWORD)sleep_time); if (rc != WAIT_TIMEOUT && rc != WAIT_OBJECT_0) { FIXME("Unexpected error %d(%d) in timer thread\n", rc, GetLastError());

1 0