March 2009 - Wine-Commits - list.winehq.org

Jacek Caban : urlmon: Added ftp pluggable protocol implementation.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: ad4a21bc994fc9d72e1ccfdc1be5b37ebc8f3832 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ad4a21bc994fc9d72e1ccfdc1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 2 19:57:35 2009 +0100 urlmon: Added ftp pluggable protocol implementation. --- dlls/urlmon/ftp.c | 115 +++++++++++++++++++++++++++++++++++++++++++---------- 1 files changed, 94 insertions(+), 21 deletions(-) diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c index f79641e..dbdd7a7 100644 --- a/dlls/urlmon/ftp.c +++ b/dlls/urlmon/ftp.c @@ -1,5 +1,5 @@ /* - * Copyright 2005 Jacek Caban + * Copyright 2005-2009 Jacek Caban for CodeWeavers * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -22,17 +22,64 @@ WINE_DEFAULT_DEBUG_CHANNEL(urlmon); typedef struct { + Protocol base; + const IInternetProtocolVtbl *lpInternetProtocolVtbl; const IInternetPriorityVtbl *lpInternetPriorityVtbl; LONG ref; } FtpProtocol; -#define PROTOCOL_THIS(iface) DEFINE_THIS(FtpProtocol, InternetProtocol, iface) - #define PROTOCOL(x) ((IInternetProtocol*) &(x)->lpInternetProtocolVtbl) #define PRIORITY(x) ((IInternetPriority*) &(x)->lpInternetPriorityVtbl) +#define ASYNCPROTOCOL_THIS(iface) DEFINE_THIS2(FtpProtocol, base, iface) + +static HRESULT FtpProtocol_open_request(Protocol *prot, LPCWSTR url, DWORD request_flags, + IInternetBindInfo *bind_info) +{ + FtpProtocol *This = ASYNCPROTOCOL_THIS(prot); + + This->base.request = InternetOpenUrlW(This->base.internet, url, NULL, 0, + request_flags|INTERNET_FLAG_EXISTING_CONNECT|INTERNET_FLAG_PASSIVE, + (DWORD_PTR)&This->base); + if (!This->base.request && GetLastError() != ERROR_IO_PENDING) { + WARN("InternetOpenUrl failed: %d\n", GetLastError()); + return INET_E_RESOURCE_NOT_FOUND; + } + + return S_OK; +} + +static HRESULT FtpProtocol_start_downloading(Protocol *prot) +{ + FtpProtocol *This = ASYNCPROTOCOL_THIS(prot); + DWORD size; + BOOL res; + + res = FtpGetFileSize(This->base.request, &size); + if(res) + This->base.content_length = size; + else + WARN("FtpGetFileSize failed: %d\n", GetLastError()); + + return S_OK; +} + +static void FtpProtocol_close_connection(Protocol *prot) +{ +} + +#undef ASYNCPROTOCOL_THIS + +static const ProtocolVtbl AsyncProtocolVtbl = { + FtpProtocol_open_request, + FtpProtocol_start_downloading, + FtpProtocol_close_connection +}; + +#define PROTOCOL_THIS(iface) DEFINE_THIS(FtpProtocol, InternetProtocol, iface) + static HRESULT WINAPI FtpProtocol_QueryInterface(IInternetProtocol *iface, REFIID riid, void **ppv) { FtpProtocol *This = PROTOCOL_THIS(iface); @@ -77,6 +124,7 @@ static ULONG WINAPI FtpProtocol_Release(IInternetProtocol *iface) TRACE("(%p) ref=%d\n", This, ref); if(!ref) { + protocol_close_connection(&This->base); heap_free(This); URLMON_UnlockModule(); @@ -90,16 +138,25 @@ static HRESULT WINAPI FtpProtocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, DWORD grfPI, DWORD dwReserved) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)->(%s %p %p %08x %d)\n", This, debugstr_w(szUrl), pOIProtSink, - pOIBindInfo, grfPI, dwReserved); - return E_NOTIMPL; + + static const WCHAR ftpW[] = {'f','t','p',':'}; + + TRACE("(%p)->(%s %p %p %08x %d)\n", This, debugstr_w(szUrl), pOIProtSink, + pOIBindInfo, grfPI, dwReserved); + + if(strncmpW(szUrl, ftpW, sizeof(ftpW)/sizeof(WCHAR))) + return MK_E_SYNTAX; + + return protocol_start(&This->base, PROTOCOL(This), szUrl, pOIProtSink, pOIBindInfo); } static HRESULT WINAPI FtpProtocol_Continue(IInternetProtocol *iface, PROTOCOLDATA *pProtocolData) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)->(%p)\n", This, pProtocolData); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, pProtocolData); + + return protocol_continue(&This->base, pProtocolData); } static HRESULT WINAPI FtpProtocol_Abort(IInternetProtocol *iface, HRESULT hrReason, @@ -113,8 +170,11 @@ static HRESULT WINAPI FtpProtocol_Abort(IInternetProtocol *iface, HRESULT hrReas static HRESULT WINAPI FtpProtocol_Terminate(IInternetProtocol *iface, DWORD dwOptions) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)->(%08x)\n", This, dwOptions); - return E_NOTIMPL; + + TRACE("(%p)->(%08x)\n", This, dwOptions); + + protocol_close_connection(&This->base); + return S_OK; } static HRESULT WINAPI FtpProtocol_Suspend(IInternetProtocol *iface) @@ -135,8 +195,10 @@ static HRESULT WINAPI FtpProtocol_Read(IInternetProtocol *iface, void *pv, ULONG cb, ULONG *pcbRead) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)->(%p %u %p)\n", This, pv, cb, pcbRead); - return E_NOTIMPL; + + TRACE("(%p)->(%p %u %p)\n", This, pv, cb, pcbRead); + + return protocol_read(&This->base, pv, cb, pcbRead); } static HRESULT WINAPI FtpProtocol_Seek(IInternetProtocol *iface, LARGE_INTEGER dlibMove, @@ -150,15 +212,19 @@ static HRESULT WINAPI FtpProtocol_Seek(IInternetProtocol *iface, LARGE_INTEGER d static HRESULT WINAPI FtpProtocol_LockRequest(IInternetProtocol *iface, DWORD dwOptions) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)->(%08x)\n", This, dwOptions); - return E_NOTIMPL; + + TRACE("(%p)->(%08x)\n", This, dwOptions); + + return protocol_lock_request(&This->base); } static HRESULT WINAPI FtpProtocol_UnlockRequest(IInternetProtocol *iface) { FtpProtocol *This = PROTOCOL_THIS(iface); - FIXME("(%p)\n", This); - return E_NOTIMPL; + + TRACE("(%p)\n", This); + + return protocol_unlock_request(&This->base); } #undef PROTOCOL_THIS @@ -202,15 +268,21 @@ static ULONG WINAPI FtpPriority_Release(IInternetPriority *iface) static HRESULT WINAPI FtpPriority_SetPriority(IInternetPriority *iface, LONG nPriority) { FtpProtocol *This = PRIORITY_THIS(iface); - FIXME("(%p)->(%d)\n", This, nPriority); - return E_NOTIMPL; + + TRACE("(%p)->(%d)\n", This, nPriority); + + This->base.priority = nPriority; + return S_OK; } static HRESULT WINAPI FtpPriority_GetPriority(IInternetPriority *iface, LONG *pnPriority) { FtpProtocol *This = PRIORITY_THIS(iface); - FIXME("(%p)->(%p)\n", This, pnPriority); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, pnPriority); + + *pnPriority = This->base.priority; + return S_OK; } #undef PRIORITY_THIS @@ -231,8 +303,9 @@ HRESULT FtpProtocol_Construct(IUnknown *pUnkOuter, LPVOID *ppobj) URLMON_LockModule(); - ret = heap_alloc(sizeof(FtpProtocol)); + ret = heap_alloc_zero(sizeof(FtpProtocol)); + ret->base.vtbl = &AsyncProtocolVtbl; ret->lpInternetProtocolVtbl = &FtpProtocolVtbl; ret->lpInternetPriorityVtbl = &FtpPriorityVtbl; ret->ref = 1;

1 0

Alexandre Julliard : uninstaller: Only load error strings when needed.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 1bd0690e5edc7ac8d3ec74d591cc636aea929159 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1bd0690e5edc7ac8d3ec74d59… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 3 12:35:35 2009 +0100 uninstaller: Only load error strings when needed. --- programs/uninstaller/main.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/programs/uninstaller/main.c b/programs/uninstaller/main.c index 1eaa3f3..302d834 100644 --- a/programs/uninstaller/main.c +++ b/programs/uninstaller/main.c @@ -45,8 +45,6 @@ static unsigned int numentries = 0; static int list_need_update = 1; static int oldsel = -1; static WCHAR *sFilter; -static WCHAR sAppName[MAX_STRING_LEN]; -static WCHAR sUninstallFailed[MAX_STRING_LEN]; static int FetchUninstallInformation(void); static void UninstallProgram(void); @@ -123,7 +121,6 @@ static void RemoveSpecificProgram(WCHAR *nameW) int wmain(int argc, WCHAR *argv[]) { LPCWSTR token = NULL; - HINSTANCE hInst = GetModuleHandleW(0); static const WCHAR listW[] = { '-','-','l','i','s','t',0 }; static const WCHAR removeW[] = { '-','-','r','e','m','o','v','e',0 }; int i = 1; @@ -156,10 +153,6 @@ int wmain(int argc, WCHAR *argv[]) } } - /* Load MessageBox's strings */ - LoadStringW(hInst, IDS_APPNAME, sAppName, sizeof(sAppName)/sizeof(WCHAR)); - LoadStringW(hInst, IDS_UNINSTALLFAILED, sUninstallFailed, sizeof(sUninstallFailed)/sizeof(WCHAR)); - /* Start the GUI control panel */ Control_RunDLL(GetDesktopWindow(), 0, "appwiz.cpl", SW_SHOW); return 1; @@ -267,6 +260,12 @@ static void UninstallProgram(void) } else { + WCHAR sAppName[MAX_STRING_LEN]; + WCHAR sUninstallFailed[MAX_STRING_LEN]; + HINSTANCE hInst = GetModuleHandleW(0); + + LoadStringW(hInst, IDS_APPNAME, sAppName, sizeof(sAppName)/sizeof(WCHAR)); + LoadStringW(hInst, IDS_UNINSTALLFAILED, sUninstallFailed, sizeof(sUninstallFailed)/sizeof(WCHAR)); wsprintfW(errormsg, sUninstallFailed, entries[i].command); if(MessageBoxW(0, errormsg, sAppName, MB_YESNO | MB_ICONQUESTION)==IDYES) {

1 0

Jacek Caban : wininet: Don' t send INTERNET_STATUS_HANDLE_CLOSING notification for ftp session created by InternetOpenUrl .
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: ffea80cf0ab229c6bf3bbf358707671493a9fbd8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ffea80cf0ab229c6bf3bbf358… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 2 19:57:17 2009 +0100 wininet: Don't send INTERNET_STATUS_HANDLE_CLOSING notification for ftp session created by InternetOpenUrl. --- dlls/wininet/internet.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index a14a158..785a1ef 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -186,7 +186,8 @@ BOOL WININET_Release( LPWININETHANDLEHEADER info ) info->vtbl->CloseConnection( info ); } /* Don't send a callback if this is a session handle created with InternetOpenUrl */ - if (info->htype != WH_HHTTPSESSION || !(info->dwInternalFlags & INET_OPENURL)) + if ((info->htype != WH_HHTTPSESSION && info->htype != WH_HFTPSESSION) + || !(info->dwInternalFlags & INET_OPENURL)) { INTERNET_SendCallback(info, info->dwContext, INTERNET_STATUS_HANDLE_CLOSING, &info->hInternet,

1 0

Francois Gouget : uninstaller: Use DELAYIMPORTS on the GUI dlls to speed up 'uninstaller --list'.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 52e415f769e317c802503f293f609ce592e3441a URL: http://source.winehq.org/git/wine.git/?a=commit;h=52e415f769e317c802503f293… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 2 19:26:35 2009 +0100 uninstaller: Use DELAYIMPORTS on the GUI dlls to speed up 'uninstaller --list'. --- programs/uninstaller/Makefile.in | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/programs/uninstaller/Makefile.in b/programs/uninstaller/Makefile.in index 3b151a7..0f7e0e4 100644 --- a/programs/uninstaller/Makefile.in +++ b/programs/uninstaller/Makefile.in @@ -5,7 +5,8 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = uninstaller.exe APPMODE = -mconsole -municode -IMPORTS = shlwapi shell32 user32 gdi32 advapi32 kernel32 +IMPORTS = advapi32 kernel32 +DELAYIMPORTS = shlwapi shell32 user32 gdi32 C_SRCS = \ main.c

1 0

Vincent Povirk : kernel32/tests: Add named pipe test using i/ o completion ports.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 392537bb338110c838d94e6beff7e916bccd2fe9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=392537bb338110c838d94e6be… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Feb 20 13:39:44 2009 -0600 kernel32/tests: Add named pipe test using i/o completion ports. --- dlls/kernel32/tests/pipe.c | 111 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 111 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/pipe.c b/dlls/kernel32/tests/pipe.c index 48d9e14..f4c5ad4 100644 --- a/dlls/kernel32/tests/pipe.c +++ b/dlls/kernel32/tests/pipe.c @@ -629,6 +629,112 @@ static DWORD CALLBACK serverThreadMain3(LPVOID arg) return 0; } +/** Trivial byte echo server - uses i/o completion ports */ +static DWORD CALLBACK serverThreadMain4(LPVOID arg) +{ + int i; + HANDLE hcompletion; + + trace("serverThreadMain4\n"); + /* Set up a simple echo server */ + hnp = CreateNamedPipe(PIPENAME "serverThreadMain4", PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, + PIPE_TYPE_BYTE | PIPE_WAIT, + /* nMaxInstances */ 1, + /* nOutBufSize */ 1024, + /* nInBufSize */ 1024, + /* nDefaultWait */ NMPWAIT_USE_DEFAULT_WAIT, + /* lpSecurityAttrib */ NULL); + ok(hnp != INVALID_HANDLE_VALUE, "CreateNamedPipe failed\n"); + + hcompletion = CreateIoCompletionPort(hnp, NULL, 12345, 1); + ok(hcompletion != NULL, "CreateIoCompletionPort failed, error=%i\n", GetLastError()); + + for (i = 0; i < NB_SERVER_LOOPS; i++) { + char buf[512]; + DWORD written; + DWORD readden; + DWORD dummy; + DWORD success; + OVERLAPPED oConnect; + OVERLAPPED oRead; + OVERLAPPED oWrite; + OVERLAPPED *oResult; + DWORD err; + ULONG_PTR compkey; + + memset(&oConnect, 0, sizeof(oConnect)); + memset(&oRead, 0, sizeof(oRead)); + memset(&oWrite, 0, sizeof(oWrite)); + + /* Wait for client to connect */ + trace("Server calling overlapped ConnectNamedPipe...\n"); + success = ConnectNamedPipe(hnp, &oConnect); + err = GetLastError(); + ok(!success && (err == ERROR_IO_PENDING || err == ERROR_PIPE_CONNECTED) , "overlapped ConnectNamedPipe\n"); + trace("overlapped ConnectNamedPipe returned.\n"); + if (!success && err == ERROR_IO_PENDING) { + trace("ConnectNamedPipe GetQueuedCompletionStatus\n"); + success = GetQueuedCompletionStatus(hcompletion, &dummy, &compkey, &oResult, 0); + if (!success) + { + ok( GetLastError() == WAIT_TIMEOUT, + "ConnectNamedPipe GetQueuedCompletionStatus wrong error %u\n", GetLastError()); + success = GetQueuedCompletionStatus(hcompletion, &dummy, &compkey, &oResult, 10000); + } + ok(success, "ConnectNamedPipe GetQueuedCompletionStatus failed, errno=%i\n", GetLastError()); + if (success) + { + ok(compkey == 12345, "got completion key %i instead of 12345\n", (int)compkey); + ok(oResult == &oConnect, "got overlapped pointer %p instead of %p\n", oResult, &oConnect); + } + } + trace("overlapped ConnectNamedPipe operation complete.\n"); + + /* Echo bytes once */ + memset(buf, 0, sizeof(buf)); + + trace("Server reading...\n"); + success = ReadFile(hnp, buf, sizeof(buf), &readden, &oRead); + trace("Server ReadFile returned...\n"); + err = GetLastError(); + ok(success || err == ERROR_IO_PENDING, "overlapped ReadFile, err=%i\n", err); + success = GetQueuedCompletionStatus(hcompletion, &readden, &compkey, + &oResult, 10000); + ok(success, "ReadFile GetQueuedCompletionStatus failed, errno=%i\n", GetLastError()); + if (success) + { + ok(compkey == 12345, "got completion key %i instead of 12345\n", (int)compkey); + ok(oResult == &oRead, "got overlapped pointer %p instead of %p\n", oResult, &oRead); + } + trace("Server done reading.\n"); + + trace("Server writing...\n"); + success = WriteFile(hnp, buf, readden, &written, &oWrite); + trace("Server WriteFile returned...\n"); + err = GetLastError(); + ok(success || err == ERROR_IO_PENDING, "overlapped WriteFile\n"); + success = GetQueuedCompletionStatus(hcompletion, &written, &compkey, + &oResult, 10000); + ok(success, "WriteFile GetQueuedCompletionStatus failed, errno=%i\n", GetLastError()); + if (success) + { + ok(compkey == 12345, "got completion key %i instead of 12345\n", (int)compkey); + ok(oResult == &oWrite, "got overlapped pointer %p instead of %p\n", oResult, &oWrite); + ok(written == readden, "write file len\n"); + } + trace("Server done writing.\n"); + + /* finish this connection, wait for next one */ + ok(FlushFileBuffers(hnp), "FlushFileBuffers\n"); + ok(DisconnectNamedPipe(hnp), "DisconnectNamedPipe\n"); + } + + ok(CloseHandle(hnp), "CloseHandle named pipe failed, err=%i\n", GetLastError()); + ok(CloseHandle(hcompletion), "CloseHandle completion failed, err=%i\n", GetLastError()); + + return 0; +} + static void exercizeServer(const char *pipename, HANDLE serverThread) { int i; @@ -711,6 +817,11 @@ static void test_NamedPipe_2(void) ok(serverThread != INVALID_HANDLE_VALUE, "CreateThread\n"); exercizeServer(PIPENAME "serverThreadMain3", serverThread); + /* Try server #4 */ + serverThread = CreateThread(NULL, 0, serverThreadMain4, 0, 0, &serverThreadId); + ok(serverThread != INVALID_HANDLE_VALUE, "CreateThread\n"); + exercizeServer(PIPENAME "serverThreadMain4", serverThread); + ok(SetEvent( alarm_event ), "SetEvent\n"); CloseHandle( alarm_event ); trace("test_NamedPipe_2 returning\n");

1 0

Vitaliy Margolen : dinput: Add few special cases for key mappings.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 8dac79d38b63372013ac6b4c26e2045e6e4b10b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8dac79d38b63372013ac6b4c2… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Fri Feb 27 09:20:08 2009 -0700 dinput: Add few special cases for key mappings. --- dlls/dinput/keyboard.c | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/dlls/dinput/keyboard.c b/dlls/dinput/keyboard.c index f9c689b..de8c63c 100644 --- a/dlls/dinput/keyboard.c +++ b/dlls/dinput/keyboard.c @@ -87,11 +87,17 @@ static int KeyboardCallback( LPDIRECTINPUTDEVICE8A iface, WPARAM wparam, LPARAM TRACE("(%p) %ld,%ld\n", iface, wparam, lparam); - dik_code = map_dik_code(hook->scanCode & 0xff,hook->vkCode); - /* R-Shift is special - it is an extended key with separate scan code */ - if (hook->flags & LLKHF_EXTENDED && dik_code != 0x36) - dik_code |= 0x80; - + switch (hook->vkCode) + { + /* R-Shift is special - it is an extended key with separate scan code */ + case VK_RSHIFT : dik_code = DIK_RSHIFT; break; + case VK_PAUSE : dik_code = DIK_PAUSE; break; + case VK_NUMLOCK : dik_code = DIK_NUMLOCK; break; + case VK_SUBTRACT: dik_code = DIK_SUBTRACT; break; + default: + dik_code = map_dik_code(hook->scanCode & 0xff, hook->vkCode); + if (hook->flags & LLKHF_EXTENDED) dik_code |= 0x80; + } new_diks = hook->flags & LLKHF_UP ? 0 : 0x80; /* returns now if key event already known */

1 0

Alexandre Julliard : kernel32: Fix the last error code for timeout in GetQueuedCompletionStatus.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: c47e32a7ccbe26ff72cf374e4a183fb6ad9f0e7f URL: http://source.winehq.org/git/wine.git/?a=commit;h=c47e32a7ccbe26ff72cf374e4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Mar 2 20:35:23 2009 +0100 kernel32: Fix the last error code for timeout in GetQueuedCompletionStatus. --- dlls/kernel32/sync.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c index be96633..38002d7 100644 --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -2230,7 +2230,8 @@ BOOL WINAPI GetQueuedCompletionStatus( HANDLE CompletionPort, LPDWORD lpNumberOf return TRUE; } - SetLastError( RtlNtStatusToDosError(status) ); + if (status == STATUS_TIMEOUT) SetLastError( WAIT_TIMEOUT ); + else SetLastError( RtlNtStatusToDosError(status) ); return FALSE; }

1 0

Alexandre Julliard : server: Make the new named pipe server fd inherit the I/ O completion if it was set before connecting.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 50171c5cc1c0c04bdca2fd2aeaa3ba8168c7236f URL: http://source.winehq.org/git/wine.git/?a=commit;h=50171c5cc1c0c04bdca2fd2ae… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Mar 2 20:34:39 2009 +0100 server: Make the new named pipe server fd inherit the I/O completion if it was set before connecting. --- server/async.c | 2 +- server/fd.c | 10 ++++++++-- server/file.h | 3 ++- server/named_pipe.c | 1 + 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/server/async.c b/server/async.c index 0a69f7a..91f0c44 100644 --- a/server/async.c +++ b/server/async.c @@ -214,7 +214,7 @@ struct async *create_async( struct thread *thread, struct async_queue *queue, co async->timeout = NULL; async->queue = (struct async_queue *)grab_object( queue ); async->completion = NULL; - if (queue->fd) fd_assign_completion( queue->fd, &async->completion, &async->comp_key ); + if (queue->fd) async->completion = fd_get_completion( queue->fd, &async->comp_key ); list_add_tail( &queue->queue, &async->queue_entry ); grab_object( async ); diff --git a/server/fd.c b/server/fd.c index c8b6f7a..d9688e1 100644 --- a/server/fd.c +++ b/server/fd.c @@ -1940,10 +1940,16 @@ static struct fd *get_handle_fd_obj( struct process *process, obj_handle_t handl return fd; } -void fd_assign_completion( struct fd *fd, struct completion **p_port, apc_param_t *p_key ) +struct completion *fd_get_completion( struct fd *fd, apc_param_t *p_key ) { *p_key = fd->comp_key; - *p_port = fd->completion ? (struct completion *)grab_object( fd->completion ) : NULL; + return fd->completion ? (struct completion *)grab_object( fd->completion ) : NULL; +} + +void fd_copy_completion( struct fd *src, struct fd *dst ) +{ + assert( !dst->completion ); + dst->completion = fd_get_completion( src, &dst->comp_key ); } /* flush a file buffers */ diff --git a/server/file.h b/server/file.h index 0eac537..1aaa284 100644 --- a/server/file.h +++ b/server/file.h @@ -143,7 +143,8 @@ extern void async_set_result( struct object *obj, unsigned int status, extern int async_waiting( struct async_queue *queue ); extern void async_terminate( struct async *async, unsigned int status ); extern void async_wake_up( struct async_queue *queue, unsigned int status ); -extern void fd_assign_completion( struct fd *fd, struct completion **p_port, apc_param_t *p_key ); +extern struct completion *fd_get_completion( struct fd *fd, apc_param_t *p_key ); +extern void fd_copy_completion( struct fd *src, struct fd *dst ); /* access rights that require Unix read permission */ #define FILE_UNIX_READ_ACCESS (FILE_READ_DATA|FILE_READ_ATTRIBUTES|FILE_READ_EA) diff --git a/server/named_pipe.c b/server/named_pipe.c index c4d1993..539509e 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -830,6 +830,7 @@ static struct object *named_pipe_open_file( struct object *obj, unsigned int acc server->fd = create_anonymous_fd( &pipe_server_fd_ops, fds[0], &server->obj, server->options ); if (client->fd && server->fd) { + fd_copy_completion( server->ioctl_fd, server->fd ); if (server->state == ps_wait_open) fd_async_wake_up( server->ioctl_fd, ASYNC_TYPE_WAIT, STATUS_SUCCESS ); set_server_state( server, ps_connected_server );

1 0

Alexandre Julliard : server: Overlapped named pipes are never blocking, even if no APC was specified.
by Alexandre Julliard March 3, 2009

March 3, 2009

Module: wine Branch: master Commit: 9dd3fe54675280254508e81ef11c42a95e64f0bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=9dd3fe54675280254508e81ef… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Mar 2 20:33:52 2009 +0100 server: Overlapped named pipes are never blocking, even if no APC was specified. --- server/named_pipe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index 1651a67..c4d1993 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -605,7 +605,7 @@ static obj_handle_t pipe_server_ioctl( struct fd *fd, ioctl_code_t code, const a { case ps_idle_server: case ps_wait_connect: - if (blocking) + if (blocking && !is_overlapped( get_fd_options(fd) )) { async_data_t new_data = *async_data; if (!(wait_handle = alloc_wait_event( current->process ))) break;

1 0

Maurilio Genovese : debian squeeze repository
by Jeremy Newman March 2, 2009

March 2, 2009

Module: website Branch: master Commit: fd6e744f28fb202308c8784c8b8202e5e2249922 URL: http://source.winehq.org/git/website.git/?a=commit;h=fd6e744f28fb202308c878… Author: Maurilio Genovese <repository(a)lamaresh.net> Date: Sat Feb 28 15:29:41 2009 +0100 debian squeeze repository in attachment Maurilio Genovese >From df7599be6f10d02d7d6803a50263801b751790bd Mon Sep 17 00:00:00 2001 From: Maurilio Genovese <repository(a)lamaresh.net> Date: Sat, 28 Feb 2009 15:27:42 +0100 Subject: New Debian Squeeze repository --- templates/en/download.template | 2 +- templates/en/download/deblenny.template | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/en/download.template b/templates/en/download.template index 43d9479..f1fefbb 100644 --- a/templates/en/download.template +++ b/templates/en/download.template @@ -70,7 +70,7 @@ requested in exchange for hosting the Wine web site.</p> <img src="{$root}/images/distro/debian.png" width="50" height="50" alt="Debian Linux" border="0"></a> </td> <td> <b><a href="{$root}/download/deblenny">Debian</a></b> - binary .debs for Debian Etch, Lenny and Sid</td> + binary .debs for Debian Lenny, Squeeze and Sid</td> <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a><br><a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> </tr> diff --git a/templates/en/download/deblenny.template b/templates/en/download/deblenny.template index 3c404b5..98a3552 100644 --- a/templates/en/download/deblenny.template +++ b/templates/en/download/deblenny.template @@ -2,7 +2,7 @@  <h1 class="title"><a href="http://www.debian.org/" target="_new"><img src="{$root}/images/distro/debian.png" width="50" height="50" alt="Debian Linux" border="0"></a> -Wine for Debian Etch, Lenny and Sid +Wine for Debian Lenny, Squeeze and Sid <a href="http://www.debian.org/" target="_new"><img src="{$root}/images/distro/debian.png" width="50" height="50" alt="Debian Linux" border="0"></a></h1> <p>Debian-based distributions utilize a special tool for managing packages known as APT. APT is able to automagically install all of the needed dependencies for a software package, as well as keep the package up to date, by scanning what are known as APT repositories. Debian-based distributions have their own repositories of software that include Wine, however we keep our own repository of the latest available beta packages here for download.</p> @@ -22,11 +22,11 @@ Wine for Debian Etch, Lenny and Sid <div style="position:relative;left:20px">Open a terminal</div> <div style="position:relative;left:20px"><i>su</i> <font color="gray">#to log as root</font></div> <div style="position:relative;left:20px"><i>gedit /etc/apt/sources.list</i> <font color="gray">#to open repository file with a text editor (you can use gedit or another)</font></div> -<div style="position:relative;left:20px">Add this line for Etch: <i>deb http://www.lamaresh.net/apt etch main</i></div> <div style="position:relative;left:20px">Add this line for Lenny: <i>deb http://www.lamaresh.net/apt lenny main</i></div> +<div style="position:relative;left:20px">Add this line for Squeeze: <i>deb http://www.lamaresh.net/apt squeeze main</i></div> <div style="position:relative;left:20px">Add this line for Sid: <i>deb http://www.lamaresh.net/apt sid main</i></div> <div style="position:relative;left:20px">Save and close sources.list</div> -<div style="position:relative;left:20px"><i>wget -O - http://www.lamaresh.net/apt/key.gpg | apt-key add</i> <font color="gray">#to add gpg key</font></div> +<div style="position:relative;left:20px"><i>wget -O - http://www.lamaresh.net/apt/key.gpg | apt-key add - </i> <font color="gray">#to add gpg key</font></div> <div style="position:relative;left:20px"><i>apt-get update</i> <font color="gray">#to update package list</font></div> <div style="position:relative;left:20px"><i>apt-get install wine</i> <font color="gray">#to install latest wine version</font></div><p></p> <h2>Method 2: Download .deb and manually install it</h2>

1 0