February 2011 - Wine-Commits

Austin English : msi/tests: Don't check return values inside of if(0) (LLVM /Clang).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 5e92277f97aac84354e5f4acd835fc81dbdad677 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5e92277f97aac84354e5f4acd… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:40 2011 -0800 msi/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/msi/tests/automation.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index 46178b8..a6f1ddb 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -661,10 +661,10 @@ static void test_dispatch(void) /* Test invoking this function (without parameters passed) */ if (0) /* All of these crash MSI on Windows XP */ { - hr = IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, NULL, NULL, NULL); - hr = IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, NULL, &excepinfo, NULL); + IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, NULL, NULL, NULL); + IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, NULL, &excepinfo, NULL); VariantInit(&varresult); - hr = IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, &varresult, &excepinfo, NULL); + IDispatch_Invoke(pInstaller, dispid, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, NULL, &varresult, &excepinfo, NULL); } /* Try with NULL params */ @@ -2289,7 +2289,7 @@ static void test_Installer_Products(BOOL bProductInstalled) if (0) /* Crashes on Windows XP */ { /* IEnumVARIANT::Clone, NULL pointer */ - hr = IEnumVARIANT_Clone(pEnum, NULL); + IEnumVARIANT_Clone(pEnum, NULL); } /* IEnumVARIANT::Clone */

1 0

Austin English : kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 8b7904d78d52e8c3367de2eeba985c7ca13ca24d URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b7904d78d52e8c3367de2eeb… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:56 2011 -0800 kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/kernel32/tests/heap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/heap.c b/dlls/kernel32/tests/heap.c index 98c99d7..f7ac478 100644 --- a/dlls/kernel32/tests/heap.c +++ b/dlls/kernel32/tests/heap.c @@ -469,11 +469,11 @@ static void test_HeapQueryInformation(void) if (0) /* crashes under XP */ { size = 0; - ret = pHeapQueryInformation(0, + pHeapQueryInformation(0, HeapCompatibilityInformation, &info, sizeof(info), &size); size = 0; - ret = pHeapQueryInformation(GetProcessHeap(), + pHeapQueryInformation(GetProcessHeap(), HeapCompatibilityInformation, NULL, sizeof(info), &size); }

1 0

Austin English : kernel32/tests: Make sure to use return values (LLVM/Clang ).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 39d5a9080679ac20baad113288d221248089a789 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39d5a9080679ac20baad11328… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:28:07 2011 -0800 kernel32/tests: Make sure to use return values (LLVM/Clang). --- dlls/kernel32/tests/version.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index 5151170..9f9b72e 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -52,7 +52,7 @@ static void test_GetVersionEx(void) if (0) { /* Silently crashes on XP */ - ret = GetVersionExA(NULL); + GetVersionExA(NULL); } SetLastError(0xdeadbeef); @@ -166,6 +166,7 @@ static void test_VerifyVersionInfo(void) ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, pVerSetConditionMask(pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER_EQUAL), VER_MAJORVERSION, VER_GREATER_EQUAL)); + ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); info.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX); GetVersionEx((OSVERSIONINFO *)&info);

1 0

Austin English : kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: e330380a6b5bb1c9829a1a17b1affb560a3e0c55 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e330380a6b5bb1c9829a1a17b… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:59 2011 -0800 kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/kernel32/tests/path.c | 23 +++++++++-------------- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c index 1ccafb7..741f47f 100644 --- a/dlls/kernel32/tests/path.c +++ b/dlls/kernel32/tests/path.c @@ -486,10 +486,7 @@ static void test_CurrentDirectoryA(CHAR *origdir, CHAR *newdir) */ if (0) { - SetLastError( 0xdeadbeef ); - len = GetCurrentDirectoryA( 42, (LPSTR)(MAX_PATH + 42) ); - ok( len == 0 && GetLastError() == ERROR_INVALID_PARAMETER, - "GetCurrentDirectoryA failed to fail %u err %u\n", len, GetLastError() ); + GetCurrentDirectoryA( 42, (LPSTR)(MAX_PATH + 42) ); } /* SetCurrentDirectoryA shouldn't care whether the string has a @@ -1241,7 +1238,7 @@ static void test_GetLongPathNameW(void) /* NULL buffer with length crashes on Windows */ if (0) - length = pGetLongPathNameW(shortpath, NULL, 20); + pGetLongPathNameW(shortpath, NULL, 20); ok(DeleteFileW(shortpath), "Could not delete temporary file\n"); ok(RemoveDirectoryW(dirpath), "Could not delete temporary directory\n"); @@ -1302,7 +1299,8 @@ static void test_GetSystemDirectory(void) total = res; /* this crashes on XP */ - if (0) res = GetSystemDirectory(NULL, total); + if (0) + GetSystemDirectory(NULL, total); SetLastError(0xdeadbeef); res = GetSystemDirectory(NULL, total-1); @@ -1360,7 +1358,8 @@ static void test_GetWindowsDirectory(void) total = res; /* this crashes on XP */ - if (0) res = GetWindowsDirectory(NULL, total); + if (0) + GetWindowsDirectory(NULL, total); SetLastError(0xdeadbeef); res = GetWindowsDirectory(NULL, total-1); @@ -1415,7 +1414,7 @@ static void test_NeedCurrentDirectoryForExePathA(void) /* Crashes in Windows */ if (0) - ok(pNeedCurrentDirectoryForExePathA(NULL), "returned FALSE for NULL\n"); + pNeedCurrentDirectoryForExePathA(NULL); SetEnvironmentVariableA("NoDefaultCurrentDirectoryInExePath", NULL); ok(pNeedCurrentDirectoryForExePathA("."), "returned FALSE for \".\"\n"); @@ -1442,7 +1441,7 @@ static void test_NeedCurrentDirectoryForExePathW(void) /* Crashes in Windows */ if (0) - ok(pNeedCurrentDirectoryForExePathW(NULL), "returned FALSE for NULL\n"); + pNeedCurrentDirectoryForExePathW(NULL); SetEnvironmentVariableA("NoDefaultCurrentDirectoryInExePath", NULL); ok(pNeedCurrentDirectoryForExePathW(thispath), "returned FALSE for \".\"\n"); @@ -1595,11 +1594,7 @@ static void test_SearchPathW(void) if (0) { /* NULL filename, crashes on nt4 */ - SetLastError(0xdeadbeef); - ret = pSearchPathW(pathW, NULL, NULL, sizeof(buffW)/sizeof(WCHAR), buffW, &ptrW); - ok(ret == 0, "Expected failure, got %d\n", ret); - ok(GetLastError() == ERROR_INVALID_PARAMETER, - "Expected ERROR_INVALID_PARAMETER, got %x\n", GetLastError()); + pSearchPathW(pathW, NULL, NULL, sizeof(buffW)/sizeof(WCHAR), buffW, &ptrW); } /* empty filename */

1 0

Austin English : crypt32/tests: Make sure to use return values (LLVM/Clang) .
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 29b5aab0265cf04e6a85b6804066af43a212b277 URL: http://source.winehq.org/git/wine.git/?a=commit;h=29b5aab0265cf04e6a85b6804… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:12 2011 -0800 crypt32/tests: Make sure to use return values (LLVM/Clang). --- dlls/crypt32/tests/message.c | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/tests/message.c b/dlls/crypt32/tests/message.c index 37ae6fd..1fe9a57 100644 --- a/dlls/crypt32/tests/message.c +++ b/dlls/crypt32/tests/message.c @@ -515,6 +515,8 @@ static void test_verify_message_signature(void) cbDecoded = 0xdeadbeef; ret = CryptVerifyMessageSignature(NULL, 0, NULL, 0, NULL, &cbDecoded, NULL); + ok(!ret && GetLastError() == E_INVALIDARG, + "Expected E_INVALIDARG, got %08x\n", GetLastError()); ok(cbDecoded == 0, "expected 0, got %08x\n", cbDecoded); SetLastError(0xdeadbeef); ret = CryptVerifyMessageSignature(&para, 0, NULL, 0, NULL, 0, NULL); @@ -541,15 +543,24 @@ static void test_verify_message_signature(void) /* Check whether cert is set on error */ cert = (PCCERT_CONTEXT)0xdeadbeef; ret = CryptVerifyMessageSignature(&para, 0, NULL, 0, NULL, 0, &cert); + ok(!ret && (GetLastError() == CRYPT_E_ASN1_EOD || + GetLastError() == OSS_BAD_ARG /* NT40 */), + "Expected CRYPT_E_ASN1_EOD, got %08x\n", GetLastError()); ok(cert == NULL, "Expected NULL cert\n"); /* Check whether cbDecoded is set on error */ cbDecoded = 0xdeadbeef; ret = CryptVerifyMessageSignature(&para, 0, NULL, 0, NULL, &cbDecoded, NULL); + ok(!ret && (GetLastError() == CRYPT_E_ASN1_EOD || + GetLastError() == OSS_BAD_ARG /* NT40 */), + "Expected CRYPT_E_ASN1_EOD, got %08x\n", GetLastError()); ok(!cbDecoded, "Expected 0\n"); SetLastError(0xdeadbeef); ret = CryptVerifyMessageSignature(&para, 0, dataEmptyBareContent, sizeof(dataEmptyBareContent), NULL, 0, NULL); + ok(!ret && (GetLastError() == CRYPT_E_ASN1_BADTAG || + GetLastError() == OSS_PDU_MISMATCH /* NT40 */), + "Expected CRYPT_E_ASN1_BADTAG, got %08x\n", GetLastError()); ok(GetLastError() == CRYPT_E_ASN1_BADTAG || GetLastError() == OSS_PDU_MISMATCH, /* win9x */ "Expected CRYPT_E_ASN1_BADTAG, got %08x\n", GetLastError()); @@ -679,6 +690,7 @@ static void test_hash_message(void) SetLastError(0xdeadbeef); ret = CryptHashMessage(&para, FALSE, 2, toHash, hashSize, NULL, NULL, NULL, NULL); + ok(ret, "CryptHashMessage failed: 0x%08x\n", GetLastError()); /* Try again with a valid encoding type */ para.dwMsgEncodingType = PKCS_7_ASN_ENCODING; SetLastError(0xdeadbeef); @@ -694,7 +706,7 @@ static void test_hash_message(void) */ if (0) { - ret = CryptHashMessage(&para, FALSE, 2, NULL, NULL, NULL, + CryptHashMessage(&para, FALSE, 2, NULL, NULL, NULL, &hashedBlobSize, NULL, NULL); } /* Passing a valid pointer for the data to hash fails, as the hash @@ -781,6 +793,7 @@ static void test_hash_message(void) SetLastError(0xdeadbeef); ret = CryptHashMessage(&para, TRUE, 2, toHash, hashSize, NULL, &hashedBlobSize, computedHash, &computedHashSize); + ok(ret, "CryptHashMessage failed: 0x%08x\n", GetLastError()); ok(computedHashSize == sizeof(hashVal), "unexpected size of hash value %d\n", computedHashSize); ok(!memcmp(computedHash, hashVal, computedHashSize),

1 0

Austin English : crypt32/tests: Don't check return values inside of if(0) ( LLVM/Clang).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: c6301aec11012ffaa6f3cd1510568e7b94e4ab98 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c6301aec11012ffaa6f3cd151… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:09 2011 -0800 crypt32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/crypt32/tests/main.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/crypt32/tests/main.c b/dlls/crypt32/tests/main.c index 5f2e4d0..8c5b41e 100644 --- a/dlls/crypt32/tests/main.c +++ b/dlls/crypt32/tests/main.c @@ -47,8 +47,7 @@ static void test_findAttribute(void) if (0) { /* crashes */ - SetLastError(0xdeadbeef); - ret = CertFindAttribute(NULL, 1, NULL); + CertFindAttribute(NULL, 1, NULL); /* returns NULL, last error is ERROR_INVALID_PARAMETER * crashes on Vista */ @@ -138,7 +137,7 @@ static void test_findRDNAttr(void) { /* crashes */ SetLastError(0xdeadbeef); - ret = CertFindRDNAttr(NULL, NULL); + CertFindRDNAttr(NULL, NULL); /* returns NULL, last error is ERROR_INVALID_PARAMETER * crashes on Vista */ @@ -395,7 +394,7 @@ static void test_format_object(void) /* Crash */ if (0) { - ret = pCryptFormatObject(0, 0, 0, NULL, NULL, NULL, 0, NULL, NULL); + pCryptFormatObject(0, 0, 0, NULL, NULL, NULL, 0, NULL, NULL); } /* When called with any but the default encoding, it fails to find a * formatting function.

1 0

Juan Lang : crypt32: Allow updating data messages with no content.
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 2910cf9660d4e6a3791289286d364ea1a22d343c URL: http://source.winehq.org/git/wine.git/?a=commit;h=2910cf9660d4e6a3791289286… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Feb 10 11:58:17 2011 -0800 crypt32: Allow updating data messages with no content. --- dlls/crypt32/msg.c | 21 ++++++++------------- dlls/crypt32/tests/msg.c | 1 - 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/dlls/crypt32/msg.c b/dlls/crypt32/msg.c index ee80f1a..97860e5 100644 --- a/dlls/crypt32/msg.c +++ b/dlls/crypt32/msg.c @@ -277,20 +277,15 @@ static BOOL CDataEncodeMsg_Update(HCRYPTMSG hCryptMsg, const BYTE *pbData, } else { - msg->base.state = MsgStateFinalized; - if (!cbData) - SetLastError(E_INVALIDARG); - else - { - CRYPT_DATA_BLOB blob = { cbData, (LPBYTE)pbData }; + CRYPT_DATA_BLOB blob = { cbData, (LPBYTE)pbData }; - /* non-streamed data messages don't allow non-final updates, - * don't bother checking whether data already exist, they can't. - */ - ret = CryptEncodeObjectEx(X509_ASN_ENCODING, X509_OCTET_STRING, - &blob, CRYPT_ENCODE_ALLOC_FLAG, NULL, &msg->bare_content, - &msg->bare_content_len); - } + msg->base.state = MsgStateFinalized; + /* non-streamed data messages don't allow non-final updates, + * don't bother checking whether data already exist, they can't. + */ + ret = CryptEncodeObjectEx(X509_ASN_ENCODING, X509_OCTET_STRING, + &blob, CRYPT_ENCODE_ALLOC_FLAG, NULL, &msg->bare_content, + &msg->bare_content_len); } } return ret; diff --git a/dlls/crypt32/tests/msg.c b/dlls/crypt32/tests/msg.c index 95a0a29..de55d6b 100644 --- a/dlls/crypt32/tests/msg.c +++ b/dlls/crypt32/tests/msg.c @@ -394,7 +394,6 @@ static void test_data_msg_update(void) NULL); /* Starting with Vista, can update a message with no data. */ ret = CryptMsgUpdate(msg, NULL, 0, TRUE); - todo_wine ok(ret || broken(!ret), "CryptMsgUpdate failed: %08x\n", GetLastError()); if (ret) {

1 0

Juan Lang : crypt32/tests: Update a CryptMsgUpdate call to succeed on more Windows versions, and check its return value (Clang).
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 14626a7804053b7972cde8b8b6a4fb74ac1ebe7e URL: http://source.winehq.org/git/wine.git/?a=commit;h=14626a7804053b7972cde8b8b… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Feb 10 12:00:40 2011 -0800 crypt32/tests: Update a CryptMsgUpdate call to succeed on more Windows versions, and check its return value (Clang). --- dlls/crypt32/tests/msg.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/tests/msg.c b/dlls/crypt32/tests/msg.c index fc54041..3834760 100644 --- a/dlls/crypt32/tests/msg.c +++ b/dlls/crypt32/tests/msg.c @@ -3205,7 +3205,8 @@ static void test_msg_control(void) ok(!ret && GetLastError() == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", GetLastError()); } - ret = CryptMsgUpdate(msg, NULL, 0, TRUE); + ret = CryptMsgUpdate(msg, msgData, sizeof(msgData), TRUE); + ok(ret, "CryptMsgUpdate failed: %08x\n", GetLastError()); /* or after an update. */ for (i = 1; !old_crypt32 && (i <= CMSG_CTRL_ADD_CMS_SIGNER_INFO); i++) {

1 0

Juan Lang : crypt32/tests: In more recent Windows versions, updating a data message with no content succeeds.
by Alexandre Julliard Feb. 11, 2011

Feb. 11, 2011

Module: wine Branch: master Commit: 07297ea9d014468381b691624a843696e8315f53 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07297ea9d014468381b691624… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Feb 10 12:02:52 2011 -0800 crypt32/tests: In more recent Windows versions, updating a data message with no content succeeds. --- dlls/crypt32/tests/msg.c | 45 +++++++++++++++++++++++++++++++-------------- 1 files changed, 31 insertions(+), 14 deletions(-) diff --git a/dlls/crypt32/tests/msg.c b/dlls/crypt32/tests/msg.c index 3834760..95a0a29 100644 --- a/dlls/crypt32/tests/msg.c +++ b/dlls/crypt32/tests/msg.c @@ -365,6 +365,8 @@ static BOOL WINAPI nop_stream_output(const void *pvArg, BYTE *pb, DWORD cb, return TRUE; } +static const BYTE dataEmptyBareContent[] = { 0x04,0x00 }; + static void test_data_msg_update(void) { HCRYPTMSG msg; @@ -390,20 +392,36 @@ static void test_data_msg_update(void) msg = CryptMsgOpenToEncode(PKCS_7_ASN_ENCODING, 0, CMSG_DATA, NULL, NULL, NULL); - /* Can't update a message with no data */ - SetLastError(0xdeadbeef); + /* Starting with Vista, can update a message with no data. */ ret = CryptMsgUpdate(msg, NULL, 0, TRUE); - /* This test returns FALSE on XP and earlier but TRUE on Vista, so can't be tested. - * GetLastError is either E_INVALIDARG (NT) or unset (9x/Vista), so it doesn't - * make sense to test this. - */ + todo_wine + ok(ret || broken(!ret), "CryptMsgUpdate failed: %08x\n", GetLastError()); + if (ret) + { + DWORD size; - /* Curiously, a valid update will now fail as well, presumably because of - * the last (invalid, but final) update. - */ - ret = CryptMsgUpdate(msg, msgData, sizeof(msgData), TRUE); - ok(!ret && GetLastError() == CRYPT_E_MSG_ERROR, - "Expected CRYPT_E_MSG_ERROR, got %x\n", GetLastError()); + ret = CryptMsgGetParam(msg, CMSG_BARE_CONTENT_PARAM, 0, NULL, &size); + ok(ret, "CryptMsgGetParam failed: %08x\n", GetLastError()); + if (ret) + { + LPBYTE buf = CryptMemAlloc(size); + + if (buf) + { + ret = CryptMsgGetParam(msg, CMSG_BARE_CONTENT_PARAM, 0, buf, + &size); + ok(ret, "CryptMsgGetParam failed: %08x\n", GetLastError()); + if (ret) + { + ok(size == sizeof(dataEmptyBareContent), + "unexpected size %d\n", size); + ok(!memcmp(buf, dataEmptyBareContent, size), + "unexpected value\n"); + } + CryptMemFree(buf); + } + } + } CryptMsgClose(msg); msg = CryptMsgOpenToEncode(PKCS_7_ASN_ENCODING, CMSG_DETACHED_FLAG, @@ -510,7 +528,6 @@ static void test_data_msg_get_param(void) CryptMsgClose(msg); } -static const BYTE dataEmptyBareContent[] = { 0x04,0x00 }; static const BYTE dataEmptyContent[] = { 0x30,0x0f,0x06,0x09,0x2a,0x86,0x48,0x86,0xf7,0x0d,0x01,0x07,0x01,0xa0,0x02, 0x04,0x00 };

1 0

Juan Lang : wintrust/tests: Fix a leak (valgrind).
by Alexandre Julliard Feb. 10, 2011

Feb. 10, 2011

Module: wine Branch: master Commit: 4325d75d5db32f01f1ca5a784f39e069be2f0040 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4325d75d5db32f01f1ca5a784… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Jan 26 08:45:14 2011 -0800 wintrust/tests: Fix a leak (valgrind). --- dlls/wintrust/tests/softpub.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/wintrust/tests/softpub.c b/dlls/wintrust/tests/softpub.c index c602705..0327bf5 100644 --- a/dlls/wintrust/tests/softpub.c +++ b/dlls/wintrust/tests/softpub.c @@ -484,6 +484,7 @@ static void testCertTrust(SAFE_PROVIDER_FUNCTIONS *funcs, GUID *actionID) CertFreeCertificateContext(cert); } } + funcs->pfnFree(data.padwTrustStepErrors); } static void test_provider_funcs(void)

1 0