June 2012 - Wine-Commits - list.winehq.org

Jacek Caban : jscript: Don' t use DISPPARAMS named args for internal parameter passing.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 0307d7356982230841612002b39d240adc8cf0ce URL: http://source.winehq.org/git/wine.git/?a=commit;h=0307d7356982230841612002b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:07:48 2012 +0200 jscript: Don't use DISPPARAMS named args for internal parameter passing. --- dlls/jscript/dispex.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 37dc9de..c52ac7d 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -358,7 +358,8 @@ static HRESULT convert_params(const DISPPARAMS *dp, VARIANT *buf, DISPPARAMS *re VARIANT *d; unsigned i; - *ret = *dp; + ret->cArgs = dp->cArgs - dp->cNamedArgs; + ret->cNamedArgs = 0; for(i = 0; i < ret->cArgs && !need_conversion; i++) { switch(V_VT(get_arg(dp, i))) { @@ -369,8 +370,10 @@ static HRESULT convert_params(const DISPPARAMS *dp, VARIANT *buf, DISPPARAMS *re } } - if(!need_conversion) + if(!need_conversion) { + ret->rgvarg = dp->rgvarg + dp->cNamedArgs; return S_OK; + } if(ret->cArgs > 6) { ret->rgvarg = heap_alloc(ret->cArgs * sizeof(VARIANT));

1 0

Nikolay Sivov : msxml3: Support VT_I2 variants tracing.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: fd5e384979cef576ecf9173f2a8e22c4dddc4d3d URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd5e384979cef576ecf9173f2… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sat Jun 23 17:08:27 2012 +0400 msxml3: Support VT_I2 variants tracing. --- dlls/msxml3/main.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c index bfb301e..48d007f 100644 --- a/dlls/msxml3/main.c +++ b/dlls/msxml3/main.c @@ -268,6 +268,8 @@ const char *debugstr_variant(const VARIANT *v) return "{VT_EMPTY}"; case VT_NULL: return "{VT_NULL}"; + case VT_I2: + return wine_dbg_sprintf("{VT_I2: %d}", V_I2(v)); case VT_I4: return wine_dbg_sprintf("{VT_I4: %d}", V_I4(v)); case VT_R8:

1 0

Piotr Caban : msvcp90: Added partial num_get<wchar> and num_get<short> implementation.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 4732e3f75c11255e8ecef51267519874056b9970 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4732e3f75c11255e8ecef5126… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Jun 25 15:48:39 2012 +0200 msvcp90: Added partial num_get<wchar> and num_get<short> implementation. --- dlls/msvcp90/locale.c | 288 +++++++++++++++++++++++++++++++++++---------- dlls/msvcp90/msvcp90.spec | 52 ++++---- 2 files changed, 250 insertions(+), 90 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4732e3f75c11255e8ecef…

1 0

Jacek Caban : mshtml: Store event object in HTMLInnerWindow instead of HTMLOuterWindow.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: c73b135686d145c760c9c66622489ca4dbd81c4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=c73b135686d145c760c9c6662… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:06:27 2012 +0200 mshtml: Store event object in HTMLInnerWindow instead of HTMLOuterWindow. --- dlls/mshtml/htmlevent.c | 10 ++++++---- dlls/mshtml/htmlwindow.c | 2 +- dlls/mshtml/mshtml_private.h | 4 ++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 4b201c4..ca966ba 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -989,6 +989,7 @@ void fire_event(HTMLDocumentNode *doc, eventid_t eid, BOOL set_event, nsIDOMNode IHTMLEventObj *prev_event; nsIDOMNode *parent, *nsnode; BOOL prevent_default = FALSE; + HTMLInnerWindow *window; HTMLDOMNode *node; PRUint16 node_type; nsresult nsres; @@ -996,7 +997,8 @@ void fire_event(HTMLDocumentNode *doc, eventid_t eid, BOOL set_event, nsIDOMNode TRACE("(%p) %s\n", doc, debugstr_w(event_info[eid].name)); - prev_event = doc->basedoc.window->event; + window = doc->basedoc.window->base.inner_window; + prev_event = window->event; if(set_event) { hres = get_node(doc, target, TRUE, &node); if(FAILED(hres)) @@ -1004,9 +1006,9 @@ void fire_event(HTMLDocumentNode *doc, eventid_t eid, BOOL set_event, nsIDOMNode event_obj = create_event(node, eid, nsevent); node_release(node); - doc->basedoc.window->event = &event_obj->IHTMLEventObj_iface; + window->event = &event_obj->IHTMLEventObj_iface; }else { - doc->basedoc.window->event = NULL; + window->event = NULL; } nsIDOMNode_GetNodeType(target, &node_type); @@ -1070,7 +1072,7 @@ void fire_event(HTMLDocumentNode *doc, eventid_t eid, BOOL set_event, nsIDOMNode if(event_obj && event_obj->prevent_default) prevent_default = TRUE; - doc->basedoc.window->event = prev_event; + window->event = prev_event; if(event_obj) IHTMLEventObj_Release(&event_obj->IHTMLEventObj_iface); diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index c20d765..dc6d9af 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -1027,7 +1027,7 @@ static HRESULT WINAPI HTMLWindow2_get_document(IHTMLWindow2 *iface, IHTMLDocumen static HRESULT WINAPI HTMLWindow2_get_event(IHTMLWindow2 *iface, IHTMLEventObj **p) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - HTMLOuterWindow *window = This->outer_window; + HTMLInnerWindow *window = This->inner_window; TRACE("(%p)->(%p)\n", This, p); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index de0a237..31532cd 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -331,8 +331,6 @@ struct HTMLOuterWindow { IUri *uri; BSTR url; - IHTMLEventObj *event; - SCRIPTMODE scriptmode; IInternetSecurityManager *secmgr; @@ -355,6 +353,8 @@ struct HTMLInnerWindow { struct list script_hosts; + IHTMLEventObj *event; + HTMLOptionElementFactory *option_factory; global_prop_t *global_props;

1 0

Jacek Caban : mshtml: Keep reference in node returned from get_node.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 7ebcb1820eda3c43c8de3eb28d7390c9e7c8184e URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ebcb1820eda3c43c8de3eb28… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:04:40 2012 +0200 mshtml: Keep reference in node returned from get_node. --- dlls/mshtml/htmldoc.c | 16 +++++++++++----- dlls/mshtml/htmldoc3.c | 11 +++++++---- dlls/mshtml/htmlelem.c | 1 + dlls/mshtml/htmlelemcol.c | 3 +++ dlls/mshtml/htmlevent.c | 19 ++++++++++++++----- dlls/mshtml/htmlform.c | 1 - dlls/mshtml/htmlnode.c | 18 +++++++----------- dlls/mshtml/htmloption.c | 1 + dlls/mshtml/htmlselect.c | 1 - dlls/mshtml/mshtml_private.h | 5 +++++ dlls/mshtml/mutation.c | 1 + dlls/mshtml/nsembed.c | 1 + dlls/mshtml/pluginhost.c | 1 + dlls/mshtml/txtrange.c | 4 +++- 14 files changed, 55 insertions(+), 28 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7ebcb1820eda3c43c8de3…

1 0

Hans Leidekker : wbemprox: Add a partial Win32_NetworkAdapter class implementation.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 7b8c10f0b1041f5a42e3f7d59340c5f4128a013a URL: http://source.winehq.org/git/wine.git/?a=commit;h=7b8c10f0b1041f5a42e3f7d59… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Jun 25 11:20:09 2012 +0200 wbemprox: Add a partial Win32_NetworkAdapter class implementation. --- dlls/wbemprox/Makefile.in | 2 +- dlls/wbemprox/builtin.c | 75 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 76 insertions(+), 1 deletions(-) diff --git a/dlls/wbemprox/Makefile.in b/dlls/wbemprox/Makefile.in index 56e3d8f..bc82945 100644 --- a/dlls/wbemprox/Makefile.in +++ b/dlls/wbemprox/Makefile.in @@ -1,5 +1,5 @@ MODULE = wbemprox.dll -IMPORTS = dxgi oleaut32 ole32 advapi32 +IMPORTS = iphlpapi dxgi oleaut32 ole32 advapi32 C_SRCS = \ builtin.c \ diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index af913d4..6092173 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -26,6 +26,8 @@ #include "windef.h" #include "winbase.h" #include "wbemcli.h" +#include "winsock2.h" +#include "iphlpapi.h" #include "tlhelp32.h" #include "initguid.h" #include "d3d10.h" @@ -47,6 +49,8 @@ static const WCHAR class_processorW[] = {'W','i','n','3','2','_','P','r','o','c','e','s','s','o','r',0}; static const WCHAR class_videocontrollerW[] = {'W','i','n','3','2','_','V','i','d','e','o','C','o','n','t','r','o','l','l','e','r',0}; +static const WCHAR class_networkadapterW[] = + {'W','i','n','3','2','_','N','e','t','w','o','r','k','A','d','a','p','t','e','r',0}; static const WCHAR prop_adapterramW[] = {'A','d','a','p','t','e','r','R','A','M',0}; @@ -60,10 +64,14 @@ static const WCHAR prop_deviceidW[] = {'D','e','v','i','c','e','I','d',0}; static const WCHAR prop_handleW[] = {'H','a','n','d','l','e',0}; +static const WCHAR prop_interfaceindexW[] = + {'I','n','t','e','r','f','a','c','e','I','n','d','e','x',0}; static const WCHAR prop_manufacturerW[] = {'M','a','n','u','f','a','c','t','u','r','e','r',0}; static const WCHAR prop_modelW[] = {'M','o','d','e','l',0}; +static const WCHAR prop_netconnectionstatusW[] = + {'N','e','t','C','o','n','n','e','c','t','i','o','n','S','t','a','t','u','s',0}; static const WCHAR prop_osarchitectureW[] = {'O','S','A','r','c','h','i','t','e','c','t','u','r','e',0}; static const WCHAR prop_pprocessidW[] = @@ -90,6 +98,12 @@ static const struct column col_compsys[] = { prop_manufacturerW, CIM_STRING }, { prop_modelW, CIM_STRING } }; +static const struct column col_networkadapter[] = +{ + { prop_deviceidW, CIM_STRING|COL_FLAG_DYNAMIC|COL_FLAG_KEY }, + { prop_interfaceindexW, CIM_SINT32 }, + { prop_netconnectionstatusW, CIM_UINT16 } +}; static const struct column col_os[] = { { prop_captionW, CIM_STRING }, @@ -154,6 +168,12 @@ struct record_computersystem const WCHAR *manufacturer; const WCHAR *model; }; +struct record_networkadapter +{ + const WCHAR *device_id; + INT32 interface_index; + UINT16 netconnection_status; +}; struct record_operatingsystem { const WCHAR *caption; @@ -193,6 +213,60 @@ static const struct record_processor data_processor[] = { processor_manufacturerW } }; +static UINT16 get_connection_status( IF_OPER_STATUS status ) +{ + switch (status) + { + case IfOperStatusDown: + return 0; /* Disconnected */ + case IfOperStatusUp: + return 2; /* Connected */ + default: + ERR("unhandled status %u\n", status); + break; + } + return 0; +} + +static void fill_networkadapter( struct table *table ) +{ + static const WCHAR fmtW[] = {'%','u',0}; + WCHAR device_id[11]; + struct record_networkadapter *rec; + IP_ADAPTER_ADDRESSES *aa, *buffer; + UINT num_rows = 0, offset = 0; + DWORD size = 0, ret; + + ret = GetAdaptersAddresses( AF_UNSPEC, 0, NULL, NULL, &size ); + if (ret != ERROR_BUFFER_OVERFLOW) return; + + if (!(buffer = heap_alloc( size ))) return; + if (GetAdaptersAddresses( AF_UNSPEC, 0, NULL, buffer, &size )) + { + heap_free( buffer ); + return; + } + for (aa = buffer; aa; aa = aa->Next) num_rows++; + if (!(table->data = heap_alloc( sizeof(*rec) * num_rows ))) + { + heap_free( buffer ); + return; + } + for (aa = buffer; aa; aa = aa->Next) + { + rec = (struct record_networkadapter *)(table->data + offset); + sprintfW( device_id, fmtW, aa->u.s.IfIndex ); + rec->device_id = heap_strdupW( device_id ); + rec->interface_index = aa->u.s.IfIndex; + rec->netconnection_status = get_connection_status( aa->OperStatus ); + offset += sizeof(*rec); + } + TRACE("created %u rows\n", num_rows); + table->num_rows = num_rows; + + heap_free( buffer ); +} + static WCHAR *get_cmdline( DWORD process_id ) { if (process_id == GetCurrentProcessId()) return heap_strdupW( GetCommandLineW() ); @@ -301,6 +375,7 @@ static struct table classtable[] = { { class_biosW, SIZEOF(col_bios), col_bios, SIZEOF(data_bios), (BYTE *)data_bios, NULL }, { class_compsysW, SIZEOF(col_compsys), col_compsys, SIZEOF(data_compsys), (BYTE *)data_compsys, NULL }, + { class_networkadapterW, SIZEOF(col_networkadapter), col_networkadapter, 0, NULL, fill_networkadapter }, { class_osW, SIZEOF(col_os), col_os, 0, NULL, fill_os }, { class_processW, SIZEOF(col_process), col_process, 0, NULL, fill_process }, { class_processorW, SIZEOF(col_processor), col_processor, SIZEOF(data_processor), (BYTE *)data_processor, NULL },

1 0

Jacek Caban : mshtml: Moved option_factory from HTMLOuterWindow to HTMLInnerWindow.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: c77b8bfdd9a25e4b36f4b1f7738b7e9e41cd4d4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=c77b8bfdd9a25e4b36f4b1f77… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:05:58 2012 +0200 mshtml: Moved option_factory from HTMLOuterWindow to HTMLInnerWindow. --- dlls/mshtml/htmloption.c | 9 ++++++--- dlls/mshtml/htmlwindow.c | 21 +++++++++++++-------- dlls/mshtml/mshtml_private.h | 7 ++++--- 3 files changed, 23 insertions(+), 14 deletions(-) diff --git a/dlls/mshtml/htmloption.c b/dlls/mshtml/htmloption.c index ad3e8fb..8bc0f40 100644 --- a/dlls/mshtml/htmloption.c +++ b/dlls/mshtml/htmloption.c @@ -517,15 +517,18 @@ static const IHTMLOptionElementFactoryVtbl HTMLOptionElementFactoryVtbl = { HTMLOptionElementFactory_create }; -HTMLOptionElementFactory *HTMLOptionElementFactory_Create(HTMLOuterWindow *window) +HRESULT HTMLOptionElementFactory_Create(HTMLInnerWindow *window, HTMLOptionElementFactory **ret_ptr) { HTMLOptionElementFactory *ret; - ret = heap_alloc(sizeof(HTMLOptionElementFactory)); + ret = heap_alloc(sizeof(*ret)); + if(!ret) + return E_OUTOFMEMORY; ret->IHTMLOptionElementFactory_iface.lpVtbl = &HTMLOptionElementFactoryVtbl; ret->ref = 1; ret->window = window; - return ret; + *ret_ptr = ret; + return S_OK; } diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 94731ec..f6d6212 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -192,11 +192,6 @@ static void release_outer_window(HTMLOuterWindow *This) if(This->frame_element) This->frame_element->content_window = NULL; - if(This->option_factory) { - This->option_factory->window = NULL; - IHTMLOptionElementFactory_Release(&This->option_factory->IHTMLOptionElementFactory_iface); - } - if(This->image_factory) { This->image_factory->window = NULL; IHTMLImageElementFactory_Release(&This->image_factory->IHTMLImageElementFactory_iface); @@ -233,6 +228,11 @@ static void release_inner_window(HTMLInnerWindow *This) heap_free(This->global_props[i].name); heap_free(This->global_props); + if(This->option_factory) { + This->option_factory->window = NULL; + IHTMLOptionElementFactory_Release(&This->option_factory->IHTMLOptionElementFactory_iface); + } + heap_free(This); } @@ -1083,12 +1083,17 @@ static HRESULT WINAPI HTMLWindow2_get_screen(IHTMLWindow2 *iface, IHTMLScreen ** static HRESULT WINAPI HTMLWindow2_get_Option(IHTMLWindow2 *iface, IHTMLOptionElementFactory **p) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - HTMLOuterWindow *window = This->outer_window; + HTMLInnerWindow *window = This->inner_window; TRACE("(%p)->(%p)\n", This, p); - if(!window->option_factory) - window->option_factory = HTMLOptionElementFactory_Create(window); + if(!window->option_factory) { + HRESULT hres; + + hres = HTMLOptionElementFactory_Create(window, &window->option_factory); + if(FAILED(hres)) + return hres; + } *p = &window->option_factory->IHTMLOptionElementFactory_iface; IHTMLOptionElementFactory_AddRef(*p); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 004a4b4..35800d8 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -269,7 +269,7 @@ typedef struct { LONG ref; - HTMLOuterWindow *window; + HTMLInnerWindow *window; } HTMLOptionElementFactory; typedef struct { @@ -338,7 +338,6 @@ struct HTMLOuterWindow { IInternetSecurityManager *secmgr; - HTMLOptionElementFactory *option_factory; HTMLImageElementFactory *image_factory; HTMLLocation *location; IHTMLScreen *screen; @@ -355,6 +354,8 @@ struct HTMLInnerWindow { HTMLDocumentNode *doc; + HTMLOptionElementFactory *option_factory; + global_prop_t *global_props; DWORD global_prop_cnt; DWORD global_prop_size; @@ -660,7 +661,7 @@ HRESULT HTMLOuterWindow_Create(HTMLDocumentObj*,nsIDOMWindow*,HTMLOuterWindow*,H HRESULT update_window_doc(HTMLOuterWindow*) DECLSPEC_HIDDEN; HTMLOuterWindow *nswindow_to_window(const nsIDOMWindow*) DECLSPEC_HIDDEN; void get_top_window(HTMLOuterWindow*,HTMLOuterWindow**) DECLSPEC_HIDDEN; -HTMLOptionElementFactory *HTMLOptionElementFactory_Create(HTMLOuterWindow*) DECLSPEC_HIDDEN; +HRESULT HTMLOptionElementFactory_Create(HTMLInnerWindow*,HTMLOptionElementFactory**) DECLSPEC_HIDDEN; HTMLImageElementFactory *HTMLImageElementFactory_Create(HTMLOuterWindow*) DECLSPEC_HIDDEN; HRESULT HTMLLocation_Create(HTMLOuterWindow*,HTMLLocation**) DECLSPEC_HIDDEN; IOmNavigator *OmNavigator_Create(void) DECLSPEC_HIDDEN;

1 0

Jacek Caban : mshtml: Moved global_props from HTMLOuterWindow to HTMLInnerWindow.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 2698fe0b3fce9dcc18455e753cb44d285bfb6cc9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2698fe0b3fce9dcc18455e753… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:05:48 2012 +0200 mshtml: Moved global_props from HTMLOuterWindow to HTMLInnerWindow. --- dlls/mshtml/htmlframe.c | 2 +- dlls/mshtml/htmliframe.c | 2 +- dlls/mshtml/htmlwindow.c | 27 ++++++++++++++------------- dlls/mshtml/mshtml_private.h | 10 +++++----- 4 files changed, 21 insertions(+), 20 deletions(-) diff --git a/dlls/mshtml/htmlframe.c b/dlls/mshtml/htmlframe.c index 13f6bd4..749df4b 100644 --- a/dlls/mshtml/htmlframe.c +++ b/dlls/mshtml/htmlframe.c @@ -231,7 +231,7 @@ static HRESULT HTMLFrameElement_get_dispid(HTMLDOMNode *iface, BSTR name, if(!This->framebase.content_window) return DISP_E_UNKNOWNNAME; - return search_window_props(This->framebase.content_window, name, grfdex, pid); + return search_window_props(This->framebase.content_window->base.inner_window, name, grfdex, pid); } static HRESULT HTMLFrameElement_invoke(HTMLDOMNode *iface, DISPID id, LCID lcid, diff --git a/dlls/mshtml/htmliframe.c b/dlls/mshtml/htmliframe.c index 03ebb47..3cae237 100644 --- a/dlls/mshtml/htmliframe.c +++ b/dlls/mshtml/htmliframe.c @@ -202,7 +202,7 @@ static HRESULT HTMLIFrame_get_dispid(HTMLDOMNode *iface, BSTR name, if(!This->framebase.content_window) return DISP_E_UNKNOWNNAME; - return search_window_props(This->framebase.content_window, name, grfdex, pid); + return search_window_props(This->framebase.content_window->base.inner_window, name, grfdex, pid); } static HRESULT HTMLIFrame_invoke(HTMLDOMNode *iface, DISPID id, LCID lcid, diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 4a696b7..94731ec 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -180,8 +180,6 @@ static ULONG WINAPI HTMLWindow2_AddRef(IHTMLWindow2 *iface) static void release_outer_window(HTMLOuterWindow *This) { - unsigned i; - remove_target_tasks(This->task_magic); set_window_bscallback(This, NULL); set_current_mon(This, NULL); @@ -212,13 +210,9 @@ static void release_outer_window(HTMLOuterWindow *This) if(This->screen) IHTMLScreen_Release(This->screen); - for(i=0; i < This->global_prop_cnt; i++) - heap_free(This->global_props[i].name); - This->window_ref->window = NULL; windowref_release(This->window_ref); - heap_free(This->global_props); release_script_hosts(This); if(This->nswindow) @@ -230,8 +224,15 @@ static void release_outer_window(HTMLOuterWindow *This) static void release_inner_window(HTMLInnerWindow *This) { + unsigned i; + htmldoc_release(&This->doc->basedoc); release_dispex(&This->dispex); + + for(i=0; i < This->global_prop_cnt; i++) + heap_free(This->global_props[i].name); + heap_free(This->global_props); + heap_free(This); } @@ -2186,7 +2187,7 @@ static HRESULT WINAPI WindowDispEx_Invoke(IDispatchEx *iface, DISPID dispIdMembe pDispParams, pVarResult, pExcepInfo, puArgErr); } -static global_prop_t *alloc_global_prop(HTMLOuterWindow *This, global_prop_type_t type, BSTR name) +static global_prop_t *alloc_global_prop(HTMLInnerWindow *This, global_prop_type_t type, BSTR name) { if(This->global_prop_cnt == This->global_prop_size) { global_prop_t *new_props; @@ -2213,12 +2214,12 @@ static global_prop_t *alloc_global_prop(HTMLOuterWindow *This, global_prop_type_ return This->global_props + This->global_prop_cnt++; } -static inline DWORD prop_to_dispid(HTMLOuterWindow *This, global_prop_t *prop) +static inline DWORD prop_to_dispid(HTMLInnerWindow *This, global_prop_t *prop) { return MSHTML_DISPID_CUSTOM_MIN + (prop-This->global_props); } -HRESULT search_window_props(HTMLOuterWindow *This, BSTR bstrName, DWORD grfdex, DISPID *pid) +HRESULT search_window_props(HTMLInnerWindow *This, BSTR bstrName, DWORD grfdex, DISPID *pid) { DWORD i; ScriptHost *script_host; @@ -2232,7 +2233,7 @@ HRESULT search_window_props(HTMLOuterWindow *This, BSTR bstrName, DWORD grfdex, } } - if(find_global_prop(This, bstrName, grfdex, &script_host, &id)) { + if(find_global_prop(This->base.outer_window, bstrName, grfdex, &script_host, &id)) { global_prop_t *prop; prop = alloc_global_prop(This, GLOBAL_SCRIPTVAR, bstrName); @@ -2252,7 +2253,7 @@ HRESULT search_window_props(HTMLOuterWindow *This, BSTR bstrName, DWORD grfdex, static HRESULT WINAPI WindowDispEx_GetDispID(IDispatchEx *iface, BSTR bstrName, DWORD grfdex, DISPID *pid) { HTMLWindow *This = impl_from_IDispatchEx(iface); - HTMLOuterWindow *window = This->outer_window; + HTMLInnerWindow *window = This->inner_window; HRESULT hres; TRACE("(%p)->(%s %x %p)\n", This, debugstr_w(bstrName), grfdex, pid); @@ -2450,10 +2451,10 @@ static HRESULT HTMLWindow_invoke(DispatchEx *dispex, DISPID id, LCID lcid, WORD HRESULT hres; idx = id - MSHTML_DISPID_CUSTOM_MIN; - if(idx >= This->base.outer_window->global_prop_cnt) + if(idx >= This->global_prop_cnt) return DISP_E_MEMBERNOTFOUND; - prop = This->base.outer_window->global_props+idx; + prop = This->global_props+idx; switch(prop->type) { case GLOBAL_SCRIPTVAR: { diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 010542e..004a4b4 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -344,10 +344,6 @@ struct HTMLOuterWindow { IHTMLScreen *screen; IOmHistory *history; - global_prop_t *global_props; - DWORD global_prop_cnt; - DWORD global_prop_size; - struct list children; struct list sibling_entry; struct list entry; @@ -358,6 +354,10 @@ struct HTMLInnerWindow { DispatchEx dispex; HTMLDocumentNode *doc; + + global_prop_t *global_props; + DWORD global_prop_cnt; + DWORD global_prop_size; }; typedef enum { @@ -850,7 +850,7 @@ HRESULT exec_script(HTMLOuterWindow*,const WCHAR*,const WCHAR*,VARIANT*) DECLSPE void set_script_mode(HTMLOuterWindow*,SCRIPTMODE) DECLSPEC_HIDDEN; BOOL find_global_prop(HTMLOuterWindow*,BSTR,DWORD,ScriptHost**,DISPID*) DECLSPEC_HIDDEN; IDispatch *get_script_disp(ScriptHost*) DECLSPEC_HIDDEN; -HRESULT search_window_props(HTMLOuterWindow*,BSTR,DWORD,DISPID*) DECLSPEC_HIDDEN; +HRESULT search_window_props(HTMLInnerWindow*,BSTR,DWORD,DISPID*) DECLSPEC_HIDDEN; HRESULT wrap_iface(IUnknown*,IUnknown*,IUnknown**) DECLSPEC_HIDDEN;

1 0

Jacek Caban : mshtml: Moved DispatchEx instance from HTMLOuterWindow to HTMLInnerWindow.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: c13bb135ca9e780de6f530c73bf2cd52212eb3ed URL: http://source.winehq.org/git/wine.git/?a=commit;h=c13bb135ca9e780de6f530c73… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:05:33 2012 +0200 mshtml: Moved DispatchEx instance from HTMLOuterWindow to HTMLInnerWindow. --- dlls/mshtml/htmlwindow.c | 38 +++++++++++++++++++------------------- dlls/mshtml/mshtml_private.h | 2 +- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index bb389d1..4a696b7 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -154,7 +154,7 @@ static HRESULT WINAPI HTMLWindow2_QueryInterface(IHTMLWindow2 *iface, REFIID rii }else if(IsEqualGUID(&IID_ITravelLogClient, riid)) { TRACE("(%p)->(IID_ITravelLogClient %p)\n", This, ppv); *ppv = &This->ITravelLogClient_iface; - }else if(dispex_query_interface(&This->outer_window->dispex, riid, ppv)) { + }else if(dispex_query_interface(&This->inner_window->dispex, riid, ppv)) { assert(!*ppv); return E_NOINTERFACE; } @@ -225,13 +225,13 @@ static void release_outer_window(HTMLOuterWindow *This) nsIDOMWindow_Release(This->nswindow); list_remove(&This->entry); - release_dispex(&This->dispex); heap_free(This); } static void release_inner_window(HTMLInnerWindow *This) { htmldoc_release(&This->doc->basedoc); + release_dispex(&This->dispex); heap_free(This); } @@ -2137,7 +2137,7 @@ static HRESULT WINAPI WindowDispEx_GetTypeInfoCount(IDispatchEx *iface, UINT *pc TRACE("(%p)->(%p)\n", This, pctinfo); - return IDispatchEx_GetTypeInfoCount(&This->outer_window->dispex.IDispatchEx_iface, pctinfo); + return IDispatchEx_GetTypeInfoCount(&This->inner_window->dispex.IDispatchEx_iface, pctinfo); } static HRESULT WINAPI WindowDispEx_GetTypeInfo(IDispatchEx *iface, UINT iTInfo, @@ -2147,7 +2147,7 @@ static HRESULT WINAPI WindowDispEx_GetTypeInfo(IDispatchEx *iface, UINT iTInfo, TRACE("(%p)->(%u %u %p)\n", This, iTInfo, lcid, ppTInfo); - return IDispatchEx_GetTypeInfo(&This->outer_window->dispex.IDispatchEx_iface, iTInfo, lcid, ppTInfo); + return IDispatchEx_GetTypeInfo(&This->inner_window->dispex.IDispatchEx_iface, iTInfo, lcid, ppTInfo); } static HRESULT WINAPI WindowDispEx_GetIDsOfNames(IDispatchEx *iface, REFIID riid, @@ -2182,7 +2182,7 @@ static HRESULT WINAPI WindowDispEx_Invoke(IDispatchEx *iface, DISPID dispIdMembe /* FIXME: Use script dispatch */ - return IDispatchEx_Invoke(&This->outer_window->dispex.IDispatchEx_iface, dispIdMember, riid, lcid, wFlags, + return IDispatchEx_Invoke(&This->inner_window->dispex.IDispatchEx_iface, dispIdMember, riid, lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); } @@ -2261,7 +2261,7 @@ static HRESULT WINAPI WindowDispEx_GetDispID(IDispatchEx *iface, BSTR bstrName, if(hres != DISP_E_UNKNOWNNAME) return hres; - hres = IDispatchEx_GetDispID(&window->dispex.IDispatchEx_iface, bstrName, grfdex, pid); + hres = IDispatchEx_GetDispID(&window->base.inner_window->dispex.IDispatchEx_iface, bstrName, grfdex, pid); if(hres != DISP_E_UNKNOWNNAME) return hres; @@ -2310,7 +2310,7 @@ static HRESULT WINAPI WindowDispEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID return hres; } - return IDispatchEx_InvokeEx(&window->dispex.IDispatchEx_iface, id, lcid, wFlags, pdp, pvarRes, + return IDispatchEx_InvokeEx(&window->base.inner_window->dispex.IDispatchEx_iface, id, lcid, wFlags, pdp, pvarRes, pei, pspCaller); } @@ -2320,7 +2320,7 @@ static HRESULT WINAPI WindowDispEx_DeleteMemberByName(IDispatchEx *iface, BSTR b TRACE("(%p)->(%s %x)\n", This, debugstr_w(bstrName), grfdex); - return IDispatchEx_DeleteMemberByName(&This->outer_window->dispex.IDispatchEx_iface, bstrName, grfdex); + return IDispatchEx_DeleteMemberByName(&This->inner_window->dispex.IDispatchEx_iface, bstrName, grfdex); } static HRESULT WINAPI WindowDispEx_DeleteMemberByDispID(IDispatchEx *iface, DISPID id) @@ -2329,7 +2329,7 @@ static HRESULT WINAPI WindowDispEx_DeleteMemberByDispID(IDispatchEx *iface, DISP TRACE("(%p)->(%x)\n", This, id); - return IDispatchEx_DeleteMemberByDispID(&This->outer_window->dispex.IDispatchEx_iface, id); + return IDispatchEx_DeleteMemberByDispID(&This->inner_window->dispex.IDispatchEx_iface, id); } static HRESULT WINAPI WindowDispEx_GetMemberProperties(IDispatchEx *iface, DISPID id, DWORD grfdexFetch, DWORD *pgrfdex) @@ -2338,7 +2338,7 @@ static HRESULT WINAPI WindowDispEx_GetMemberProperties(IDispatchEx *iface, DISPI TRACE("(%p)->(%x %x %p)\n", This, id, grfdexFetch, pgrfdex); - return IDispatchEx_GetMemberProperties(&This->outer_window->dispex.IDispatchEx_iface, id, grfdexFetch, + return IDispatchEx_GetMemberProperties(&This->inner_window->dispex.IDispatchEx_iface, id, grfdexFetch, pgrfdex); } @@ -2348,7 +2348,7 @@ static HRESULT WINAPI WindowDispEx_GetMemberName(IDispatchEx *iface, DISPID id, TRACE("(%p)->(%x %p)\n", This, id, pbstrName); - return IDispatchEx_GetMemberName(&This->outer_window->dispex.IDispatchEx_iface, id, pbstrName); + return IDispatchEx_GetMemberName(&This->inner_window->dispex.IDispatchEx_iface, id, pbstrName); } static HRESULT WINAPI WindowDispEx_GetNextDispID(IDispatchEx *iface, DWORD grfdex, DISPID id, DISPID *pid) @@ -2357,7 +2357,7 @@ static HRESULT WINAPI WindowDispEx_GetNextDispID(IDispatchEx *iface, DWORD grfde TRACE("(%p)->(%x %x %p)\n", This, grfdex, id, pid); - return IDispatchEx_GetNextDispID(&This->outer_window->dispex.IDispatchEx_iface, grfdex, id, pid); + return IDispatchEx_GetNextDispID(&This->inner_window->dispex.IDispatchEx_iface, grfdex, id, pid); } static HRESULT WINAPI WindowDispEx_GetNameSpaceParent(IDispatchEx *iface, IUnknown **ppunk) @@ -2436,24 +2436,24 @@ static const IServiceProviderVtbl ServiceProviderVtbl = { HTMLWindowSP_QueryService }; -static inline HTMLOuterWindow *impl_from_DispatchEx(DispatchEx *iface) +static inline HTMLInnerWindow *impl_from_DispatchEx(DispatchEx *iface) { - return CONTAINING_RECORD(iface, HTMLOuterWindow, dispex); + return CONTAINING_RECORD(iface, HTMLInnerWindow, dispex); } static HRESULT HTMLWindow_invoke(DispatchEx *dispex, DISPID id, LCID lcid, WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) { - HTMLOuterWindow *This = impl_from_DispatchEx(dispex); + HTMLInnerWindow *This = impl_from_DispatchEx(dispex); global_prop_t *prop; DWORD idx; HRESULT hres; idx = id - MSHTML_DISPID_CUSTOM_MIN; - if(idx >= This->global_prop_cnt) + if(idx >= This->base.outer_window->global_prop_cnt) return DISP_E_MEMBERNOTFOUND; - prop = This->global_props+idx; + prop = This->base.outer_window->global_props+idx; switch(prop->type) { case GLOBAL_SCRIPTVAR: { @@ -2580,6 +2580,8 @@ static HRESULT create_inner_window(HTMLOuterWindow *outer_window, HTMLDocumentNo htmldoc_addref(&doc_node->basedoc); window->doc = doc_node; + init_dispex(&window->dispex, (IUnknown*)&window->base.IHTMLWindow2_iface, &HTMLWindow_dispex); + *ret = window; return S_OK; } @@ -2608,8 +2610,6 @@ HRESULT HTMLOuterWindow_Create(HTMLDocumentObj *doc_obj, nsIDOMWindow *nswindow, window->window_ref->window = window; window->window_ref->ref = 1; - init_dispex(&window->dispex, (IUnknown*)&window->base.IHTMLWindow2_iface, &HTMLWindow_dispex); - if(nswindow) { nsIDOMWindow_AddRef(nswindow); window->nswindow = nswindow; diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index cfec956..010542e 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -316,7 +316,6 @@ struct HTMLWindow { struct HTMLOuterWindow { HTMLWindow base; - DispatchEx dispex; windowref_t *window_ref; LONG task_magic; @@ -356,6 +355,7 @@ struct HTMLOuterWindow { struct HTMLInnerWindow { HTMLWindow base; + DispatchEx dispex; HTMLDocumentNode *doc; };

1 0

Jacek Caban : mshtml: Moved document node from HTMLOuterWindow to HTMLInnerWindow.
by Alexandre Julliard June 25, 2012

June 25, 2012

Module: wine Branch: master Commit: 79356c65c1e681ed46656cd65bb0f63617f37b8b URL: http://source.winehq.org/git/wine.git/?a=commit;h=79356c65c1e681ed46656cd65… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jun 25 14:05:17 2012 +0200 mshtml: Moved document node from HTMLOuterWindow to HTMLInnerWindow. --- dlls/mshtml/htmldoc.c | 7 +- dlls/mshtml/htmlevent.c | 2 +- dlls/mshtml/htmlevent.h | 2 +- dlls/mshtml/htmlframe.c | 4 +- dlls/mshtml/htmlframebase.c | 4 +- dlls/mshtml/htmliframe.c | 4 +- dlls/mshtml/htmlimg.c | 9 ++- dlls/mshtml/htmloption.c | 6 +- dlls/mshtml/htmlwindow.c | 172 +++++++++++++++++++++++++++--------------- dlls/mshtml/mshtml_private.h | 5 +- dlls/mshtml/navigate.c | 12 ++-- dlls/mshtml/npplugin.c | 8 +- dlls/mshtml/nsio.c | 8 +- dlls/mshtml/persist.c | 2 +- dlls/mshtml/script.c | 6 +- 15 files changed, 151 insertions(+), 100 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=79356c65c1e681ed46656…

1 0