January 2017 - Wine-Commits

Gerald Pfeifer : winedump: Increase buffer size and potential string length inoutput_spec_symbol.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: 3d258b0fd7df2744c35a9b7ee5d8653fb6653aa2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3d258b0fd7df2744c35a9b7ee… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Jan 21 17:26:42 2017 +0100 winedump: Increase buffer size and potential string length inoutput_spec_symbol. Signed-off-by: Gerald Pfeifer <gerald(a)pfeifer.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/winedump/output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/winedump/output.c b/tools/winedump/output.c index 6c2bfae..bbbb1ac 100644 --- a/tools/winedump/output.c +++ b/tools/winedump/output.c @@ -62,13 +62,13 @@ void output_spec_preamble (void) */ void output_spec_symbol (const parsed_symbol *sym) { - char ord_spec[16]; + char ord_spec[20]; assert (specfile); assert (sym && sym->symbol); if (sym->ordinal >= 0) - snprintf(ord_spec, 8, "%d", sym->ordinal); + snprintf(ord_spec, 12, "%d", sym->ordinal); else { ord_spec[0] = '@';

1 0

Andrew Eikum : kernel32/tests: Test result from LCIDToLocaleName.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: 3da1616e840fc3e4848662ac1bf2ab34ca9d0185 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3da1616e840fc3e4848662ac1… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Jan 24 14:44:05 2017 -0600 kernel32/tests: Test result from LCIDToLocaleName. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/locale.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index 7cbaafa..1bac846 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/kernel32/tests/locale.c @@ -2675,25 +2675,26 @@ static void test_LCMapStringEx(void) struct neutralsublang_name_t { WCHAR name[3]; + WCHAR sname[16]; LCID lcid; int todo; }; static const struct neutralsublang_name_t neutralsublang_names[] = { - { {'a','r',0}, MAKELCID(MAKELANGID(LANG_ARABIC, SUBLANG_ARABIC_SAUDI_ARABIA), SORT_DEFAULT) }, - { {'a','z',0}, MAKELCID(MAKELANGID(LANG_AZERI, SUBLANG_AZERI_LATIN), SORT_DEFAULT) }, - { {'d','e',0}, MAKELCID(MAKELANGID(LANG_GERMAN, SUBLANG_GERMAN), SORT_DEFAULT) }, - { {'e','n',0}, MAKELCID(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), SORT_DEFAULT) }, - { {'e','s',0}, MAKELCID(MAKELANGID(LANG_SPANISH, SUBLANG_SPANISH_MODERN), SORT_DEFAULT) }, - { {'g','a',0}, MAKELCID(MAKELANGID(LANG_IRISH, SUBLANG_IRISH_IRELAND), SORT_DEFAULT) }, - { {'i','t',0}, MAKELCID(MAKELANGID(LANG_ITALIAN, SUBLANG_ITALIAN), SORT_DEFAULT) }, - { {'m','s',0}, MAKELCID(MAKELANGID(LANG_MALAY, SUBLANG_MALAY_MALAYSIA), SORT_DEFAULT) }, - { {'n','l',0}, MAKELCID(MAKELANGID(LANG_DUTCH, SUBLANG_DUTCH), SORT_DEFAULT) }, - { {'p','t',0}, MAKELCID(MAKELANGID(LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN), SORT_DEFAULT) }, - { {'s','r',0}, MAKELCID(MAKELANGID(LANG_SERBIAN, SUBLANG_SERBIAN_SERBIA_LATIN), SORT_DEFAULT), 1 }, - { {'s','v',0}, MAKELCID(MAKELANGID(LANG_SWEDISH, SUBLANG_SWEDISH), SORT_DEFAULT) }, - { {'u','z',0}, MAKELCID(MAKELANGID(LANG_UZBEK, SUBLANG_UZBEK_LATIN), SORT_DEFAULT) }, - { {'z','h',0}, MAKELCID(MAKELANGID(LANG_CHINESE, SUBLANG_CHINESE_SIMPLIFIED), SORT_DEFAULT) }, + { {'a','r',0}, {'a','r','-','S','A',0}, MAKELCID(MAKELANGID(LANG_ARABIC, SUBLANG_ARABIC_SAUDI_ARABIA), SORT_DEFAULT) }, + { {'a','z',0}, {'a','z','-','L','a','t','n','-','A','Z',0}, MAKELCID(MAKELANGID(LANG_AZERI, SUBLANG_AZERI_LATIN), SORT_DEFAULT) }, + { {'d','e',0}, {'d','e','-','D','E',0}, MAKELCID(MAKELANGID(LANG_GERMAN, SUBLANG_GERMAN), SORT_DEFAULT) }, + { {'e','n',0}, {'e','n','-','U','S',0}, MAKELCID(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), SORT_DEFAULT) }, + { {'e','s',0}, {'e','s','-','E','S',0}, MAKELCID(MAKELANGID(LANG_SPANISH, SUBLANG_SPANISH_MODERN), SORT_DEFAULT) }, + { {'g','a',0}, {'g','a','-','I','E',0}, MAKELCID(MAKELANGID(LANG_IRISH, SUBLANG_IRISH_IRELAND), SORT_DEFAULT) }, + { {'i','t',0}, {'i','t','-','I','T',0}, MAKELCID(MAKELANGID(LANG_ITALIAN, SUBLANG_ITALIAN), SORT_DEFAULT) }, + { {'m','s',0}, {'m','s','-','M','Y',0}, MAKELCID(MAKELANGID(LANG_MALAY, SUBLANG_MALAY_MALAYSIA), SORT_DEFAULT) }, + { {'n','l',0}, {'n','l','-','N','L',0}, MAKELCID(MAKELANGID(LANG_DUTCH, SUBLANG_DUTCH), SORT_DEFAULT) }, + { {'p','t',0}, {'p','t','-','B','R',0}, MAKELCID(MAKELANGID(LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN), SORT_DEFAULT) }, + { {'s','r',0}, {'s','r','-','L','a','t','n','-','R','S',0}, MAKELCID(MAKELANGID(LANG_SERBIAN, SUBLANG_SERBIAN_SERBIA_LATIN), SORT_DEFAULT), 1 }, + { {'s','v',0}, {'s','v','-','S','E',0}, MAKELCID(MAKELANGID(LANG_SWEDISH, SUBLANG_SWEDISH), SORT_DEFAULT) }, + { {'u','z',0}, {'u','z','-','L','a','t','n','-','U','Z',0}, MAKELCID(MAKELANGID(LANG_UZBEK, SUBLANG_UZBEK_LATIN), SORT_DEFAULT) }, + { {'z','h',0}, {'z','h','-','C','N',0}, MAKELCID(MAKELANGID(LANG_CHINESE, SUBLANG_CHINESE_SIMPLIFIED), SORT_DEFAULT) }, { {0} } }; @@ -2761,7 +2762,7 @@ static void test_LocaleNameToLCID(void) *buffer = 0; ret = pLCIDToLocaleName(lcid, buffer, sizeof(buffer)/sizeof(WCHAR), 0); ok(ret > 0, "%s: got %d\n", wine_dbgstr_w(ptr->name), ret); - ok(lstrcmpW(ptr->name, buffer), "%s: got wrong locale name %s\n", + ok(!lstrcmpW(ptr->sname, buffer), "%s: got wrong locale name %s\n", wine_dbgstr_w(ptr->name), wine_dbgstr_w(buffer)); ptr++;

1 0

Andrew Eikum : kernel32: Don' t care about case when finding matching locale.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: 72b9acd94bc891b993b69730d6ceb3878342dcad URL: http://source.winehq.org/git/wine.git/?a=commit;h=72b9acd94bc891b993b69730d… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Jan 24 14:44:11 2017 -0600 kernel32: Don't care about case when finding matching locale. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/locale.c | 6 +++--- dlls/kernel32/tests/locale.c | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c index 2bf1024..ca59751 100644 --- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c @@ -390,7 +390,7 @@ static BOOL CALLBACK find_locale_id_callback( HMODULE hModule, LPCWSTR type, GetLocaleInfoW( lcid, LOCALE_SNAME | LOCALE_NOUSEROVERRIDE, buffer, sizeof(buffer)/sizeof(WCHAR) )) { - if (!strcmpW( data->win_name, buffer )) + if (!strcmpiW( data->win_name, buffer )) { matches = 4; /* everything matches */ goto done; @@ -400,7 +400,7 @@ static BOOL CALLBACK find_locale_id_callback( HMODULE hModule, LPCWSTR type, if (!GetLocaleInfoW( lcid, LOCALE_SISO639LANGNAME | LOCALE_NOUSEROVERRIDE, buffer, sizeof(buffer)/sizeof(WCHAR) )) return TRUE; - if (strcmpW( buffer, data->lang )) return TRUE; + if (strcmpiW( buffer, data->lang )) return TRUE; matches++; /* language name matched */ if (data->country) @@ -408,7 +408,7 @@ static BOOL CALLBACK find_locale_id_callback( HMODULE hModule, LPCWSTR type, if (GetLocaleInfoW( lcid, LOCALE_SISO3166CTRYNAME|LOCALE_NOUSEROVERRIDE, buffer, sizeof(buffer)/sizeof(WCHAR) )) { - if (strcmpW( buffer, data->country )) goto done; + if (strcmpiW( buffer, data->country )) goto done; matches++; /* country name matched */ } } diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index 1bac846..05564c4 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/kernel32/tests/locale.c @@ -2704,6 +2704,7 @@ static void test_LocaleNameToLCID(void) INT ret; WCHAR buffer[LOCALE_NAME_MAX_LENGTH]; static const WCHAR enW[] = {'e','n',0}; + static const WCHAR esesW[] = {'e','s','-','e','s',0}; if (!pLocaleNameToLCID) { @@ -2744,6 +2745,10 @@ static void test_LocaleNameToLCID(void) ok(!lcid && GetLastError() == ERROR_INVALID_PARAMETER, "Expected lcid == 0, got %08x, error %d\n", lcid, GetLastError()); + /* lower-case */ + lcid = pLocaleNameToLCID(esesW, 0); + ok(lcid == MAKELCID(MAKELANGID(LANG_SPANISH, SUBLANG_SPANISH_MODERN), SORT_DEFAULT), "Got wrong lcid for es-es: 0x%x\n", lcid); + /* english neutral name */ lcid = pLocaleNameToLCID(enW, 0); ok(lcid == MAKELCID(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), SORT_DEFAULT) ||

1 0

Bruno Jesus : iphlpapi/tests: Avoid ntoa() twice in function call as it returns same pointer.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: 76644a7c26f2c2b3a5968665c349b45bdb294387 URL: http://source.winehq.org/git/wine.git/?a=commit;h=76644a7c26f2c2b3a5968665c… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Wed Jan 25 15:33:00 2017 -0200 iphlpapi/tests: Avoid ntoa() twice in function call as it returns same pointer. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/iphlpapi/tests/iphlpapi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c index cb73a9d..64d03cf 100644 --- a/dlls/iphlpapi/tests/iphlpapi.c +++ b/dlls/iphlpapi/tests/iphlpapi.c @@ -1598,9 +1598,12 @@ static void test_AllocateAndGetTcpExTableFromStack(void) trace( "AllocateAndGetTcpExTableFromStack table: %u entries\n", table_ex->dwNumEntries ); for (i = 0; i < table_ex->dwNumEntries; i++) { + char remote_ip[16]; + + strcpy(remote_ip, ntoa(table_ex->table[i].dwRemoteAddr)); trace( "%u: local %s:%u remote %s:%u state %u pid %u\n", i, ntoa(table_ex->table[i].dwLocalAddr), ntohs(table_ex->table[i].dwLocalPort), - ntoa( table_ex->table[i].dwRemoteAddr ), ntohs(table_ex->table[i].dwRemotePort), + remote_ip, ntohs(table_ex->table[i].dwRemotePort), U(table_ex->table[i]).dwState, table_ex->table[i].dwOwningPid ); } }

1 0

Vincent Povirk : hhctrl.ocx: Also take basename of folders when searching.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: a16344ca1936254b021d82c4dfe6e2f6657010d4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a16344ca1936254b021d82c4d… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Jan 25 11:23:01 2017 -0600 hhctrl.ocx: Also take basename of folders when searching. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hhctrl.ocx/search.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/hhctrl.ocx/search.c b/dlls/hhctrl.ocx/search.c index 287e6d0..d758a1b 100644 --- a/dlls/hhctrl.ocx/search.c +++ b/dlls/hhctrl.ocx/search.c @@ -167,14 +167,14 @@ static SearchItem *SearchCHM_Storage(SearchItem *item, IStorage *pStorage, } while (IEnumSTATSTG_Next(elem, 1, &entries, &retr) == NOERROR) { + filename = entries.pwcsName; + while(strchrW(filename, '/')) + filename = strchrW(filename, '/')+1; switch(entries.type) { case STGTY_STORAGE: - item = SearchCHM_Folder(item, pStorage, entries.pwcsName, needle); + item = SearchCHM_Folder(item, pStorage, filename, needle); break; case STGTY_STREAM: - filename = entries.pwcsName; - while(strchrW(filename, '/')) - filename = strchrW(filename, '/')+1; if(strstrW(filename, szHTMext)) { WCHAR *title = SearchCHM_File(pStorage, filename, needle);

1 0

Jacek Caban : mshtml/tests: Added text selection type tests.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: f5f4765aab12f24a72e1cf28149b7955e19b95c4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5f4765aab12f24a72e1cf281… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jan 25 18:12:45 2017 +0100 mshtml/tests: Added text selection type tests. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/dom.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 8e8a662..e784189 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5378,6 +5378,24 @@ static void test_create_img_elem(IHTMLDocument2 *doc) } } +#define test_doc_selection_type(a,b) _test_doc_selection_type(__LINE__,a,b) +static void _test_doc_selection_type(unsigned line, IHTMLDocument2 *doc, const char *type) +{ + IHTMLSelectionObject *selection; + BSTR str; + HRESULT hres; + + hres = IHTMLDocument2_get_selection(doc, &selection); + ok_(__FILE__,line)(hres == S_OK, "get_selection failed: %08x\n", hres); + + hres = IHTMLSelectionObject_get_type(selection, &str); + ok_(__FILE__,line)(hres == S_OK, "get_type failed: %08x\n", hres); + ok_(__FILE__,line)(!strcmp_wa(str, type), "type = %s, expected %s\n", wine_dbgstr_w(str), type); + SysFreeString(str); + + IHTMLSelectionObject_Release(selection); +} + #define insert_adjacent_elem(a,b,c) _insert_adjacent_elem(__LINE__,a,b,c) static void _insert_adjacent_elem(unsigned line, IHTMLElement *parent, const char *where, IHTMLElement *elem) { @@ -5702,6 +5720,11 @@ static void test_txtrange(IHTMLDocument2 *doc) test_range_set_end_point(range, "xxx", body_range, E_INVALIDARG); + hres = IHTMLTxtRange_select(range); + ok(hres == S_OK, "select failed: %08x\n", hres); + + test_doc_selection_type(doc, "Text"); + IHTMLTxtRange_Release(range); IHTMLTxtRange_Release(range2); IHTMLTxtRange_Release(body_range); @@ -6281,17 +6304,13 @@ static void test_default_selection(IHTMLDocument2 *doc) IHTMLSelectionObject *selection; IHTMLTxtRange *range; IDispatch *disp; - BSTR str; HRESULT hres; + test_doc_selection_type(doc, "None"); + hres = IHTMLDocument2_get_selection(doc, &selection); ok(hres == S_OK, "get_selection failed: %08x\n", hres); - hres = IHTMLSelectionObject_get_type(selection, &str); - ok(hres == S_OK, "get_type failed: %08x\n", hres); - ok(!strcmp_wa(str, "None"), "type = %s\n", wine_dbgstr_w(str)); - SysFreeString(str); - hres = IHTMLSelectionObject_createRange(selection, &disp); IHTMLSelectionObject_Release(selection); ok(hres == S_OK, "createRange failed: %08x\n", hres);

1 0

Aric Stewart : usp10: Implement Chaining Context Substitution Format 2: Class-based Chaining Context Glyph Substitution.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: aae5a831e2e76e39b76464ba921dded7c2fbf9e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aae5a831e2e76e39b76464ba9… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Jan 25 07:17:38 2017 -0600 usp10: Implement Chaining Context Substitution Format 2: Class-based Chaining Context Glyph Substitution. Used by the font Noto Nastaliq Urdu. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/usp10/opentype.c | 155 ++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 151 insertions(+), 4 deletions(-) diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c index 90df479..d2eb749 100644 --- a/dlls/usp10/opentype.c +++ b/dlls/usp10/opentype.c @@ -290,6 +290,41 @@ typedef struct{ }GSUB_ChainContextSubstFormat1; typedef struct { + WORD SubstFormat; /* = 2 */ + WORD Coverage; + WORD BacktrackClassDef; + WORD InputClassDef; + WORD LookaheadClassDef; + WORD ChainSubClassSetCnt; + WORD ChainSubClassSet[1]; +}GSUB_ChainContextSubstFormat2; + +typedef struct { + WORD ChainSubClassRuleCnt; + WORD ChainSubClassRule[1]; +}GSUB_ChainSubClassSet; + +typedef struct { + WORD BacktrackGlyphCount; + WORD Backtrack[1]; +}GSUB_ChainSubClassRule_1; + +typedef struct { + WORD InputGlyphCount; + WORD Input[1]; +}GSUB_ChainSubClassRule_2; + +typedef struct { + WORD LookaheadGlyphCount; + WORD LookAhead[1]; +}GSUB_ChainSubClassRule_3; + +typedef struct { + WORD SubstCount; + GSUB_SubstLookupRecord SubstLookupRecord[1]; +}GSUB_ChainSubClassRule_4; + +typedef struct { WORD SubstFormat; /* = 3 */ WORD BacktrackGlyphCount; WORD Coverage[1]; @@ -1175,10 +1210,122 @@ static INT GSUB_apply_ChainContextSubst(const OT_LookupList* lookup, const OT_Lo } else if (GET_BE_WORD(ccsf1->SubstFormat) == 2) { - static int once; - if (!once++) - FIXME(" TODO: subtype 2 (Class-based Chaining Context Glyph Substitution)\n"); - continue; + int newIndex = glyph_index; + WORD offset, count; + const void *backtrack_class_table; + const void *input_class_table; + const void *lookahead_class_table; + int i; + WORD class; + + const GSUB_ChainContextSubstFormat2 *ccsf2 = (const GSUB_ChainContextSubstFormat2*)ccsf1; + const GSUB_ChainSubClassSet *csc; + + TRACE(" subtype 2 (Class-based Chaining Context Glyph Substitution)\n"); + + offset = GET_BE_WORD(ccsf2->Coverage); + + if (GSUB_is_glyph_covered((const BYTE*)ccsf2+offset, glyphs[glyph_index]) == -1) + { + TRACE("Glyph not covered\n"); + continue; + } + offset = GET_BE_WORD(ccsf2->BacktrackClassDef); + backtrack_class_table = (const BYTE*)ccsf2+offset; + offset = GET_BE_WORD(ccsf2->InputClassDef); + input_class_table = (const BYTE*)ccsf2+offset; + offset = GET_BE_WORD(ccsf2->LookaheadClassDef); + lookahead_class_table = (const BYTE*)ccsf2+offset; + count = GET_BE_WORD(ccsf2->ChainSubClassSetCnt); + + class = OT_get_glyph_class(input_class_table, glyphs[glyph_index]); + offset = GET_BE_WORD(ccsf2->ChainSubClassSet[class]); + + if (offset == 0) + { + TRACE("No rules for class\n"); + continue; + } + + csc = (const GSUB_ChainSubClassSet*)((BYTE*)ccsf2+offset); + count = GET_BE_WORD(csc->ChainSubClassRuleCnt); + + TRACE("%i rules to check\n",count); + + for (i = 0; i < count; i++) + { + int k; + int indexGlyphs; + const GSUB_ChainSubClassRule_1 *cscr_1; + const GSUB_ChainSubClassRule_2 *cscr_2; + const GSUB_ChainSubClassRule_3 *cscr_3; + const GSUB_ChainSubClassRule_4 *cscr_4; + + offset = GET_BE_WORD(csc->ChainSubClassRule[i]); + cscr_1 = (const GSUB_ChainSubClassRule_1*)((BYTE*)csc+offset); + + for (k = 0; k < GET_BE_WORD(cscr_1->BacktrackGlyphCount); k++) + { + WORD target_class = GET_BE_WORD(cscr_1->Backtrack[k]); + WORD glyph_class = OT_get_glyph_class(backtrack_class_table, glyphs[glyph_index + (dirBacktrack * (k+1))]); + if (target_class != glyph_class) + break; + } + if (k != GET_BE_WORD(cscr_1->BacktrackGlyphCount)) + continue; + TRACE("Matched Backtrack\n"); + + cscr_2 = (const GSUB_ChainSubClassRule_2*)((BYTE *)cscr_1 + + FIELD_OFFSET(GSUB_ChainSubClassRule_1, Backtrack[GET_BE_WORD(cscr_1->BacktrackGlyphCount)])); + + indexGlyphs = GET_BE_WORD(cscr_2->InputGlyphCount); + for (k = 0; k < indexGlyphs - 1; k++) + { + WORD target_class = GET_BE_WORD(cscr_2->Input[k]); + WORD glyph_class = OT_get_glyph_class(input_class_table, glyphs[glyph_index + (write_dir * (k+1))]); + if (target_class != glyph_class) + break; + } + if (k != indexGlyphs-1) + continue; + TRACE("Matched IndexGlyphs\n"); + + cscr_3 = (const GSUB_ChainSubClassRule_3*)((BYTE *)cscr_2 + + FIELD_OFFSET(GSUB_ChainSubClassRule_2, Input[GET_BE_WORD(cscr_2->InputGlyphCount)-1])); + + for (k = 0; k < GET_BE_WORD(cscr_3->LookaheadGlyphCount); k++) + { + WORD target_class = GET_BE_WORD(cscr_3->LookAhead[k]); + WORD glyph_class = OT_get_glyph_class(lookahead_class_table, glyphs[glyph_index + (dirLookahead * (indexGlyphs+k))]); + if (target_class != glyph_class) + break; + } + if (k != GET_BE_WORD(cscr_3->LookaheadGlyphCount)) + continue; + TRACE("Matched LookAhead\n"); + + cscr_4 = (const GSUB_ChainSubClassRule_4*)((BYTE *)cscr_3 + + FIELD_OFFSET(GSUB_ChainSubClassRule_3, LookAhead[GET_BE_WORD(cscr_3->LookaheadGlyphCount)])); + + if (GET_BE_WORD(cscr_4->SubstCount)) + { + for (k = 0; k < GET_BE_WORD(cscr_4->SubstCount); k++) + { + int lookupIndex = GET_BE_WORD(cscr_4->SubstLookupRecord[k].LookupListIndex); + int SequenceIndex = GET_BE_WORD(cscr_4->SubstLookupRecord[k].SequenceIndex) * write_dir; + + TRACE("SUBST: %i -> %i %i\n",k, SequenceIndex, lookupIndex); + newIndex = GSUB_apply_lookup(lookup, lookupIndex, glyphs, glyph_index + SequenceIndex, write_dir, glyph_count); + if (newIndex == -1) + { + ERR("Chain failed to generate a glyph\n"); + continue; + } + } + return newIndex; + } + else return GSUB_E_NOGLYPH; + } } else if (GET_BE_WORD(ccsf1->SubstFormat) == 3) {

1 0

Aric Stewart : usp10: Implement Contextual Positioning Subtable: Format 2.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: b98a70aa40b1ce8dddbfbcfce5bc0a49117a749d URL: http://source.winehq.org/git/wine.git/?a=commit;h=b98a70aa40b1ce8dddbfbcfce… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Jan 25 07:16:29 2017 -0600 usp10: Implement Contextual Positioning Subtable: Format 2. Used by the font Noto Nastaliq Urdu. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/usp10/opentype.c | 128 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 128 insertions(+) diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c index 29ec503..90df479 100644 --- a/dlls/usp10/opentype.c +++ b/dlls/usp10/opentype.c @@ -511,6 +511,29 @@ typedef struct { typedef struct { WORD PosFormat; + WORD Coverage; + WORD ClassDef; + WORD PosClassSetCnt; + WORD PosClassSet[1]; +} GPOS_ContextPosFormat2; + +typedef struct { + WORD PosClassRuleCnt; + WORD PosClassRule[1]; +} GPOS_PosClassSet; + +typedef struct { + WORD GlyphCount; + WORD PosCount; + WORD Class[1]; +} GPOS_PosClassRule_1; + +typedef struct { + GPOS_PosLookupRecord PosLookupRecord[1]; +} GPOS_PosClassRule_2; + +typedef struct { + WORD PosFormat; WORD BacktrackGlyphCount; WORD Coverage[1]; } GPOS_ChainContextPosFormat3_1; @@ -1869,6 +1892,109 @@ static BOOL GPOS_apply_MarkToMark(const OT_LookupTable *look, const SCRIPT_ANALY return rc; } +static INT GPOS_apply_ContextPos(ScriptCache *psc, LPOUTLINETEXTMETRICW lpotm, LPLOGFONTW lplogfont, const SCRIPT_ANALYSIS *analysis, INT* piAdvance, + const OT_LookupList *lookup, const OT_LookupTable *look, const WORD *glyphs, INT glyph_index, + INT glyph_count, INT ppem, GOFFSET *pGoffset) +{ + int j; + int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; + + TRACE("Contextual Positioning Subtable\n"); + + for (j = 0; j < GET_BE_WORD(look->SubTableCount); j++) + { + const GPOS_ContextPosFormat2 *cpf2 = (GPOS_ContextPosFormat2*)GPOS_get_subtable(look, j); + + if (GET_BE_WORD(cpf2->PosFormat) == 1) + { + static int once; + if (!once++) + FIXME(" TODO: subtype 1\n"); + continue; + } + else if (GET_BE_WORD(cpf2->PosFormat) == 2) + { + WORD offset = GET_BE_WORD(cpf2->Coverage); + int index; + + TRACE("Contextual Positioning Subtable: Format 2\n"); + + index = GSUB_is_glyph_covered((const BYTE*)cpf2+offset, glyphs[glyph_index]); + TRACE("Coverage index %i\n",index); + if (index != -1) + { + int k, count, class; + const GPOS_PosClassSet *pcs; + const void *glyph_class_table = NULL; + + offset = GET_BE_WORD(cpf2->ClassDef); + glyph_class_table = (const BYTE *)cpf2 + offset; + + class = OT_get_glyph_class(glyph_class_table,glyphs[glyph_index]); + + offset = GET_BE_WORD(cpf2->PosClassSet[class]); + if (offset == 0) + { + TRACE("No class rule table for class %i\n",class); + continue; + } + pcs = (const GPOS_PosClassSet*)((const BYTE*)cpf2+offset); + count = GET_BE_WORD(pcs->PosClassRuleCnt); + TRACE("PosClassSet has %i members\n",count); + for (k = 0; k < count; k++) + { + const GPOS_PosClassRule_1 *pr; + const GPOS_PosClassRule_2 *pr_2; + int g_count, l; + + offset = GET_BE_WORD(pcs->PosClassRule[k]); + pr = (const GPOS_PosClassRule_1*)((const BYTE*)pcs+offset); + g_count = GET_BE_WORD(pr->GlyphCount); + TRACE("PosClassRule has %i glyphs classes\n",g_count); + for (l = 0; l < g_count-1; l++) + { + int g_class = OT_get_glyph_class(glyph_class_table, glyphs[glyph_index + (write_dir * (l+1))]); + if (g_class != GET_BE_WORD(pr->Class[l])) break; + } + + if (l < g_count-1) + { + TRACE("Rule does not match\n"); + continue; + } + + TRACE("Rule matches\n"); + pr_2 = (const GPOS_PosClassRule_2*)((const BYTE*)pr+ + FIELD_OFFSET(GPOS_PosClassRule_1, Class[g_count-1])); + + for (l = 0; l < GET_BE_WORD(pr->PosCount); l++) + { + int lookupIndex = GET_BE_WORD(pr_2->PosLookupRecord[l].LookupListIndex); + int SequenceIndex = GET_BE_WORD(pr_2->PosLookupRecord[l].SequenceIndex) * write_dir; + + TRACE("Position: %i -> %i %i\n",l, SequenceIndex, lookupIndex); + GPOS_apply_lookup(psc, lpotm, lplogfont, analysis, piAdvance, lookup, lookupIndex, glyphs, glyph_index + SequenceIndex, glyph_count, pGoffset); + } + return glyph_index + 1; + } + } + + TRACE("Not covered\n"); + continue; + } + else if (GET_BE_WORD(cpf2->PosFormat) == 3) + { + static int once; + if (!once++) + FIXME(" TODO: subtype 3\n"); + continue; + } + else + FIXME("Unhandled Contextual Positioning Format %i\n",GET_BE_WORD(cpf2->PosFormat)); + } + return glyph_index + 1; +} + static INT GPOS_apply_ChainContextPos(ScriptCache *psc, LPOUTLINETEXTMETRICW lpotm, LPLOGFONTW lplogfont, const SCRIPT_ANALYSIS *analysis, INT* piAdvance, const OT_LookupList *lookup, const OT_LookupTable *look, const WORD *glyphs, INT glyph_index, INT glyph_count, INT ppem, GOFFSET *pGoffset) @@ -2117,6 +2243,8 @@ static INT GPOS_apply_lookup(ScriptCache *psc, LPOUTLINETEXTMETRICW lpotm, LPLOG } break; } + case 7: + return GPOS_apply_ContextPos(psc, lpotm, lplogfont, analysis, piAdvance, lookup, look, glyphs, glyph_index, glyph_count, ppem, pGoffset); case 8: { return GPOS_apply_ChainContextPos(psc, lpotm, lplogfont, analysis, piAdvance, lookup, look, glyphs, glyph_index, glyph_count, ppem, pGoffset);

1 0

Vincent Povirk : hhctrl.ocx: Don't skip a tag in next_node.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: 89ca96d06cf7ef063664a36069000341dfdc39c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=89ca96d06cf7ef063664a3606… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Jan 25 11:23:02 2017 -0600 hhctrl.ocx: Don't skip a tag in next_node. At the time this function is called, we're already past the '<' that begins the current tag. Calling find_end_node twice here means we were skipping every other tag. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hhctrl.ocx/stream.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/dlls/hhctrl.ocx/stream.c b/dlls/hhctrl.ocx/stream.c index 84ed317..b4239ca 100644 --- a/dlls/hhctrl.ocx/stream.c +++ b/dlls/hhctrl.ocx/stream.c @@ -139,17 +139,6 @@ static BOOL find_node_end(stream_t *stream, strbuf_t *buf) BOOL next_node(stream_t *stream, strbuf_t *buf) { - strbuf_t tmpbuf; - - /* search through the end of the current node */ - strbuf_init(&tmpbuf); - if(!find_node_end(stream, &tmpbuf)) - { - strbuf_free(&tmpbuf); - return FALSE; - } - strbuf_free(&tmpbuf); - /* find the beginning of the next node */ if(!stream_chr(stream, NULL, '<')) return FALSE;

1 0

Jacek Caban : mshtml: Added IHTMLSelectionObject2:: get_typeDetail semi-stub implementation.
by Alexandre Julliard Jan. 25, 2017

Jan. 25, 2017

Module: wine Branch: master Commit: fedc26ec3f0fc292189cf60a58ff7cd393cef16f URL: http://source.winehq.org/git/wine.git/?a=commit;h=fedc26ec3f0fc292189cf60a5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jan 25 18:13:00 2017 +0100 mshtml: Added IHTMLSelectionObject2::get_typeDetail semi-stub implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/selection.c | 10 ++++++++-- dlls/mshtml/tests/dom.c | 11 +++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/selection.c b/dlls/mshtml/selection.c index 2cf0e0a..dfbb386 100644 --- a/dlls/mshtml/selection.c +++ b/dlls/mshtml/selection.c @@ -307,8 +307,14 @@ static HRESULT WINAPI HTMLSelectionObject2_createRangeCollection(IHTMLSelectionO static HRESULT WINAPI HTMLSelectionObject2_get_typeDetail(IHTMLSelectionObject2 *iface, BSTR *p) { HTMLSelectionObject *This = impl_from_IHTMLSelectionObject2(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + static const WCHAR undefinedW[] = {'u','n','d','e','f','i','n','e','d',0}; + + FIXME("(%p)->(%p) semi-stub\n", This, p); + + /* FIXME: We should try to use ISelectionServicesListener::GetTypeDetail here. */ + *p = SysAllocString(undefinedW); + return *p ? S_OK : E_OUTOFMEMORY; } static const IHTMLSelectionObject2Vtbl HTMLSelectionObject2Vtbl = { diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index e784189..7524d55 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5381,6 +5381,7 @@ static void test_create_img_elem(IHTMLDocument2 *doc) #define test_doc_selection_type(a,b) _test_doc_selection_type(__LINE__,a,b) static void _test_doc_selection_type(unsigned line, IHTMLDocument2 *doc, const char *type) { + IHTMLSelectionObject2 *selection2; IHTMLSelectionObject *selection; BSTR str; HRESULT hres; @@ -5393,7 +5394,17 @@ static void _test_doc_selection_type(unsigned line, IHTMLDocument2 *doc, const c ok_(__FILE__,line)(!strcmp_wa(str, type), "type = %s, expected %s\n", wine_dbgstr_w(str), type); SysFreeString(str); + hres = IHTMLSelectionObject_QueryInterface(selection, &IID_IHTMLSelectionObject2, (void**)&selection2); + ok_(__FILE__,line)(hres == S_OK, "Could not get IHTMLSelectionObject2 iface: %08x\n", hres); + IHTMLSelectionObject_Release(selection); + + hres = IHTMLSelectionObject2_get_typeDetail(selection2, &str); + ok_(__FILE__,line)(hres == S_OK, "get_typeDetail failed: %08x\n", hres); + ok_(__FILE__,line)(!strcmp_wa(str, "undefined"), "typeDetail = %s\n", wine_dbgstr_w(str)); + SysFreeString(str); + + IHTMLSelectionObject2_Release(selection2); } #define insert_adjacent_elem(a,b,c) _insert_adjacent_elem(__LINE__,a,b,c)

1 0