December 2020 - Wine-Commits

Alexandre Julliard : rpcrt4/tests: Avoid a printf format warning.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: b61cfa88235d77cee4878837afd9f65d025e4a3f URL: https://source.winehq.org/git/wine.git/?a=commit;h=b61cfa88235d77cee4878837… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 2 12:19:18 2020 +0100 rpcrt4/tests: Avoid a printf format warning. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/rpcrt4/tests/rpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/rpcrt4/tests/rpc.c b/dlls/rpcrt4/tests/rpc.c index 0b9e71ec0a2..8ae63a140e7 100644 --- a/dlls/rpcrt4/tests/rpc.c +++ b/dlls/rpcrt4/tests/rpc.c @@ -896,9 +896,9 @@ static void test_RpcIfInqId(void) ok(status == RPC_S_OK, "Test %u: Expected %#x, got %#x.\n", test_idx, RPC_S_OK, status); ok(!memcmp(&if_id.Uuid, &guid, sizeof(guid)), "Test %u: Expected UUID %s, got %s.\n", test_idx, wine_dbgstr_guid(&guid), wine_dbgstr_guid(&if_id.Uuid)); - ok(if_id.VersMajor == 1, "Test %u: Expected major version %hu, got %hu.\n", test_idx, 1, + ok(if_id.VersMajor == 1, "Test %u: Expected major version 1, got %hu.\n", test_idx, if_id.VersMajor); - ok(if_id.VersMinor == 2, "Test %u: Expected minor version %hu, got %hu.\n", test_idx, 2, + ok(if_id.VersMinor == 2, "Test %u: Expected minor version 2, got %hu.\n", test_idx, if_id.VersMinor); } }

1 0

Alexandre Julliard : wine.inf: Create a default win.ini file.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: 31062ee534e1a9b6ed02dafb1967f7cbe7520420 URL: https://source.winehq.org/git/wine.git/?a=commit;h=31062ee534e1a9b6ed02dafb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 2 12:19:25 2020 +0100 wine.inf: Create a default win.ini file. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/wine.inf.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index d292b065a0e..0cbbcb710f6 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -2758,6 +2758,8 @@ system.ini, drivers32,,"; vidc.IV50=ir50_32.dll" system.ini, drivers32,,"; vidc.IV31=ir32_32.dll" system.ini, drivers32,,"; vidc.IV32=ir32_32.dll" +win.ini, mail,,"mapi=1" + [Timezones] ; The timezone information (TZI field) comes from the Olson timezone database ; http://www.twinsun.com/tz/tz-link.htm

1 0

Piotr Caban : msvcrt: Remove MSVCRT_ prefix from misc.c functions.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: 0364b7681fd6f628b06a9653119cd4f7d1c5cfdb URL: https://source.winehq.org/git/wine.git/?a=commit;h=0364b7681fd6f628b06a9653… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Dec 2 00:53:54 2020 +0100 msvcrt: Remove MSVCRT_ prefix from misc.c functions. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crtdll/crtdll.spec | 12 +++++------ dlls/msvcr100/msvcr100.spec | 30 +++++++++++++------------- dlls/msvcr110/msvcr110.spec | 36 +++++++++++++++---------------- dlls/msvcr120/msvcr120.spec | 42 ++++++++++++++++++------------------ dlls/msvcr70/msvcr70.spec | 14 ++++++------ dlls/msvcr71/msvcr71.spec | 14 ++++++------ dlls/msvcr80/msvcr80.spec | 34 ++++++++++++++--------------- dlls/msvcr90/msvcr90.spec | 34 ++++++++++++++--------------- dlls/msvcrt/misc.c | 52 ++++++++++++++++++++++----------------------- dlls/msvcrt/msvcrt.h | 1 - dlls/msvcrt/msvcrt.spec | 24 ++++++++++----------- dlls/msvcrt/printf.h | 2 +- dlls/msvcrtd/msvcrtd.spec | 12 +++++------ dlls/ucrtbase/ucrtbase.spec | 46 +++++++++++++++++++-------------------- include/msvcrt/stdio.h | 2 +- 15 files changed, 177 insertions(+), 178 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=0364b7681fd6f628b06a…

1 0

Piotr Caban : msvcrt: Remove MSVCRT_ prefix from environ.c functions.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: 9011b0b7c05c481ff043357be655f1fc7e66b924 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9011b0b7c05c481ff043357b… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Dec 2 00:53:33 2020 +0100 msvcrt: Remove MSVCRT_ prefix from environ.c functions. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crtdll/crtdll.spec | 2 +- dlls/msvcr100/msvcr100.spec | 4 ++-- dlls/msvcr110/msvcr110.spec | 4 ++-- dlls/msvcr120/msvcr120.spec | 4 ++-- dlls/msvcr70/msvcr70.spec | 4 ++-- dlls/msvcr71/msvcr71.spec | 4 ++-- dlls/msvcr80/msvcr80.spec | 4 ++-- dlls/msvcr90/msvcr90.spec | 4 ++-- dlls/msvcrt/dir.c | 4 ++-- dlls/msvcrt/environ.c | 16 ++++++++-------- dlls/msvcrt/file.c | 4 ++-- dlls/msvcrt/msvcrt.h | 2 -- dlls/msvcrt/msvcrt.spec | 8 ++++---- dlls/msvcrt/process.c | 2 +- dlls/msvcrt/time.c | 2 +- dlls/msvcrtd/msvcrtd.spec | 4 ++-- dlls/ucrtbase/ucrtbase.spec | 8 ++++---- 17 files changed, 39 insertions(+), 41 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=9011b0b7c05c481ff043…

1 0

Piotr Caban : msvcrt: Use heap structures and definitions from public header.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: 6d799bfa06a818b068bec6ce540477f89d4f63e1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6d799bfa06a818b068bec6ce… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Dec 2 00:53:24 2020 +0100 msvcrt: Use heap structures and definitions from public header. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/heap.c | 29 +++++++++++++++-------------- dlls/msvcrt/msvcrt.h | 18 ------------------ 2 files changed, 15 insertions(+), 32 deletions(-) diff --git a/dlls/msvcrt/heap.c b/dlls/msvcrt/heap.c index c541d8aa6fa..94b1f6a6b87 100644 --- a/dlls/msvcrt/heap.c +++ b/dlls/msvcrt/heap.c @@ -21,6 +21,7 @@ * handler and non atomic heap operations */ +#include <malloc.h> #include "msvcrt.h" #include "mtdll.h" #include "wine/debug.h" @@ -246,9 +247,9 @@ int CDECL _heapchk(void) (sb_heap && !HeapValidate(sb_heap, 0, NULL))) { msvcrt_set_errno(GetLastError()); - return MSVCRT__HEAPBADNODE; + return _HEAPBADNODE; } - return MSVCRT__HEAPOK; + return _HEAPOK; } /********************************************************************* @@ -269,7 +270,7 @@ int CDECL _heapmin(void) /********************************************************************* * _heapwalk (MSVCRT.@) */ -int CDECL _heapwalk(struct MSVCRT__heapinfo* next) +int CDECL _heapwalk(_HEAPINFO *next) { PROCESS_HEAP_ENTRY phe; @@ -279,14 +280,14 @@ int CDECL _heapwalk(struct MSVCRT__heapinfo* next) LOCK_HEAP; phe.lpData = next->_pentry; phe.cbData = next->_size; - phe.wFlags = next->_useflag == MSVCRT__USEDENTRY ? PROCESS_HEAP_ENTRY_BUSY : 0; + phe.wFlags = next->_useflag == _USEDENTRY ? PROCESS_HEAP_ENTRY_BUSY : 0; if (phe.lpData && phe.wFlags & PROCESS_HEAP_ENTRY_BUSY && !HeapValidate( heap, 0, phe.lpData )) { UNLOCK_HEAP; msvcrt_set_errno(GetLastError()); - return MSVCRT__HEAPBADNODE; + return _HEAPBADNODE; } do @@ -295,19 +296,19 @@ int CDECL _heapwalk(struct MSVCRT__heapinfo* next) { UNLOCK_HEAP; if (GetLastError() == ERROR_NO_MORE_ITEMS) - return MSVCRT__HEAPEND; + return _HEAPEND; msvcrt_set_errno(GetLastError()); if (!phe.lpData) - return MSVCRT__HEAPBADBEGIN; - return MSVCRT__HEAPBADNODE; + return _HEAPBADBEGIN; + return _HEAPBADNODE; } } while (phe.wFlags & (PROCESS_HEAP_REGION|PROCESS_HEAP_UNCOMMITTED_RANGE)); UNLOCK_HEAP; next->_pentry = phe.lpData; next->_size = phe.cbData; - next->_useflag = phe.wFlags & PROCESS_HEAP_ENTRY_BUSY ? MSVCRT__USEDENTRY : MSVCRT__FREEENTRY; - return MSVCRT__HEAPOK; + next->_useflag = phe.wFlags & PROCESS_HEAP_ENTRY_BUSY ? _USEDENTRY : _FREEENTRY; + return _HEAPOK; } /********************************************************************* @@ -316,17 +317,17 @@ int CDECL _heapwalk(struct MSVCRT__heapinfo* next) int CDECL _heapset(unsigned int value) { int retval; - struct MSVCRT__heapinfo heap; + _HEAPINFO heap; memset( &heap, 0, sizeof(heap) ); LOCK_HEAP; - while ((retval = _heapwalk(&heap)) == MSVCRT__HEAPOK) + while ((retval = _heapwalk(&heap)) == _HEAPOK) { - if (heap._useflag == MSVCRT__FREEENTRY) + if (heap._useflag == _FREEENTRY) memset(heap._pentry, value, heap._size); } UNLOCK_HEAP; - return retval == MSVCRT__HEAPEND? MSVCRT__HEAPOK : retval; + return retval == _HEAPEND ? _HEAPOK : retval; } /********************************************************************* diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 91d5b879a6f..8b20acbfd7e 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -247,8 +247,6 @@ extern void msvcrt_free_scheduler_thread(void) DECLSPEC_HIDDEN; extern unsigned msvcrt_create_io_inherit_block(WORD*, BYTE**) DECLSPEC_HIDDEN; -extern unsigned int __cdecl _control87(unsigned int, unsigned int); - /* run-time error codes */ #define _RT_STACK 0 #define _RT_NULLPTR 1 @@ -287,12 +285,6 @@ extern FILE MSVCRT__iob[]; typedef struct _complex _Dcomplex; -struct MSVCRT__heapinfo { - int* _pentry; - size_t _size; - int _useflag; -}; - #ifdef __i386__ struct MSVCRT___JUMP_BUFFER { unsigned long Ebp; @@ -560,16 +552,6 @@ struct MSVCRT__stat64 { #define MSVCRT__P_NOWAITO 3 #define MSVCRT__P_DETACH 4 -#define MSVCRT__HEAPEMPTY -1 -#define MSVCRT__HEAPOK -2 -#define MSVCRT__HEAPBADBEGIN -3 -#define MSVCRT__HEAPBADNODE -4 -#define MSVCRT__HEAPEND -5 -#define MSVCRT__HEAPBADPTR -6 - -#define MSVCRT__FREEENTRY 0 -#define MSVCRT__USEDENTRY 1 - #define MSVCRT__OUT_TO_DEFAULT 0 #define MSVCRT__OUT_TO_STDERR 1 #define MSVCRT__OUT_TO_MSGBOX 2

1 0

Michael Stefaniuc : windowscodecs: Use wide-char string literals.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: a2c6c3133089ae529e23c7f405d295d8b7a27d28 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a2c6c3133089ae529e23c7f4… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Dec 1 00:58:23 2020 +0100 windowscodecs: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windowscodecs/info.c | 172 ++++++++++++++++------------------------- dlls/windowscodecs/pngformat.c | 21 +++-- 2 files changed, 75 insertions(+), 118 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a2c6c3133089ae529e23…

1 0

Michael Stefaniuc : windowscodecs: Use wide-char string literals in regsvr.c.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: dcb65e3f6578614bf873da4a20ed18137ad5eae2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dcb65e3f6578614bf873da4a… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Dec 1 00:58:22 2020 +0100 windowscodecs: Use wide-char string literals in regsvr.c. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windowscodecs/regsvr.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/dlls/windowscodecs/regsvr.c b/dlls/windowscodecs/regsvr.c index 2fb03a2e1e9..5ab43353320 100644 --- a/dlls/windowscodecs/regsvr.c +++ b/dlls/windowscodecs/regsvr.c @@ -147,37 +147,36 @@ static HRESULT unregister_pixelformats(struct regsvr_pixelformat const *list); /*********************************************************************** * static string constants */ -static const WCHAR clsid_keyname[] = { - 'C', 'L', 'S', 'I', 'D', 0 }; +static const WCHAR clsid_keyname[] = L"CLSID"; static const char author_valuename[] = "Author"; static const char friendlyname_valuename[] = "FriendlyName"; -static const WCHAR vendor_valuename[] = {'V','e','n','d','o','r',0}; -static const WCHAR containerformat_valuename[] = {'C','o','n','t','a','i','n','e','r','F','o','r','m','a','t',0}; +static const WCHAR vendor_valuename[] = L"Vendor"; +static const WCHAR containerformat_valuename[] = L"ContainerFormat"; static const char version_valuename[] = "Version"; static const char mimetypes_valuename[] = "MimeTypes"; static const char extensions_valuename[] = "FileExtensions"; -static const WCHAR formats_keyname[] = {'F','o','r','m','a','t','s',0}; -static const WCHAR patterns_keyname[] = {'P','a','t','t','e','r','n','s',0}; -static const WCHAR instance_keyname[] = {'I','n','s','t','a','n','c','e',0}; -static const WCHAR clsid_valuename[] = {'C','L','S','I','D',0}; +static const WCHAR formats_keyname[] = L"Formats"; +static const WCHAR patterns_keyname[] = L"Patterns"; +static const WCHAR instance_keyname[] = L"Instance"; +static const WCHAR clsid_valuename[] = L"CLSID"; static const char length_valuename[] = "Length"; static const char position_valuename[] = "Position"; static const char pattern_valuename[] = "Pattern"; static const char mask_valuename[] = "Mask"; static const char endofstream_valuename[] = "EndOfStream"; -static const WCHAR pixelformats_keyname[] = {'P','i','x','e','l','F','o','r','m','a','t','s',0}; -static const WCHAR metadataformat_valuename[] = {'M','e','t','a','d','a','t','a','F','o','r','m','a','t',0}; +static const WCHAR pixelformats_keyname[] = L"PixelFormats"; +static const WCHAR metadataformat_valuename[] = L"MetadataFormat"; static const char specversion_valuename[] = "SpecVersion"; static const char requiresfullstream_valuename[] = "RequiresFullStream"; static const char supportspadding_valuename[] = "SupportsPadding"; static const char requiresfixedsize_valuename[] = "FixedSize"; -static const WCHAR containers_keyname[] = {'C','o','n','t','a','i','n','e','r','s',0}; +static const WCHAR containers_keyname[] = L"Containers"; static const char dataoffset_valuename[] = "DataOffset"; static const char bitsperpixel_valuename[] = "BitLength"; static const char channelcount_valuename[] = "ChannelCount"; static const char numericrepresentation_valuename[] = "NumericRepresentation"; static const char supportstransparency_valuename[] = "SupportsTransparency"; -static const WCHAR channelmasks_keyname[] = {'C','h','a','n','n','e','l','M','a','s','k','s',0}; +static const WCHAR channelmasks_keyname[] = L"ChannelMasks"; /*********************************************************************** * register_decoders @@ -305,8 +304,7 @@ static HRESULT register_decoders(struct regsvr_decoder const *list) for (i=0; list->patterns[i].length; i++) { HKEY pattern_key; - static const WCHAR int_format[] = {'%','i',0}; - swprintf(buf, 39, int_format, i); + swprintf(buf, 39, L"%i", i); res = RegCreateKeyExW(patterns_key, buf, 0, NULL, 0, KEY_READ | KEY_WRITE, NULL, &pattern_key, NULL); if (res != ERROR_SUCCESS) break; @@ -851,8 +849,7 @@ static HRESULT register_metadatareaders(struct regsvr_metadatareader const *list for (i=0; container->patterns[i].length; i++) { HKEY pattern_key; - static const WCHAR int_format[] = {'%','i',0}; - swprintf(buf, 39, int_format, i); + swprintf(buf, 39, L"%i", i); res = RegCreateKeyExW(format_key, buf, 0, NULL, 0, KEY_READ | KEY_WRITE, NULL, &pattern_key, NULL); if (res != ERROR_SUCCESS) break; @@ -1031,7 +1028,6 @@ static HRESULT register_pixelformats(struct regsvr_pixelformat const *list) if (res != ERROR_SUCCESS) goto error_close_clsid_key; if (list->channelmasks) { - static const WCHAR valuename_format[] = {'%','d',0}; HKEY masks_key; UINT i, mask_size; WCHAR mask_valuename[11]; @@ -1043,7 +1039,7 @@ static HRESULT register_pixelformats(struct regsvr_pixelformat const *list) if (res != ERROR_SUCCESS) goto error_close_clsid_key; for (i=0; i < list->channelcount; i++) { - swprintf(mask_valuename, ARRAY_SIZE(mask_valuename), valuename_format, i); + swprintf(mask_valuename, ARRAY_SIZE(mask_valuename), L"%d", i); res = RegSetValueExW(masks_key, mask_valuename, 0, REG_BINARY, list->channelmasks[i], mask_size); if (res != ERROR_SUCCESS) break;

1 0

Michael Stefaniuc : windowscodecs: Use wide-char string literals in metadataquery.c.
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: wine Branch: master Commit: e5e76fd311a1a439a7b83b0fd6ebdabce91fdf3b URL: https://source.winehq.org/git/wine.git/?a=commit;h=e5e76fd311a1a439a7b83b0f… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Dec 1 00:58:20 2020 +0100 windowscodecs: Use wide-char string literals in metadataquery.c. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windowscodecs/metadataquery.c | 241 +++++++++++-------------------------- 1 file changed, 71 insertions(+), 170 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e5e76fd311a1a439a7b8…

1 0

Zebediah Figura : vkd3d-shader: Validate "compile_info" in vkd3d_shader_preprocess().
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: vkd3d Branch: master Commit: 5065cb6c1f3298bf1cb4612de5b8643a34e00efa URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=5065cb6c1f3298bf1cb4612… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Dec 2 09:29:11 2020 -0600 vkd3d-shader: Validate "compile_info" in vkd3d_shader_preprocess(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/vkd3d_shader_main.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 6289a18..1a02924 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -252,7 +252,8 @@ static void vkd3d_shader_parser_destroy(struct vkd3d_shader_parser *parser) free_shader_desc(&parser->shader_desc); } -static int vkd3d_shader_validate_compile_info(const struct vkd3d_shader_compile_info *compile_info) +static int vkd3d_shader_validate_compile_info(const struct vkd3d_shader_compile_info *compile_info, + bool validate_target_type) { const enum vkd3d_shader_source_type *source_types; const enum vkd3d_shader_target_type *target_types; @@ -276,16 +277,19 @@ static int vkd3d_shader_validate_compile_info(const struct vkd3d_shader_compile_ return VKD3D_ERROR_INVALID_ARGUMENT; } - target_types = vkd3d_shader_get_supported_target_types(compile_info->source_type, &count); - for (i = 0; i < count; ++i) + if (validate_target_type) { - if (target_types[i] == compile_info->target_type) - break; - } - if (i == count) - { - WARN("Invalid shader target type %#x.\n", compile_info->target_type); - return VKD3D_ERROR_INVALID_ARGUMENT; + target_types = vkd3d_shader_get_supported_target_types(compile_info->source_type, &count); + for (i = 0; i < count; ++i) + { + if (target_types[i] == compile_info->target_type) + break; + } + if (i == count) + { + WARN("Invalid shader target type %#x.\n", compile_info->target_type); + return VKD3D_ERROR_INVALID_ARGUMENT; + } } return VKD3D_OK; @@ -832,7 +836,7 @@ int vkd3d_shader_scan(const struct vkd3d_shader_compile_info *compile_info, char if (messages) *messages = NULL; - if ((ret = vkd3d_shader_validate_compile_info(compile_info)) < 0) + if ((ret = vkd3d_shader_validate_compile_info(compile_info, true)) < 0) return ret; vkd3d_shader_message_context_init(&message_context, compile_info->log_level, compile_info->source_name); @@ -933,7 +937,7 @@ int vkd3d_shader_compile(const struct vkd3d_shader_compile_info *compile_info, if (messages) *messages = NULL; - if ((ret = vkd3d_shader_validate_compile_info(compile_info)) < 0) + if ((ret = vkd3d_shader_validate_compile_info(compile_info, true)) < 0) return ret; vkd3d_shader_message_context_init(&message_context, compile_info->log_level, compile_info->source_name); @@ -1150,10 +1154,15 @@ const enum vkd3d_shader_target_type *vkd3d_shader_get_supported_target_types( int vkd3d_shader_preprocess(const struct vkd3d_shader_compile_info *compile_info, struct vkd3d_shader_code *out, char **messages) { + int ret; + TRACE("compile_info %p, out %p, messages %p.\n", compile_info, out, messages); if (messages) *messages = NULL; + if ((ret = vkd3d_shader_validate_compile_info(compile_info, false)) < 0) + return ret; + return VKD3D_ERROR_NOT_IMPLEMENTED; }

1 0

Zebediah Figura : vkd3d-utils: Initialize input parameters to ID3DInclude::Open().
by Alexandre Julliard Dec. 2, 2020

Dec. 2, 2020

Module: vkd3d Branch: master Commit: d2f6ddba4972b8c03d2f9240876e426347901d69 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=d2f6ddba4972b8c03d2f924… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Tue Dec 1 20:51:10 2020 -0600 vkd3d-utils: Initialize input parameters to ID3DInclude::Open(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-utils/vkd3d_utils_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/vkd3d-utils/vkd3d_utils_main.c b/libs/vkd3d-utils/vkd3d_utils_main.c index 2bbedd8..9c968cc 100644 --- a/libs/vkd3d-utils/vkd3d_utils_main.c +++ b/libs/vkd3d-utils/vkd3d_utils_main.c @@ -129,11 +129,12 @@ static int open_include(const char *filename, bool local, const char *parent_dat struct vkd3d_shader_code *code) { ID3DInclude *iface = context; - unsigned int size; + unsigned int size = 0; if (!iface) return VKD3D_ERROR; + memset(code, 0, sizeof(*code)); if (FAILED(ID3DInclude_Open(iface, local ? D3D_INCLUDE_LOCAL : D3D_INCLUDE_SYSTEM, filename, parent_data, &code->code, &size))) return VKD3D_ERROR;

1 0