January 2022 - Wine-Commits

Henri Verbeet : wined3d: Use wined3d_bit_scan() in shader_generate_glsl_declarations().
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 1a7dbab1c45129ace79b21ca6165fa72c05fa8fa URL: https://source.winehq.org/git/wine.git/?a=commit;h=1a7dbab1c45129ace79b21ca… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jan 28 15:47:21 2022 +0100 wined3d: Use wined3d_bit_scan() in shader_generate_glsl_declarations(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/glsl_shader.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index aa3c8780269..5a2111e46a7 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -2168,7 +2168,7 @@ static void shader_generate_glsl_declarations(const struct wined3d_context_gl *c const struct wined3d_shader_lconst *lconst; const char *prefix; unsigned int i; - DWORD map; + uint32_t map; if (wined3d_settings.strict_shader_math) shader_addline(buffer, "#pragma optionNV(fastmath off)\n"); @@ -2176,9 +2176,11 @@ static void shader_generate_glsl_declarations(const struct wined3d_context_gl *c prefix = shader_glsl_get_prefix(version->type); /* Prototype the subroutines */ - for (i = 0, map = reg_maps->labels; map; map >>= 1, ++i) + map = reg_maps->labels; + while (map) { - if (map & 1) shader_addline(buffer, "void subroutine%u();\n", i); + i = wined3d_bit_scan(&map); + shader_addline(buffer, "void subroutine%u();\n", i); } if (version->type != WINED3D_SHADER_TYPE_PIXEL && version->type != WINED3D_SHADER_TYPE_COMPUTE) @@ -2500,9 +2502,11 @@ static void shader_generate_glsl_declarations(const struct wined3d_context_gl *c } /* Declare address variables */ - for (i = 0, map = reg_maps->address; map; map >>= 1, ++i) + map = reg_maps->address; + while (map) { - if (map & 1) shader_addline(buffer, "ivec4 A%u;\n", i); + i = wined3d_bit_scan(&map); + shader_addline(buffer, "ivec4 A%u;\n", i); } /* Declare output register temporaries */ @@ -2517,10 +2521,11 @@ static void shader_generate_glsl_declarations(const struct wined3d_context_gl *c } else if (version->major < 4) { - for (i = 0, map = reg_maps->temporary; map; map >>= 1, ++i) + map = reg_maps->temporary; + while (map) { - if (map & 1) - shader_addline(buffer, "vec4 R%u;\n", i); + i = wined3d_bit_scan(&map); + shader_addline(buffer, "vec4 R%u;\n", i); } }

1 0

Rémi Bernon : winexinput.sys: Fix warnings from long integer types.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: cd30bf64d6da2b9373c96f0903379233f92ed6a8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=cd30bf64d6da2b9373c96f09… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Jan 28 10:46:47 2022 +0100 winexinput.sys: Fix warnings from long integer types. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winexinput.sys/Makefile.in | 1 - dlls/winexinput.sys/main.c | 42 ++++++++++++++++++++--------------------- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git a/dlls/winexinput.sys/Makefile.in b/dlls/winexinput.sys/Makefile.in index ce98960de9b..e115235920a 100644 --- a/dlls/winexinput.sys/Makefile.in +++ b/dlls/winexinput.sys/Makefile.in @@ -1,4 +1,3 @@ -EXTRADEFS = -DWINE_NO_LONG_TYPES MODULE = winexinput.sys IMPORTS = ntoskrnl hidparse EXTRADLLFLAGS = -Wl,--subsystem,native diff --git a/dlls/winexinput.sys/main.c b/dlls/winexinput.sys/main.c index 339db17817c..e0ffb71440f 100644 --- a/dlls/winexinput.sys/main.c +++ b/dlls/winexinput.sys/main.c @@ -124,7 +124,7 @@ struct device { BOOL is_fdo; BOOL is_gamepad; - BOOL removed; + LONG removed; WCHAR device_id[MAX_DEVICE_ID_LEN]; }; @@ -204,28 +204,28 @@ static void translate_report_to_xinput_state(struct func_device *fdo) count = ARRAY_SIZE(usages); status = HidP_GetUsages(HidP_Input, HID_USAGE_PAGE_BUTTON, 0, usages, &count, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsages returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsages returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_HATSWITCH, &hat, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue hat returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue hat returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_X, &lx, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue x returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue x returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_Y, &ly, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue y returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue y returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_Z, &lt, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue z returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue z returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_RX, &rx, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue rx returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue rx returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_RY, &ry, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue ry returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue ry returned %#lx\n", status); status = HidP_GetUsageValue(HidP_Input, HID_USAGE_PAGE_GENERIC, 0, HID_USAGE_GENERIC_RZ, &rt, preparsed, fdo->report_buf, fdo->report_len); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue rz returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetUsageValue rz returned %#lx\n", status); if (hat < 1 || hat > 8) fdo->xinput_state.buttons = 0; else fdo->xinput_state.buttons = hat << 10; @@ -322,7 +322,7 @@ static NTSTATUS WINAPI gamepad_internal_ioctl(DEVICE_OBJECT *device, IRP *irp) ULONG code = stack->Parameters.DeviceIoControl.IoControlCode; struct func_device *fdo = fdo_from_DEVICE_OBJECT(device); - TRACE("device %p, irp %p, code %#x, bus_device %p.\n", device, irp, code, fdo->bus_device); + TRACE("device %p, irp %p, code %#lx, bus_device %p.\n", device, irp, code, fdo->bus_device); switch (code) { @@ -397,7 +397,7 @@ static NTSTATUS WINAPI internal_ioctl(DEVICE_OBJECT *device, IRP *irp) return STATUS_DELETE_PENDING; } - TRACE("device %p, irp %p, code %#x, bus_device %p.\n", device, irp, code, fdo->bus_device); + TRACE("device %p, irp %p, code %#lx, bus_device %p.\n", device, irp, code, fdo->bus_device); if (code == IOCTL_HID_READ_REPORT) return try_complete_pending_read(device, irp); if (impl->is_gamepad) return gamepad_internal_ioctl(device, irp); @@ -465,7 +465,7 @@ static NTSTATUS WINAPI pdo_pnp(DEVICE_OBJECT *device, IRP *irp) IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation(irp); struct func_device *fdo = fdo_from_DEVICE_OBJECT(device); struct device *impl = impl_from_DEVICE_OBJECT(device); - ULONG code = stack->MinorFunction; + UCHAR code = stack->MinorFunction; NTSTATUS status; IRP *pending; @@ -568,7 +568,7 @@ static NTSTATUS create_child_pdos(DEVICE_OBJECT *device) if ((status = IoCreateDevice(device->DriverObject, sizeof(struct phys_device), &name_str, 0, 0, FALSE, &gamepad_device))) { - ERR("failed to create gamepad device, status %#x.\n", status); + ERR("failed to create gamepad device, status %#lx.\n", status); return status; } @@ -579,7 +579,7 @@ static NTSTATUS create_child_pdos(DEVICE_OBJECT *device) if ((status = IoCreateDevice(device->DriverObject, sizeof(struct phys_device), &name_str, 0, 0, FALSE, &xinput_device))) { - ERR("failed to create xinput device, status %#x.\n", status); + ERR("failed to create xinput device, status %#lx.\n", status); IoDeleteDevice(gamepad_device); return status; } @@ -641,7 +641,7 @@ static void check_value_caps(struct func_device *fdo, USHORT usage, HIDP_VALUE_C static NTSTATUS initialize_device(DEVICE_OBJECT *device) { struct func_device *fdo = fdo_from_DEVICE_OBJECT(device); - ULONG i, u, button_count, report_desc_len, report_count; + UINT i, u, button_count, report_desc_len, report_count; PHIDP_REPORT_DESCRIPTOR report_desc; PHIDP_PREPARSED_DATA preparsed; HIDP_BUTTON_CAPS *button_caps; @@ -669,7 +669,7 @@ static NTSTATUS initialize_device(DEVICE_OBJECT *device) button_count = 0; if (!(button_caps = malloc(sizeof(*button_caps) * caps.NumberInputButtonCaps))) return STATUS_NO_MEMORY; status = HidP_GetButtonCaps(HidP_Input, button_caps, &caps.NumberInputButtonCaps, preparsed); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetButtonCaps returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetButtonCaps returned %#lx\n", status); else for (i = 0; i < caps.NumberInputButtonCaps; i++) { if (button_caps[i].UsagePage != HID_USAGE_PAGE_BUTTON) continue; @@ -682,7 +682,7 @@ static NTSTATUS initialize_device(DEVICE_OBJECT *device) if (!(value_caps = malloc(sizeof(*value_caps) * caps.NumberInputValueCaps))) return STATUS_NO_MEMORY; status = HidP_GetValueCaps(HidP_Input, value_caps, &caps.NumberInputValueCaps, preparsed); - if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetValueCaps returned %#x\n", status); + if (status != HIDP_STATUS_SUCCESS) WARN("HidP_GetValueCaps returned %#lx\n", status); else for (i = 0; i < caps.NumberInputValueCaps; i++) { HIDP_VALUE_CAPS *caps = value_caps + i; @@ -721,7 +721,7 @@ static NTSTATUS WINAPI fdo_pnp(DEVICE_OBJECT *device, IRP *irp) { IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation(irp); struct func_device *fdo = fdo_from_DEVICE_OBJECT(device); - ULONG code = stack->MinorFunction; + UCHAR code = stack->MinorFunction; DEVICE_RELATIONS *devices; DEVICE_OBJECT *child; NTSTATUS status; @@ -839,7 +839,7 @@ static NTSTATUS WINAPI add_device(DRIVER_OBJECT *driver, DEVICE_OBJECT *bus_devi if ((status = get_device_id(bus_device, BusQueryDeviceID, bus_id))) { - ERR("failed to get bus device id, status %#x.\n", status); + ERR("failed to get bus device id, status %#lx.\n", status); return status; } @@ -852,14 +852,14 @@ static NTSTATUS WINAPI add_device(DRIVER_OBJECT *driver, DEVICE_OBJECT *bus_devi if ((status = get_device_id(bus_device, BusQueryInstanceID, instance_id))) { - ERR("failed to get bus device instance id, status %#x.\n", status); + ERR("failed to get bus device instance id, status %#lx.\n", status); return status; } if ((status = IoCreateDevice(driver, sizeof(struct func_device), NULL, FILE_DEVICE_BUS_EXTENDER, 0, FALSE, &device))) { - ERR("failed to create bus FDO, status %#x.\n", status); + ERR("failed to create bus FDO, status %#lx.\n", status); return status; }

1 0

Daniel Lehman : msvcp140_atomic_wait: Implement __std_bulk_submit_threadpool_work.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: a7f71dbb7b6146a95b5fe551a9e27ba3347a529c URL: https://source.winehq.org/git/wine.git/?a=commit;h=a7f71dbb7b6146a95b5fe551… Author: Daniel Lehman <dlehman(a)esri.com> Date: Fri Jan 28 16:19:20 2022 +0100 msvcp140_atomic_wait: Implement __std_bulk_submit_threadpool_work. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140_atomic_wait/main.c | 7 +++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- .../tests/msvcp140_atomic_wait.c | 20 ++++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/dlls/msvcp140_atomic_wait/main.c b/dlls/msvcp140_atomic_wait/main.c index c00ed08bffe..f489a7d8e05 100644 --- a/dlls/msvcp140_atomic_wait/main.c +++ b/dlls/msvcp140_atomic_wait/main.c @@ -31,6 +31,13 @@ unsigned int __stdcall __std_parallel_algorithms_hw_threads(void) return _Thrd_hardware_concurrency(); } +void __stdcall __std_bulk_submit_threadpool_work(PTP_WORK work, size_t count) +{ + TRACE("(%p %Iu)\n", work, count); + while (count--) + SubmitThreadpoolWork(work); +} + void __stdcall __std_close_threadpool_work(PTP_WORK work) { TRACE("(%p)\n", work); diff --git a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec index 5b03b7ccfe8..bb4edfb76e5 100644 --- a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec +++ b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec @@ -11,7 +11,7 @@ @ stub __std_atomic_wait_get_deadline @ stub __std_atomic_wait_get_remaining_timeout @ stub __std_atomic_wait_indirect -@ stub __std_bulk_submit_threadpool_work +@ stdcall __std_bulk_submit_threadpool_work(ptr long) @ stub __std_calloc_crt @ stdcall __std_close_threadpool_work(ptr) @ stdcall __std_create_threadpool_work(ptr ptr ptr) diff --git a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c index f67270fe3b5..3a971bb4ce3 100644 --- a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c +++ b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c @@ -24,6 +24,7 @@ static unsigned int (__stdcall *p___std_parallel_algorithms_hw_threads)(void); +static void (__stdcall *p___std_bulk_submit_threadpool_work)(PTP_WORK, size_t); static void (__stdcall *p___std_close_threadpool_work)(PTP_WORK); static PTP_WORK (__stdcall *p___std_create_threadpool_work)(PTP_WORK_CALLBACK, void*, PTP_CALLBACK_ENVIRON); static void (__stdcall *p___std_submit_threadpool_work)(PTP_WORK); @@ -40,6 +41,7 @@ static HMODULE init(void) SET(p___std_parallel_algorithms_hw_threads, "__std_parallel_algorithms_hw_threads"); + SET(p___std_bulk_submit_threadpool_work, "__std_bulk_submit_threadpool_work"); SET(p___std_close_threadpool_work, "__std_close_threadpool_work"); SET(p___std_create_threadpool_work, "__std_create_threadpool_work"); SET(p___std_submit_threadpool_work, "__std_submit_threadpool_work"); @@ -86,6 +88,7 @@ static void test_threadpool_work(void) if (0) /* crash on windows */ { + p___std_bulk_submit_threadpool_work(NULL, 5); p___std_create_threadpool_work(NULL, NULL, NULL); p___std_submit_threadpool_work(NULL); p___std_wait_for_threadpool_work_callbacks(NULL, FALSE); @@ -103,6 +106,23 @@ static void test_threadpool_work(void) ok(cb_work == work, "expected %p, got %p\n", work, cb_work); ok(cb_context == &workcalled, "expected %p, got %p\n", &workcalled, cb_context); + /* bulk submit */ + workcalled = 0; + work = p___std_create_threadpool_work(threadpool_workcallback, &workcalled, NULL); + ok(!!work, "failed to create threadpool_work\n"); + p___std_bulk_submit_threadpool_work(work, 13); + p___std_wait_for_threadpool_work_callbacks(work, FALSE); + p___std_close_threadpool_work(work); + ok(workcalled == 13, "expected work to be called 13 times, got %d\n", workcalled); + + workcalled = 0; + work = p___std_create_threadpool_work(threadpool_workcallback, &workcalled, NULL); + ok(!!work, "failed to create threadpool_work\n"); + p___std_bulk_submit_threadpool_work(work, 0); + p___std_wait_for_threadpool_work_callbacks(work, FALSE); + p___std_close_threadpool_work(work); + ok(workcalled == 0, "expected no work, got %d\n", workcalled); + /* test with environment */ cb_event = CreateEventW(NULL, TRUE, FALSE, NULL); memset(&environment, 0, sizeof(environment));

1 0

Alexandre Julliard : Release 7.1.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 594e431e36d65e470bcbe930eb3d0f2bbca17736 URL: https://source.winehq.org/git/wine.git/?a=commit;h=594e431e36d65e470bcbe930… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 28 21:27:46 2022 +0100 Release 7.1. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 963 +++++++++++++++++++++++++++++++++++--------------------------- AUTHORS | 3 + VERSION | 2 +- configure | 18 +- 4 files changed, 559 insertions(+), 427 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=594e431e36d65e470bcb…

1 0

Henri Verbeet : wined3d: Use wined3d_bit_scan() in shader_glsl_load_constantsB().
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: bbb7d41eae2762afae97aeb52459eb0b579779c5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bbb7d41eae2762afae97aeb5… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jan 28 15:47:20 2022 +0100 wined3d: Use wined3d_bit_scan() in shader_glsl_load_constantsB(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/glsl_shader.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 1ebd067ae56..aa3c8780269 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1239,16 +1239,15 @@ static void shader_glsl_load_constants_i(const struct wined3d_shader *shader, co } /* Context activation is done by the caller. */ -static void shader_glsl_load_constantsB(const struct wined3d_shader *shader, const struct wined3d_gl_info *gl_info, - const GLint locations[WINED3D_MAX_CONSTS_B], const BOOL *constants, WORD constants_set) +static void shader_glsl_load_constants_b(const struct wined3d_shader *shader, const struct wined3d_gl_info *gl_info, + const BOOL *constants, const GLint locations[WINED3D_MAX_CONSTS_B], uint32_t constants_set) { unsigned int i; struct list* ptr; - for (i = 0; constants_set; constants_set >>= 1, ++i) + while (constants_set) { - if (!(constants_set & 1)) continue; - + i = wined3d_bit_scan(&constants_set); GL_EXTCALL(glUniform1iv(locations[i], 1, &constants[i])); } @@ -1546,8 +1545,8 @@ static void shader_glsl_load_constants(void *shader_priv, struct wined3d_context prog->vs.uniform_i_locations, vshader->reg_maps.integer_constants); if (update_mask & WINED3D_SHADER_CONST_VS_B) - shader_glsl_load_constantsB(vshader, gl_info, prog->vs.uniform_b_locations, state->vs_consts_b, - vshader->reg_maps.boolean_constants); + shader_glsl_load_constants_b(vshader, gl_info, state->vs_consts_b, + prog->vs.uniform_b_locations, vshader->reg_maps.boolean_constants); if (update_mask & WINED3D_SHADER_CONST_VS_CLIP_PLANES) { @@ -1699,8 +1698,8 @@ static void shader_glsl_load_constants(void *shader_priv, struct wined3d_context prog->ps.uniform_i_locations, pshader->reg_maps.integer_constants); if (update_mask & WINED3D_SHADER_CONST_PS_B) - shader_glsl_load_constantsB(pshader, gl_info, prog->ps.uniform_b_locations, state->ps_consts_b, - pshader->reg_maps.boolean_constants); + shader_glsl_load_constants_b(pshader, gl_info, state->ps_consts_b, + prog->ps.uniform_b_locations, pshader->reg_maps.boolean_constants); if (update_mask & WINED3D_SHADER_CONST_PS_BUMP_ENV) {

1 0

Rémi Bernon : windows.gaming.input: Fix printf format warnings with long types.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: ad060ae862635948c30ead218fa7a0b2853349eb URL: https://source.winehq.org/git/wine.git/?a=commit;h=ad060ae862635948c30ead21… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Jan 28 10:46:46 2022 +0100 windows.gaming.input: Fix printf format warnings with long types. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windows.gaming.input/Makefile.in | 1 - dlls/windows.gaming.input/main.c | 28 +++++++++++++++------------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/dlls/windows.gaming.input/Makefile.in b/dlls/windows.gaming.input/Makefile.in index db009015e88..fab3c4e62d5 100644 --- a/dlls/windows.gaming.input/Makefile.in +++ b/dlls/windows.gaming.input/Makefile.in @@ -1,4 +1,3 @@ -EXTRADEFS = -DWINE_NO_LONG_TYPES MODULE = windows.gaming.input.dll IMPORTS = combase uuid diff --git a/dlls/windows.gaming.input/main.c b/dlls/windows.gaming.input/main.c index e8048ec440c..5278ec261bd 100644 --- a/dlls/windows.gaming.input/main.c +++ b/dlls/windows.gaming.input/main.c @@ -60,7 +60,7 @@ static inline struct gamepad_vector *impl_from_IVectorView_Gamepad(IVectorView_G static HRESULT STDMETHODCALLTYPE vector_view_gamepad_QueryInterface( IVectorView_Gamepad *iface, REFIID iid, void **out) { - TRACE("iface %p, iid %s, out %p stub!\n", iface, debugstr_guid(iid), out); + TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IInspectable) || @@ -82,7 +82,7 @@ static ULONG STDMETHODCALLTYPE vector_view_gamepad_AddRef( { struct gamepad_vector *impl = impl_from_IVectorView_Gamepad(iface); ULONG ref = InterlockedIncrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p increasing refcount to %lu.\n", iface, ref); return ref; } @@ -91,7 +91,7 @@ static ULONG STDMETHODCALLTYPE vector_view_gamepad_Release( { struct gamepad_vector *impl = impl_from_IVectorView_Gamepad(iface); ULONG ref = InterlockedDecrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p decreasing refcount to %lu.\n", iface, ref); return ref; } @@ -119,7 +119,7 @@ static HRESULT STDMETHODCALLTYPE vector_view_gamepad_GetTrustLevel( static HRESULT STDMETHODCALLTYPE vector_view_gamepad_GetAt( IVectorView_Gamepad *iface, UINT32 index, IGamepad **value) { - FIXME("iface %p, index %#x, value %p stub!\n", iface, index, value); + FIXME("iface %p, index %u, value %p stub!\n", iface, index, value); *value = NULL; return E_BOUNDS; } @@ -145,7 +145,8 @@ static HRESULT STDMETHODCALLTYPE vector_view_gamepad_GetMany( IVectorView_Gamepad *iface, UINT32 start_index, UINT32 items_size, IGamepad **items, UINT *value) { - FIXME("iface %p, start_index %#x, items %p, value %p stub!\n", iface, start_index, items, value); + FIXME("iface %p, start_index %u, items_size %u, items %p, value %p stub!\n", iface, start_index, + items_size, items, value); *value = 0; return E_BOUNDS; } @@ -186,7 +187,7 @@ static inline struct raw_game_controller_vector *impl_from_IVectorView_RawGameCo static HRESULT STDMETHODCALLTYPE vector_view_raw_game_controller_QueryInterface( IVectorView_RawGameController *iface, REFIID iid, void **out) { - TRACE("iface %p, iid %s, out %p stub!\n", iface, debugstr_guid(iid), out); + TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IInspectable) || @@ -208,7 +209,7 @@ static ULONG STDMETHODCALLTYPE vector_view_raw_game_controller_AddRef( { struct raw_game_controller_vector *impl = impl_from_IVectorView_RawGameController(iface); ULONG ref = InterlockedIncrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p increasing refcount to %lu.\n", iface, ref); return ref; } @@ -217,7 +218,7 @@ static ULONG STDMETHODCALLTYPE vector_view_raw_game_controller_Release( { struct raw_game_controller_vector *impl = impl_from_IVectorView_RawGameController(iface); ULONG ref = InterlockedDecrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p decreasing refcount to %lu.\n", iface, ref); return ref; } @@ -245,7 +246,7 @@ static HRESULT STDMETHODCALLTYPE vector_view_raw_game_controller_GetTrustLevel( static HRESULT STDMETHODCALLTYPE vector_view_raw_game_controller_GetAt( IVectorView_RawGameController *iface, UINT32 index, IRawGameController **value) { - FIXME("iface %p, index %#x, value %p stub!\n", iface, index, value); + FIXME("iface %p, index %u, value %p stub!\n", iface, index, value); *value = NULL; return E_BOUNDS; } @@ -271,7 +272,8 @@ static HRESULT STDMETHODCALLTYPE vector_view_raw_game_controller_GetMany( IVectorView_RawGameController *iface, UINT32 start_index, UINT32 items_size, IRawGameController **items, UINT *value) { - FIXME("iface %p, start_index %#x, items %p, value %p stub!\n", iface, start_index, items, value); + FIXME("iface %p, start_index %u, items_size %u, items %p, value %p stub!\n", iface, start_index, + items_size, items, value); *value = 0; return E_BOUNDS; } @@ -326,7 +328,7 @@ static HRESULT STDMETHODCALLTYPE windows_gaming_input_QueryInterface( { struct windows_gaming_input *impl = impl_from_IActivationFactory(iface); - TRACE("iface %p, iid %s, out %p stub!\n", iface, debugstr_guid(iid), out); + TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IInspectable) || @@ -362,7 +364,7 @@ static ULONG STDMETHODCALLTYPE windows_gaming_input_AddRef( { struct windows_gaming_input *impl = impl_from_IActivationFactory(iface); ULONG ref = InterlockedIncrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p increasing refcount to %lu.\n", iface, ref); return ref; } @@ -371,7 +373,7 @@ static ULONG STDMETHODCALLTYPE windows_gaming_input_Release( { struct windows_gaming_input *impl = impl_from_IActivationFactory(iface); ULONG ref = InterlockedDecrement(&impl->ref); - TRACE("iface %p, ref %u.\n", iface, ref); + TRACE("iface %p decreasing refcount to %lu.\n", iface, ref); return ref; }

1 0

Daniel Lehman : msvcp140_atomic_wait: Implement __std_close_threadpool_work.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 69debac78681812b7dff36b9056ef6cd375e387b URL: https://source.winehq.org/git/wine.git/?a=commit;h=69debac78681812b7dff36b9… Author: Daniel Lehman <dlehman(a)esri.com> Date: Fri Jan 28 16:19:11 2022 +0100 msvcp140_atomic_wait: Implement __std_close_threadpool_work. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140_atomic_wait/main.c | 6 ++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c | 9 ++++++--- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/dlls/msvcp140_atomic_wait/main.c b/dlls/msvcp140_atomic_wait/main.c index 28e86b93d7d..c00ed08bffe 100644 --- a/dlls/msvcp140_atomic_wait/main.c +++ b/dlls/msvcp140_atomic_wait/main.c @@ -31,6 +31,12 @@ unsigned int __stdcall __std_parallel_algorithms_hw_threads(void) return _Thrd_hardware_concurrency(); } +void __stdcall __std_close_threadpool_work(PTP_WORK work) +{ + TRACE("(%p)\n", work); + return CloseThreadpoolWork(work); +} + PTP_WORK __stdcall __std_create_threadpool_work(PTP_WORK_CALLBACK callback, void *context, PTP_CALLBACK_ENVIRON environ) { diff --git a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec index cc8bc0e404e..5b03b7ccfe8 100644 --- a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec +++ b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec @@ -13,7 +13,7 @@ @ stub __std_atomic_wait_indirect @ stub __std_bulk_submit_threadpool_work @ stub __std_calloc_crt -@ stub __std_close_threadpool_work +@ stdcall __std_close_threadpool_work(ptr) @ stdcall __std_create_threadpool_work(ptr ptr ptr) @ stub __std_execution_wait_on_uchar @ stub __std_execution_wake_by_address_all diff --git a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c index a7ba1dc76ea..f67270fe3b5 100644 --- a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c +++ b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c @@ -24,6 +24,7 @@ static unsigned int (__stdcall *p___std_parallel_algorithms_hw_threads)(void); +static void (__stdcall *p___std_close_threadpool_work)(PTP_WORK); static PTP_WORK (__stdcall *p___std_create_threadpool_work)(PTP_WORK_CALLBACK, void*, PTP_CALLBACK_ENVIRON); static void (__stdcall *p___std_submit_threadpool_work)(PTP_WORK); static void (__stdcall *p___std_wait_for_threadpool_work_callbacks)(PTP_WORK, BOOL); @@ -39,6 +40,7 @@ static HMODULE init(void) SET(p___std_parallel_algorithms_hw_threads, "__std_parallel_algorithms_hw_threads"); + SET(p___std_close_threadpool_work, "__std_close_threadpool_work"); SET(p___std_create_threadpool_work, "__std_create_threadpool_work"); SET(p___std_submit_threadpool_work, "__std_submit_threadpool_work"); SET(p___std_wait_for_threadpool_work_callbacks, "__std_wait_for_threadpool_work_callbacks"); @@ -87,6 +89,7 @@ static void test_threadpool_work(void) p___std_create_threadpool_work(NULL, NULL, NULL); p___std_submit_threadpool_work(NULL); p___std_wait_for_threadpool_work_callbacks(NULL, FALSE); + p___std_close_threadpool_work(NULL); } /* simple test */ @@ -95,7 +98,7 @@ static void test_threadpool_work(void) ok(!!work, "failed to create threadpool_work\n"); p___std_submit_threadpool_work(work); p___std_wait_for_threadpool_work_callbacks(work, FALSE); - CloseThreadpoolWork(work); + p___std_close_threadpool_work(work); ok(workcalled == 1, "expected work to be called once, got %d\n", workcalled); ok(cb_work == work, "expected %p, got %p\n", work, cb_work); ok(cb_context == &workcalled, "expected %p, got %p\n", &workcalled, cb_context); @@ -110,7 +113,7 @@ static void test_threadpool_work(void) ok(!!work, "failed to create threadpool_work\n"); p___std_submit_threadpool_work(work); p___std_wait_for_threadpool_work_callbacks(work, FALSE); - CloseThreadpoolWork(work); + p___std_close_threadpool_work(work); ret = WaitForSingleObject(cb_event, 1000); ok(ret == WAIT_OBJECT_0, "expected finalization callback to be called\n"); ok(workcalled == 2, "expected work to be called twice, got %d\n", workcalled); @@ -126,7 +129,7 @@ static void test_threadpool_work(void) gle = GetLastError(); ok(gle == 0xdeadbeef, "expected 0xdeadbeef, got %x\n", gle); ok(!!work, "failed to create threadpool_work\n"); - CloseThreadpoolWork(work); + p___std_close_threadpool_work(work); memset(&environment3, 0, sizeof(environment3)); environment3.Version = 3;

1 0

Daniel Lehman : msvcp140_atomic_wait: Implement __std_submit_threadpool_work.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 68ad71a072d355bf8b4caec996e84a4fbd277059 URL: https://source.winehq.org/git/wine.git/?a=commit;h=68ad71a072d355bf8b4caec9… Author: Daniel Lehman <dlehman(a)esri.com> Date: Fri Jan 28 16:18:58 2022 +0100 msvcp140_atomic_wait: Implement __std_submit_threadpool_work. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140_atomic_wait/main.c | 6 ++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/msvcp140_atomic_wait/main.c b/dlls/msvcp140_atomic_wait/main.c index bdc46412771..1f5440b248a 100644 --- a/dlls/msvcp140_atomic_wait/main.c +++ b/dlls/msvcp140_atomic_wait/main.c @@ -37,3 +37,9 @@ PTP_WORK __stdcall __std_create_threadpool_work(PTP_WORK_CALLBACK callback, void TRACE("(%p %p %p)\n", callback, context, environ); return CreateThreadpoolWork(callback, context, environ); } + +void __stdcall __std_submit_threadpool_work(PTP_WORK work) +{ + TRACE("(%p)\n", work); + return SubmitThreadpoolWork(work); +} diff --git a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec index 3b4fd48dc7f..d5c9b45a119 100644 --- a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec +++ b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec @@ -20,7 +20,7 @@ @ stub __std_free_crt @ stdcall __std_parallel_algorithms_hw_threads() @ stub __std_release_shared_mutex_for_instance -@ stub __std_submit_threadpool_work +@ stdcall __std_submit_threadpool_work(ptr) @ stub __std_tzdb_delete_current_zone @ stub __std_tzdb_delete_leap_seconds @ stub __std_tzdb_delete_sys_info diff --git a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c index 097a81e5029..0e707e9be44 100644 --- a/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c +++ b/dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c @@ -25,6 +25,7 @@ static unsigned int (__stdcall *p___std_parallel_algorithms_hw_threads)(void); static PTP_WORK (__stdcall *p___std_create_threadpool_work)(PTP_WORK_CALLBACK, void*, PTP_CALLBACK_ENVIRON); +static void (__stdcall *p___std_submit_threadpool_work)(PTP_WORK); #define SETNOFAIL(x,y) x = (void*)GetProcAddress(msvcp,y) #define SET(x,y) do { SETNOFAIL(x,y); ok(x != NULL, "Export '%s' not found\n", y); } while(0) @@ -38,6 +39,7 @@ static HMODULE init(void) SET(p___std_parallel_algorithms_hw_threads, "__std_parallel_algorithms_hw_threads"); SET(p___std_create_threadpool_work, "__std_create_threadpool_work"); + SET(p___std_submit_threadpool_work, "__std_submit_threadpool_work"); return msvcp; } @@ -81,13 +83,14 @@ static void test_threadpool_work(void) if (0) /* crash on windows */ { p___std_create_threadpool_work(NULL, NULL, NULL); + p___std_submit_threadpool_work(NULL); } /* simple test */ workcalled = 0; work = p___std_create_threadpool_work(threadpool_workcallback, &workcalled, NULL); ok(!!work, "failed to create threadpool_work\n"); - SubmitThreadpoolWork(work); + p___std_submit_threadpool_work(work); WaitForThreadpoolWorkCallbacks(work, FALSE); CloseThreadpoolWork(work); ok(workcalled == 1, "expected work to be called once, got %d\n", workcalled); @@ -102,7 +105,7 @@ static void test_threadpool_work(void) workcalled = 0; work = p___std_create_threadpool_work(threadpool_workcallback, &workcalled, &environment); ok(!!work, "failed to create threadpool_work\n"); - SubmitThreadpoolWork(work); + p___std_submit_threadpool_work(work); WaitForThreadpoolWorkCallbacks(work, FALSE); CloseThreadpoolWork(work); ret = WaitForSingleObject(cb_event, 1000);

1 0

Zebediah Figura : wined3d: Introduce WINED3D_LOCATION_CLEARED and use it for the initial state of buffers.
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 1af6cb07b2d9a42200dcf776169df06b74a11fcf URL: https://source.winehq.org/git/wine.git/?a=commit;h=1af6cb07b2d9a42200dcf776… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Jan 27 20:22:51 2022 -0600 wined3d: Introduce WINED3D_LOCATION_CLEARED and use it for the initial state of buffers. The practical effect of this is to defer clearing buffers until they are used. Under normal circumstances the buffer will be initially discarded, in which case we need not clear it at all, and may even avoid ever allocating sysmem. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/buffer.c | 31 +++++++++++++++++++++++-------- dlls/wined3d/utils.c | 1 + dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 25 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c index abbef0fac41..2f3b5fd316e 100644 --- a/dlls/wined3d/buffer.c +++ b/dlls/wined3d/buffer.c @@ -607,13 +607,28 @@ BOOL wined3d_buffer_load_location(struct wined3d_buffer *buffer, switch (location) { case WINED3D_LOCATION_SYSMEM: - range.offset = 0; - range.size = buffer->resource.size; - buffer->buffer_ops->buffer_download_ranges(buffer, context, - buffer->resource.heap_memory, 0, 1, &range); + if (buffer->locations & WINED3D_LOCATION_CLEARED) + { + memset(buffer->resource.heap_memory, 0, buffer->resource.size); + } + else + { + range.offset = 0; + range.size = buffer->resource.size; + buffer->buffer_ops->buffer_download_ranges(buffer, context, + buffer->resource.heap_memory, 0, 1, &range); + } break; case WINED3D_LOCATION_BUFFER: + if (buffer->locations & WINED3D_LOCATION_CLEARED) + { + /* FIXME: Clear the buffer on the GPU if possible. */ + if (!wined3d_buffer_prepare_location(buffer, context, WINED3D_LOCATION_SYSMEM)) + return FALSE; + memset(buffer->resource.heap_memory, 0, buffer->resource.size); + } + if (!buffer->conversion_map) buffer->buffer_ops->buffer_upload_ranges(buffer, context, buffer->resource.heap_memory, 0, buffer->modified_areas, buffer->maps); @@ -650,7 +665,7 @@ DWORD wined3d_buffer_get_memory(struct wined3d_buffer *buffer, struct wined3d_co TRACE("buffer %p, context %p, data %p, locations %s.\n", buffer, context, data, wined3d_debug_location(locations)); - if (locations & WINED3D_LOCATION_DISCARDED) + if (locations & (WINED3D_LOCATION_DISCARDED | WINED3D_LOCATION_CLEARED)) { locations = ((buffer->flags & WINED3D_BUFFER_USE_BO) ? WINED3D_LOCATION_BUFFER : WINED3D_LOCATION_SYSMEM); if (!wined3d_buffer_load_location(buffer, context, locations)) @@ -949,7 +964,7 @@ static HRESULT buffer_resource_sub_resource_map(struct wined3d_resource *resourc } if (flags & WINED3D_MAP_WRITE) - wined3d_buffer_invalidate_range(buffer, WINED3D_LOCATION_BUFFER, dirty_offset, dirty_size); + wined3d_buffer_invalidate_range(buffer, ~WINED3D_LOCATION_SYSMEM, dirty_offset, dirty_size); } else { @@ -971,7 +986,7 @@ static HRESULT buffer_resource_sub_resource_map(struct wined3d_resource *resourc if (flags & WINED3D_MAP_WRITE) { - wined3d_buffer_invalidate_location(buffer, WINED3D_LOCATION_SYSMEM); + wined3d_buffer_invalidate_location(buffer, ~WINED3D_LOCATION_BUFFER); buffer_invalidate_bo_range(buffer, dirty_offset, dirty_size); } @@ -1241,7 +1256,7 @@ static HRESULT wined3d_buffer_init(struct wined3d_buffer *buffer, struct wined3d } buffer->buffer_ops = buffer_ops; buffer->structure_byte_stride = desc->structure_byte_stride; - buffer->locations = data ? WINED3D_LOCATION_DISCARDED : WINED3D_LOCATION_SYSMEM; + buffer->locations = WINED3D_LOCATION_CLEARED; TRACE("buffer %p, size %#x, usage %#x, memory @ %p.\n", buffer, buffer->resource.size, buffer->resource.usage, buffer->resource.heap_memory); diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index e50d42ead92..bf9ae11ea13 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -6864,6 +6864,7 @@ const char *wined3d_debug_location(DWORD location) #define LOCATION_TO_STR(x) if (location & x) { debug_append(&buffer, #x, " | "); location &= ~x; } LOCATION_TO_STR(WINED3D_LOCATION_DISCARDED); LOCATION_TO_STR(WINED3D_LOCATION_SYSMEM); + LOCATION_TO_STR(WINED3D_LOCATION_CLEARED); LOCATION_TO_STR(WINED3D_LOCATION_BUFFER); LOCATION_TO_STR(WINED3D_LOCATION_TEXTURE_RGB); LOCATION_TO_STR(WINED3D_LOCATION_TEXTURE_SRGB); diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index e28fc3b880d..1b3a13024f9 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -4316,6 +4316,7 @@ void wined3d_resource_update_draw_binding(struct wined3d_resource *resource) DEC #define WINED3D_LOCATION_DISCARDED 0x00000001 #define WINED3D_LOCATION_SYSMEM 0x00000002 +#define WINED3D_LOCATION_CLEARED 0x00000004 #define WINED3D_LOCATION_BUFFER 0x00000008 #define WINED3D_LOCATION_TEXTURE_RGB 0x00000010 #define WINED3D_LOCATION_TEXTURE_SRGB 0x00000020

1 0

Henri Verbeet : wined3d: Use wined3d_bit_scan() in shader_arb_load_np2fixup_constants().
by Alexandre Julliard Jan. 28, 2022

Jan. 28, 2022

Module: wine Branch: master Commit: 837e60507652fca9cbce482d2a5f050650256646 URL: https://source.winehq.org/git/wine.git/?a=commit;h=837e60507652fca9cbce482d… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Jan 28 15:47:23 2022 +0100 wined3d: Use wined3d_bit_scan() in shader_arb_load_np2fixup_constants(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 820ba0199e8..54a90a690ac 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -497,27 +497,26 @@ static void shader_arb_load_np2fixup_constants(const struct arb_ps_np2fixup_info const struct wined3d_gl_info *gl_info, const struct wined3d_state *state) { GLfloat np2fixup_constants[4 * WINED3D_MAX_FRAGMENT_SAMPLERS]; - WORD active = fixup->super.active; - UINT i; + uint32_t active = fixup->super.active; + const struct wined3d_texture *tex; + unsigned char idx; + GLfloat *tex_dim; + unsigned int i; if (!active) return; - for (i = 0; active; active >>= 1, ++i) + while (active) { - const struct wined3d_texture *tex = state->textures[i]; - unsigned char idx = fixup->super.idx[i]; - GLfloat *tex_dim = &np2fixup_constants[(idx >> 1) * 4]; - - if (!(active & 1)) - continue; - - if (!tex) + i = wined3d_bit_scan(&active); + if (!(tex = state->textures[i])) { ERR("Nonexistent texture is flagged for NP2 texcoord fixup.\n"); continue; } + idx = fixup->super.idx[i]; + tex_dim = &np2fixup_constants[(idx >> 1) * 4]; if (idx % 2) { tex_dim[2] = tex->pow2_matrix[0];

1 0