March 2022 - Wine-Commits - list.winehq.org

Francois Gouget : testbot/cgi: PageBase::*Cookies() do not take a $Page parameter.
by Alexandre Julliard March 28, 2022

March 28, 2022

Module: tools Branch: master Commit: 34440654366951f7ed43863e25c55ab43ce73bde URL: https://source.winehq.org/git/tools.git/?a=commit;h=34440654366951f7ed43863… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 28 17:29:04 2022 +0200 testbot/cgi: PageBase::*Cookies() do not take a $Page parameter. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/Page.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm index 85e94b3..014324f 100644 --- a/testbot/lib/ObjectModel/CGI/Page.pm +++ b/testbot/lib/ObjectModel/CGI/Page.pm @@ -220,14 +220,14 @@ sub UnsetCookies($) { my ($self) = @_; - $self->{PageBase}->UnsetCookies($self); + $self->{PageBase}->UnsetCookies(); } sub SetCookies($) { my ($self) = @_; - $self->{PageBase}->SetCookies($self); + $self->{PageBase}->SetCookies(); } sub GetCurrentSession($)

1 0

Francois Gouget : testbot/cgi: Standardize access to the FormPage property descriptors.
by Alexandre Julliard March 28, 2022

March 28, 2022

Module: tools Branch: master Commit: 6d5e0b25b33feda5a0658a442b5c4752e2c9ec38 URL: https://source.winehq.org/git/tools.git/?a=commit;h=6d5e0b25b33feda5a0658a4… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 28 17:30:35 2022 +0200 testbot/cgi: Standardize access to the FormPage property descriptors. Note that this requires the list of property descriptors to always be set. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 9e34a73..2565c07 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -117,8 +117,7 @@ sub GetPropertyDescriptorByName($$) { my ($self, $Name) = @_; - my $PropertyDescriptors = $self->GetPropertyDescriptors(); - foreach my $PropertyDescriptor (@{$PropertyDescriptors}) + foreach my $PropertyDescriptor (@{$self->GetPropertyDescriptors()}) { if ($PropertyDescriptor->GetName() eq $Name) {

1 0

Francois Gouget : testbot/web: Use the property descriptors in the Activity page.
by Alexandre Julliard March 28, 2022

March 28, 2022

Module: tools Branch: master Commit: ba10f7463580848d383f7e6b5e3b629939b8cc1d URL: https://source.winehq.org/git/tools.git/?a=commit;h=ba10f7463580848d383f7e6… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 28 17:30:31 2022 +0200 testbot/web: Use the property descriptors in the Activity page. The whole point is to pass them to _initialize() so FormPage::Validate() can then do its job. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/Activity.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl index 272215f..d98f50a 100644 --- a/testbot/web/Activity.pl +++ b/testbot/web/Activity.pl @@ -45,7 +45,7 @@ sub _initialize($$$) my @PropertyDescriptors = ( CreateBasicPropertyDescriptor("Hours", "Hours", !1, 1, "N", 3), ); - $self->SUPER::_initialize($Request, $RequiredRole); + $self->SUPER::_initialize($Request, $RequiredRole, \@PropertyDescriptors); $self->{Method} = "get"; if (!$self->GetParam("Hours") or !$self->Validate() or

1 0

Francois Gouget : testbot/cgi: Add support for nameless actions.
by Alexandre Julliard March 28, 2022

March 28, 2022

Module: tools Branch: master Commit: 8c93967546fbf11e39551d85706dea4237e3af83 URL: https://source.winehq.org/git/tools.git/?a=commit;h=8c93967546fbf11e39551d8… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 28 17:32:34 2022 +0200 testbot/cgi: Add support for nameless actions. Action names starting with a dot will not be sent to the form page. This can be useful to get a clean 'get' URL. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 2565c07..83b078b 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -555,6 +555,11 @@ Returns a list of actions that can be applied after completing or reading this form. Each action is a string which is used as the label of a button at the bottom of the form. +If an action name starts with a dot, the button label omits the dot and the +corresponding <input> field gets no name attribute. Note that this means the +action name is not sent to the form so it probably does not make sense to have +more than one such action per form. + By default there is no action. =back @@ -573,7 +578,9 @@ sub GenerateActions($) print "<div class='ItemActions'>\n"; foreach my $Action (@{$self->GetActions()}) { - print "<input type='submit' name='Action' value='$Action'/>\n"; + print "<input type='submit' "; + print "name='Action' " if ($Action !~ s/^\.//); + print "value='$Action'/>\n"; } print "</div>\n"; }

1 0

Francois Gouget : testbot/web: Use the Get method for the Stats page.
by Alexandre Julliard March 28, 2022

March 28, 2022

Module: tools Branch: master Commit: 63e67bb794bbaf761a83223a0292dbf9097a0e40 URL: https://source.winehq.org/git/tools.git/?a=commit;h=63e67bb794bbaf761a83223… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 28 17:32:37 2022 +0200 testbot/web: Use the Get method for the Stats page. This makes it easier to bookmark the page for custom values. Also make the action nameless for a cleaner URL. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/Stats.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testbot/web/Stats.pl b/testbot/web/Stats.pl index 8433c6d..39c2878 100644 --- a/testbot/web/Stats.pl +++ b/testbot/web/Stats.pl @@ -44,6 +44,7 @@ sub _initialize($$$) CreateBasicPropertyDescriptor("Days", "Days to analyze", !1, 1, "N", 2), ); $self->SUPER::_initialize($Request, $RequiredRole, \@PropertyDescriptors); + $self->{Method} = "get"; if (!$self->GetParam("Days") or !$self->Validate() or !int($self->GetParam("Days"))) # 00 case! @@ -368,7 +369,7 @@ sub GenerateBody($) sub GetActions($) { #my ($self) = @_; - return ["Update"]; + return [".Update"]; } sub GenerateFooter($)

1 0

Alexandre Julliard : Wine release 7.5
by Alexandre Julliard March 25, 2022

March 25, 2022

Module: website Branch: master Commit: 7fbaa42a7bc53cddef8effdd8fd5ab6be72231d6 URL: https://source.winehq.org/git/website.git/?a=commit;h=7fbaa42a7bc53cddef8ef… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 25 21:28:40 2022 +0100 Wine release 7.5 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2022032501.xml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/news/en/2022032501.xml b/news/en/2022032501.xml new file mode 100644 index 00000000..94b368ad --- /dev/null +++ b/news/en/2022032501.xml @@ -0,0 +1,18 @@ +<news> +<date>March 25, 2022</date> +<title>Wine 7.5 Released</title> +<body> +<p> The Wine development release 7.5 is now available.</p> +<p> <a href="{$root}/announce/7.5">What's new</a> in this release: +<ul> + <li>ALSA driver converted to PE.</li> + <li>Locale database generated from Unicode CLDR.</li> + <li>HLSL compiler support with the bundled vkd3d.</li> + <li>Initial support for the OCSP protocol.</li> + <li>More cleanups to support 'long' type.</li> + <li>Various bug fixes.</li> +</ul> +</p> +<p>The source is <a href="//dl.winehq.org/wine/source/7.x/wine-7.5.tar.xz">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</p></body></news>

1 0

Tag wine-7.5 : Alexandre Julliard : Release 7.5
by Alexandre Julliard March 25, 2022

March 25, 2022

Module: wine Branch: refs/tags/wine-7.5 Tag: d816c0e87852bce6739ac51b29fa72e65ea9fae5 URL: https://source.winehq.org/git/wine.git/?a=tag;h=d816c0e87852bce6739ac51b29f… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 25 21:26:21 2022 +0100 Release 7.5

1 0

Alexandre Julliard : Release 7.5.
by Alexandre Julliard March 25, 2022

March 25, 2022

Module: wine Branch: master Commit: 4bbb43d6c7ee824ff533628020c6309c4ff86c28 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4bbb43d6c7ee824ff5336280… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 25 21:26:21 2022 +0100 Release 7.5. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 1044 +++++++++++++++++++++++++++---------------------------------- AUTHORS | 1 + VERSION | 2 +- configure | 18 +- 4 files changed, 467 insertions(+), 598 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=4bbb43d6c7ee824ff533…

1 0

Jinoh Kang : server: Allow async completion callback to retrieve status on synchronous failure.
by Alexandre Julliard March 25, 2022

March 25, 2022

Module: wine Branch: master Commit: e81c2a6af4c2b4103f2e06fd280fee2bf56de1ee URL: https://source.winehq.org/git/wine.git/?a=commit;h=e81c2a6af4c2b4103f2e06fd… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Thu Mar 24 02:25:08 2022 +0900 server: Allow async completion callback to retrieve status on synchronous failure. This also makes async_handoff() behaviour more consistent with async_set_result() for handling I/O failures. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/async.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/async.c b/server/async.c index a4c9090fa73..a4fbeab555e 100644 --- a/server/async.c +++ b/server/async.c @@ -370,6 +370,7 @@ obj_handle_t async_handoff( struct async *async, data_size_t *result, int force_ if (!async->pending && NT_ERROR( get_error() )) { + async->iosb->status = get_error(); async_call_completion_callback( async ); close_handle( async->thread->process, async->wait_handle );

1 0

Jinoh Kang : server: Generalise async completion callback to be called on synchronous failure.
by Alexandre Julliard March 25, 2022

March 25, 2022

Module: wine Branch: master Commit: 5d98ffe982b3b0ad72dfc938bfbe5bee7e210dcb URL: https://source.winehq.org/git/wine.git/?a=commit;h=5d98ffe982b3b0ad72dfc938… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Thu Mar 24 02:25:04 2022 +0900 server: Generalise async completion callback to be called on synchronous failure. Today, async_set_completion_callback() is used to register a function that is called when the async I/O is completed. It is assumed that the async will eventually be queued when such callback is registered. However, this incurs extra complexity in future code that needs the completion logic to be invoked even if the async is never actually queued (e.g. when the I/O failed synchronously before async_handoff). Generalise async completion callback by calling it in async_handoff() when the I/O status indicates failure. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/async.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/server/async.c b/server/async.c index a92798fcd39..a4c9090fa73 100644 --- a/server/async.c +++ b/server/async.c @@ -322,6 +322,13 @@ void async_wake_obj( struct async *async ) } } +static void async_call_completion_callback( struct async *async ) +{ + if (async->completion_callback) + async->completion_callback( async->completion_callback_private ); + async->completion_callback = NULL; +} + /* return async object status and wait handle to client */ obj_handle_t async_handoff( struct async *async, data_size_t *result, int force_blocking ) { @@ -363,6 +370,8 @@ obj_handle_t async_handoff( struct async *async, data_size_t *result, int force_ if (!async->pending && NT_ERROR( get_error() )) { + async_call_completion_callback( async ); + close_handle( async->thread->process, async->wait_handle ); async->wait_handle = 0; return 0; @@ -528,9 +537,7 @@ void async_set_result( struct object *obj, unsigned int status, apc_param_t tota wake_up( &async->obj, 0 ); } - if (async->completion_callback) - async->completion_callback( async->completion_callback_private ); - async->completion_callback = NULL; + async_call_completion_callback( async ); if (async->queue) {

1 0