July 2023 - Wine-Commits - list.winehq.org

Jinoh Kang : winegcc: Enable SafeSEH only on i386.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 9de7c79153418a1936b18a96b7cc4ad91aa67e3a URL: https://gitlab.winehq.org/wine/wine/-/commit/9de7c79153418a1936b18a96b7cc4a… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Sat Jul 15 03:28:59 2023 +0000 winegcc: Enable SafeSEH only on i386. SafeSEH is not applicable to architectures other than i386. This fixes compiling with the clang ARM assembler, which cannot parse ".def @feat.00" since "@" is parsed as the start of a line comment. --- tools/winegcc/winegcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 9d73252411b..34f8a1e4e87 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -989,7 +989,8 @@ static const char *build_spec_obj( struct options *opts, const char *spec_file, if (opts->large_address_aware) strarray_add( &spec_args, "--large-address-aware" ); } - if (opts->target.platform == PLATFORM_WINDOWS) strarray_add(&spec_args, "--safeseh"); + if (opts->target.platform == PLATFORM_WINDOWS && opts->target.cpu == CPU_i386) + strarray_add(&spec_args, "--safeseh"); if (entry_point) {

1 0

Victor Chiletto : user32: Add hotpatch prologue to RegisterRawInputDevices.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: fb296929f98e93e5ba08ff4585c09886076da5a9 URL: https://gitlab.winehq.org/wine/wine/-/commit/fb296929f98e93e5ba08ff4585c098… Author: Victor Chiletto <vchiletto(a)codeweavers.com> Date: Fri Jul 14 18:02:31 2023 -0300 user32: Add hotpatch prologue to RegisterRawInputDevices. re4_tweaks relies on this function being hotpatchable [1]. [1]: https://github.com/nipkownix/re4_tweaks/blob/7cfcf5c4272f7d68d177661ffe84e9… --- dlls/user32/user32.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index b715d712c31..96e6e1a7d6b 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -612,7 +612,7 @@ @ stub RegisterNetworkCapabilities @ stdcall RegisterPointerDeviceNotifications(long long) @ stdcall RegisterPowerSettingNotification(long ptr long) -@ stdcall RegisterRawInputDevices(ptr long long) NtUserRegisterRawInputDevices +@ stdcall -import RegisterRawInputDevices(ptr long long) NtUserRegisterRawInputDevices @ stdcall RegisterServicesProcess(long) @ stdcall RegisterShellHookWindow (long) @ stdcall RegisterSuspendResumeNotification(long long)

1 0

Alexandre Julliard : pdh: Use nameless unions/structs.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 1fba1185e49fe7cb893f7fad3ca1b2cdb0494a95 URL: https://gitlab.winehq.org/wine/wine/-/commit/1fba1185e49fe7cb893f7fad3ca1b2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jul 17 11:32:27 2023 +0200 pdh: Use nameless unions/structs. --- dlls/pdh/pdh_main.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/dlls/pdh/pdh_main.c b/dlls/pdh/pdh_main.c index 121b7e712ce..073a74e1b52 100644 --- a/dlls/pdh/pdh_main.c +++ b/dlls/pdh/pdh_main.c @@ -23,8 +23,6 @@ #include <stdlib.h> #include <math.h> -#define NONAMELESSUNION - #include "windef.h" #include "winbase.h" @@ -302,18 +300,18 @@ static PDH_STATUS format_value( struct counter *counter, DWORD format, union val factor = counter->scale ? counter->scale : counter->defaultscale; if (format & PDH_FMT_LONG) { - if (format & PDH_FMT_1000) value->u.longValue = raw2->longvalue * 1000; - else value->u.longValue = raw2->longvalue * pow( 10, factor ); + if (format & PDH_FMT_1000) value->longValue = raw2->longvalue * 1000; + else value->longValue = raw2->longvalue * pow( 10, factor ); } else if (format & PDH_FMT_LARGE) { - if (format & PDH_FMT_1000) value->u.largeValue = raw2->largevalue * 1000; - else value->u.largeValue = raw2->largevalue * pow( 10, factor ); + if (format & PDH_FMT_1000) value->largeValue = raw2->largevalue * 1000; + else value->largeValue = raw2->largevalue * pow( 10, factor ); } else if (format & PDH_FMT_DOUBLE) { - if (format & PDH_FMT_1000) value->u.doubleValue = raw2->doublevalue * 1000; - else value->u.doubleValue = raw2->doublevalue * pow( 10, factor ); + if (format & PDH_FMT_1000) value->doubleValue = raw2->doublevalue * 1000; + else value->doubleValue = raw2->doublevalue * pow( 10, factor ); } else { @@ -1076,7 +1074,7 @@ double WINAPI PdhVbGetDoubleCounterValue( PDH_HCOUNTER handle, PDH_STATUS *count status = PdhGetFormattedCounterValue( handle, PDH_FMT_DOUBLE, NULL, &value ); if (counter_status) *counter_status = status; - return value.u.doubleValue; + return value.doubleValue; } /***********************************************************************

1 0

Jinoh Kang : ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 057467bff9599d2e559e35ae8f26039bcb42888c URL: https://gitlab.winehq.org/wine/wine/-/commit/057467bff9599d2e559e35ae8f2603… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Tue Nov 9 00:41:17 2021 +0900 ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher. Today, NtContinue() on ARM64 does not restore X16 and X17 from the context. This is because the values for X16 and X17 are overwritten when the current thread returns to the "user mode" (PE side) via __wine_syscall_dispatcher, which in turn uses them as scratch registers for restoring SP and PC respectively. We cannot avoid using scratch registers when restoring SP and PC. This is because ARMv8 does not have an unprivileged (EL0) instruction that loads SP and PC from memory or non-GPR architectural state. Fix this by making ARM64 __wine_syscall_dispatcher perform a full context restore via raise(SIGUSR2) when NtContinue() is used. Since raising a signal is quite expensive, it should be done only when necessary. To achieve this, split the ARM64 syscall dispatcher's returning behaviour into a fast path (that does not involve signals) and a slow path (that involves signals): - If CONTEXT_INTEGER is not set, the dispatcher takes the fast path: the X16 and X17 registers are clobbered as usual. - If X16 == PC and X17 == SP, the dispatcher also takes the fast path: it can safely use X16 and X17 without corrupting the register values, since those two registers already have the desired values. This fast path is used in call_user_apc_dispatcher(), call_user_exception_dispatcher(), and call_init_thunk(). - Otherwise, the dispatcher takes the slow path: it raises SIGUSR2 and does full context restore in the signal handler. Fixes: 88e336214db94318b6657d641919fcce6be4a328 --- dlls/ntdll/unix/signal_arm64.c | 62 ++++++++++++++++++++++++++++++++---------- 1 file changed, 47 insertions(+), 15 deletions(-) diff --git a/dlls/ntdll/unix/signal_arm64.c b/dlls/ntdll/unix/signal_arm64.c index 7f998f894d4..d98268bcd54 100644 --- a/dlls/ntdll/unix/signal_arm64.c +++ b/dlls/ntdll/unix/signal_arm64.c @@ -477,6 +477,21 @@ NTSTATUS unwind_builtin_dll( void *args ) } +/*********************************************************************** + * syscall_frame_fixup_for_fastpath + * + * Fixes up the given syscall frame such that the syscall dispatcher + * can return via the fast path if CONTEXT_INTEGER is set in + * restore_flags. + * + * Clobbers the frame's X16 and X17 register values. + */ +static void syscall_frame_fixup_for_fastpath( struct syscall_frame *frame ) +{ + frame->x[16] = frame->pc; + frame->x[17] = frame->sp; +} + /*********************************************************************** * save_fpu * @@ -1054,6 +1069,7 @@ NTSTATUS call_user_apc_dispatcher( CONTEXT *context, ULONG_PTR arg1, ULONG_PTR a frame->x[3] = arg3; frame->x[4] = (ULONG64)func; frame->restore_flags |= CONTEXT_CONTROL | CONTEXT_INTEGER; + syscall_frame_fixup_for_fastpath( frame ); return status; } @@ -1086,6 +1102,7 @@ NTSTATUS call_user_exception_dispatcher( EXCEPTION_RECORD *rec, CONTEXT *context frame->lr = lr; frame->sp = sp; frame->restore_flags |= CONTEXT_INTEGER | CONTEXT_CONTROL; + syscall_frame_fixup_for_fastpath( frame ); return status; } @@ -1578,6 +1595,14 @@ void signal_init_process(void) } +/*********************************************************************** + * syscall_dispatcher_return_slowpath + */ +void DECLSPEC_HIDDEN syscall_dispatcher_return_slowpath(void) +{ + raise( SIGUSR2 ); +} + /*********************************************************************** * call_init_thunk */ @@ -1638,6 +1663,7 @@ void DECLSPEC_HIDDEN call_init_thunk( LPTHREAD_START_ROUTINE entry, void *arg, B frame->x[18] = (ULONG64)teb; frame->prev_frame = NULL; frame->restore_flags |= CONTEXT_INTEGER; + syscall_frame_fixup_for_fastpath( frame ); frame->syscall_table = KeServiceDescriptorTable; pthread_sigmask( SIG_UNBLOCK, &server_block_set, NULL ); @@ -1734,13 +1760,28 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "blr x16\n\t" "mov sp, x22\n" __ASM_LOCAL_LABEL("__wine_syscall_dispatcher_return") ":\n\t" - "ldp x18, x19, [sp, #0x90]\n\t" + "ldr w16, [sp, #0x10c]\n\t" /* frame->restore_flags */ + "tbz x16, #1, 2f\n\t" /* CONTEXT_INTEGER */ + "ldp x12, x13, [sp, #0x80]\n\t" /* frame->x[16..17] */ + "ldp x14, x15, [sp, #0xf8]\n\t" /* frame->sp, frame->pc */ + "cmp x12, x15\n\t" /* frame->x16 == frame->pc? */ + "ccmp x13, x14, #0, eq\n\t" /* frame->x17 == frame->sp? */ + "beq 1f\n\t" /* take slowpath if unequal */ + "bl " __ASM_NAME("syscall_dispatcher_return_slowpath") "\n" + "1:\tldp x0, x1, [sp, #0x00]\n\t" + "ldp x2, x3, [sp, #0x10]\n\t" + "ldp x4, x5, [sp, #0x20]\n\t" + "ldp x6, x7, [sp, #0x30]\n\t" + "ldp x8, x9, [sp, #0x40]\n\t" + "ldp x10, x11, [sp, #0x50]\n\t" + "ldp x12, x13, [sp, #0x60]\n\t" + "ldp x14, x15, [sp, #0x70]\n" + "2:\tldp x18, x19, [sp, #0x90]\n\t" "ldp x20, x21, [sp, #0xa0]\n\t" "ldp x22, x23, [sp, #0xb0]\n\t" "ldp x24, x25, [sp, #0xc0]\n\t" "ldp x26, x27, [sp, #0xd0]\n\t" "ldp x28, x29, [sp, #0xe0]\n\t" - "ldr w16, [sp, #0x10c]\n\t" /* frame->restore_flags */ "tbz x16, #2, 1f\n\t" /* CONTEXT_FLOATING_POINT */ "ldp q0, q1, [sp, #0x130]\n\t" "ldp q2, q3, [sp, #0x150]\n\t" @@ -1758,19 +1799,10 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "ldp q26, q27, [sp, #0x2d0]\n\t" "ldp q28, q29, [sp, #0x2f0]\n\t" "ldp q30, q31, [sp, #0x310]\n\t" - "ldr w9, [sp, #0x128]\n\t" - "msr FPCR, x9\n\t" - "ldr w9, [sp, #0x12c]\n\t" - "msr FPSR, x9\n" - "1:\ttbz x16, #1, 1f\n\t" /* CONTEXT_INTEGER */ - "ldp x0, x1, [sp, #0x00]\n\t" - "ldp x2, x3, [sp, #0x10]\n\t" - "ldp x4, x5, [sp, #0x20]\n\t" - "ldp x6, x7, [sp, #0x30]\n\t" - "ldp x8, x9, [sp, #0x40]\n\t" - "ldp x10, x11, [sp, #0x50]\n\t" - "ldp x12, x13, [sp, #0x60]\n\t" - "ldp x14, x15, [sp, #0x70]\n" + "ldr w17, [sp, #0x128]\n\t" + "msr FPCR, x17\n\t" + "ldr w17, [sp, #0x12c]\n\t" + "msr FPSR, x17\n" "1:\tldp x16, x17, [sp, #0x100]\n\t" "msr NZCV, x17\n\t" "ldp x30, x17, [sp, #0xf0]\n\t"

1 0

Alistair Leslie-Hughes : gdiplus: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 92f52d1eb47b9e1313891312350959d2cac32ec6 URL: https://gitlab.winehq.org/wine/wine/-/commit/92f52d1eb47b9e1313891312350959… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Jul 12 17:41:33 2023 +1000 gdiplus: Remove DECLSPEC_HIDDEN usage. --- dlls/gdiplus/gdiplus_private.h | 138 ++++++++++++++++++++--------------------- 1 file changed, 69 insertions(+), 69 deletions(-)

1 0

Nikolay Sivov : d3dcompiler/tests: Add another test for matrix majority flags.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 24557a257a74aa18b52331b45bd9d9ce856cd906 URL: https://gitlab.winehq.org/wine/wine/-/commit/24557a257a74aa18b52331b45bd9d9… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Jul 12 18:21:34 2023 +0200 d3dcompiler/tests: Add another test for matrix majority flags. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/d3dcompiler_43/tests/hlsl_d3d9.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c index 9fe79b1ac44..1ba283f4d99 100644 --- a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c +++ b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c @@ -907,6 +907,7 @@ static void test_majority(void) { ps_column_source, { 0.1f, 0.5f, 0.1f, 0.5f } }, { ps_no_modifiers_source, { 0.1f, 0.2f, 0.1f, 0.2f }, D3DCOMPILE_PACK_MATRIX_ROW_MAJOR }, { ps_no_modifiers_source, { 0.1f, 0.5f, 0.1f, 0.5f }, D3DCOMPILE_PACK_MATRIX_COLUMN_MAJOR }, + { ps_no_modifiers_source, { 0.1f, 0.2f, 0.1f, 0.2f }, D3DCOMPILE_PACK_MATRIX_COLUMN_MAJOR | D3DCOMPILE_PACK_MATRIX_ROW_MAJOR }, { ps_pragmas_source, { 0.1f, 0.2f, 0.1f, 0.5f }, D3DCOMPILE_PACK_MATRIX_ROW_MAJOR }, { ps_pragmas_source, { 0.1f, 0.2f, 0.1f, 0.5f }, D3DCOMPILE_PACK_MATRIX_COLUMN_MAJOR }, }; @@ -955,7 +956,7 @@ static void test_majority(void) draw_quad(test_context.device, ps_code); v = get_color_vec4(test_context.device, 0, 0); - todo_wine_if(i == 4) + todo_wine_if(i == 4 || i == 6) ok(compare_vec4(&v, c->x, c->y, c->z, c->w, 1), "Got unexpected value {%.8e, %.8e, %.8e, %.8e}.\n", v.x, v.y, v.z, v.w);

1 0

Alistair Leslie-Hughes : twain_32: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 19c50160955f95348fa8bff18210d7787a42c915 URL: https://gitlab.winehq.org/wine/wine/-/commit/19c50160955f95348fa8bff18210d7… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Jul 12 17:41:33 2023 +1000 twain_32: Remove DECLSPEC_HIDDEN usage. --- dlls/twain_32/twain_i.h | 39 ++++++++++++++------------------------- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/dlls/twain_32/twain_i.h b/dlls/twain_32/twain_i.h index ad513458cdc..7ff608d2e95 100644 --- a/dlls/twain_32/twain_i.h +++ b/dlls/twain_32/twain_i.h @@ -45,34 +45,23 @@ typedef struct tagActiveDS HWND event_window; } activeDS; -extern TW_UINT16 DSM_twCC DECLSPEC_HIDDEN; /* current condition code of Source Manager */ +extern TW_UINT16 DSM_twCC; /* current condition code of Source Manager */ -extern activeDS *activeSources DECLSPEC_HIDDEN; /* list of active data sources */ +extern activeDS *activeSources; /* list of active data sources */ -extern HINSTANCE DSM_hinstance DECLSPEC_HIDDEN; +extern HINSTANCE DSM_hinstance; /* Implementation of operation triplets (From Application to Source Manager) */ -extern TW_UINT16 TWAIN_CloseDS - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_IdentityGetDefault - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_IdentityGetFirst - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_IdentityGetNext - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_OpenDS - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_UserSelect - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_CloseDSM - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_OpenDSM - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_GetDSMStatus - (pTW_IDENTITY pOrigin, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_ControlNull - (pTW_IDENTITY pOrigin, pTW_IDENTITY pDest, activeDS *pSource, TW_UINT16 MSG, TW_MEMREF pData) DECLSPEC_HIDDEN; -extern TW_UINT16 TWAIN_ProcessEvent - (pTW_IDENTITY pOrigin, activeDS *pSource, TW_MEMREF pData) DECLSPEC_HIDDEN; +extern TW_UINT16 TWAIN_CloseDS(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_IdentityGetDefault(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_IdentityGetFirst(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_IdentityGetNext(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_OpenDS(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_UserSelect(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_CloseDSM(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_OpenDSM(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_GetDSMStatus(pTW_IDENTITY pOrigin, TW_MEMREF pData); +extern TW_UINT16 TWAIN_ControlNull(pTW_IDENTITY pOrigin, pTW_IDENTITY pDest, activeDS *pSource, TW_UINT16 MSG, TW_MEMREF pData); +extern TW_UINT16 TWAIN_ProcessEvent(pTW_IDENTITY pOrigin, activeDS *pSource, TW_MEMREF pData); #endif

1 0

Bernhard Kölbl : mfmediaengine: Add support for inserting audio effects.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 91a84cff9570d97be3ba3ce915b0cb91541cb480 URL: https://gitlab.winehq.org/wine/wine/-/commit/91a84cff9570d97be3ba3ce915b0cb… Author: Bernhard Kölbl <besentv(a)gmail.com> Date: Sun Dec 4 00:03:50 2022 +0100 mfmediaengine: Add support for inserting audio effects. --- dlls/mfmediaengine/main.c | 18 +++++++++++++++--- dlls/mfmediaengine/tests/mfmediaengine.c | 14 ++++++-------- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/dlls/mfmediaengine/main.c b/dlls/mfmediaengine/main.c index e3da2fa0752..925d9c3566e 100644 --- a/dlls/mfmediaengine/main.c +++ b/dlls/mfmediaengine/main.c @@ -159,6 +159,7 @@ struct media_engine IMFPresentationDescriptor *pd; } presentation; struct effects video_effects; + struct effects audio_effects; struct { LONGLONG pts; @@ -1274,7 +1275,10 @@ static HRESULT media_engine_create_topology(struct media_engine *engine, IMFMedi { IMFTopology_AddNode(topology, audio_src); IMFTopology_AddNode(topology, sar_node); - IMFTopologyNode_ConnectOutput(audio_src, 0, sar_node, 0); + + if (FAILED(hr = media_engine_create_effects(engine->audio_effects.effects, engine->audio_effects.count, + audio_src, sar_node, topology))) + WARN("Failed to create audio effect nodes, hr %#lx.\n", hr); } if (sar_node) @@ -1453,6 +1457,7 @@ static void free_media_engine(struct media_engine *engine) IMFAttributes_Release(engine->attributes); if (engine->resolver) IMFSourceResolver_Release(engine->resolver); + media_engine_clear_effects(&engine->audio_effects); media_engine_clear_effects(&engine->video_effects); media_engine_release_video_frame_resources(engine); media_engine_clear_presentation(engine); @@ -2700,9 +2705,16 @@ static HRESULT WINAPI media_engine_InsertVideoEffect(IMFMediaEngineEx *iface, IU static HRESULT WINAPI media_engine_InsertAudioEffect(IMFMediaEngineEx *iface, IUnknown *effect, BOOL is_optional) { - FIXME("%p, %p, %d stub.\n", iface, effect, is_optional); + struct media_engine *engine = impl_from_IMFMediaEngineEx(iface); + HRESULT hr = S_OK; - return E_NOTIMPL; + TRACE("%p, %p, %d.\n", iface, effect, is_optional); + + EnterCriticalSection(&engine->cs); + hr = media_engine_insert_effect(engine, &engine->audio_effects, effect, is_optional); + LeaveCriticalSection(&engine->cs); + + return hr; } static HRESULT WINAPI media_engine_RemoveAllEffects(IMFMediaEngineEx *iface) diff --git a/dlls/mfmediaengine/tests/mfmediaengine.c b/dlls/mfmediaengine/tests/mfmediaengine.c index 8b4d06a3bd5..aa9de414fcb 100644 --- a/dlls/mfmediaengine/tests/mfmediaengine.c +++ b/dlls/mfmediaengine/tests/mfmediaengine.c @@ -1844,12 +1844,12 @@ static void test_effect(void) ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaEngineEx_InsertAudioEffect(media_engine_ex, (IUnknown *)&audio_effect->IMFTransform_iface, FALSE); - todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); - todo_wine EXPECT_REF(&audio_effect->IMFTransform_iface, 2); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + EXPECT_REF(&audio_effect->IMFTransform_iface, 2); hr = IMFMediaEngineEx_InsertAudioEffect(media_engine_ex, (IUnknown *)&audio_effect2->IMFTransform_iface, FALSE); - todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); - todo_wine EXPECT_REF(&audio_effect2->IMFTransform_iface, 2); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + EXPECT_REF(&audio_effect2->IMFTransform_iface, 2); url = SysAllocString(L"i420-64x64.avi"); hr = IMFMediaEngineEx_SetSourceFromByteStream(media_engine_ex, stream, url); @@ -1875,9 +1875,7 @@ static void test_effect(void) if (SUCCEEDED(hr = MFCreateAudioRenderer(NULL, &sink))) { - todo_wine ok(audio_effect->processing_count > 0, "Unexpected processing count %lu.\n", audio_effect->processing_count); - todo_wine ok(audio_effect2->processing_count > 0, "Unexpected processing count %lu.\n", audio_effect2->processing_count); IMFMediaSink_Release(sink); @@ -1905,12 +1903,12 @@ done: if (audio_effect2) { ref = IMFTransform_Release(&audio_effect2->IMFTransform_iface); - ok(!ref, "Unexpected ref %lu.\n", ref); + todo_wine ok(!ref, "Unexpected ref %lu.\n", ref); } if (audio_effect) { ref = IMFTransform_Release(&audio_effect->IMFTransform_iface); - ok(!ref, "Unexpected ref %lu.\n", ref); + todo_wine ok(!ref, "Unexpected ref %lu.\n", ref); } if (video_effect2)

1 0

Bernhard Kölbl : mfmediaengine/tests: Add tests for audio effects.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: wine Branch: master Commit: 096b46cf8dc46b3a75639846ec9370225db02a26 URL: https://gitlab.winehq.org/wine/wine/-/commit/096b46cf8dc46b3a75639846ec9370… Author: Bernhard Kölbl <bkoelbl(a)codeweavers.com> Date: Tue Jul 4 18:54:37 2023 +0200 mfmediaengine/tests: Add tests for audio effects. --- dlls/mfmediaengine/tests/Makefile.in | 2 +- dlls/mfmediaengine/tests/i420-64x64.avi | Bin 25472 -> 58982 bytes dlls/mfmediaengine/tests/mfmediaengine.c | 51 ++++++++++++++++++++++++++++--- dlls/mfmediaengine/tests/resource.rc | 5 +-- 4 files changed, 50 insertions(+), 8 deletions(-) diff --git a/dlls/mfmediaengine/tests/Makefile.in b/dlls/mfmediaengine/tests/Makefile.in index b23d530d46f..437229a905d 100644 --- a/dlls/mfmediaengine/tests/Makefile.in +++ b/dlls/mfmediaengine/tests/Makefile.in @@ -1,5 +1,5 @@ TESTDLL = mfmediaengine.dll -IMPORTS = ole32 mfplat oleaut32 mfuuid uuid +IMPORTS = ole32 mf mfplat oleaut32 mfuuid uuid C_SRCS = \ mfmediaengine.c diff --git a/dlls/mfmediaengine/tests/i420-64x64.avi b/dlls/mfmediaengine/tests/i420-64x64.avi index 8c560691974..74a8dac82f2 100644 Binary files a/dlls/mfmediaengine/tests/i420-64x64.avi and b/dlls/mfmediaengine/tests/i420-64x64.avi differ diff --git a/dlls/mfmediaengine/tests/mfmediaengine.c b/dlls/mfmediaengine/tests/mfmediaengine.c index 8aa9492d32b..8b4d06a3bd5 100644 --- a/dlls/mfmediaengine/tests/mfmediaengine.c +++ b/dlls/mfmediaengine/tests/mfmediaengine.c @@ -1307,7 +1307,7 @@ static void test_TransferVideoFrame(void) res = 0; hr = IMFMediaEngineEx_GetNumberOfStreams(media_engine, &res); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); - ok(res == 1, "Unexpected stream count %lu.\n", res); + ok(res == 2, "Unexpected stream count %lu.\n", res); /* FIXME: Wine first video frame is often full of garbage, wait for another update */ res = WaitForSingleObject(notify->ready_event, 500); @@ -1483,7 +1483,7 @@ static HRESULT WINAPI passthrough_mft_AddInputStreams(IMFTransform *iface, DWORD static HRESULT WINAPI passthrough_mft_GetInputAvailableType(IMFTransform *iface, DWORD id, DWORD index, IMFMediaType **type) { - static const GUID *types[] = { &MFMediaType_Video }; + static const GUID *types[] = { &MFMediaType_Video, &MFMediaType_Audio }; HRESULT hr; if (id) @@ -1772,9 +1772,9 @@ HRESULT passthrough_mft_create(UINT32 index, struct passthrough_mft **out) return S_OK; } -static void test_video_effect(void) +static void test_effect(void) { - struct passthrough_mft *video_effect = NULL, *video_effect2 = NULL; + struct passthrough_mft *video_effect = NULL, *video_effect2 = NULL, *audio_effect = NULL, *audio_effect2 = NULL; struct test_transfer_notify *notify; IMFMediaEngineEx *media_engine_ex = NULL; ID3D11Texture2D *texture = NULL; @@ -1782,6 +1782,7 @@ static void test_video_effect(void) ID3D11Device *device = NULL; D3D11_TEXTURE2D_DESC desc; IMFByteStream *stream; + IMFMediaSink *sink; RECT dst_rect; UINT token; HRESULT hr; @@ -1836,6 +1837,20 @@ static void test_video_effect(void) ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); EXPECT_REF(&video_effect2->IMFTransform_iface, 2); + hr = passthrough_mft_create(0, &audio_effect); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = passthrough_mft_create(1, &audio_effect2); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IMFMediaEngineEx_InsertAudioEffect(media_engine_ex, (IUnknown *)&audio_effect->IMFTransform_iface, FALSE); + todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + todo_wine EXPECT_REF(&audio_effect->IMFTransform_iface, 2); + + hr = IMFMediaEngineEx_InsertAudioEffect(media_engine_ex, (IUnknown *)&audio_effect2->IMFTransform_iface, FALSE); + todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + todo_wine EXPECT_REF(&audio_effect2->IMFTransform_iface, 2); + url = SysAllocString(L"i420-64x64.avi"); hr = IMFMediaEngineEx_SetSourceFromByteStream(media_engine_ex, stream, url); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); @@ -1858,6 +1873,21 @@ static void test_video_effect(void) ok(video_effect->processing_count > 0, "Unexpected processing count %lu.\n", video_effect->processing_count); ok(video_effect2->processing_count > 0, "Unexpected processing count %lu.\n", video_effect2->processing_count); + if (SUCCEEDED(hr = MFCreateAudioRenderer(NULL, &sink))) + { + todo_wine + ok(audio_effect->processing_count > 0, "Unexpected processing count %lu.\n", audio_effect->processing_count); + todo_wine + ok(audio_effect2->processing_count > 0, "Unexpected processing count %lu.\n", audio_effect2->processing_count); + + IMFMediaSink_Release(sink); + } + else if (hr == MF_E_NO_AUDIO_PLAYBACK_DEVICE) + { + ok(!audio_effect->processing_count, "Unexpected processing count %lu.\n", audio_effect->processing_count); + ok(!audio_effect2->processing_count, "Unexpected processing count %lu.\n", audio_effect2->processing_count); + } + done: if (media_engine_ex) { @@ -1872,6 +1902,17 @@ done: if (device) ID3D11Device_Release(device); + if (audio_effect2) + { + ref = IMFTransform_Release(&audio_effect2->IMFTransform_iface); + ok(!ref, "Unexpected ref %lu.\n", ref); + } + if (audio_effect) + { + ref = IMFTransform_Release(&audio_effect->IMFTransform_iface); + ok(!ref, "Unexpected ref %lu.\n", ref); + } + if (video_effect2) { ref = IMFTransform_Release(&video_effect2->IMFTransform_iface); @@ -1917,7 +1958,7 @@ START_TEST(mfmediaengine) test_SetSourceFromByteStream(); test_audio_configuration(); test_TransferVideoFrame(); - test_video_effect(); + test_effect(); IMFMediaEngineClassFactory_Release(factory); diff --git a/dlls/mfmediaengine/tests/resource.rc b/dlls/mfmediaengine/tests/resource.rc index 50152586758..960e5ffd73e 100644 --- a/dlls/mfmediaengine/tests/resource.rc +++ b/dlls/mfmediaengine/tests/resource.rc @@ -21,8 +21,9 @@ /* Generated with: * gst-launch-1.0 videotestsrc num-buffers=4 pattern=smpte100 ! \ * video/x-raw,format=I420,width=64,height=64,framerate=30000/1001 ! \ - * videoflip method=clockwise ! videoconvert ! \ - * avimux ! filesink location=dlls/mfmediaengine/tests/i420-64x64.avi + * videoflip method=clockwise ! videoconvert ! queue ! mux. \ + * audiotestsrc num-buffers=4 ! audioconvert ! audio/x-raw,rate=44100,channels=2 ! queue ! mux. \ + * avimux name=mux ! filesink location=dlls/mfmediaengine/tests/i420-64x64.avi */ /* @makedep: i420-64x64.avi */ i420-64x64.avi RCDATA i420-64x64.avi

1 0

Zebediah Figura : vkd3d-shader/ir: Normalise sm1-style constants.
by Alexandre Julliard July 17, 2023

July 17, 2023

Module: vkd3d Branch: master Commit: 25cf6a720b1f9aeec961ea456cab77aef66e2ea1 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/25cf6a720b1f9aeec961ea456cab7… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Jul 9 17:46:04 2023 -0500 vkd3d-shader/ir: Normalise sm1-style constants. --- libs/vkd3d-shader/ir.c | 126 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) diff --git a/libs/vkd3d-shader/ir.c b/libs/vkd3d-shader/ir.c index 0e574e27..1ce05247 100644 --- a/libs/vkd3d-shader/ir.c +++ b/libs/vkd3d-shader/ir.c @@ -1071,6 +1071,129 @@ static enum vkd3d_result instruction_array_normalise_io_registers(struct vkd3d_s return VKD3D_OK; } +struct flat_constant_def +{ + enum vkd3d_shader_d3dbc_constant_register set; + uint32_t index; + uint32_t value[4]; +}; + +struct flat_constants_normaliser +{ + struct vkd3d_shader_parser *parser; + struct flat_constant_def *defs; + size_t def_count, defs_capacity; +}; + +static bool get_flat_constant_register_type(const struct vkd3d_shader_register *reg, + enum vkd3d_shader_d3dbc_constant_register *set, uint32_t *index) +{ + static const struct + { + enum vkd3d_shader_register_type type; + enum vkd3d_shader_d3dbc_constant_register set; + uint32_t offset; + } + regs[] = + { + {VKD3DSPR_CONST, VKD3D_SHADER_D3DBC_FLOAT_CONSTANT_REGISTER, 0}, + {VKD3DSPR_CONST2, VKD3D_SHADER_D3DBC_FLOAT_CONSTANT_REGISTER, 2048}, + {VKD3DSPR_CONST3, VKD3D_SHADER_D3DBC_FLOAT_CONSTANT_REGISTER, 4096}, + {VKD3DSPR_CONST4, VKD3D_SHADER_D3DBC_FLOAT_CONSTANT_REGISTER, 6144}, + {VKD3DSPR_CONSTINT, VKD3D_SHADER_D3DBC_INT_CONSTANT_REGISTER, 0}, + {VKD3DSPR_CONSTBOOL, VKD3D_SHADER_D3DBC_BOOL_CONSTANT_REGISTER, 0}, + }; + + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(regs); ++i) + { + if (reg->type == regs[i].type) + { + if (reg->idx[0].rel_addr) + { + FIXME("Unhandled relative address.\n"); + return false; + } + + *set = regs[i].set; + *index = regs[i].offset + reg->idx[0].offset; + return true; + } + } + + return false; +} + +static void shader_register_normalise_flat_constants(struct vkd3d_shader_src_param *param, + const struct flat_constants_normaliser *normaliser) +{ + enum vkd3d_shader_d3dbc_constant_register set; + uint32_t index; + size_t i, j; + + if (!get_flat_constant_register_type(&param->reg, &set, &index)) + return; + + for (i = 0; i < normaliser->def_count; ++i) + { + if (normaliser->defs[i].set == set && normaliser->defs[i].index == index) + { + param->reg.type = VKD3DSPR_IMMCONST; + param->reg.idx_count = 0; + param->reg.immconst_type = VKD3D_IMMCONST_VEC4; + for (j = 0; j < 4; ++j) + param->reg.u.immconst_uint[j] = normaliser->defs[i].value[j]; + return; + } + } + + param->reg.type = VKD3DSPR_CONSTBUFFER; + param->reg.idx[0].offset = set; /* register ID */ + param->reg.idx[1].offset = set; /* register index */ + param->reg.idx[2].offset = index; /* buffer index */ + param->reg.idx_count = 3; +} + +static enum vkd3d_result instruction_array_normalise_flat_constants(struct vkd3d_shader_parser *parser) +{ + struct flat_constants_normaliser normaliser = {.parser = parser}; + unsigned int i, j; + + for (i = 0; i < parser->instructions.count; ++i) + { + struct vkd3d_shader_instruction *ins = &parser->instructions.elements[i]; + + if (ins->handler_idx == VKD3DSIH_DEF || ins->handler_idx == VKD3DSIH_DEFI || ins->handler_idx == VKD3DSIH_DEFB) + { + struct flat_constant_def *def; + + if (!vkd3d_array_reserve((void **)&normaliser.defs, &normaliser.defs_capacity, + normaliser.def_count + 1, sizeof(*normaliser.defs))) + { + vkd3d_free(normaliser.defs); + return VKD3D_ERROR_OUT_OF_MEMORY; + } + + def = &normaliser.defs[normaliser.def_count++]; + + get_flat_constant_register_type((struct vkd3d_shader_register *)&ins->dst[0].reg, &def->set, &def->index); + for (j = 0; j < 4; ++j) + def->value[j] = ins->src[0].reg.u.immconst_uint[j]; + + vkd3d_shader_instruction_make_nop(ins); + } + else + { + for (j = 0; j < ins->src_count; ++j) + shader_register_normalise_flat_constants((struct vkd3d_shader_src_param *)&ins->src[j], &normaliser); + } + } + + vkd3d_free(normaliser.defs); + return VKD3D_OK; +} + enum vkd3d_result vkd3d_shader_normalise(struct vkd3d_shader_parser *parser) { struct vkd3d_shader_instruction_array *instructions = &parser->instructions; @@ -1087,6 +1210,9 @@ enum vkd3d_result vkd3d_shader_normalise(struct vkd3d_shader_parser *parser) &parser->shader_desc.input_signature, &parser->shader_desc.output_signature, &parser->shader_desc.patch_constant_signature); + if (result >= 0) + result = instruction_array_normalise_flat_constants(parser); + if (result >= 0 && TRACE_ON()) vkd3d_shader_trace(instructions, &parser->shader_version);

1 0