September 2023 - Wine-Commits

Jacek Caban : shell32: Use a signed value to assign single signed bitfields values.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 81c05589afa9d88e5b7c4f3b3074d457a3df14b6 URL: https://gitlab.winehq.org/wine/wine/-/commit/81c05589afa9d88e5b7c4f3b3074d4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:18:10 2023 +0200 shell32: Use a signed value to assign single signed bitfields values. --- dlls/shell32/shellord.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c index 56f386c7944..a007c0e5c60 100644 --- a/dlls/shell32/shellord.c +++ b/dlls/shell32/shellord.c @@ -306,12 +306,12 @@ VOID WINAPI SHGetSettings(LPSHELLFLAGSTATE lpsfs, DWORD dwMask) if (SSF_SHOWSYSFILES & dwMask) lpsfs->fShowSysFiles = 0; } else if (dwData == 1) - { if (SSF_SHOWALLOBJECTS & dwMask) lpsfs->fShowAllObjects = 1; + { if (SSF_SHOWALLOBJECTS & dwMask) lpsfs->fShowAllObjects = -1; if (SSF_SHOWSYSFILES & dwMask) lpsfs->fShowSysFiles = 0; } else if (dwData == 2) { if (SSF_SHOWALLOBJECTS & dwMask) lpsfs->fShowAllObjects = 0; - if (SSF_SHOWSYSFILES & dwMask) lpsfs->fShowSysFiles = 1; + if (SSF_SHOWSYSFILES & dwMask) lpsfs->fShowSysFiles = -1; } } RegCloseKey (hKey); @@ -1182,15 +1182,15 @@ BOOL WINAPI ReadCabinetState(CABINETSTATE *cs, int length) memset(cs, 0, sizeof(*cs)); cs->cLength = sizeof(*cs); cs->nVersion = 2; - cs->fFullPathTitle = FALSE; - cs->fSaveLocalView = TRUE; - cs->fNotShell = FALSE; - cs->fSimpleDefault = TRUE; - cs->fDontShowDescBar = FALSE; - cs->fNewWindowMode = FALSE; - cs->fShowCompColor = FALSE; - cs->fDontPrettyNames = FALSE; - cs->fAdminsCreateCommonGroups = TRUE; + cs->fFullPathTitle = 0; + cs->fSaveLocalView = -1; + cs->fNotShell = 0; + cs->fSimpleDefault = -1; + cs->fDontShowDescBar = 0; + cs->fNewWindowMode = 0; + cs->fShowCompColor = 0; + cs->fDontPrettyNames = 0; + cs->fAdminsCreateCommonGroups = -1; cs->fMenuEnumFilter = 96; }

1 0

Jacek Caban : regedit: Use unsigned types for bitfields.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 555394b79c5e993e8155a7e0dce8bcea25db99fc URL: https://gitlab.winehq.org/wine/wine/-/commit/555394b79c5e993e8155a7e0dce8bc… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:16:03 2023 +0200 regedit: Use unsigned types for bitfields. --- programs/regedit/hexedit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/regedit/hexedit.c b/programs/regedit/hexedit.c index d29c916918e..ac47b61dd6e 100644 --- a/programs/regedit/hexedit.c +++ b/programs/regedit/hexedit.c @@ -43,9 +43,9 @@ typedef struct tagHEXEDIT_INFO { HWND hwndSelf; HFONT hFont; - BOOL bFocus : 1; - BOOL bFocusHex : 1; /* TRUE if focus is on hex, FALSE if focus on ASCII */ - BOOL bInsert : 1; /* insert mode if TRUE, overwrite mode if FALSE */ + UINT bFocus : 1; + UINT bFocusHex : 1; /* TRUE if focus is on hex, FALSE if focus on ASCII */ + UINT bInsert : 1; /* insert mode if TRUE, overwrite mode if FALSE */ INT nHeight; /* height of text */ INT nCaretPos; /* caret pos in nibbles */ BYTE *pData;

1 0

Jacek Caban : shell32: Use unsigned types for bit fields.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 50adef1949d477e017c05ca414d3bf81c3af6783 URL: https://gitlab.winehq.org/wine/wine/-/commit/50adef1949d477e017c05ca414d3bf… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:16:55 2023 +0200 shell32: Use unsigned types for bit fields. --- dlls/shell32/shellpath.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index b09b35795fb..015d7cdd4e2 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -3289,9 +3289,9 @@ static HRESULT set_folder_attributes(void) static const struct { const CLSID *clsid; - BOOL wfparsing : 1; - BOOL wfdisplay : 1; - BOOL hideasdel : 1; + unsigned int wfparsing : 1; + unsigned int wfdisplay : 1; + unsigned int hideasdel : 1; DWORD attr; DWORD call_for_attr; } folders[] =

1 0

Alexandre Julliard : ntdll/tests: Fix some test failures on ARM64 Windows.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 78c77ae3e06e767a2aabb8e92626dd4e8a71daf7 URL: https://gitlab.winehq.org/wine/wine/-/commit/78c77ae3e06e767a2aabb8e92626dd… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Sep 13 20:31:28 2023 +0200 ntdll/tests: Fix some test failures on ARM64 Windows. --- dlls/ntdll/tests/directory.c | 6 +++--- dlls/ntdll/tests/exception.c | 2 +- dlls/ntdll/tests/file.c | 22 +++++++++++----------- dlls/ntdll/tests/info.c | 2 +- dlls/ntdll/tests/pipe.c | 16 ++++++++-------- dlls/ntdll/tests/rtl.c | 26 ++++++++++++++------------ dlls/ntdll/tests/virtual.c | 12 ++++++++---- 7 files changed, 46 insertions(+), 40 deletions(-)

1 0

Jacek Caban : ole32/tests: Don't use bitfield for called_todo.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 3d50c79b64678dc5998021315f0c8e5f761714ac URL: https://gitlab.winehq.org/wine/wine/-/commit/3d50c79b64678dc5998021315f0c8e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:15:38 2023 +0200 ole32/tests: Don't use bitfield for called_todo. --- dlls/ole32/tests/dragdrop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ole32/tests/dragdrop.c b/dlls/ole32/tests/dragdrop.c index cc24efdcbd2..bd63c11401f 100644 --- a/dlls/ole32/tests/dragdrop.c +++ b/dlls/ole32/tests/dragdrop.c @@ -72,7 +72,7 @@ struct method_call HRESULT set_ret; DWORD set_param; - int called_todo : 1; + BOOL called_todo; }; const struct method_call *call_ptr;

1 0

Jacek Caban : mshtml: Use unsigned types for bitfields.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 1913d265d755400851e9f8a366901571265a065f URL: https://gitlab.winehq.org/wine/wine/-/commit/1913d265d755400851e9f8a3669015… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:14:44 2023 +0200 mshtml: Use unsigned types for bitfields. --- dlls/mshtml/mshtml_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 59fbffa078c..5b9b1fac1b5 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -958,8 +958,8 @@ struct HTMLDocumentNode { nsIDOMDocument *dom_document; nsIDOMHTMLDocument *html_document; - BOOL content_ready : 1; - BOOL unload_sent : 1; + unsigned int content_ready : 1; + unsigned int unload_sent : 1; IHTMLDOMImplementation *dom_implementation; IHTMLNamespaceCollection *namespaces;

1 0

Jacek Caban : msvcrt: Use unsigned types for bitfields.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 7848941a4537e1ac18796ba67f2d2ba45a42ad26 URL: https://gitlab.winehq.org/wine/wine/-/commit/7848941a4537e1ac18796ba67f2d2b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 13 12:14:49 2023 +0200 msvcrt: Use unsigned types for bitfields. --- dlls/msvcrt/file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 24d801a5306..58a607e3bbe 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -109,9 +109,9 @@ typedef struct { unsigned char wxflag; char textmode; char lookahead[3]; - char unicode : 1; - char utf8translations : 1; - char dbcsBufferUsed : 1; + unsigned int unicode : 1; + unsigned int utf8translations : 1; + unsigned int dbcsBufferUsed : 1; char dbcsBuffer[MB_LEN_MAX]; } ioinfo;

1 0

Joel Holdsworth : ntdll/tests: Update link test to reflect Windows 11 behaviour.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 50dfe977b7cf1dfb4a929fd9468798ef5f233bd7 URL: https://gitlab.winehq.org/wine/wine/-/commit/50dfe977b7cf1dfb4a929fd9468798… Author: Joel Holdsworth <joel(a)airwebreathe.org.uk> Date: Mon Aug 7 14:50:43 2023 +0100 ntdll/tests: Update link test to reflect Windows 11 behaviour. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- dlls/ntdll/tests/file.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 556ba351809..41882778488 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -2413,7 +2413,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef , "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY , + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2460,7 +2461,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2494,7 +2496,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_OBJECT_NAME_COLLISION || res == STATUS_FILE_IS_A_DIRECTORY /* > Win XP */, "res expected STATUS_OBJECT_NAME_COLLISION or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; @@ -2531,7 +2534,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_OBJECT_NAME_COLLISION || res == STATUS_FILE_IS_A_DIRECTORY /* > Win XP */, "res expected STATUS_OBJECT_NAME_COLLISION or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; @@ -2566,7 +2570,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2602,7 +2607,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2639,7 +2645,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_OBJECT_NAME_COLLISION || res == STATUS_FILE_IS_A_DIRECTORY /* > Win XP */, "res expected STATUS_OBJECT_NAME_COLLISION or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; @@ -2676,7 +2683,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2715,7 +2723,8 @@ static void test_file_link_information(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformation ); - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef || io.Status == STATUS_FILE_IS_A_DIRECTORY, + "io.Status expected 0xdeadbeef or STATUS_FILE_IS_A_DIRECTORY, got %lx\n", io.Status ); ok( res == STATUS_FILE_IS_A_DIRECTORY, "res expected STATUS_FILE_IS_A_DIRECTORY, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" );

1 0

Alexandre Julliard : include: Add DECLSPEC_NOINLINE macro.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: d08723fbf797d89599255e4cd5cfe2f7d9cc8956 URL: https://gitlab.winehq.org/wine/wine/-/commit/d08723fbf797d89599255e4cd5cfe2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Sep 13 22:05:17 2023 +0200 include: Add DECLSPEC_NOINLINE macro. --- include/winnt.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/winnt.h b/include/winnt.h index c1f007d0536..e5dc402c694 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -155,6 +155,16 @@ extern "C" { # endif #endif +#ifndef DECLSPEC_NOINLINE +# if defined(_MSC_VER) && (_MSC_VER >= 1300) +# define DECLSPEC_NOINLINE __declspec(noinline) +# elif defined(__GNUC__) +# define DECLSPEC_NOINLINE __attribute__((noinline)) +# else +# define DECLSPEC_NOINLINE +# endif +#endif + #ifndef DECLSPEC_DEPRECATED # if defined(_MSC_VER) && (_MSC_VER >= 1300) && !defined(MIDL_PASS) # define DECLSPEC_DEPRECATED __declspec(deprecated)

1 0

Zebediah Figura : wmvcore: Explicitly include strmif.h.
by Alexandre Julliard Sept. 13, 2023

Sept. 13, 2023

Module: wine Branch: master Commit: 8d61e9312c041d2f5ed3a66c9d90ad38cebebff7 URL: https://gitlab.winehq.org/wine/wine/-/commit/8d61e9312c041d2f5ed3a66c9d90ad… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 12:40:13 2023 -0500 wmvcore: Explicitly include strmif.h. For IReferenceClock. Currently we rely on it getting included via the following path: wmsdk.idl -> wmsdkidl.idl -> drmexternals.idl -> wmdrmsdk.idl -> mfobjects.idl -> mediaobj.idl -> strmif.idl However, mediaobj.idl should not pull in strmif.idl. --- dlls/wmvcore/async_reader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wmvcore/async_reader.c b/dlls/wmvcore/async_reader.c index 95f617b5cf8..3a8556a5f0a 100644 --- a/dlls/wmvcore/async_reader.c +++ b/dlls/wmvcore/async_reader.c @@ -26,6 +26,7 @@ #define EXTERN_GUID DEFINE_GUID #include "initguid.h" +#include "strmif.h" #include "wmvcore_private.h" #include "wmsdk.h"

1 0