March 2024 - Wine-Commits - list.winehq.org

Hans Leidekker : dnsapi/tests: Skip tests if no CNAME records are returned.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 1482e2f960d9997a0e1fc23c2c72151d4bf64be7 URL: https://gitlab.winehq.org/wine/wine/-/commit/1482e2f960d9997a0e1fc23c2c7215… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Mar 12 13:34:08 2024 +0100 dnsapi/tests: Skip tests if no CNAME records are returned. --- dlls/dnsapi/tests/query.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/dnsapi/tests/query.c b/dlls/dnsapi/tests/query.c index 1412fdfa17b..d2472f61f88 100644 --- a/dlls/dnsapi/tests/query.c +++ b/dlls/dnsapi/tests/query.c @@ -167,6 +167,11 @@ static void test_DnsQuery(void) skip("query timed out\n"); return; } + if (status == DNS_INFO_NO_RECORDS) + { + skip("no CNAME records\n"); + return; + } ok(status == ERROR_SUCCESS, "got %ld\n", status); if (status == ERROR_SUCCESS && winetest_debug > 1) {

1 0

Dmitry Timoshkov : wineps.drv: Return default resolution if PPD doesn't provide the list of supported resolutions.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: e42afe7daf68871fde5944d73cbcef880187871d URL: https://gitlab.winehq.org/wine/wine/-/commit/e42afe7daf68871fde5944d73cbcef… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 26 20:47:57 2024 +0300 wineps.drv: Return default resolution if PPD doesn't provide the list of supported resolutions. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wineps.drv/driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 7b5d2abb32d..d56118e5e2c 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -703,6 +703,15 @@ DWORD WINAPI DrvDeviceCapabilities(HANDLE printer, WCHAR *device_name, WORD capa lp += 2; } } + if (!i) + { + if (output != NULL) + { + lp[0] = pi->ppd->DefaultResolution; + lp[1] = pi->ppd->DefaultResolution; + } + i = 1; + } ret = i; break; }

1 0

David Gow : evr/dshow: Support NV12 in evr_render.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: e2b1de523e8bd59ed43fc17e90ff791a4870fdaa URL: https://gitlab.winehq.org/wine/wine/-/commit/e2b1de523e8bd59ed43fc17e90ff79… Author: David Gow <david(a)ingeniumdigital.com> Date: Sun Feb 25 23:47:53 2024 +0800 evr/dshow: Support NV12 in evr_render. Add support for NV12 to evr_render(), as otherwise no video is rendered at all in games like Age of Empires II DE. In the process, the evr_copy_sample_buffer() function has been refactored to move the MFCopyImage() call into format-specific code (to better handle multi-planar formats cleanly). Signed-off-by: David Gow <david(a)ingeniumdigital.com> --- dlls/evr/evr.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/dlls/evr/evr.c b/dlls/evr/evr.c index 516427c5fff..52c5de5e2c4 100644 --- a/dlls/evr/evr.c +++ b/dlls/evr/evr.c @@ -354,6 +354,7 @@ static HRESULT evr_copy_sample_buffer(struct evr *filter, const GUID *subtype, I LONG src_stride; HRESULT hr; BYTE *src; + BYTE *dst_uv; if (FAILED(hr = IMFMediaType_GetUINT32(filter->media_type, &MF_MT_DEFAULT_STRIDE, (UINT32 *)&src_stride))) { @@ -364,14 +365,6 @@ static HRESULT evr_copy_sample_buffer(struct evr *filter, const GUID *subtype, I width = frame_size >> 32; lines = frame_size; - if (IsEqualGUID(subtype, &MFVideoFormat_YUY2)) - { - width = (3 * width + 3) & ~3; - } - else - { - width *= 4; - } if (FAILED(hr = IMediaSample_GetPointer(input_sample, &src))) { @@ -392,6 +385,30 @@ static HRESULT evr_copy_sample_buffer(struct evr *filter, const GUID *subtype, I if (SUCCEEDED(hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, D3DLOCK_DISCARD))) { if (src_stride < 0) src += (-src_stride) * (lines - 1); + + if (IsEqualGUID(subtype, &MFVideoFormat_YUY2)) + { + width = (3 * width + 3) & ~3; + MFCopyImage(locked_rect.pBits, locked_rect.Pitch, src, src_stride, width, lines); + } + else if (IsEqualGUID(subtype, &MFVideoFormat_NV12)) + { + /* Width and height must be rounded up to even. */ + width = (width + 1) & ~1; + lines = (lines + 1) & ~1; + + /* Y plane */ + MFCopyImage(locked_rect.pBits, locked_rect.Pitch, src, src_stride, width, lines); + + /* UV plane */ + dst_uv = (BYTE *)locked_rect.pBits + (lines * locked_rect.Pitch); + MFCopyImage(dst_uv, locked_rect.Pitch, src + (lines * src_stride), src_stride, width, lines / 2); + } + else + { + /* All other formats are 32-bit, single plane. */ + MFCopyImage(locked_rect.pBits, locked_rect.Pitch, src, src_stride, width * 4, lines); + } MFCopyImage(locked_rect.pBits, locked_rect.Pitch, src, src_stride, width, lines); IDirect3DSurface9_UnlockRect(surface); } @@ -427,7 +444,8 @@ static HRESULT evr_render(struct strmbase_renderer *iface, IMediaSample *input_s if (IsEqualGUID(&subtype, &MFVideoFormat_ARGB32) || IsEqualGUID(&subtype, &MFVideoFormat_RGB32) - || IsEqualGUID(&subtype, &MFVideoFormat_YUY2)) + || IsEqualGUID(&subtype, &MFVideoFormat_YUY2) + || IsEqualGUID(&subtype, &MFVideoFormat_NV12)) { if (SUCCEEDED(hr = evr_copy_sample_buffer(filter, &subtype, input_sample, &sample))) {

1 0

Alexandre Julliard : ntdll: Port the RtlRestoreContext test to ARM.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: f42316c86d6dce34f532346d5efc52625d7e9939 URL: https://gitlab.winehq.org/wine/wine/-/commit/f42316c86d6dce34f532346d5efc52… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 12 20:24:40 2024 +0100 ntdll: Port the RtlRestoreContext test to ARM. --- dlls/ntdll/signal_arm.c | 38 ++++----- dlls/ntdll/tests/exception.c | 179 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 198 insertions(+), 19 deletions(-)

1 0

Alexandre Julliard : ntdll: Port the RtlRestoreContext test to ARM64.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 74d1dbb95a91ce8704b9ff940c6bb4b6806a5951 URL: https://gitlab.winehq.org/wine/wine/-/commit/74d1dbb95a91ce8704b9ff940c6bb4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 12 20:23:47 2024 +0100 ntdll: Port the RtlRestoreContext test to ARM64. --- dlls/ntdll/signal_arm64.c | 106 ++++++++---------------- dlls/ntdll/tests/exception.c | 191 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 223 insertions(+), 74 deletions(-)

1 0

Alexandre Julliard : ntdll: Add test for non-volatile regs in consolidated unwinds.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 5286ed3b0a40385a591ecf0daa5252d890171060 URL: https://gitlab.winehq.org/wine/wine/-/commit/5286ed3b0a40385a591ecf0daa5252… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 12 17:46:10 2024 +0100 ntdll: Add test for non-volatile regs in consolidated unwinds. --- dlls/ntdll/signal_x86_64.c | 2 +- dlls/ntdll/tests/exception.c | 69 ++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 65 insertions(+), 6 deletions(-) diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c index d37cd741c09..8611364b3e9 100644 --- a/dlls/ntdll/signal_x86_64.c +++ b/dlls/ntdll/signal_x86_64.c @@ -847,7 +847,7 @@ void WINAPI RtlUnwindEx( PVOID end_frame, PVOID target_ip, EXCEPTION_RECORD *rec } context->Rax = (ULONG64)retval; - context->Rip = (ULONG64)target_ip; + if (rec->ExceptionCode != STATUS_UNWIND_CONSOLIDATE) context->Rip = (ULONG64)target_ip; RtlRestoreContext(context, rec); } diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index 9ce0646cd47..eb8e92d8292 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -2182,12 +2182,45 @@ static void test_KiUserCallbackDispatcher(void) #elif defined(__x86_64__) -static int consolidate_dummy_called; +static LONG consolidate_dummy_called; static PVOID CALLBACK test_consolidate_dummy(EXCEPTION_RECORD *rec) { CONTEXT *ctx = (CONTEXT *)rec->ExceptionInformation[1]; - consolidate_dummy_called = 1; - ok(ctx->Rip == 0xdeadbeef, "test_consolidate_dummy failed for Rip, expected: 0xdeadbeef, got: %Ix\n", ctx->Rip); + + switch (InterlockedIncrement(&consolidate_dummy_called)) + { + case 1: /* RtlRestoreContext */ + ok(ctx->Rip == 0xdeadbeef, "RtlRestoreContext wrong Rip, expected: 0xdeadbeef, got: %Ix\n", ctx->Rip); + ok( rec->ExceptionInformation[10] == -1, "wrong info %Ix\n", rec->ExceptionInformation[10] ); + break; + case 2: /* RtlUnwindEx */ + ok(ctx->Rip != 0xdeadbeef, "RtlUnwindEx wrong Rip, got: %Ix\n", ctx->Rip ); + if (is_arm64ec) + { + DISPATCHER_CONTEXT_NONVOLREG_ARM64 *regs = (void *)rec->ExceptionInformation[10]; + _JUMP_BUFFER *buf = (void *)rec->ExceptionInformation[3]; + ARM64EC_NT_CONTEXT *ec_ctx = (ARM64EC_NT_CONTEXT *)ctx; + int i; + + ok( rec->ExceptionInformation[10] != -1, "wrong info %Ix\n", rec->ExceptionInformation[10] ); + ok( regs->GpNvRegs[0] == buf->R12, "wrong reg X19, %Ix / %Ix\n", regs->GpNvRegs[0], buf->R12 ); + ok( regs->GpNvRegs[1] == buf->R13, "wrong reg X20, %Ix / %Ix\n", regs->GpNvRegs[1], buf->R13 ); + ok( regs->GpNvRegs[2] == buf->R14, "wrong reg X21, %Ix / %Ix\n", regs->GpNvRegs[2], buf->R14 ); + ok( regs->GpNvRegs[3] == buf->R15, "wrong reg X22, %Ix / %Ix\n", regs->GpNvRegs[3], buf->R15 ); + ok( regs->GpNvRegs[4] == 0, "wrong reg X23, %Ix / 0\n", regs->GpNvRegs[4] ); + ok( regs->GpNvRegs[5] == 0, "wrong reg X24, %Ix / 0\n", regs->GpNvRegs[5] ); + ok( regs->GpNvRegs[6] == buf->Rsi, "wrong reg X25, %Ix / %Ix\n", regs->GpNvRegs[6], buf->Rsi ); + ok( regs->GpNvRegs[7] == buf->Rdi, "wrong reg X26, %Ix / %Ix\n", regs->GpNvRegs[7], buf->Rdi ); + ok( regs->GpNvRegs[8] == buf->Rbx, "wrong reg X27, %Ix / %Ix\n", regs->GpNvRegs[8], buf->Rbx ); + ok( regs->GpNvRegs[9] == 0, "wrong reg X28, %Ix / 0\n", regs->GpNvRegs[9] ); + ok( regs->GpNvRegs[10] == buf->Rbp,"wrong reg X29, %Ix / %Ix\n", regs->GpNvRegs[10], buf->Rbp ); + for (i = 0; i < 8; i++) + ok(regs->FpNvRegs[i] == ec_ctx->V[i + 8].D[0], "wrong reg D%u, expected: %g, got: %g\n", + i + 8, regs->FpNvRegs[i], ec_ctx->V[i + 8].D[0] ); + } + else ok( rec->ExceptionInformation[10] == -1, "wrong info %Ix\n", rec->ExceptionInformation[10] ); + break; + } return (PVOID)rec->ExceptionInformation[2]; } @@ -2312,13 +2345,39 @@ static void test_restore_context(void) rec.ExceptionInformation[0] = (DWORD64)test_consolidate_dummy; rec.ExceptionInformation[1] = (DWORD64)&ctx; rec.ExceptionInformation[2] = ctx.Rip; + rec.ExceptionInformation[10] = -1; ctx.Rip = 0xdeadbeef; pRtlRestoreContext(&ctx, &rec); ok(0, "shouldn't be reached\n"); } else if (pass == 3) - ok(consolidate_dummy_called, "test_consolidate_dummy not called\n"); + ok(consolidate_dummy_called == 1, "test_consolidate_dummy not called\n"); + else + ok(0, "unexpected pass %ld\n", pass); + + /* test with consolidate through RtlUnwindEx */ + pass = 0; + InterlockedIncrement(&pass); + pRtlCaptureContext(&ctx); + InterlockedIncrement(&pass); + if (pass == 2) + { + rec.ExceptionCode = STATUS_UNWIND_CONSOLIDATE; + rec.NumberParameters = 4; + rec.ExceptionInformation[0] = (DWORD64)test_consolidate_dummy; + rec.ExceptionInformation[1] = (DWORD64)&ctx; + rec.ExceptionInformation[2] = ctx.Rip; + rec.ExceptionInformation[3] = (DWORD64)&buf; + rec.ExceptionInformation[10] = -1; /* otherwise it doesn't get set */ + ctx.Rip = 0xdeadbeef; + /* uses consolidate callback Rip instead of bogus 0xdeadbeef */ + setjmp((_JBTYPE *)&buf); + pRtlUnwindEx((void*)buf.Frame, (void*)0xdeadbeef, &rec, NULL, &ctx, NULL); + ok(0, "shouldn't be reached\n"); + } + else if (pass == 3) + ok(consolidate_dummy_called == 2, "test_consolidate_dummy not called\n"); else ok(0, "unexpected pass %ld\n", pass); } @@ -2348,7 +2407,7 @@ static void test___C_specific_handler(void) } memset(&rec, 0, sizeof(rec)); - rec.ExceptionFlags = 2; /* EXCEPTION_UNWINDING */ + rec.ExceptionFlags = EXCEPTION_UNWINDING; frame = 0x1234; memset(&dispatch, 0, sizeof(dispatch)); dispatch.ImageBase = (ULONG_PTR)GetModuleHandleA(NULL);

1 0

Marcus Meissner : ntdll/tests: Fix size passed to GetModuleFileNameW.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 084c8cc9c033532e86b37756957f3c6eda635cf9 URL: https://gitlab.winehq.org/wine/wine/-/commit/084c8cc9c033532e86b37756957f3c… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Tue Mar 12 14:20:27 2024 +0100 ntdll/tests: Fix size passed to GetModuleFileNameW. --- dlls/ntdll/tests/exception.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index e4922aac616..57d1b7f492b 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -10304,7 +10304,7 @@ static void test_backtrace(void) if (count && !buffer[count - 1]) count--; /* win11 32-bit */ RtlPcToFileHeader( buffer[count - 1], &module ); - GetModuleFileNameW( module, name, sizeof(name) ); + GetModuleFileNameW( module, name, ARRAY_SIZE(name) ); if ((p = wcsrchr( name, '\\' ))) p++; else p = name; ok( !wcsicmp( p, L"ntdll.dll" ), "wrong module %p %s for frame %u %p\n",

1 0

Alexandre Julliard : ntdll/tests: Directly link to setjmp().
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 99aee076e50ec96b6c4a38efb4c6971a7f3bda49 URL: https://gitlab.winehq.org/wine/wine/-/commit/99aee076e50ec96b6c4a38efb4c697… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 12 17:45:18 2024 +0100 ntdll/tests: Directly link to setjmp(). --- dlls/ntdll/tests/exception.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index 57d1b7f492b..01177a2c5d7 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -147,7 +147,6 @@ static NTSTATUS (WINAPI *pRtlWow64GetThreadContext)(HANDLE, WOW64_CONTEXT *); static NTSTATUS (WINAPI *pRtlWow64SetThreadContext)(HANDLE, const WOW64_CONTEXT *); static NTSTATUS (WINAPI *pRtlWow64GetCpuAreaInfo)(WOW64_CPURESERVED*,ULONG,WOW64_CPU_AREA_INFO*); static NTSTATUS (WINAPI *pRtlGetNativeSystemInformation)(SYSTEM_INFORMATION_CLASS,void*,ULONG,ULONG*); -static int (CDECL *p_setjmp)(_JUMP_BUFFER*); #endif enum debugger_stages @@ -2201,9 +2200,9 @@ static void test_restore_context(void) int i; LONG pass; - if (!pRtlUnwindEx || !pRtlRestoreContext || !pRtlCaptureContext || !p_setjmp) + if (!pRtlUnwindEx || !pRtlRestoreContext || !pRtlCaptureContext) { - skip("RtlUnwindEx/RtlCaptureContext/RtlRestoreContext/_setjmp not found\n"); + skip("RtlUnwindEx/RtlCaptureContext/RtlRestoreContext not found\n"); return; } @@ -2221,12 +2220,12 @@ static void test_restore_context(void) else ok(pass < 4, "unexpected pass %ld\n", pass); - /* test with jmp using RltRestoreContext */ + /* test with jmp using RtlRestoreContext */ pass = 0; InterlockedIncrement(&pass); RtlCaptureContext(&ctx); InterlockedIncrement(&pass); /* only called once */ - p_setjmp(&buf); + setjmp((_JBTYPE *)&buf); InterlockedIncrement(&pass); if (pass == 3) { @@ -2285,7 +2284,7 @@ static void test_restore_context(void) InterlockedIncrement(&pass); pRtlCaptureContext(&ctx); InterlockedIncrement(&pass); /* only called once */ - p_setjmp(&buf); + setjmp((_JBTYPE *)&buf); InterlockedIncrement(&pass); if (pass == 3) { @@ -2294,7 +2293,7 @@ static void test_restore_context(void) rec.ExceptionInformation[0] = (DWORD64)&buf; /* uses buf.Rip instead of bogus 0xdeadbeef */ - pRtlUnwindEx((void*)buf.Rsp, (void*)0xdeadbeef, &rec, NULL, &ctx, NULL); + pRtlUnwindEx((void*)buf.Frame, (void*)0xdeadbeef, &rec, NULL, &ctx, NULL); ok(0, "shouldn't be reached\n"); } else @@ -10314,9 +10313,6 @@ static void test_backtrace(void) START_TEST(exception) { HMODULE hkernel32 = GetModuleHandleA("kernel32.dll"); -#if defined(__x86_64__) - HMODULE hmsvcrt = LoadLibraryA("msvcrt.dll"); -#endif hntdll = GetModuleHandleA("ntdll.dll"); my_argc = winetest_get_mainargs( &my_argv ); @@ -10509,7 +10505,6 @@ START_TEST(exception) X(RtlWow64GetCpuAreaInfo); X(RtlGetNativeSystemInformation); #undef X - p_setjmp = (void *)GetProcAddress( hmsvcrt, "_setjmp" ); if (pRtlGetNativeSystemInformation) {

1 0

Alexandre Julliard : ws2_32/tests: Fix a couple of failures on Windows.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: 66f940a2eccbf00c08d3bc08467bc18d321868f7 URL: https://gitlab.winehq.org/wine/wine/-/commit/66f940a2eccbf00c08d3bc08467bc1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 12 08:42:51 2024 +0100 ws2_32/tests: Fix a couple of failures on Windows. --- dlls/ws2_32/tests/protocol.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/ws2_32/tests/protocol.c b/dlls/ws2_32/tests/protocol.c index 8a1efb6b5d0..e1a431a3e32 100644 --- a/dlls/ws2_32/tests/protocol.c +++ b/dlls/ws2_32/tests/protocol.c @@ -1917,8 +1917,8 @@ static void test_GetAddrInfoW(void) SetLastError(0xdeadbeef); result2 = NULL; ret = GetAddrInfoW(idn_domain, NULL, &hint, &result2); - ok(ret == WSAHOST_NOT_FOUND, "got %d expected WSAHOST_NOT_FOUND\n", ret); - ok(WSAGetLastError() == WSAHOST_NOT_FOUND, "expected 11001, got %d\n", WSAGetLastError()); + ok(ret == WSAHOST_NOT_FOUND || ret == WSATRY_AGAIN, "got %d\n", ret); + ok(WSAGetLastError() == ret, "got %d\n", WSAGetLastError()); ok(result2 == NULL, "got %p\n", result2); } @@ -1926,6 +1926,7 @@ static struct completion_routine_test { WSAOVERLAPPED *overlapped; DWORD error; + DWORD error2; ADDRINFOEXW **result; HANDLE event; DWORD called; @@ -1935,7 +1936,7 @@ static void CALLBACK completion_routine(DWORD error, DWORD byte_count, WSAOVERLA { struct completion_routine_test *test = &completion_routine_test; - ok(error == test->error, "got %lu\n", error); + ok(error == test->error || (test->error2 && error == test->error2), "got %lu\n", error); ok(!byte_count, "got %lu\n", byte_count); ok(overlapped == test->overlapped, "got %p\n", overlapped); ok(overlapped->Internal == test->error, "got %Iu\n", overlapped->Internal); @@ -2073,6 +2074,7 @@ static void test_GetAddrInfoExW(void) overlapped.hEvent = NULL; completion_routine_test.overlapped = &overlapped; completion_routine_test.error = ERROR_SUCCESS; + completion_routine_test.error2 = ERROR_SUCCESS; completion_routine_test.result = &result; completion_routine_test.event = event; completion_routine_test.called = 0; @@ -2093,6 +2095,7 @@ static void test_GetAddrInfoExW(void) result = (void *)0xdeadbeef; completion_routine_test.overlapped = &overlapped; completion_routine_test.error = WSAHOST_NOT_FOUND; + completion_routine_test.error2 = WSANO_DATA; completion_routine_test.called = 0; ResetEvent(event); ret = pGetAddrInfoExW(nxdomain, NULL, NS_DNS, NULL, NULL, &result, NULL, &overlapped, completion_routine, NULL);

1 0

Brendan McGrath : comdlg32: Don't treat cmb1 as the printer list unless in PRINT_SETUP.
by Alexandre Julliard March 12, 2024

March 12, 2024

Module: wine Branch: master Commit: bbdc50c5320dc1c51c080e24bf7ec712c7b847c0 URL: https://gitlab.winehq.org/wine/wine/-/commit/bbdc50c5320dc1c51c080e24bf7ec7… Author: Brendan McGrath <bmcgrath(a)codeweavers.com> Date: Tue Jan 30 06:37:13 2024 +1100 comdlg32: Don't treat cmb1 as the printer list unless in PRINT_SETUP. This changes WMCommandW to match WMCommandA. --- dlls/comdlg32/printdlg.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c index d300b46a5b6..aed486a9b09 100644 --- a/dlls/comdlg32/printdlg.c +++ b/dlls/comdlg32/printdlg.c @@ -1988,7 +1988,10 @@ static LRESULT PRINTDLG_WMCommandW(HWND hDlg, WPARAM wParam, } break; - case cmb1: /* Printer Combobox in PRINT SETUP */ + case cmb1: /* Printer Combobox in PRINT SETUP, quality combobox in PRINT16 */ + if (PrinterComboID != LOWORD(wParam)) { + break; + } /* FALLTHROUGH */ case cmb4: /* Printer combobox */ if (HIWORD(wParam)==CBN_SELCHANGE) {

1 0