June 2024 - Wine-Commits - list.winehq.org

Rémi Bernon : win32u: Use the default window surface when window is not visible.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: aa14eea31f6da9ad6fccb18f6798d17f609b7182 URL: https://gitlab.winehq.org/wine/wine/-/commit/aa14eea31f6da9ad6fccb18f6798d1… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jun 20 09:33:05 2024 +0200 win32u: Use the default window surface when window is not visible. --- dlls/win32u/driver.c | 2 +- dlls/win32u/window.c | 7 +++++-- dlls/wineandroid.drv/android.h | 2 +- dlls/wineandroid.drv/window.c | 7 ++----- dlls/winemac.drv/macdrv.h | 2 +- dlls/winemac.drv/surface.c | 6 ++---- dlls/winemac.drv/window.c | 1 - dlls/winewayland.drv/waylanddrv.h | 2 +- dlls/winewayland.drv/window.c | 8 ++------ dlls/winewayland.drv/window_surface.c | 4 ++-- dlls/winex11.drv/bitblt.c | 5 ++--- dlls/winex11.drv/window.c | 1 - dlls/winex11.drv/x11drv.h | 2 +- include/wine/gdi_driver.h | 4 ++-- 14 files changed, 22 insertions(+), 31 deletions(-)

1 0

Rémi Bernon : win32u: Use the previous surface as default surface when compatible.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: 63b0a187bd16b8215ca1134b249d03940077b378 URL: https://gitlab.winehq.org/wine/wine/-/commit/63b0a187bd16b8215ca1134b249d03… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Jun 25 23:10:55 2024 +0200 win32u: Use the previous surface as default surface when compatible. --- dlls/win32u/window.c | 38 +++++++++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c index 2c78eaf1d98..05496418665 100644 --- a/dlls/win32u/window.c +++ b/dlls/win32u/window.c @@ -1802,6 +1802,34 @@ static BOOL get_surface_rect( const RECT *visible_rect, RECT *surface_rect ) return TRUE; } +static BOOL get_default_window_surface( HWND hwnd, const RECT *surface_rect, struct window_surface **surface ) +{ + struct window_surface *previous; + WND *win; + + TRACE( "hwnd %p, surface_rect %s, surface %p\n", hwnd, wine_dbgstr_rect( surface_rect ), surface ); + + if (!(win = get_win_ptr( hwnd )) || win == WND_DESKTOP || win == WND_OTHER_PROCESS) return FALSE; + + if ((previous = win->surface) && EqualRect( &previous->rect, surface_rect )) + { + window_surface_add_ref( (*surface = previous) ); + TRACE( "trying to reuse previous surface %p\n", previous ); + } + else if (!win->parent || win->parent == get_desktop_window()) + { + *surface = &dummy_surface; /* provide a default surface for top-level windows */ + window_surface_add_ref( *surface ); + } + else + { + *surface = NULL; /* use parent surface for child windows */ + TRACE( "using parent window surface\n" ); + } + + release_win_ptr( win ); + return TRUE; +} /*********************************************************************** * apply_window_pos @@ -1812,19 +1840,15 @@ static BOOL apply_window_pos( HWND hwnd, HWND insert_after, UINT swp_flags, const RECT *window_rect, const RECT *client_rect, const RECT *valid_rects ) { WND *win; - HWND surface_win = 0, parent = NtUserGetAncestor( hwnd, GA_PARENT ); + HWND surface_win = 0; BOOL ret, needs_surface, needs_update = FALSE; RECT surface_rect, visible_rect = *window_rect, old_visible_rect, old_window_rect, old_client_rect, extra_rects[3]; - struct window_surface *old_surface, *new_surface = NULL; + struct window_surface *old_surface, *new_surface; needs_surface = user_driver->pWindowPosChanging( hwnd, swp_flags, window_rect, client_rect, &visible_rect ); if (!get_surface_rect( &visible_rect, &surface_rect )) needs_surface = FALSE; - if (!parent || parent == get_desktop_window()) - { - new_surface = &dummy_surface; /* provide a default surface for top-level windows */ - window_surface_add_ref( new_surface ); - } + if (!get_default_window_surface( hwnd, &surface_rect, &new_surface )) return FALSE; if (!needs_surface || IsRectEmpty( &visible_rect )) needs_surface = FALSE; /* use default surface */ else needs_surface = !user_driver->pCreateWindowSurface( hwnd, swp_flags, &surface_rect, &new_surface );

1 0

Rémi Bernon : winewayland: Clip huge window surfaces to the virtual screen rect.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: 970c3f9d42561456d88be60b35163bf6dd935c3e URL: https://gitlab.winehq.org/wine/wine/-/commit/970c3f9d42561456d88be60b35163b… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jun 19 18:15:53 2024 +0200 winewayland: Clip huge window surfaces to the virtual screen rect. --- dlls/winewayland.drv/waylanddrv.h | 3 +- dlls/winewayland.drv/window.c | 14 +++++---- dlls/winewayland.drv/window_surface.c | 55 +++++++++++++++++++++++++---------- 3 files changed, 49 insertions(+), 23 deletions(-) diff --git a/dlls/winewayland.drv/waylanddrv.h b/dlls/winewayland.drv/waylanddrv.h index d0a8977f887..28e754b6562 100644 --- a/dlls/winewayland.drv/waylanddrv.h +++ b/dlls/winewayland.drv/waylanddrv.h @@ -236,6 +236,7 @@ void wayland_output_use_xdg_extension(struct wayland_output *output); * Wayland surface */ +BOOL get_surface_rect(const RECT *visible_rect, RECT *surface_rect); struct wayland_surface *wayland_surface_create(HWND hwnd); void wayland_surface_destroy(struct wayland_surface *surface); void wayland_surface_make_toplevel(struct wayland_surface *surface); @@ -272,7 +273,7 @@ void wayland_shm_buffer_unref(struct wayland_shm_buffer *shm_buffer); * Wayland window surface */ -void wayland_window_surface_update_wayland_surface(struct window_surface *surface, +void wayland_window_surface_update_wayland_surface(struct window_surface *surface, const RECT *visible_rect, struct wayland_surface *wayland_surface); void wayland_window_flush(HWND hwnd); diff --git a/dlls/winewayland.drv/window.c b/dlls/winewayland.drv/window.c index 060a25d50c6..9d2432262b8 100644 --- a/dlls/winewayland.drv/window.c +++ b/dlls/winewayland.drv/window.c @@ -124,7 +124,7 @@ static void wayland_win_data_destroy(struct wayland_win_data *data) if (data->window_surface) { - wayland_window_surface_update_wayland_surface(data->window_surface, NULL); + wayland_window_surface_update_wayland_surface(data->window_surface, NULL, NULL); window_surface_release(data->window_surface); } if (data->wayland_surface) wayland_surface_destroy(data->wayland_surface); @@ -200,20 +200,20 @@ static void reapply_cursor_clipping(void) NtUserSetThreadDpiAwarenessContext(context); } -static void wayland_win_data_update_wayland_surface(struct wayland_win_data *data) +static void wayland_win_data_update_wayland_surface(struct wayland_win_data *data, const RECT *visible_rect) { struct wayland_surface *surface = data->wayland_surface; HWND parent = NtUserGetAncestor(data->hwnd, GA_PARENT); BOOL visible, xdg_visible; WCHAR text[1024]; - TRACE("hwnd=%p\n", data->hwnd); + TRACE("hwnd=%p, rect=%s\n", data->hwnd, wine_dbgstr_rect(visible_rect)); /* We don't want wayland surfaces for child windows. */ if (parent != NtUserGetDesktopWindow() && parent != 0) { if (data->window_surface) - wayland_window_surface_update_wayland_surface(data->window_surface, NULL); + wayland_window_surface_update_wayland_surface(data->window_surface, NULL, NULL); if (surface) wayland_surface_destroy(surface); surface = NULL; goto out; @@ -251,7 +251,7 @@ static void wayland_win_data_update_wayland_surface(struct wayland_win_data *dat pthread_mutex_unlock(&surface->mutex); if (data->window_surface) - wayland_window_surface_update_wayland_surface(data->window_surface, surface); + wayland_window_surface_update_wayland_surface(data->window_surface, visible_rect, surface); /* Size/position changes affect the effective pointer constraint, so update * it as needed. */ @@ -432,6 +432,7 @@ BOOL WAYLAND_WindowPosChanging(HWND hwnd, UINT swp_flags, const RECT *window_rec struct wayland_win_data *data = wayland_win_data_get(hwnd); HWND parent; BOOL visible, ret = FALSE; + RECT surface_rect; TRACE("hwnd %p window %s client %s visible %s flags %08x\n", hwnd, wine_dbgstr_rect(window_rect), wine_dbgstr_rect(client_rect), @@ -445,6 +446,7 @@ BOOL WAYLAND_WindowPosChanging(HWND hwnd, UINT swp_flags, const RECT *window_rec !(swp_flags & SWP_HIDEWINDOW); if ((parent && parent != NtUserGetDesktopWindow()) || !visible) goto done; /* use default surface */ + if (!get_surface_rect( visible_rect, &surface_rect )) goto done; /* use default surface */ ret = TRUE; @@ -484,7 +486,7 @@ void WAYLAND_WindowPosChanged(HWND hwnd, HWND insert_after, UINT swp_flags, if (data->window_surface) window_surface_release(data->window_surface); data->window_surface = surface; - wayland_win_data_update_wayland_surface(data); + wayland_win_data_update_wayland_surface(data, visible_rect); if (data->wayland_surface) wayland_win_data_update_wayland_state(data); wayland_win_data_release(data); diff --git a/dlls/winewayland.drv/window_surface.c b/dlls/winewayland.drv/window_surface.c index 9377b05b4ce..c557bd30fe4 100644 --- a/dlls/winewayland.drv/window_surface.c +++ b/dlls/winewayland.drv/window_surface.c @@ -283,8 +283,8 @@ static void copy_pixel_region(char *src_pixels, RECT *src_rect, if (!intersect_rect(&rc, rgn_rect, src_rect)) continue; if (!intersect_rect(&rc, &rc, dst_rect)) continue; - src = src_pixels + rc.top * src_stride + rc.left * bpp; - dst = dst_pixels + rc.top * dst_stride + rc.left * bpp; + src = src_pixels + (rc.top - src_rect->top) * src_stride + (rc.left - src_rect->left) * bpp; + dst = dst_pixels + (rc.top - dst_rect->top) * dst_stride + (rc.left - dst_rect->left) * bpp; width_bytes = (rc.right - rc.left) * bpp; height = rc.bottom - rc.top; @@ -346,7 +346,8 @@ static BOOL wayland_window_surface_flush(struct window_surface *window_surface, goto done; } - surface_damage_region = NtGdiCreateRectRgn(dirty->left, dirty->top, dirty->right, dirty->bottom); + surface_damage_region = NtGdiCreateRectRgn(rect->left + dirty->left, rect->top + dirty->top, + rect->left + dirty->right, rect->top + dirty->bottom); if (!surface_damage_region) { ERR("failed to create surface damage region\n"); @@ -486,7 +487,7 @@ failed: /*********************************************************************** * wayland_window_surface_update_wayland_surface */ -void wayland_window_surface_update_wayland_surface(struct window_surface *window_surface, +void wayland_window_surface_update_wayland_surface(struct window_surface *window_surface, const RECT *visible_rect, struct wayland_surface *wayland_surface) { struct wayland_window_surface *wws; @@ -497,27 +498,51 @@ void wayland_window_surface_update_wayland_surface(struct window_surface *window wws = wayland_window_surface_cast(window_surface); window_surface_lock(window_surface); - TRACE("surface=%p hwnd=%p wayland_surface=%p\n", wws, window_surface->hwnd, wayland_surface); + TRACE("surface=%p hwnd=%p visible_rect=%s wayland_surface=%p\n", wws, window_surface->hwnd, + wine_dbgstr_rect(visible_rect), wayland_surface); wws->wayland_surface = wayland_surface; - /* We only need a buffer queue if we have a surface to commit to. */ - if (wws->wayland_surface && !wws->wayland_buffer_queue) - { - wws->wayland_buffer_queue = - wayland_buffer_queue_create(wws->info.bmiHeader.biWidth, - abs(wws->info.bmiHeader.biHeight)); - } - else if (!wws->wayland_surface && wws->wayland_buffer_queue) + if (wws->wayland_buffer_queue) { wayland_buffer_queue_destroy(wws->wayland_buffer_queue); wws->wayland_buffer_queue = NULL; } + /* We only need a buffer queue if we have a surface to commit to. */ + if (wws->wayland_surface) + { + wws->wayland_buffer_queue = + wayland_buffer_queue_create(visible_rect->right - visible_rect->left, + visible_rect->bottom - visible_rect->top); + } + window_surface_unlock(window_surface); } +BOOL get_surface_rect(const RECT *visible_rect, RECT *surface_rect) +{ + RECT virtual_rect = NtUserGetVirtualScreenRect(); + + *surface_rect = *visible_rect; + + /* crop surfaces which are larger than the virtual screen rect, some applications create huge windows */ + if ((surface_rect->right - surface_rect->left > virtual_rect.right - virtual_rect.left || + surface_rect->bottom - surface_rect->top > virtual_rect.bottom - virtual_rect.top) && + !intersect_rect( surface_rect, surface_rect, &virtual_rect )) + return FALSE; + OffsetRect(surface_rect, -visible_rect->left, -visible_rect->top); + + /* round the surface coordinates to avoid re-creating them too often on resize */ + surface_rect->left &= ~127; + surface_rect->top &= ~127; + surface_rect->right = max(surface_rect->left + 128, (surface_rect->right + 127) & ~127); + surface_rect->bottom = max(surface_rect->top + 128, (surface_rect->bottom + 127) & ~127); + return TRUE; +} + + /*********************************************************************** * WAYLAND_CreateWindowSurface */ @@ -529,14 +554,12 @@ BOOL WAYLAND_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_ TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); if (!(data = wayland_win_data_get(hwnd))) return TRUE; /* use default surface */ + if (!get_surface_rect( visible_rect, &surface_rect )) goto done; /* use default surface */ /* Release the dummy surface wine provides for toplevels. */ if (*surface) window_surface_release(*surface); *surface = NULL; - surface_rect = *visible_rect; - OffsetRect(&surface_rect, -surface_rect.left, -surface_rect.top); - /* Check if we can reuse our current window surface. */ if (data->window_surface && EqualRect(&data->window_surface->rect, &surface_rect))

1 0

Rémi Bernon : win32u: Move the surface rect computation out of the drivers.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: b09249fdc640915aeb47012af486c8893c49ef81 URL: https://gitlab.winehq.org/wine/wine/-/commit/b09249fdc640915aeb47012af486c8… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Jun 25 23:10:10 2024 +0200 win32u: Move the surface rect computation out of the drivers. --- dlls/win32u/dce.c | 17 ++++++----------- dlls/win32u/driver.c | 2 +- dlls/win32u/win32u_private.h | 2 +- dlls/win32u/window.c | 30 +++++++++++++++++++++++++++--- dlls/wineandroid.drv/android.h | 2 +- dlls/wineandroid.drv/window.c | 34 ++++------------------------------ dlls/winemac.drv/macdrv.h | 3 +-- dlls/winemac.drv/surface.c | 32 ++++---------------------------- dlls/winemac.drv/window.c | 2 -- dlls/winewayland.drv/waylanddrv.h | 3 +-- dlls/winewayland.drv/window.c | 2 -- dlls/winewayland.drv/window_surface.c | 32 ++++---------------------------- dlls/winex11.drv/bitblt.c | 32 ++++---------------------------- dlls/winex11.drv/window.c | 2 -- dlls/winex11.drv/x11drv.h | 3 +-- 15 files changed, 55 insertions(+), 143 deletions(-)

1 0

Rémi Bernon : winemac: Clip huge surfaces to the virtual screen rect.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: 98c669b1c2bc281e54854f36db75cfd1fbd2aca8 URL: https://gitlab.winehq.org/wine/wine/-/commit/98c669b1c2bc281e54854f36db75cf… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jun 19 17:34:29 2024 +0200 winemac: Clip huge surfaces to the virtual screen rect. --- dlls/winemac.drv/cocoa_window.m | 9 +++++++++ dlls/winemac.drv/macdrv.h | 1 + dlls/winemac.drv/surface.c | 29 +++++++++++++++++++---------- dlls/winemac.drv/window.c | 2 ++ 4 files changed, 31 insertions(+), 10 deletions(-) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index caf06ff338f..a56dbbc4614 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -365,6 +365,7 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi @interface WineContentView : WineBaseView <NSTextInputClient, NSViewLayerContentScaleDelegate> { + CGRect surfaceRect; CGImageRef colorImage; NSMutableArray* glContexts; @@ -489,6 +490,7 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi self = [super initWithFrame:frame]; if (self) { + [self setLayerContentsPlacement:NSViewLayerContentsPlacementTopLeft]; [self setWantsLayer:YES]; [self setLayerRetinaProperties:retina_on]; [self setAutoresizesSubviews:NO]; @@ -552,6 +554,7 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi if (image) { + layer.position = surfaceRect.origin; layer.contents = (id)image; CFRelease(image); [window windowDidDrawContent]; @@ -567,6 +570,11 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi } } + - (void) setSurfaceRect:(CGRect)rect + { + surfaceRect = rect; + } + - (void) setColorImage:(CGImageRef)image { CGImageRelease(colorImage); @@ -3516,6 +3524,7 @@ void macdrv_window_set_color_image(macdrv_window w, CGImageRef image, CGRect rec WineContentView *view = [window contentView]; [view setColorImage:image]; + [view setSurfaceRect:cgrect_mac_from_win(rect)]; [view setNeedsDisplayInRect:NSRectFromCGRect(cgrect_mac_from_win(dirty))]; CGImageRelease(image); diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index 811947f723c..6863232b65a 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -208,6 +208,7 @@ extern macdrv_window macdrv_get_cocoa_window(HWND hwnd, BOOL require_on_screen); extern RGNDATA *get_region_data(HRGN hrgn, HDC hdc_lptodp); extern void activate_on_following_focus(void); extern void set_surface_use_alpha(struct window_surface *window_surface, BOOL use_alpha); +extern BOOL get_surface_rect(const RECT *visible_rect, RECT *surface_rect); extern void macdrv_handle_event(const macdrv_event *event); diff --git a/dlls/winemac.drv/surface.c b/dlls/winemac.drv/surface.c index 8b68d5d0ab5..7b4f744edba 100644 --- a/dlls/winemac.drv/surface.c +++ b/dlls/winemac.drv/surface.c @@ -225,16 +225,25 @@ void set_surface_use_alpha(struct window_surface *window_surface, BOOL use_alpha } -static inline RECT get_surface_rect(const RECT *visible_rect) +BOOL get_surface_rect(const RECT *visible_rect, RECT *surface_rect) { - RECT rect = *visible_rect; - - OffsetRect(&rect, -visible_rect->left, -visible_rect->top); - rect.left &= ~127; - rect.top &= ~127; - rect.right = max(rect.left + 128, (rect.right + 127) & ~127); - rect.bottom = max(rect.top + 128, (rect.bottom + 127) & ~127); - return rect; + RECT virtual_rect = NtUserGetVirtualScreenRect(); + + *surface_rect = *visible_rect; + + /* crop surfaces which are larger than the virtual screen rect, some applications create huge windows */ + if ((surface_rect->right - surface_rect->left > virtual_rect.right - virtual_rect.left || + surface_rect->bottom - surface_rect->top > virtual_rect.bottom - virtual_rect.top) && + !intersect_rect( surface_rect, surface_rect, &virtual_rect )) + return FALSE; + OffsetRect(surface_rect, -visible_rect->left, -visible_rect->top); + + /* round the surface coordinates to avoid re-creating them too often on resize */ + surface_rect->left &= ~127; + surface_rect->top &= ~127; + surface_rect->right = max(surface_rect->left + 128, (surface_rect->right + 127) & ~127); + surface_rect->bottom = max(surface_rect->top + 128, (surface_rect->bottom + 127) & ~127); + return TRUE; } @@ -250,11 +259,11 @@ BOOL macdrv_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_r TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); if (!(data = get_win_data(hwnd))) return TRUE; /* use default surface */ + if (!get_surface_rect( visible_rect, &surface_rect )) goto done; /* use default surface */ if (*surface) window_surface_release(*surface); *surface = NULL; - surface_rect = get_surface_rect(visible_rect); if (data->surface) { if (EqualRect(&data->surface->rect, &surface_rect)) diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 36f3e3053d6..0f38d96523e 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -1951,6 +1951,7 @@ BOOL macdrv_WindowPosChanging(HWND hwnd, UINT swp_flags, const RECT *window_rect { struct macdrv_win_data *data = get_win_data(hwnd); DWORD style = NtUserGetWindowLongW(hwnd, GWL_STYLE); + RECT surface_rect; BOOL ret = FALSE; TRACE("%p swp %04x window %s client %s visible %s\n", hwnd, @@ -1966,6 +1967,7 @@ BOOL macdrv_WindowPosChanging(HWND hwnd, UINT swp_flags, const RECT *window_rect if (!data->cocoa_window) goto done; /* use default surface */ if (swp_flags & SWP_HIDEWINDOW) goto done; /* use default surface */ if (data->ulw_layered) goto done; /* use default surface */ + if (!get_surface_rect( visible_rect, &surface_rect )) goto done; /* use default surface */ ret = TRUE;

1 0

Rémi Bernon : wineandroid: Only clip huge surfaces to the virtual screen rect.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: 28818df6500b71e1fb064bd9e1d0d65e654e2a6e URL: https://gitlab.winehq.org/wine/wine/-/commit/28818df6500b71e1fb064bd9e1d0d6… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jun 19 21:06:36 2024 +0200 wineandroid: Only clip huge surfaces to the virtual screen rect. --- dlls/wineandroid.drv/window.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/dlls/wineandroid.drv/window.c b/dlls/wineandroid.drv/window.c index 764b202d6e5..59f10adb60a 100644 --- a/dlls/wineandroid.drv/window.c +++ b/dlls/wineandroid.drv/window.c @@ -1121,10 +1121,20 @@ static struct android_win_data *create_win_data( HWND hwnd, const RECT *window_r } -static inline BOOL get_surface_rect( const RECT *visible_rect, RECT *surface_rect ) +static BOOL get_surface_rect( const RECT *visible_rect, RECT *surface_rect ) { - if (!intersect_rect( surface_rect, visible_rect, &virtual_screen_rect )) return FALSE; + RECT virtual_rect = NtUserGetVirtualScreenRect(); + + *surface_rect = *visible_rect; + + /* crop surfaces which are larger than the virtual screen rect, some applications create huge windows */ + if ((surface_rect->right - surface_rect->left > virtual_rect.right - virtual_rect.left || + surface_rect->bottom - surface_rect->top > virtual_rect.bottom - virtual_rect.top) && + !intersect_rect( surface_rect, surface_rect, &virtual_rect )) + return FALSE; OffsetRect( surface_rect, -visible_rect->left, -visible_rect->top ); + + /* round the surface coordinates to avoid re-creating them too often on resize */ surface_rect->left &= ~31; surface_rect->top &= ~31; surface_rect->right = max( surface_rect->left + 32, (surface_rect->right + 31) & ~31 );

1 0

Rémi Bernon : winex11: Only clip huge surfaces to the virtual screen rect.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: ba9e0b5522387f308c378199b1198f83643db12a URL: https://gitlab.winehq.org/wine/wine/-/commit/ba9e0b5522387f308c378199b1198f… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jun 19 21:34:24 2024 +0200 winex11: Only clip huge surfaces to the virtual screen rect. --- dlls/winex11.drv/bitblt.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/bitblt.c b/dlls/winex11.drv/bitblt.c index c4ae4dd522e..715d263028f 100644 --- a/dlls/winex11.drv/bitblt.c +++ b/dlls/winex11.drv/bitblt.c @@ -2186,10 +2186,18 @@ HRGN expose_surface( struct window_surface *window_surface, const RECT *rect ) BOOL get_surface_rect( const RECT *visible_rect, RECT *surface_rect ) { - *surface_rect = NtUserGetVirtualScreenRect(); + RECT virtual_rect = NtUserGetVirtualScreenRect(); - if (!intersect_rect( surface_rect, surface_rect, visible_rect )) return FALSE; + *surface_rect = *visible_rect; + + /* crop surfaces which are larger than the virtual screen rect, some applications create huge windows */ + if ((surface_rect->right - surface_rect->left > virtual_rect.right - virtual_rect.left || + surface_rect->bottom - surface_rect->top > virtual_rect.bottom - virtual_rect.top) && + !intersect_rect( surface_rect, surface_rect, &virtual_rect )) + return FALSE; OffsetRect( surface_rect, -visible_rect->left, -visible_rect->top ); + + /* round the surface coordinates to avoid re-creating them too often on resize */ surface_rect->left &= ~31; surface_rect->top &= ~31; surface_rect->right = max( surface_rect->left + 32, (surface_rect->right + 31) & ~31 );

1 0

Aurimas Fišeras : po: Update Lithuanian translation.
by Alexandre Julliard June 27, 2024

June 27, 2024

Module: wine Branch: master Commit: 1efd486f645a0016871490fef737cd2d27739600 URL: https://gitlab.winehq.org/wine/wine/-/commit/1efd486f645a0016871490fef737cd… Author: Aurimas Fišeras <aurimas(a)members.fsf.org> Date: Thu Jun 27 08:37:06 2024 +0300 po: Update Lithuanian translation. --- po/lt.po | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/po/lt.po b/po/lt.po index da7341b5c09..5c46c3f85d0 100644 --- a/po/lt.po +++ b/po/lt.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2024-06-25 00:23+0300\n" +"PO-Revision-Date: 2024-06-27 08:36+0300\n" "Last-Translator: Aurimas Fišeras <aurimas(a)members.fsf.org>\n" "Language-Team: Lithuanian <komp_lt(a)konf.lt>\n" "Language: lt\n" @@ -14586,10 +14586,8 @@ msgid "Syntax error: unexpected %1\n" msgstr "Sintaksės klaida: netikėtas %1\n" #: programs/cmd/cmd.rc:412 -#, fuzzy -#| msgid "End of file.\n" msgid "End of line" -msgstr "Failo pabaiga.\n" +msgstr "Eilutės pabaiga" #: programs/conhost/conhost.rc:54 msgid "Cursor size"

1 0

Esme Povirk : mscoree: Update Wine Mono to 9.2.0.
by Alexandre Julliard June 26, 2024

June 26, 2024

Module: wine Branch: master Commit: 07544942e2c9c2f35263adb5104998f18967dc6c URL: https://gitlab.winehq.org/wine/wine/-/commit/07544942e2c9c2f35263adb5104998… Author: Esme Povirk <esme(a)codeweavers.com> Date: Wed Jun 26 17:49:05 2024 +0000 mscoree: Update Wine Mono to 9.2.0. --- dlls/appwiz.cpl/addons.c | 4 ++-- dlls/mscoree/mscoree_private.h | 2 +- tools/gitlab/test.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c index 0b11a48b8fe..e5a509ab288 100644 --- a/dlls/appwiz.cpl/addons.c +++ b/dlls/appwiz.cpl/addons.c @@ -56,10 +56,10 @@ WINE_DEFAULT_DEBUG_CHANNEL(appwizcpl); #define GECKO_SHA "???" #endif -#define MONO_VERSION "9.1.0" +#define MONO_VERSION "9.2.0" #if defined(__i386__) || defined(__x86_64__) #define MONO_ARCH "x86" -#define MONO_SHA "8a0a1e6837b494df49927e5d759b1c6908e89b8a2f8e3ad025e1c2881882476e" +#define MONO_SHA "fd5829244d92985b8a404745adddb58c3a9b0bbb6d54ca4c6eaf86ea466735f9" #else #define MONO_ARCH "" #define MONO_SHA "???" diff --git a/dlls/mscoree/mscoree_private.h b/dlls/mscoree/mscoree_private.h index 9f73522c6c4..32c019cbb66 100644 --- a/dlls/mscoree/mscoree_private.h +++ b/dlls/mscoree/mscoree_private.h @@ -45,7 +45,7 @@ extern HRESULT assembly_get_runtime_version(ASSEMBLY *assembly, LPSTR *version); extern HRESULT assembly_get_vtable_fixups(ASSEMBLY *assembly, VTableFixup **fixups, DWORD *count); extern HRESULT assembly_get_native_entrypoint(ASSEMBLY *assembly, NativeEntryPointFunc *func); -#define WINE_MONO_VERSION "9.1.0" +#define WINE_MONO_VERSION "9.2.0" /* Mono embedding */ typedef struct _MonoDomain MonoDomain; diff --git a/tools/gitlab/test.yml b/tools/gitlab/test.yml index 882f67342a2..f49e935485a 100644 --- a/tools/gitlab/test.yml +++ b/tools/gitlab/test.yml @@ -7,7 +7,7 @@ variables: GIT_STRATEGY: none GECKO_VER: 2.47.4 - MONO_VER: 9.1.0 + MONO_VER: 9.2.0 cache: - key: wine-gecko-$GECKO_VER paths:

1 0

Rémi Bernon : server: Remove now unnecessary active_hooks from replies.
by Alexandre Julliard June 26, 2024

June 26, 2024

Module: wine Branch: master Commit: 817cb4dd696b8f9c9e118a29d949fa419a63bcaf URL: https://gitlab.winehq.org/wine/wine/-/commit/817cb4dd696b8f9c9e118a29d949fa… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jun 24 16:30:15 2024 +0200 server: Remove now unnecessary active_hooks from replies. --- include/wine/server_protocol.h | 10 +++------- server/hook.c | 4 ---- server/protocol.def | 4 ---- server/queue.c | 17 ----------------- server/request.h | 10 +++------- server/trace.c | 10 +--------- 6 files changed, 7 insertions(+), 48 deletions(-) diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index e78c3af4cc1..0516d23d3ee 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -2967,9 +2967,9 @@ struct get_message_reply int x; int y; unsigned int time; - unsigned int active_hooks; data_size_t total; /* VARARG(data,message_data); */ + char __pad_52[4]; }; @@ -4228,7 +4228,7 @@ struct set_hook_reply { struct reply_header __header; user_handle_t handle; - unsigned int active_hooks; + char __pad_12[4]; }; @@ -4244,8 +4244,6 @@ struct remove_hook_request struct remove_hook_reply { struct reply_header __header; - unsigned int active_hooks; - char __pad_12[4]; }; @@ -4267,9 +4265,7 @@ struct start_hook_chain_reply thread_id_t tid; int unicode; client_ptr_t proc; - unsigned int active_hooks; /* VARARG(module,unicode_str); */ - char __pad_36[4]; }; @@ -6591,7 +6587,7 @@ union generic_reply /* ### protocol_version begin ### */ -#define SERVER_PROTOCOL_VERSION 818 +#define SERVER_PROTOCOL_VERSION 819 /* ### protocol_version end ### */ diff --git a/server/hook.c b/server/hook.c index 3047f52492d..c2d2823cd61 100644 --- a/server/hook.c +++ b/server/hook.c @@ -486,7 +486,6 @@ DECL_HANDLER(set_hook) req->flags, req->proc, req->unicode, module, module_size ))) { reply->handle = hook->handle; - reply->active_hooks = get_active_hooks(); } else free( module ); @@ -525,7 +524,6 @@ DECL_HANDLER(remove_hook) } remove_hook( hook ); - reply->active_hooks = get_active_hooks(); } @@ -542,8 +540,6 @@ DECL_HANDLER(start_hook_chain) return; } - reply->active_hooks = get_active_hooks(); - if (!table || !(hook = get_first_valid_hook( table, req->id - WH_MINHOOK, req->event, req->window, req->object_id, req->child_id ))) { diff --git a/server/protocol.def b/server/protocol.def index 128aab3a812..33fd7a96e03 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2231,7 +2231,6 @@ enum message_type int x; /* message x position */ int y; /* message y position */ unsigned int time; /* message time */ - unsigned int active_hooks; /* active hooks bitmap */ data_size_t total; /* total size of extra data */ VARARG(data,message_data); /* message data for sent messages */ @END @@ -3035,7 +3034,6 @@ enum caret_state VARARG(module,unicode_str); /* module name */ @REPLY user_handle_t handle; /* handle to the hook */ - unsigned int active_hooks; /* active hooks bitmap */ @END @@ -3045,7 +3043,6 @@ enum caret_state client_ptr_t proc; /* hook procedure if handle is 0 */ int id; /* id of the hook if handle is 0 */ @REPLY - unsigned int active_hooks; /* active hooks bitmap */ @END @@ -3062,7 +3059,6 @@ enum caret_state thread_id_t tid; /* thread id for low-level keyboard/mouse hooks */ int unicode; /* is it a unicode hook? */ client_ptr_t proc; /* hook procedure */ - unsigned int active_hooks; /* active hooks bitmap */ VARARG(module,unicode_str); /* module name */ @END diff --git a/server/queue.c b/server/queue.c index f73beb3ce4c..53306f46793 100644 --- a/server/queue.c +++ b/server/queue.c @@ -625,21 +625,6 @@ void set_queue_hooks( struct thread *thread, struct hook_table *hooks ) queue->hooks = hooks; } -/* get the thread message queue active hooks bitmap */ -unsigned int get_active_hooks(void) -{ - unsigned int ret = 1u << 31; /* set high bit to indicate that the bitmap is valid */ - struct msg_queue *queue; - int bit; - - if (!(queue = current->queue)) return ret; - - for (bit = 0; bit < ARRAY_SIZE(queue->shared->hooks_count); bit++) - if (queue->shared->hooks_count[bit]) ret |= 1 << bit; - - return ret; -} - /* update the thread message queue hooks counters */ void add_queue_hook_count( struct thread *thread, unsigned int index, int count ) { @@ -3125,8 +3110,6 @@ DECL_HANDLER(get_message) user_handle_t get_win = get_user_full_handle( req->get_win ); unsigned int filter = req->flags >> 16; - reply->active_hooks = get_active_hooks(); - if (get_win && get_win != 1 && get_win != -1 && !get_user_object( get_win, USER_WINDOW )) { set_win32_error( ERROR_INVALID_WINDOW_HANDLE ); diff --git a/server/request.h b/server/request.h index 2dbde23f705..3944e754cfa 100644 --- a/server/request.h +++ b/server/request.h @@ -1430,8 +1430,7 @@ C_ASSERT( FIELD_OFFSET(struct get_message_reply, type) == 32 ); C_ASSERT( FIELD_OFFSET(struct get_message_reply, x) == 36 ); C_ASSERT( FIELD_OFFSET(struct get_message_reply, y) == 40 ); C_ASSERT( FIELD_OFFSET(struct get_message_reply, time) == 44 ); -C_ASSERT( FIELD_OFFSET(struct get_message_reply, active_hooks) == 48 ); -C_ASSERT( FIELD_OFFSET(struct get_message_reply, total) == 52 ); +C_ASSERT( FIELD_OFFSET(struct get_message_reply, total) == 48 ); C_ASSERT( sizeof(struct get_message_reply) == 56 ); C_ASSERT( FIELD_OFFSET(struct reply_message_request, remove) == 12 ); C_ASSERT( FIELD_OFFSET(struct reply_message_request, result) == 16 ); @@ -1863,14 +1862,12 @@ C_ASSERT( FIELD_OFFSET(struct set_hook_request, flags) == 40 ); C_ASSERT( FIELD_OFFSET(struct set_hook_request, unicode) == 44 ); C_ASSERT( sizeof(struct set_hook_request) == 48 ); C_ASSERT( FIELD_OFFSET(struct set_hook_reply, handle) == 8 ); -C_ASSERT( FIELD_OFFSET(struct set_hook_reply, active_hooks) == 12 ); C_ASSERT( sizeof(struct set_hook_reply) == 16 ); C_ASSERT( FIELD_OFFSET(struct remove_hook_request, handle) == 12 ); C_ASSERT( FIELD_OFFSET(struct remove_hook_request, proc) == 16 ); C_ASSERT( FIELD_OFFSET(struct remove_hook_request, id) == 24 ); C_ASSERT( sizeof(struct remove_hook_request) == 32 ); -C_ASSERT( FIELD_OFFSET(struct remove_hook_reply, active_hooks) == 8 ); -C_ASSERT( sizeof(struct remove_hook_reply) == 16 ); +C_ASSERT( sizeof(struct remove_hook_reply) == 8 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_request, id) == 12 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_request, event) == 16 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_request, window) == 20 ); @@ -1882,8 +1879,7 @@ C_ASSERT( FIELD_OFFSET(struct start_hook_chain_reply, pid) == 12 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_reply, tid) == 16 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_reply, unicode) == 20 ); C_ASSERT( FIELD_OFFSET(struct start_hook_chain_reply, proc) == 24 ); -C_ASSERT( FIELD_OFFSET(struct start_hook_chain_reply, active_hooks) == 32 ); -C_ASSERT( sizeof(struct start_hook_chain_reply) == 40 ); +C_ASSERT( sizeof(struct start_hook_chain_reply) == 32 ); C_ASSERT( FIELD_OFFSET(struct finish_hook_chain_request, id) == 12 ); C_ASSERT( sizeof(struct finish_hook_chain_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_hook_info_request, handle) == 12 ); diff --git a/server/trace.c b/server/trace.c index c1d25247611..36ff25afe6a 100644 --- a/server/trace.c +++ b/server/trace.c @@ -2805,7 +2805,6 @@ static void dump_get_message_reply( const struct get_message_reply *req ) fprintf( stderr, ", x=%d", req->x ); fprintf( stderr, ", y=%d", req->y ); fprintf( stderr, ", time=%08x", req->time ); - fprintf( stderr, ", active_hooks=%08x", req->active_hooks ); fprintf( stderr, ", total=%u", req->total ); dump_varargs_message_data( ", data=", cur_size ); } @@ -3656,7 +3655,6 @@ static void dump_set_hook_request( const struct set_hook_request *req ) static void dump_set_hook_reply( const struct set_hook_reply *req ) { fprintf( stderr, " handle=%08x", req->handle ); - fprintf( stderr, ", active_hooks=%08x", req->active_hooks ); } static void dump_remove_hook_request( const struct remove_hook_request *req ) @@ -3666,11 +3664,6 @@ static void dump_remove_hook_request( const struct remove_hook_request *req ) fprintf( stderr, ", id=%d", req->id ); } -static void dump_remove_hook_reply( const struct remove_hook_reply *req ) -{ - fprintf( stderr, " active_hooks=%08x", req->active_hooks ); -} - static void dump_start_hook_chain_request( const struct start_hook_chain_request *req ) { fprintf( stderr, " id=%d", req->id ); @@ -3687,7 +3680,6 @@ static void dump_start_hook_chain_reply( const struct start_hook_chain_reply *re fprintf( stderr, ", tid=%04x", req->tid ); fprintf( stderr, ", unicode=%d", req->unicode ); dump_uint64( ", proc=", &req->proc ); - fprintf( stderr, ", active_hooks=%08x", req->active_hooks ); dump_varargs_unicode_str( ", module=", cur_size ); } @@ -5143,7 +5135,7 @@ static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_set_caret_window_reply, (dump_func)dump_set_caret_info_reply, (dump_func)dump_set_hook_reply, - (dump_func)dump_remove_hook_reply, + NULL, (dump_func)dump_start_hook_chain_reply, NULL, (dump_func)dump_get_hook_info_reply,

1 0