- Wine-Commits - list.winehq.org

Jacek Caban : win32u: Use user message packing for LB_GETSELITEMS.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: c66984d17481ac336c1ed335d1e60f7a3da835f2 URL: https://gitlab.winehq.org/wine/wine/-/commit/c66984d17481ac336c1ed335d1e60f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 18 22:07:07 2023 +0200 win32u: Use user message packing for LB_GETSELITEMS. --- dlls/user32/winproc.c | 3 +-- dlls/win32u/message.c | 12 +++++++++--- dlls/win32u/tests/win32u.c | 6 ++++++ dlls/wow64win/user.c | 1 + 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index dc59413b048..a8524c746b3 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -875,9 +875,7 @@ BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam, case LB_SELECTSTRING: case CB_GETLBTEXT: case LB_GETTEXT: - break; case LB_GETSELITEMS: - if (!get_buffer_space( buffer, *wparam * sizeof(UINT), size )) return FALSE; break; case WM_NEXTMENU: { @@ -1063,6 +1061,7 @@ BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) case LB_SELECTSTRING: case CB_GETLBTEXT: case LB_GETTEXT: + case LB_GETSELITEMS: { LRESULT *result_ptr = (LRESULT *)buffer - 1; *result_ptr = result; diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index a32d4bfa1cf..bb052ade359 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -631,6 +631,9 @@ static BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lpa if (!get_buffer_space( buffer, size, prev_size )) return FALSE; break; } + case LB_GETSELITEMS: + if (!get_buffer_space( buffer, *wparam * sizeof(UINT), size )) return FALSE; + break; case WM_WINE_SETWINDOWPOS: { WINDOWPOS wp; @@ -1470,6 +1473,9 @@ size_t user_message_size( HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam, size = send_message_timeout( hwnd, LB_GETTEXTLEN, wparam, 0, SMTO_NORMAL, 0, ansi ); size = (size + 1) * char_size( ansi ); break; + case LB_GETSELITEMS: + size = wparam * sizeof(UINT); + break; } return size; @@ -1640,6 +1646,9 @@ static void copy_user_result( void *buffer, size_t size, LRESULT result, UINT me case EM_GETLINE: copy_size = string_size( buffer, ansi ); break; + case LB_GETSELITEMS: + copy_size = wparam * sizeof(UINT); + break; default: return; } @@ -1667,9 +1676,6 @@ static void copy_reply( LRESULT result, HWND hwnd, UINT message, WPARAM wparam, case WM_MOVING: copy_size = sizeof(RECT); break; - case LB_GETSELITEMS: - copy_size = wparam * sizeof(UINT); - break; case WM_MDIGETACTIVE: if (lparam) copy_size = sizeof(BOOL); break; diff --git a/dlls/win32u/tests/win32u.c b/dlls/win32u/tests/win32u.c index a435ca47bb4..d0f79b5c124 100644 --- a/dlls/win32u/tests/win32u.c +++ b/dlls/win32u/tests/win32u.c @@ -1681,6 +1681,7 @@ static void test_wndproc_hook(void) static const SCROLLBARINFO sbi_out = { .xyThumbTop = 60 }; static const DWORD dw_in = 1, dw_out = 2; static const UINT32 tabstops_in[2] = { 3, 4 }; + static const UINT32 items_out[2] = { 1, 2 }; static const struct lparam_hook_test lparam_hook_tests[] = { @@ -1891,6 +1892,11 @@ static void test_wndproc_hook(void) .lparam_size = sizeof(tabstops_in), .lparam = &tabstops_in, .poison_lparam = TRUE, .check_size = sizeof(tabstops_in), }, + { + "LB_GETSELITEMS", LB_GETSELITEMS, + .wparam = ARRAYSIZE(items_out), .msg_result = ARRAYSIZE(items_out), + .lparam_size = sizeof(items_out), .change_lparam = items_out, + }, /* messages that don't change lparam */ { "WM_USER", WM_USER }, { "WM_NOTIFY", WM_NOTIFY }, diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index c03fd4cabf9..326c9256f1d 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -846,6 +846,7 @@ static size_t packed_result_32to64( UINT message, WPARAM wparam, const void *par case EM_GETLINE: case CB_GETLBTEXT: case LB_GETTEXT: + case LB_GETSELITEMS: break; default:

1 0

Jacek Caban : win32u: Use user message packing for more messages passing string.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 216979bd08f98e0d1950060b54fb94c1c4e15860 URL: https://gitlab.winehq.org/wine/wine/-/commit/216979bd08f98e0d1950060b54fb94… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 18 20:34:57 2023 +0200 win32u: Use user message packing for more messages passing string. --- dlls/user32/winproc.c | 13 ++++++++++--- dlls/win32u/message.c | 22 ++++++++++++++++++++++ dlls/win32u/tests/win32u.c | 3 +++ 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index 92392622fc8..ff8f502a0c1 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -877,7 +877,6 @@ BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam, case EM_GETLINE: case EM_SETTABSTOPS: case LB_SETTABSTOPS: - break; case CB_ADDSTRING: case CB_INSERTSTRING: case CB_FINDSTRING: @@ -888,8 +887,6 @@ BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam, case LB_FINDSTRING: case LB_FINDSTRINGEXACT: case LB_SELECTSTRING: - if (!*buffer) return TRUE; - if (!check_string( *buffer, size )) return FALSE; break; case CB_GETLBTEXT: { @@ -1082,6 +1079,16 @@ BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) case EM_GETLINE: case EM_SETTABSTOPS: case LB_SETTABSTOPS: + case CB_ADDSTRING: + case CB_INSERTSTRING: + case CB_FINDSTRING: + case CB_FINDSTRINGEXACT: + case CB_SELECTSTRING: + case LB_ADDSTRING: + case LB_INSERTSTRING: + case LB_FINDSTRING: + case LB_FINDSTRINGEXACT: + case LB_SELECTSTRING: { LRESULT *result_ptr = (LRESULT *)buffer - 1; *result_ptr = result; diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index eb093fc2981..0c4b69c9a09 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -599,6 +599,18 @@ static BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lpa if (!*wparam) return TRUE; minsize = *wparam * sizeof(UINT); break; + case CB_ADDSTRING: + case CB_INSERTSTRING: + case CB_FINDSTRING: + case CB_FINDSTRINGEXACT: + case CB_SELECTSTRING: + case LB_ADDSTRING: + case LB_INSERTSTRING: + case LB_FINDSTRING: + case LB_FINDSTRINGEXACT: + case LB_SELECTSTRING: + if (!*buffer) return TRUE; + break; case WM_WINE_SETWINDOWPOS: { WINDOWPOS wp; @@ -1356,6 +1368,16 @@ size_t user_message_size( UINT message, WPARAM wparam, LPARAM lparam, BOOL other case LB_DIR: case LB_ADDFILE: case EM_REPLACESEL: + case CB_ADDSTRING: + case CB_INSERTSTRING: + case CB_FINDSTRING: + case CB_FINDSTRINGEXACT: + case CB_SELECTSTRING: + case LB_ADDSTRING: + case LB_INSERTSTRING: + case LB_FINDSTRING: + case LB_FINDSTRINGEXACT: + case LB_SELECTSTRING: if (other_process && lparam) size = string_size( lparam_ptr, ansi ); break; case WM_GETMINMAXINFO: diff --git a/dlls/win32u/tests/win32u.c b/dlls/win32u/tests/win32u.c index baa419bba4f..cbda77f99ac 100644 --- a/dlls/win32u/tests/win32u.c +++ b/dlls/win32u/tests/win32u.c @@ -1907,6 +1907,9 @@ static void test_wndproc_hook(void) { "LB_ADDFILE", LB_ADDFILE, .lparam = strbufW, .lparam_init_size = sizeof(strbufW) }, { "EM_REPLACESEL", EM_REPLACESEL, .lparam = strbufW, .lparam_init_size = sizeof(strbufW) }, { "WM_WININICHANGE", WM_WININICHANGE, .lparam = strbufW, .lparam_init_size = sizeof(strbufW) }, + { "CB_ADDSTRING", CB_ADDSTRING }, + { "CB_INSERTSTRING", CB_INSERTSTRING }, + { "LB_ADDSTRING", LB_ADDSTRING }, /* messages not allowed to be sent by NtUserMessageCall */ { "WM_DRAWITEM", WM_DRAWITEM, .wparam = 10,

1 0

Jacek Caban : win32u: Use user message packing for EM_SETTABSTOPS and LB_SETTABSTOPS.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 844177d5170563d1ff3af29d7fd6038bf6d5a5ac URL: https://gitlab.winehq.org/wine/wine/-/commit/844177d5170563d1ff3af29d7fd603… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 18 20:23:34 2023 +0200 win32u: Use user message packing for EM_SETTABSTOPS and LB_SETTABSTOPS. --- dlls/user32/winproc.c | 5 ++--- dlls/win32u/message.c | 9 +++++++++ dlls/win32u/tests/win32u.c | 16 ++++++++++++++-- 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index 202c955e152..92392622fc8 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -875,11 +875,8 @@ BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lparam, case EM_SETRECT: case EM_SETRECTNP: case EM_GETLINE: - break; case EM_SETTABSTOPS: case LB_SETTABSTOPS: - if (!*wparam) return TRUE; - minsize = *wparam * sizeof(UINT); break; case CB_ADDSTRING: case CB_INSERTSTRING: @@ -1083,6 +1080,8 @@ BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) case EM_SETRECT: case EM_SETRECTNP: case EM_GETLINE: + case EM_SETTABSTOPS: + case LB_SETTABSTOPS: { LRESULT *result_ptr = (LRESULT *)buffer - 1; *result_ptr = result; diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index d37b05ca1eb..eb093fc2981 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -594,6 +594,11 @@ static BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lpa *lparam = (LPARAM)(len_ptr + 1); return TRUE; } + case EM_SETTABSTOPS: + case LB_SETTABSTOPS: + if (!*wparam) return TRUE; + minsize = *wparam * sizeof(UINT); + break; case WM_WINE_SETWINDOWPOS: { WINDOWPOS wp; @@ -1410,6 +1415,10 @@ size_t user_message_size( UINT message, WPARAM wparam, LPARAM lparam, BOOL other case EM_GETLINE: size = max( *(WORD *)lparam * char_size( ansi ), sizeof(WORD) ); break; + case EM_SETTABSTOPS: + case LB_SETTABSTOPS: + size = wparam * sizeof(UINT); + break; } return size; diff --git a/dlls/win32u/tests/win32u.c b/dlls/win32u/tests/win32u.c index 4d88eeaee8b..baa419bba4f 100644 --- a/dlls/win32u/tests/win32u.c +++ b/dlls/win32u/tests/win32u.c @@ -1384,8 +1384,9 @@ static void check_params( const struct lparam_hook_test *test, UINT message, if (lparam == (LPARAM)lparam_buffer) return; - ok ((LPARAM)&message < lparam && lparam < (LPARAM)NtCurrentTeb()->Tib.StackBase, - "lparam is not on the stack\n"); + if (sizeof(void *) != 4 || (test->message != EM_SETTABSTOPS && test->message != LB_SETTABSTOPS)) + ok( (LPARAM)&message < lparam && lparam < (LPARAM)NtCurrentTeb()->Tib.StackBase, + "lparam is not on the stack\n"); switch (test->message) { @@ -1679,6 +1680,7 @@ static void test_wndproc_hook(void) static const SCROLLBARINFO sbi_in = { .xyThumbTop = 6 }; static const SCROLLBARINFO sbi_out = { .xyThumbTop = 60 }; static const DWORD dw_in = 1, dw_out = 2; + static const UINT32 tabstops_in[2] = { 3, 4 }; static const struct lparam_hook_test lparam_hook_tests[] = { @@ -1885,6 +1887,16 @@ static void test_wndproc_hook(void) .lparam = L"\x8""2345678", .lparam_size = sizeof(strbufW), .change_lparam = L"abc\0defg", .check_size = sizeof(WCHAR), .check_lparam = L"abc\0""5678", }, + { + "EM_SETTABSTOPS", EM_SETTABSTOPS, .wparam = ARRAYSIZE(tabstops_in), + .lparam_size = sizeof(tabstops_in), .lparam = &tabstops_in, .poison_lparam = TRUE, + .check_size = sizeof(tabstops_in), + }, + { + "LB_SETTABSTOPS", LB_SETTABSTOPS, .wparam = ARRAYSIZE(tabstops_in), + .lparam_size = sizeof(tabstops_in), .lparam = &tabstops_in, .poison_lparam = TRUE, + .check_size = sizeof(tabstops_in), + }, /* messages that don't change lparam */ { "WM_USER", WM_USER }, { "WM_NOTIFY", WM_NOTIFY },

1 0

Zhao Yi : comctl32/listview: Reset bNoItemMetrics to make sure that listview items can be arranged correctly.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 314c94e100907815c6932cfbedcddf231932630c URL: https://gitlab.winehq.org/wine/wine/-/commit/314c94e100907815c6932cfbedcddf… Author: Zhao Yi <zhaoyi(a)uniontech.com> Date: Wed Jul 26 21:00:29 2023 +0800 comctl32/listview: Reset bNoItemMetrics to make sure that listview items can be arranged correctly. Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> --- dlls/comctl32/listview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index 750e447dbef..7972be9669d 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -5590,6 +5590,7 @@ static BOOL LISTVIEW_DeleteAllItems(LISTVIEW_INFO *infoPtr, BOOL destroy) LISTVIEW_UpdateScroll(infoPtr); } LISTVIEW_InvalidateList(infoPtr); + infoPtr->bNoItemMetrics = TRUE; return TRUE; }

1 0

Sven Baars : wldap32: Fix a message leak in ldap_parse_resultW() (Valgrind).
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 2d17c0ff72cf7d250e85de48fe228f3b02828d19 URL: https://gitlab.winehq.org/wine/wine/-/commit/2d17c0ff72cf7d250e85de48fe228f… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 16:16:39 2023 +0200 wldap32: Fix a message leak in ldap_parse_resultW() (Valgrind). --- dlls/wldap32/parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wldap32/parse.c b/dlls/wldap32/parse.c index 26e8de14c85..9eff55e4f0e 100644 --- a/dlls/wldap32/parse.c +++ b/dlls/wldap32/parse.c @@ -188,6 +188,7 @@ ULONG CDECL ldap_parse_resultW( LDAP *ld, WLDAP32_LDAPMessage *result, ULONG *re if (referrals) *referrals = strarrayUtoW( referralsU ); if (serverctrls) *serverctrls = controlarrayUtoW( serverctrlsU ); + if (free) ldap_msgfree( result ); ldap_memfree( matchedU ); ldap_memfree( errorU ); ldap_memfree( referralsU );

1 0

Sven Baars : ldap: Free the output buffer after every InitializeSecurityContextA() call (Valgrind).
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 4fd56146a8e4d2387ff04cd15b96c542d06a10dc URL: https://gitlab.winehq.org/wine/wine/-/commit/4fd56146a8e4d2387ff04cd15b96c5… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 20:34:49 2023 +0200 ldap: Free the output buffer after every InitializeSecurityContextA() call (Valgrind). --- libs/ldap/libldap/tls_w.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libs/ldap/libldap/tls_w.c b/libs/ldap/libldap/tls_w.c index c798d4249c0..39cb5436053 100644 --- a/libs/ldap/libldap/tls_w.c +++ b/libs/ldap/libldap/tls_w.c @@ -228,7 +228,9 @@ tlsw_session_connect( LDAP *ld, tls_session *session, const char *name_in ) expected -= size; } - out_bufs[0].cbBuffer = max_token; + FreeContextBuffer( out_bufs[0].pvBuffer ); + out_bufs[0].pvBuffer = NULL; + status = InitializeSecurityContextA( &s->cred_handle, &s->ctxt_handle, (SEC_CHAR *)name_in, flags, 0, 0, &in_buf_desc, 0, NULL, &out_buf_desc, &attrs, NULL ); if ( status == SEC_E_INCOMPLETE_MESSAGE ) {

1 0

Sven Baars : wldap32: Fix a mod_type leak (Valgrind).
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: ca692fb39c7d8c1e0a579f50d84a60833d72066e URL: https://gitlab.winehq.org/wine/wine/-/commit/ca692fb39c7d8c1e0a579f50d84a60… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sun Jul 30 15:58:01 2023 +0200 wldap32: Fix a mod_type leak (Valgrind). --- dlls/wldap32/winldap_private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wldap32/winldap_private.h b/dlls/wldap32/winldap_private.h index e834f9d4e6f..ce9a7cc3fa8 100644 --- a/dlls/wldap32/winldap_private.h +++ b/dlls/wldap32/winldap_private.h @@ -868,6 +868,7 @@ static inline void modfreeU( LDAPMod *mod ) bvarrayfreeU( mod->mod_vals.modv_bvals ); else strarrayfreeU( mod->mod_vals.modv_strvals ); + free( mod->mod_type ); free( mod ); } @@ -1010,6 +1011,7 @@ static inline void modfreeW( LDAPModW *mod ) bvarrayfreeW( mod->mod_vals.modv_bvals ); else strarrayfreeW( mod->mod_vals.modv_strvals ); + free( mod->mod_type ); free( mod ); }

1 0

Piotr Caban : wineps.drv: Flush spool data even if there are no pages to print.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 3345404cbe5f5945e0fbc4d495db40365a9eda58 URL: https://gitlab.winehq.org/wine/wine/-/commit/3345404cbe5f5945e0fbc4d495db40… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Jul 31 15:31:40 2023 +0200 wineps.drv: Flush spool data even if there are no pages to print. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55291 --- dlls/wineps.drv/printproc.c | 1 + dlls/wineps.drv/ps.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index 72e5540b5be..b899814f8c1 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -3140,6 +3140,7 @@ BOOL WINAPI PrintDocumentOnPrintProcessor(HANDLE pp, WCHAR *doc_name) cleanup: if (data->ctx->job.PageNo) PSDRV_WriteFooter(data->ctx); + flush_spool(data->ctx); HeapFree(GetProcessHeap(), 0, data->ctx->job.doc_name); ClosePrinter(spool_data); diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index f9f54fa9bc6..a8050abe19b 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -502,7 +502,7 @@ INT PSDRV_WriteFooter( print_ctx *ctx ) sprintf(buf, psfooter, ctx->job.PageNo); - if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) || !flush_spool(ctx) ) { + if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); ret = 0; }

1 0

Alistair Leslie-Hughes : windowscodecs: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 0442d18363b0198b5a8109d354869d167761d201 URL: https://gitlab.winehq.org/wine/wine/-/commit/0442d18363b0198b5a8109d354869d… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Jul 29 18:14:17 2023 +1000 windowscodecs: Remove DECLSPEC_HIDDEN usage. --- dlls/windowscodecs/clsfactory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windowscodecs/clsfactory.c b/dlls/windowscodecs/clsfactory.c index 54cc154bb22..6832d984586 100644 --- a/dlls/windowscodecs/clsfactory.c +++ b/dlls/windowscodecs/clsfactory.c @@ -35,7 +35,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wincodecs); -extern HRESULT WINAPI WIC_DllGetClassObject(REFCLSID, REFIID, LPVOID *) DECLSPEC_HIDDEN; +extern HRESULT WINAPI WIC_DllGetClassObject(REFCLSID, REFIID, LPVOID *); typedef struct { REFCLSID classid;

1 0

Alistair Leslie-Hughes : hidclass.sys: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Aug. 1, 2023

Aug. 1, 2023

Module: wine Branch: master Commit: 88cc46593432fc6cc7568181a3c56c9221b4f9f5 URL: https://gitlab.winehq.org/wine/wine/-/commit/88cc46593432fc6cc7568181a3c56c… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sat Jul 29 18:16:28 2023 +1000 hidclass.sys: Remove DECLSPEC_HIDDEN usage. --- dlls/hidclass.sys/hid.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index b8cec55fb7c..3eefbf87f63 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -118,15 +118,15 @@ typedef struct _minidriver } minidriver; void call_minidriver( ULONG code, DEVICE_OBJECT *device, void *in_buff, ULONG in_size, - void *out_buff, ULONG out_size, IO_STATUS_BLOCK *io ) DECLSPEC_HIDDEN; + void *out_buff, ULONG out_size, IO_STATUS_BLOCK *io ); /* Internal device functions */ -void HID_StartDeviceThread(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; +void HID_StartDeviceThread( DEVICE_OBJECT *device ); void hid_queue_remove_pending_irps( struct hid_queue *queue ); void hid_queue_destroy( struct hid_queue *queue ); -NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_read(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_write(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_create(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; -NTSTATUS WINAPI pdo_close(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; +NTSTATUS WINAPI pdo_ioctl( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_read( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_write( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_create( DEVICE_OBJECT *device, IRP *irp ); +NTSTATUS WINAPI pdo_close( DEVICE_OBJECT *device, IRP *irp );

1 0