- Wine-Commits - list.winehq.org

Zebediah Figura : ddraw: Restructure ddraw_surface_create_wined3d_texture() to avoid gotos.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: b15339d4707964f46f7110546958d5b883bcc7c9 URL: https://gitlab.winehq.org/wine/wine/-/commit/b15339d4707964f46f7110546958d5… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sat Dec 24 16:30:36 2022 -0600 ddraw: Restructure ddraw_surface_create_wined3d_texture() to avoid gotos. And, more saliently, to allow moving more common code to the end of the function. --- dlls/ddraw/surface.c | 90 ++++++++++++++++++++++++++++------------------------ 1 file changed, 48 insertions(+), 42 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 3825a9d4075..e963d337ca3 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -6014,8 +6014,7 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, { struct wined3d_device *wined3d_device = ddraw->wined3d_device; const DDSURFACEDESC2 *desc = &texture->surface_desc; - struct wined3d_resource_desc draw_texture_desc; - struct wined3d_texture *draw_texture; + struct wined3d_texture *draw_texture = NULL; struct ddraw_surface *parent; unsigned int bind_flags; unsigned int i; @@ -6055,21 +6054,21 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, else if (desc->ddsCaps.dwCaps & DDSCAPS_3DDEVICE) bind_flags |= WINED3D_BIND_RENDER_TARGET; - if (!need_draw_texture(bind_flags, wined3d_desc)) - goto no_draw_texture; + if (need_draw_texture(bind_flags, wined3d_desc)) + { + struct wined3d_resource_desc draw_texture_desc; - draw_texture_desc = *wined3d_desc; - draw_texture_desc.bind_flags = bind_flags; - draw_texture_desc.access = WINED3D_RESOURCE_ACCESS_GPU; - draw_texture_desc.usage = WINED3DUSAGE_PRIVATE; + draw_texture_desc = *wined3d_desc; + draw_texture_desc.bind_flags = bind_flags; + draw_texture_desc.access = WINED3D_RESOURCE_ACCESS_GPU; + draw_texture_desc.usage = WINED3DUSAGE_PRIVATE; - if (FAILED(hr = wined3d_texture_create(wined3d_device, &draw_texture_desc, layers, - levels, 0, NULL, texture, &ddraw_texture_wined3d_parent_ops, &draw_texture))) - { - WARN("Failed to create draw texture, hr %#lx.\n", hr); - goto no_draw_texture; + if (SUCCEEDED(hr = wined3d_texture_create(wined3d_device, &draw_texture_desc, layers, + levels, 0, NULL, texture, &ddraw_texture_wined3d_parent_ops, &draw_texture))) + wined3d_texture_decref(draw_texture); + else + WARN("Failed to create draw texture, hr %#lx.\n", hr); } - wined3d_texture_decref(draw_texture); /* Some applications assume surfaces will always be mapped at the same * address. Some of those also assume that this address is valid even when @@ -6077,40 +6076,47 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, * visible on the screen. The game Nox is such an application, * Commandos: Behind Enemy Lines is another. Setting * WINED3D_TEXTURE_CREATE_GET_DC_LENIENT will ensure this. */ - if (FAILED(hr = wined3d_texture_create(wined3d_device, wined3d_desc, layers, levels, - WINED3D_TEXTURE_CREATE_GET_DC_LENIENT, NULL, NULL, &ddraw_null_wined3d_parent_ops, - wined3d_texture))) - { - parent = wined3d_texture_get_sub_resource_parent(draw_texture, 0); - if (texture->version == 7) - IDirectDrawSurface7_Release(&parent->IDirectDrawSurface7_iface); - else if (texture->version == 4) - IDirectDrawSurface4_Release(&parent->IDirectDrawSurface4_iface); - else - IDirectDrawSurface_Release(&parent->IDirectDrawSurface_iface); - return hr; + + if (draw_texture) + { + if (FAILED(hr = wined3d_texture_create(wined3d_device, wined3d_desc, + layers, levels, WINED3D_TEXTURE_CREATE_GET_DC_LENIENT, NULL, + NULL, &ddraw_null_wined3d_parent_ops, wined3d_texture))) + { + parent = wined3d_texture_get_sub_resource_parent(draw_texture, 0); + if (texture->version == 7) + IDirectDrawSurface7_Release(&parent->IDirectDrawSurface7_iface); + else if (texture->version == 4) + IDirectDrawSurface4_Release(&parent->IDirectDrawSurface4_iface); + else + IDirectDrawSurface_Release(&parent->IDirectDrawSurface_iface); + return hr; + } + + wined3d_resource_set_parent(wined3d_texture_get_resource(*wined3d_texture), texture); + for (i = 0; i < layers * levels; ++i) + { + parent = wined3d_texture_get_sub_resource_parent(draw_texture, i); + assert(parent->wined3d_texture == draw_texture); + parent->draw_texture = draw_texture; + parent->wined3d_texture = *wined3d_texture; + wined3d_texture_set_sub_resource_parent(*wined3d_texture, i, parent); + wined3d_texture_incref(*wined3d_texture); + } } - wined3d_resource_set_parent(wined3d_texture_get_resource(*wined3d_texture), texture); - for (i = 0; i < layers * levels; ++i) + else { - parent = wined3d_texture_get_sub_resource_parent(draw_texture, i); - assert(parent->wined3d_texture == draw_texture); - parent->draw_texture = draw_texture; - parent->wined3d_texture = *wined3d_texture; - wined3d_texture_set_sub_resource_parent(*wined3d_texture, i, parent); - wined3d_texture_incref(*wined3d_texture); + if (FAILED(hr = wined3d_texture_create(wined3d_device, wined3d_desc, + layers, levels, WINED3D_TEXTURE_CREATE_GET_DC_LENIENT, NULL, + texture, &ddraw_texture_wined3d_parent_ops, wined3d_texture))) + return hr; } + wined3d_texture_decref(*wined3d_texture); + TRACE("Surface %p, created draw_texture %p, wined3d_texture %p.\n", - wined3d_texture_get_sub_resource_parent(draw_texture, 0), draw_texture, wined3d_texture); + wined3d_texture_get_sub_resource_parent(*wined3d_texture, 0), draw_texture, *wined3d_texture); return D3D_OK; - -no_draw_texture: - if (SUCCEEDED(hr = wined3d_texture_create(wined3d_device, wined3d_desc, layers, levels, - WINED3D_TEXTURE_CREATE_GET_DC_LENIENT, NULL, texture, &ddraw_texture_wined3d_parent_ops, - wined3d_texture))) - wined3d_texture_decref(*wined3d_texture); - return hr; } HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_desc,

1 0

Rémi Bernon : win32u: Move window query functions around.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 30aa9055a0b59887cd2ef35e180ed07a58f98790 URL: https://gitlab.winehq.org/wine/wine/-/commit/30aa9055a0b59887cd2ef35e180ed0… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Mar 2 11:19:54 2023 +0100 win32u: Move window query functions around. --- dlls/win32u/input.c | 80 ++++++++++++++++++++++++++--------------------------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/dlls/win32u/input.c b/dlls/win32u/input.c index d7e502a4513..8735dc9fa74 100644 --- a/dlls/win32u/input.c +++ b/dlls/win32u/input.c @@ -535,6 +535,46 @@ static WCHAR kbd_tables_vkey_to_wchar( const KBDTABLES *tables, UINT vkey, const #undef NEXT_ENTRY +/******************************************************************* + * NtUserGetForegroundWindow (win32u.@) + */ +HWND WINAPI NtUserGetForegroundWindow(void) +{ + HWND ret = 0; + + SERVER_START_REQ( get_thread_input ) + { + req->tid = 0; + if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->foreground ); + } + SERVER_END_REQ; + return ret; +} + +/* see GetActiveWindow */ +HWND get_active_window(void) +{ + GUITHREADINFO info; + info.cbSize = sizeof(info); + return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndActive : 0; +} + +/* see GetCapture */ +HWND get_capture(void) +{ + GUITHREADINFO info; + info.cbSize = sizeof(info); + return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndCapture : 0; +} + +/* see GetFocus */ +HWND get_focus(void) +{ + GUITHREADINFO info; + info.cbSize = sizeof(info); + return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndFocus : 0; +} + /********************************************************************** * NtUserAttachThreadInput (win32u.@) */ @@ -1712,46 +1752,6 @@ BOOL WINAPI release_capture(void) return ret; } -/******************************************************************* - * NtUserGetForegroundWindow (win32u.@) - */ -HWND WINAPI NtUserGetForegroundWindow(void) -{ - HWND ret = 0; - - SERVER_START_REQ( get_thread_input ) - { - req->tid = 0; - if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->foreground ); - } - SERVER_END_REQ; - return ret; -} - -/* see GetActiveWindow */ -HWND get_active_window(void) -{ - GUITHREADINFO info; - info.cbSize = sizeof(info); - return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndActive : 0; -} - -/* see GetCapture */ -HWND get_capture(void) -{ - GUITHREADINFO info; - info.cbSize = sizeof(info); - return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndCapture : 0; -} - -/* see GetFocus */ -HWND get_focus(void) -{ - GUITHREADINFO info; - info.cbSize = sizeof(info); - return NtUserGetGUIThreadInfo( GetCurrentThreadId(), &info ) ? info.hwndFocus : 0; -} - /***************************************************************** * set_focus_window *

1 0

Zebediah Figura : ddraw: Move the wined3d_texture_update_desc() call into ddraw_surface_create_wined3d_texture().
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: eea1b79e24002c07ae44748ceb9bbf0fbd34c5bd URL: https://gitlab.winehq.org/wine/wine/-/commit/eea1b79e24002c07ae44748ceb9bbf… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Dec 22 16:34:29 2022 -0600 ddraw: Move the wined3d_texture_update_desc() call into ddraw_surface_create_wined3d_texture(). --- dlls/ddraw/surface.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index e963d337ca3..0a6381c184c 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -6017,6 +6017,7 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, struct wined3d_texture *draw_texture = NULL; struct ddraw_surface *parent; unsigned int bind_flags; + unsigned int pitch = 0; unsigned int i; HRESULT hr; @@ -6041,6 +6042,8 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, WARN("Invalid pitch %lu specified.\n", desc->u1.lPitch); return DDERR_INVALIDPARAMS; } + + pitch = desc->u1.lPitch; } } @@ -6112,6 +6115,14 @@ static HRESULT ddraw_surface_create_wined3d_texture(struct ddraw *ddraw, return hr; } + if ((desc->dwFlags & DDSD_LPSURFACE) && FAILED(hr = wined3d_texture_update_desc(*wined3d_texture, 0, + wined3d_desc->width, wined3d_desc->height, wined3d_desc->format, + WINED3D_MULTISAMPLE_NONE, 0, desc->lpSurface, pitch))) + { + ERR("Failed to set surface memory, hr %#lx.\n", hr); + return hr; + } + wined3d_texture_decref(*wined3d_texture); TRACE("Surface %p, created draw_texture %p, wined3d_texture %p.\n", @@ -6132,7 +6143,6 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ struct ddraw_texture *texture; BOOL sysmem_fallback = FALSE; unsigned int layers = 1; - unsigned int pitch = 0; BOOL reserve_memory; UINT levels, i, j; HRESULT hr; @@ -6579,8 +6589,6 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ heap_free(texture); return DDERR_INVALIDPARAMS; } - - pitch = desc->u1.lPitch; } } @@ -6706,14 +6714,6 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ } } - if ((desc->dwFlags & DDSD_LPSURFACE) && FAILED(hr = wined3d_texture_update_desc(wined3d_texture, 0, - wined3d_desc.width, wined3d_desc.height, wined3d_desc.format, - WINED3D_MULTISAMPLE_NONE, 0, desc->lpSurface, pitch))) - { - ERR("Failed to set surface memory, hr %#lx.\n", hr); - goto fail; - } - reserve_memory = !(desc->dwFlags & DDSD_LPSURFACE) && desc->ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY && wined3d_display_mode_format.u1.dwRGBBitCount <= 16;

1 0

Rémi Bernon : user32/tests: Add a WM_INPUTLANGCHANGE message test.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 3a4859e22db45289f9b02ea9ab1ccc150b638d19 URL: https://gitlab.winehq.org/wine/wine/-/commit/3a4859e22db45289f9b02ea9ab1ccc… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Mar 1 22:57:29 2023 +0100 user32/tests: Add a WM_INPUTLANGCHANGE message test. --- dlls/user32/tests/input.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 173 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index 7b155d80ede..8f3d5750c2f 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -3393,6 +3393,178 @@ static void test_keyboard_layout_name(void) free(layouts_preload); } +static HKL expect_hkl; +static HKL change_hkl; +static int got_setfocus; + +static LRESULT CALLBACK test_ActivateKeyboardLayout_window_proc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) +{ + ok( msg != WM_INPUTLANGCHANGEREQUEST, "got WM_INPUTLANGCHANGEREQUEST\n" ); + + if (msg == WM_SETFOCUS) got_setfocus = 1; + if (msg == WM_INPUTLANGCHANGE) + { + HKL layout = GetKeyboardLayout( 0 ); + CHARSETINFO info; + WCHAR klidW[64]; + UINT codepage; + LCID lcid; + + /* get keyboard layout lcid from its name, as the HKL might be aliased */ + GetKeyboardLayoutNameW( klidW ); + swscanf( klidW, L"%x", &lcid ); + lcid = LOWORD(lcid); + + if (!(HIWORD(layout) & 0x8000)) ok( lcid == HIWORD(layout), "got lcid %#lx\n", lcid ); + + GetLocaleInfoA( lcid, LOCALE_IDEFAULTANSICODEPAGE | LOCALE_RETURN_NUMBER, + (char *)&codepage, sizeof(codepage) ); + TranslateCharsetInfo( UlongToPtr( codepage ), &info, TCI_SRCCODEPAGE ); + + ok( !got_setfocus, "got WM_SETFOCUS before WM_INPUTLANGCHANGE\n" ); + ok( layout == expect_hkl, "got layout %p\n", layout ); + ok( wparam == info.ciCharset || broken(wparam == 0 && (HIWORD(layout) & 0x8000)), + "got wparam %#Ix\n", wparam ); + ok( lparam == (LPARAM)expect_hkl, "got lparam %#Ix\n", lparam ); + change_hkl = (HKL)lparam; + } + + return DefWindowProcW( hwnd, msg, wparam, lparam ); +} + +static DWORD CALLBACK test_ActivateKeyboardLayout_thread_proc( void *arg ) +{ + ActivateKeyboardLayout( arg, 0 ); + return 0; +} + +static void test_ActivateKeyboardLayout( char **argv ) +{ + HKL layout, tmp_layout, *layouts; + HWND hwnd1, hwnd2; + HANDLE thread; + UINT i, count; + DWORD ret; + + layout = GetKeyboardLayout( 0 ); + count = GetKeyboardLayoutList( 0, NULL ); + ok( count > 0, "GetKeyboardLayoutList returned %d\n", count ); + layouts = malloc( count * sizeof(HKL) ); + ok( layouts != NULL, "Could not allocate memory\n" ); + count = GetKeyboardLayoutList( count, layouts ); + ok( count > 0, "GetKeyboardLayoutList returned %d\n", count ); + + hwnd1 = CreateWindowA( "static", "static", WS_VISIBLE | WS_POPUP, + 100, 100, 100, 100, 0, NULL, NULL, NULL ); + ok( !!hwnd1, "CreateWindow failed, error %lu\n", GetLastError() ); + empty_message_queue(); + + SetWindowLongPtrA( hwnd1, GWLP_WNDPROC, (LONG_PTR)test_ActivateKeyboardLayout_window_proc ); + + for (i = 0; i < count; ++i) + { + BOOL broken_focus_activate = FALSE; + HKL other_layout = layouts[i]; + + winetest_push_context( "%08x / %08x", (UINT)(UINT_PTR)layout, (UINT)(UINT_PTR)other_layout ); + + /* test WM_INPUTLANGCHANGE message */ + + change_hkl = 0; + expect_hkl = other_layout; + got_setfocus = 0; + ActivateKeyboardLayout( other_layout, 0 ); + if (other_layout == layout) ok( change_hkl == 0, "got change_hkl %p\n", change_hkl ); + else todo_wine ok( change_hkl == other_layout, "got change_hkl %p\n", change_hkl ); + change_hkl = expect_hkl = 0; + + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == other_layout, "got tmp_layout %p\n", tmp_layout ); + + /* changing the layout from another thread doesn't send the message */ + + thread = CreateThread( NULL, 0, test_ActivateKeyboardLayout_thread_proc, layout, 0, 0 ); + ret = WaitForSingleObject( thread, 1000 ); + ok( !ret, "WaitForSingleObject returned %#lx\n", ret ); + CloseHandle( thread ); + + /* and has no immediate effect */ + + empty_message_queue(); + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == other_layout, "got tmp_layout %p\n", tmp_layout ); + + /* but the change only takes effect after focus changes */ + + hwnd2 = CreateWindowA( "static", "static", WS_VISIBLE | WS_POPUP, + 100, 100, 100, 100, 0, NULL, NULL, NULL ); + ok( !!hwnd2, "CreateWindow failed, error %lu\n", GetLastError() ); + + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == layout || broken(layout != other_layout && tmp_layout == other_layout) /* w7u */, + "got tmp_layout %p\n", tmp_layout ); + if (broken(layout != other_layout && tmp_layout == other_layout)) + { + win_skip( "Broken layout activation on focus change, skipping some tests\n" ); + broken_focus_activate = TRUE; + } + empty_message_queue(); + + /* only the focused window receives the WM_INPUTLANGCHANGE message */ + + ActivateKeyboardLayout( other_layout, 0 ); + ok( change_hkl == 0, "got change_hkl %p\n", change_hkl ); + + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == other_layout, "got tmp_layout %p\n", tmp_layout ); + + thread = CreateThread( NULL, 0, test_ActivateKeyboardLayout_thread_proc, layout, 0, 0 ); + ret = WaitForSingleObject( thread, 1000 ); + ok( !ret, "WaitForSingleObject returned %#lx\n", ret ); + CloseHandle( thread ); + + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == other_layout, "got tmp_layout %p\n", tmp_layout ); + + /* changing focus is enough for the layout change to take effect */ + + change_hkl = 0; + expect_hkl = layout; + got_setfocus = 0; + SetFocus( hwnd1 ); + + if (broken_focus_activate) + { + ok( got_setfocus == 1, "got got_setfocus %d\n", got_setfocus ); + ok( change_hkl == 0, "got change_hkl %p\n", change_hkl ); + got_setfocus = 0; + ActivateKeyboardLayout( layout, 0 ); + } + + if (other_layout == layout) ok( change_hkl == 0, "got change_hkl %p\n", change_hkl ); + else todo_wine ok( change_hkl == layout, "got change_hkl %p\n", change_hkl ); + change_hkl = expect_hkl = 0; + + tmp_layout = GetKeyboardLayout( 0 ); + todo_wine_if(layout != other_layout) + ok( tmp_layout == layout, "got tmp_layout %p\n", tmp_layout ); + + DestroyWindow( hwnd2 ); + empty_message_queue(); + + winetest_pop_context(); + } + + DestroyWindow( hwnd1 ); + + free( layouts ); +} + static void test_key_names(void) { char buffer[40]; @@ -4961,6 +5133,7 @@ START_TEST(input) test_ToAscii(); test_get_async_key_state(); test_keyboard_layout_name(); + test_ActivateKeyboardLayout( argv ); test_key_names(); test_attach_input(); test_GetKeyState();

1 0

Eric Pouech : dbghelp: Don't set ELF loader when wine's loader isn't accessible.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 9877ba97320e8786437d4465816e281ad8b527e2 URL: https://gitlab.winehq.org/wine/wine/-/commit/9877ba97320e8786437d4465816e28… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Mar 8 11:43:22 2023 +0100 dbghelp: Don't set ELF loader when wine's loader isn't accessible. For dbghelp in 32-bit, when accessing a live debuggee in multi-arch configuration, Wine's ELF loader is likely mapped above 4G, hence not accessible with 32bit Windows APIs. So don't try to expose the ELF libraries in that case. Introducing a new loader operation class to support live targets, for which system operations are not accessible, but pretending they are successful. Note: - when Wine's loader ELF module isn't registered by dbghelp, any other ELF module will not be registered by dbghelp. - further work may be needed for winedbg in auto mode (launched with AeDebug key on process exception) as in that mode winedbg doesn't relaunch itself in 64bit, so won't be able to access (64bit) ELF information (in multi-arch configuration). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/dbghelp_private.h | 1 + dlls/dbghelp/elf_module.c | 12 +++++++++--- dlls/dbghelp/module.c | 41 +++++++++++++++++++++++++++++++---------- dlls/dbghelp/tests/dbghelp.c | 1 - 4 files changed, 41 insertions(+), 14 deletions(-) diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index 1852aef1795..c11ccf81a92 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -716,6 +716,7 @@ void minidump_add_memory_block(struct dump_context* dc, ULONG64 base, ULONG size extern const WCHAR S_ElfW[] DECLSPEC_HIDDEN; extern const WCHAR S_WineLoaderW[] DECLSPEC_HIDDEN; extern const struct loader_ops no_loader_ops DECLSPEC_HIDDEN; +extern const struct loader_ops empty_loader_ops DECLSPEC_HIDDEN; extern BOOL module_init_pair(struct module_pair* pair, HANDLE hProcess, DWORD64 addr) DECLSPEC_HIDDEN; diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index 3c1e225e195..ee8315c4a23 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); struct elf_info { unsigned flags; /* IN one (or several) of the ELF_INFO constants */ - DWORD_PTR dbg_hdr_addr; /* OUT address of debug header (if ELF_INFO_DEBUG_HEADER is set) */ + DWORD64 dbg_hdr_addr; /* OUT address of debug header (if ELF_INFO_DEBUG_HEADER is set) */ struct module* module; /* OUT loaded module (if ELF_INFO_MODULE is set) */ const WCHAR* module_name; /* OUT found module name (if ELF_INFO_NAME is set) */ }; @@ -1769,8 +1769,14 @@ BOOL elf_read_wine_loader_dbg_info(struct process* pcs, ULONG_PTR addr) HeapFree(GetProcessHeap(), 0, loader); } if (!ret || !elf_info.dbg_hdr_addr) return FALSE; - - TRACE("Found ELF debug header %#Ix\n", elf_info.dbg_hdr_addr); + if (elf_info.dbg_hdr_addr != (ULONG_PTR)elf_info.dbg_hdr_addr) + { + ERR("Unable to access ELF libraries (outside 32bit limit)\n"); + module_remove(pcs, elf_info.module); + pcs->loader = &empty_loader_ops; + return FALSE; + } + TRACE("Found ELF debug header %#I64x\n", elf_info.dbg_hdr_addr); elf_info.module->format_info[DFI_ELF]->u.elf_info->elf_loader = 1; module_set_module(elf_info.module, S_WineLoaderW); pcs->dbg_hdr_addr = elf_info.dbg_hdr_addr; diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 8c7639dba38..ee559cfd99e 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -1548,11 +1548,6 @@ PVOID WINAPI SymFunctionTableAccess64(HANDLE hProcess, DWORD64 AddrBase) return module->cpu->find_runtime_function(module, AddrBase); } -static BOOL native_synchronize_module_list(struct process* pcs) -{ - return FALSE; -} - static struct module* native_load_module(struct process* pcs, const WCHAR* name, ULONG_PTR addr) { return NULL; @@ -1564,22 +1559,48 @@ static BOOL native_load_debug_info(struct process* process, struct module* modul return FALSE; } -static BOOL native_enum_modules(struct process *process, enum_modules_cb cb, void* user) +static BOOL native_fetch_file_info(struct process* process, const WCHAR* name, ULONG_PTR load_addr, DWORD_PTR* base, + DWORD* size, DWORD* checksum) { return FALSE; } -static BOOL native_fetch_file_info(struct process* process, const WCHAR* name, ULONG_PTR load_addr, DWORD_PTR* base, - DWORD* size, DWORD* checksum) +static BOOL noloader_synchronize_module_list(struct process* pcs) +{ + return FALSE; +} + +static BOOL noloader_enum_modules(struct process *process, enum_modules_cb cb, void* user) { return FALSE; } +static BOOL empty_synchronize_module_list(struct process* pcs) +{ + return TRUE; +} + +static BOOL empty_enum_modules(struct process *process, enum_modules_cb cb, void* user) +{ + return TRUE; +} + +/* to be used when debuggee isn't a live target */ const struct loader_ops no_loader_ops = { - native_synchronize_module_list, + noloader_synchronize_module_list, + native_load_module, + native_load_debug_info, + noloader_enum_modules, + native_fetch_file_info, +}; + +/* to be used when debuggee is a live target, but which system information isn't available */ +const struct loader_ops empty_loader_ops = +{ + empty_synchronize_module_list, native_load_module, native_load_debug_info, - native_enum_modules, + empty_enum_modules, native_fetch_file_info, }; diff --git a/dlls/dbghelp/tests/dbghelp.c b/dlls/dbghelp/tests/dbghelp.c index 445576532e6..339585993e0 100644 --- a/dlls/dbghelp/tests/dbghelp.c +++ b/dlls/dbghelp/tests/dbghelp.c @@ -735,7 +735,6 @@ static void test_loaded_modules(void) } ret = SymRefreshModuleList(pi.hProcess); - todo_wine_if(get_process_kind(pi.hProcess) == PCSKIND_WOW64) ok(ret || broken(GetLastError() == STATUS_PARTIAL_COPY /* Win11 in some cases */), "SymRefreshModuleList failed: %lu\n", GetLastError()); SymCleanup(pi.hProcess);

1 0

Eric Pouech : dbghelp/tests: Preserve last error in process_get_kind().
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: e1f41c0a174f874f8b19dbe813480a343d67f369 URL: https://gitlab.winehq.org/wine/wine/-/commit/e1f41c0a174f874f8b19dbe813480a… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Mar 8 11:43:22 2023 +0100 dbghelp/tests: Preserve last error in process_get_kind(). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/tests/dbghelp.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/dlls/dbghelp/tests/dbghelp.c b/dlls/dbghelp/tests/dbghelp.c index 07dfe6fbf6e..f6cea0125f4 100644 --- a/dlls/dbghelp/tests/dbghelp.c +++ b/dlls/dbghelp/tests/dbghelp.c @@ -564,7 +564,7 @@ enum process_kind PCSKIND_WOW64, /* Wine "new" wow64 configuration, and Windows with wow64 support */ }; -static enum process_kind get_process_kind(HANDLE process) +static enum process_kind get_process_kind_internal(HANDLE process) { USHORT m1, m2; @@ -601,6 +601,14 @@ static enum process_kind get_process_kind(HANDLE process) return PCSKIND_ERROR; } +static enum process_kind get_process_kind(HANDLE process) +{ + DWORD gle = GetLastError(); + enum process_kind pcskind = get_process_kind_internal(process); + SetLastError(gle); + return pcskind; +} + struct loaded_module_aggregation { HANDLE proc;

1 0

Rémi Bernon : user32/tests: Skip tests if layout failed to activate.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 9f072a273d35d29bd5ae09b9c6ba00ffd63236a6 URL: https://gitlab.winehq.org/wine/wine/-/commit/9f072a273d35d29bd5ae09b9c6ba00… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Mar 1 22:57:29 2023 +0100 user32/tests: Skip tests if layout failed to activate. --- dlls/user32/tests/input.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index c534880679a..7b155d80ede 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -3331,7 +3331,20 @@ static void test_keyboard_layout_name(void) for (i = len - 1; i >= 0; --i) { id = (DWORD_PTR)layouts[i]; + + winetest_push_context( "%08lx", id ); + ActivateKeyboardLayout(layouts[i], 0); + + tmplayout = GetKeyboardLayout(0); + todo_wine_if(tmplayout != layouts[i]) + ok( tmplayout == layouts[i], "Failed to activate keyboard layout\n"); + if (tmplayout != layouts[i]) + { + winetest_pop_context(); + continue; + } + GetKeyboardLayoutNameW(klid); for (j = 0; j < len; ++j) @@ -3370,6 +3383,8 @@ static void test_keyboard_layout_name(void) /* The layout name only depends on the keyboard layout: the high word of HKL. */ GetKeyboardLayoutNameW(tmpklid); ok(!wcsicmp(klid, tmpklid), "GetKeyboardLayoutNameW returned %s, expected %s\n", debugstr_w(tmpklid), debugstr_w(klid)); + + winetest_pop_context(); } ActivateKeyboardLayout(layout, 0);

1 0

Eric Pouech : dbghelp: Use 'wine' as loader on multi-arch configuration.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: aabb4e12bc3d3a8f0b5b8d301867cb4d7e039729 URL: https://gitlab.winehq.org/wine/wine/-/commit/aabb4e12bc3d3a8f0b5b8d301867cb… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Mar 8 11:43:22 2023 +0100 dbghelp: Use 'wine' as loader on multi-arch configuration. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/module.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index ad8ec22fe32..8c7639dba38 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -134,7 +134,7 @@ WCHAR *get_wine_loader_name(struct process *pcs) unsigned len; name = process_getenv(pcs, L"WINELOADER"); - if (!name) name = pcs->is_64bit ? L"wine64" : L"wine"; + if (!name) name = pcs->is_system_64bit ? L"wine64" : L"wine"; len = lstrlenW(name); /* WINELOADER isn't properly updated in Wow64 process calling inside Windows env block @@ -145,9 +145,14 @@ WCHAR *get_wine_loader_name(struct process *pcs) if (altname) { memcpy(altname, name, len * sizeof(WCHAR)); - if (pcs->is_64bit && len >= 2 && memcmp(name + len - 2, L"64", 2 * sizeof(WCHAR)) != 0) + if (pcs->is_system_64bit && len >= 2 && memcmp(name + len - 2, L"64", 2 * sizeof(WCHAR)) != 0) + { lstrcpyW(altname + len, L"64"); - else if (!pcs->is_64bit && len >= 2 && !memcmp(name + len - 2, L"64", 2 * sizeof(WCHAR))) + /* in multi-arch wow configuration, wine64 doesn't exist */ + if (GetFileAttributesW(altname) == INVALID_FILE_ATTRIBUTES) + altname[len] = L'\0'; + } + else if (!pcs->is_system_64bit && len >= 2 && !memcmp(name + len - 2, L"64", 2 * sizeof(WCHAR))) altname[len - 2] = '\0'; else altname[len] = '\0';

1 0

Eric Pouech : dbghelp: Fix vdso.so lookup.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 5477ee640b9d948cee8e4facec38ca0468372f61 URL: https://gitlab.winehq.org/wine/wine/-/commit/5477ee640b9d948cee8e4facec38ca… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Mar 8 11:43:22 2023 +0100 dbghelp: Fix vdso.so lookup. - should have been fixed when libwine.so has been removed - code was broken anyway - enhanced protect against error when reading debuggee's memory Introducing helper to correctly read pointer's from debuggee (and other integral values). vdso is now listed in ELF's module list (except if Wine's preloader removes it from auxilary vector) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/dbghelp_private.h | 9 +++++++++ dlls/dbghelp/elf_module.c | 44 +++++++++++++++++++++++++++--------------- 2 files changed, 37 insertions(+), 16 deletions(-) diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index c11ccf81a92..9a9773269af 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -523,6 +523,15 @@ static inline BOOL read_process_memory(const struct process *process, UINT64 add return ReadProcessMemory(process->handle, (void*)(UINT_PTR)addr, buf, size, NULL); } +static inline BOOL read_process_integral_value(const struct process* process, UINT64 addr, UINT64* pvalue, size_t size) +{ + /* Assuming that debugger and debuggee are little endian. */ + UINT64 value = 0; + if (size > sizeof(value) || !read_process_memory(process, addr, &value, size)) return FALSE; + *pvalue = value; + return TRUE; +} + struct line_info { ULONG_PTR is_first : 1, diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index ee8315c4a23..a2a60752a68 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -1339,39 +1339,51 @@ static BOOL elf_load_file_cb(void *param, HANDLE handle, const WCHAR *filename) /****************************************************************** * elf_search_auxv * - * locate some a value from the debuggee auxiliary vector + * Locate a value from the debuggee auxiliary vector */ static BOOL elf_search_auxv(const struct process* pcs, unsigned type, ULONG_PTR* val) { char buffer[sizeof(SYMBOL_INFO) + MAX_SYM_NAME]; SYMBOL_INFO*si = (SYMBOL_INFO*)buffer; - BYTE* addr; - BYTE* str; - BYTE* str_max; + const unsigned ptr_size = pcs->is_system_64bit ? 8 : 4; + UINT64 envp; + UINT64 addr; + UINT64 str; + UINT64 str_max; si->SizeOfStruct = sizeof(*si); si->MaxNameLen = MAX_SYM_NAME; - if (!SymFromName(pcs->handle, "libwine.so.1!__wine_main_environ", si) || - !(addr = (void*)(DWORD_PTR)si->Address) || - !ReadProcessMemory(pcs->handle, addr, &addr, sizeof(addr), NULL) || - !addr) + if (!SymFromName(pcs->handle, "ntdll.so!main_envp", si) || + !si->Address || + !read_process_integral_value(pcs, si->Address, &envp, ptr_size) || + !envp) { FIXME("can't find symbol in module\n"); return FALSE; } /* walk through envp[] */ /* envp[] strings are located after the auxiliary vector, so protect the walk */ - str_max = (void*)(DWORD_PTR)~0L; - while (ReadProcessMemory(pcs->handle, addr, &str, sizeof(str), NULL) && - (addr = (void*)((DWORD_PTR)addr + sizeof(str))) != NULL && str != NULL) - str_max = min(str_max, str); + str_max = ~(UINT64)0u; + addr = envp; + for (;;) + { + if (!read_process_integral_value(pcs, addr, &str, ptr_size) || (addr += ptr_size) <= ptr_size) + return FALSE; + if (!str) break; + /* It can be some env vars have been changed, pointing to a different location */ + if (str >= envp) + str_max = min(str_max, str); + } /* Walk through the end of envp[] array. * Actually, there can be several NULLs at the end of envp[]. This happens when an env variable is * deleted, the last entry is replaced by an extra NULL. */ - while (addr < str_max && ReadProcessMemory(pcs->handle, addr, &str, sizeof(str), NULL) && str == NULL) - addr = (void*)((DWORD_PTR)addr + sizeof(str)); + for (; addr < str_max; addr += ptr_size) + { + if (!read_process_integral_value(pcs, addr, &str, ptr_size)) return FALSE; + if (str) break; + } if (pcs->is_system_64bit) { @@ -1381,7 +1393,7 @@ static BOOL elf_search_auxv(const struct process* pcs, unsigned type, ULONG_PTR* UINT64 a_val; } auxv; - while (ReadProcessMemory(pcs->handle, addr, &auxv, sizeof(auxv), NULL) && auxv.a_type) + while (read_process_memory(pcs, addr, &auxv, sizeof(auxv)) && auxv.a_type) { if (auxv.a_type == type) { @@ -1399,7 +1411,7 @@ static BOOL elf_search_auxv(const struct process* pcs, unsigned type, ULONG_PTR* UINT32 a_val; } auxv; - while (ReadProcessMemory(pcs->handle, addr, &auxv, sizeof(auxv), NULL) && auxv.a_type) + while (read_process_memory(pcs, addr, &auxv, sizeof(auxv)) && auxv.a_type) { if (auxv.a_type == type) {

1 0

Eric Pouech : dbghelp/tests: Add tests for SymRefreshModuleList() on non-live target.
by Alexandre Julliard March 8, 2023

March 8, 2023

Module: wine Branch: master Commit: 0f98972fe2165d5eca52de48d8a6130de7e61a30 URL: https://gitlab.winehq.org/wine/wine/-/commit/0f98972fe2165d5eca52de48d8a613… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Mar 8 11:43:22 2023 +0100 dbghelp/tests: Add tests for SymRefreshModuleList() on non-live target. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/tests/dbghelp.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/dlls/dbghelp/tests/dbghelp.c b/dlls/dbghelp/tests/dbghelp.c index f6cea0125f4..445576532e6 100644 --- a/dlls/dbghelp/tests/dbghelp.c +++ b/dlls/dbghelp/tests/dbghelp.c @@ -424,6 +424,9 @@ static BOOL test_modules(void) ret = SymInitialize(dummy, NULL, FALSE); ok(ret, "got error %lu\n", GetLastError()); + ret = SymRefreshModuleList(dummy); + ok(!ret, "SymRefreshModuleList should have failed\n"); + count = get_module_count(dummy); ok(count == 0, "Unexpected count (%u instead of 0)\n", count); @@ -731,6 +734,10 @@ static void test_loaded_modules(void) } } + ret = SymRefreshModuleList(pi.hProcess); + todo_wine_if(get_process_kind(pi.hProcess) == PCSKIND_WOW64) + ok(ret || broken(GetLastError() == STATUS_PARTIAL_COPY /* Win11 in some cases */), "SymRefreshModuleList failed: %lu\n", GetLastError()); + SymCleanup(pi.hProcess); TerminateProcess(pi.hProcess, 0); @@ -766,6 +773,9 @@ static void test_loaded_modules(void) "Wrong directory aggregation count %u %u\n", aggregation.count_systemdir, aggregation.count_wowdir); + ret = SymRefreshModuleList(pi.hProcess); + ok(ret, "SymRefreshModuleList failed: %lu\n", GetLastError()); + SymCleanup(pi.hProcess); TerminateProcess(pi.hProcess, 0); } @@ -804,6 +814,9 @@ static void test_loaded_modules(void) "Wrong directory aggregation count %u %u\n", aggregation2.count_systemdir, aggregation2.count_wowdir); + ret = SymRefreshModuleList(pi.hProcess); + ok(ret, "SymRefreshModuleList failed: %lu\n", GetLastError()); + SymCleanup(pi.hProcess); TerminateProcess(pi.hProcess, 0); }

1 0