Alexandre Julliard pushed to branch master at wine / wine Commits: 72d74a82 by Francis De Brabandere at 2026-05-11T22:13:36+02:00 vbscript/tests: Cover cross-parse name redefinition semantics. Native VBScript treats top-level Dim as silently re-declarable across ParseScriptText calls, while Const and Class names cannot be reused once taken, and Sub/Function only conflict with an existing Class of the same name. Pin these rules with cross-parse tests covering each declaration kind paired with each other kind. Wine currently diverges on: - any decl followed by Dim (errs 1041, native accepts); - existing Class followed by Const/Sub/Function (silently allowed, native errs 1041). Marked as todo_wine pending the compile.c fix. - - - - - 1603181e by Francis De Brabandere at 2026-05-11T22:13:36+02:00 vbscript: Match native cross-parse name redefinition rules. Drop the over-aggressive var loop in check_script_collisions so that top-level Dim re-declarations across separate ParseScriptText calls silently succeed (matching native VBScript). Add cross-parse class collision checks for new Sub/Function declarations and Const decls so they error 1041 when the name is already taken by an existing class (also matching native). Removes the todo_wine markers added by the previous commit. - - - - - 2 changed files: - dlls/vbscript/compile.c - dlls/vbscript/tests/vbscript.c View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/58996cefc7188a9512a222371838ae... -- View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/58996cefc7188a9512a222371838ae... You're receiving this email because of your account on gitlab.winehq.org. Manage all notifications: https://gitlab.winehq.org/-/profile/notifications | Help: https://gitlab.winehq.org/help