October 2003 - Wine-Devel - list.winehq.org

RE: save up to 27% on gas
by Shawn Holman Oct. 12, 2003

Oct. 12, 2003

RE: save up to 27% on gas http://www.efnb.org

1 0

Re: Abort glyph rendering if everything is clipped
by Warren_Baird＠cimmetry.com Oct. 12, 2003

Oct. 12, 2003

> But then you are doing extra work for the "normal" case, and you are > also making the code less readable; not a good trade-off IMO. Well --- trading a memory allocation for an extra comparision instruction makes it a bit trickier to decide, but I take your point. > You > could always move the whole clipping rectangle stuff to avoid the > HeapAlloc (which would also fix a memory leak in the existing code...) > if you prefer. Unfortunately the clipping rectangle calculation is using the glyphs array that is allocated by the HeapAlloc. What I have right now is the clipping rectangle stuff after the HeapAlloc and GetGlyphIndicies call, and I've added code to free the allocated memory if we bail out... Here's what it looks like (my mailer will wrap lines at 72 characters --- If anyone knows how to disable that in NotesR5, *please* let me know!): (this is around line 940 in xrender.c) if(flags & ETO_GLYPH_INDEX) glyphs = (LPWORD)wstr; else { glyphs = HeapAlloc(GetProcessHeap(), 0, count * sizeof(WCHAR)); GetGlyphIndicesW(hdc, wstr, count, glyphs, 0); } if(flags & (ETO_CLIPPED | ETO_OPAQUE)) { if(!lprect) { if(flags & ETO_CLIPPED) { if(glyphs != wstr) HeapFree(GetProcessHeap(), 0, glyphs); return FALSE; } GetTextExtentPointI(hdc, glyphs, count, &sz); done_extents = TRUE; rc.left = x; rc.top = y; rc.right = x + sz.cx; rc.bottom = y + sz.cy; } else { if (IsRectEmpty(lprect)) { if(glyphs != wstr) HeapFree(GetProcessHeap(), 0, glyphs); return TRUE; } rc = *lprect; } LPtoDP(physDev->hdc, (POINT*)&rc, 2); if(rc.left > rc.right) {INT tmp = rc.left; rc.left = rc.right; rc.right = tmp;} if(rc.top > rc.bottom) {INT tmp = rc.top; rc.top = rc.bottom; rc.bottom = tmp;} } If this looks good, I can submit a new patch this afternoon... > But I think keeping that code readable is more > important than wringing every last nanosecond of the empty clip > rectangle case. I agree --- But I'd rather do both if we can. Warren

2 1

Re: patch for error handling after driver callback calls.
by Dave_Belanger＠cimmetry.com Oct. 12, 2003

Oct. 12, 2003

Hi Alexandre, I understand your idea and it makes perfect sense. Maybe the description of my patch wasn't clear enough. And maybe I shouldn't have changed SetTextColor and SetBkColor (that were actually the only callbacks that were well implemented on both the driver side and the the GDI). But if you look at most of the other callback implementations in the EMF and WMF drivers (SetTextAlign for example), you'll see that they only return TRUE or FALSE (the return value from WriteRecord) and not what the corresponding API function should return. So, the code that handles the callback return value doesn't interpret the return code correctly. There's clearly something wrong with some callbacks though. We just need to agree on a convention and respect it in all driver callbacks... So what if I regenerate a patch that looks like this in the case of SetTextAlign. Would you accept such a patch? ---------------------------------------------------------------------------------- --- wine-20030911/objects/dc.c Mon Oct 6 16:46:07 2003 +++ wine/objects/dc.c Fri Oct 10 11:39:43 2003 @@ -904,13 +904,17 @@ { UINT prevAlign; DC *dc = DC_GetDCPtr( hdc ); - if (!dc) return 0x0; - if (dc->funcs->pSetTextAlign) - prevAlign = dc->funcs->pSetTextAlign(dc->physDev, align); - else { - prevAlign = dc->textAlign; - dc->textAlign = align; + if (!dc) return GDI_ERROR; + prevAlign = dc->textAlign; + if (dc->funcs->pSetTextAlign) { + align = dc->funcs->pSetTextAlign(dc->physDev, align); + if (align == GDI_ERROR) { + /* don't change it */ + align = prevAlign; + prevAlign = GDI_ERROR; + } } + dc->textAlign = align; GDI_ReleaseObj( hdc ); return prevAlign; } --- wine-20030911/dlls/gdi/enhmfdrv/dc.c Wed Oct 8 10:58:22 2003 +++ wine/dlls/gdi/enhmfdrv/dc.c Fri Oct 10 11:45:50 2003 @@ -46,7 +46,8 @@ emr.emr.iType = EMR_SETTEXTALIGN; emr.emr.nSize = sizeof(emr); emr.iMode = align; - return EMFDRV_WriteRecord( dev, &emr.emr ); + return EMFDRV_WriteRecord( dev, &emr.emr )) + ? ((EMFDRV_PDEVICE*)dev)->dc->textAlign : GDI_ERROR; } INT EMFDRV_SetBkMode( PHYSDEV dev, INT mode ) ---------------------------------------------------------------------------------- Thanks. Dave Alexandre Julliard <julliard(a)winehq.com> on 10/09/2003 07:37:42 PM To: Dave Belanger/CSI(a)CSIDomain cc: wine-devel(a)winehq.com Subject: Re: patch for error handling after driver callback calls. Dave_Belanger(a)cimmetry.com writes: > (See attached file: patch_callbacks_return.txt) The idea is that the DC interface functions should behave just like the corresponding APIs, so if the API returns the old value the DC function should do that too. This way it guarantees that we can implement the full behavior of the API in the driver. -- Alexandre Julliard julliard(a)winehq.com

2 1

Start menu items
by Chris Hansen Oct. 11, 2003

Oct. 11, 2003

Hi, Sorry, but I'm not a member of this list, and I'm not into developing Wine. Though I read - with great pleasure - the weekly news on the website and saw a quote of Mike McCormack saying (or writing): "For starters we could just use the 'Start Menu' directory, but you miss out on things like Outlook Express and Internet Explorer's Icons, because there's no .lnk file for those... they are created by a shell namespace extension (I think :)." It is not correct that there isn't a .lnk file for these two programs in the Start Menu. Only on the Windows desktop these two are created with some namespace extension of some kind (with some registry values as I recall). In the Start Menu and the Quick Launch they are represented with a .lnk file as every other shortcut. Don't know if this information matter at all, but now you know :-) Regards Chris Hansen

1 0

Virus on the list
by Ivan Leo Murray-Smith Oct. 11, 2003

Oct. 11, 2003

Please remove the attachment of http://www.winehq.org/hypermail/wine-devel/2003/10/0337.html Ideally remove all the spam that got trough

1 0

Wine-devel You could have money coming
by Omar Meadows Oct. 11, 2003

Oct. 11, 2003

Hello, Who do you see more your boss or your kids? Looking for something powerful? Take the Free tour, and watch your business grow while you decide if it's right for you. Go To: http://19611961.da.ru You will be notified when "You have money coming"! Just visit http://19611961.da.ru Have an AWESOME day! y zo bubwz ueg

1 0

> >- SECRETS OF PRIVATE GIRLS a7 ma yxd tjx k i
by Tamera Rodriquez Oct. 11, 2003

Oct. 11, 2003

1 0

blxnd bcllwhack q raslkwdowzlhu
by Irvin Rodrigues Oct. 11, 2003

Oct. 11, 2003

Hydrocodone at a Discount Vicodin ES 90 Tab Special. Buy Now! Free Doctors consultation http://www.medscheap.biz/pharmplace take off list http://www.medscheap.biz/a.html hlt fco agpc

1 0

wine-announce-request@winehq.com , Make perfect quality backups of your DVD movies rnpsxpsjyfirhk
by Quinn Odonnell Oct. 11, 2003

Oct. 11, 2003

1 0

RE: new save up to 27% on gas rjfxb r
by Johnie Sheehan Oct. 11, 2003

Oct. 11, 2003

1 0