January 2004 - Wine-Devel - list.winehq.org

Re: Implement LockWindowUpdate [take 2]
by Alexandre Julliard Jan. 14, 2004

Jan. 14, 2004

Mike Hearn <mike(a)theoretic.com> writes: > The other reason it might have bounced is if we're not allowed to extend > WND, though as it's purely internal and not accessible from the APIs that > should be OK? I'm not sure how to do this otherwise without exporting the > currently locked window variable from USER to X11DRV which probably breaks > dll separation. Either that, or adding a new driver procedure. Extending the WND structure is OK (though it doesn't seem necessary in that case), but accessing it from x11drv is a violation of dll separation. We still do that in a number of places but they will have to be fixed, so we probably shouldn't add new ones. -- Alexandre Julliard julliard(a)winehq.com

2 2

Cdrom driver
by Robert Lunnon Jan. 13, 2004

Jan. 13, 2004

I have just finished embelishing the cdrom driver to support solaris but I have nothing to test it against. Can anyone recommend a good test program for excercising CDROM ioctls ? Thanks Bob

2 1

Re: Solaris compile time fixes for CVS wine
by Dimitrie O. Paun Jan. 13, 2004

Jan. 13, 2004

On January 8, 2004 01:22 am, Robert Lunnon wrote: > Here are a buch of Solais compatibility patches for wine (Some but not all > of them). Within the enclosed tarball the diffs are structured according to > the wine cvs tree. There is a readme file accompanying each diff to explain > what the change is. Please break the archive into one patch per message, not compressed (preferably inlined). Here are a few pointers on how to send patches: http://www.winehq.org/site/sending_patches BTW, what's the status of building Wine under Solaris? What architecture (i386, etc) are you using? -- Dimi.

4 3

Re: [Bug 521] WINE removes trailing backslash in GetFullPathNameA/W in dos_fs.c.
by Eric Pouech Jan. 13, 2004

Jan. 13, 2004

Mike McCormack a écrit : > > This closes bug 521, and removes a couple of wine_todos from the > regression test for pathes. The test for setting "lastpart" in both > GetFullPathNameA/W was wrong (would always pass). for the record, I also sent a patch regarding (among other things) this issue, which also has never been applied. I don't know Alexandre's state on this. A+

2 3

WWN Links are busted
by Tom Jan. 13, 2004

Jan. 13, 2004

Hi, If you try to go to a WWN article from the status page's they don't work. example : Wine's fundamental architecture #154 = http://www.winehq.com/site/status_wine?issue=154#Kernel%20Module%20/%20Shar… the current link is: <a href="?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a></td> when I think it should be: <a href="{$root}/site/?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a></td> Jeremey N is this correct? If so I can fix all the links in the next day or so.. Tom

2 1

Re: WWN Links are busted
by Brian Vincent (C) Jan. 13, 2004

Jan. 13, 2004

> the current link is: > <a > href="?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a> </td> I think it should be: href="/?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited" sed -e "s/href=\"\?/href=\"\/\?/g" --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Re: shell32 patches to be usable by ReactOS Explorer
by Alexandre Julliard Jan. 13, 2004

Jan. 13, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > This was no joke. If you say, you would accept such as reformating patch, > I can easyly create one that eliminates all tab-characters, and generates > nice and uniform indented code. > This will make it a bit easier to create the small self-contained patches > you want to see instead of the big one. As additional bonus you will get > a very better formated shell32 code base. There's no reason to reformat all of shell32. If a given function is messed up you can fix it (in a separate patch), but otherwise it doesn't really matter if all functions don't use the exact same style. -- Alexandre Julliard julliard(a)winehq.com

2 1

stray file
by Hans Leidekker Jan. 13, 2004

Jan. 13, 2004

Hi, There's a stray file, dlls/checklink.c, in Wine CVS with these contents: int main(void) { return 0; } It must be a leftover from a configure run. I suspected my own tree but but it came back after I removed it and did a cvs update. -Hans

4 4

Re: uxtheme: lots of infrastructure
by Alexandre Julliard Jan. 13, 2004

Jan. 13, 2004

Kevin Koltzau <kevin(a)plop.org> writes: > This is a ton of infrastructure for my future patches, and a full > implementation of GetThemeDocumentationProperty which I primarilly > used to test my INI file processing, and its now possible to set the > current theme through the API..not that its much use to do that yet The part about storing the string maps as resources seems unnecessarily complicated and inefficient. Why can't you store an array directly in the code? -- Alexandre Julliard julliard(a)winehq.com

2 4

[Janitorial] Remove CopyMetaFileW->A call
by Vincent Béron Jan. 13, 2004

Jan. 13, 2004

Indentation in CopyMetaFileW is a bit inconsistent (there are some tabs which I left since I didn't touch those lines). Should I redo my patch to get rid of them (adds some noise to the patch), keep them in a separate patch (limited to this very function) or leave it as is? Also, should I change MF_CreateMetaHeaderDisk to accept a LPCWSTR, even though it then needs to convert it back to Ascii, or is the proposed way sufficient? Changelog: Removed a W->A cross-call (CopyMetaFileW->CopyMetaFileA). Vincent

1 0