January 2004 - Wine-Devel - list.winehq.org

Re: Implemention of LockWindowUpdate
by Mike Hearn Jan. 13, 2004

Jan. 13, 2004

On Tue, 13 Jan 2004 00:10:20 +0000, Mike Hearn wrote: > This patch makes the halflife menu screen look a bit better, with less > flashing. Unfortunately it also makes it feel a bit slower, but I think > that's just an optical illusion caused by less screen activity. The > bottleneck is elsewhere. Just had a hunch, and yes, switching off XRender and antialiasing speeds things up nicely. I guess I should yell at keithp or something.... :)

1 0

Re: wine/ windows/scroll.c include/user.h dlls/x11 ...
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On Mon, 12 Jan 2004, Alexandre Julliard wrote: > Log message: > ScrollDC doesn't need to be in the graphics driver. Yay! (I submitted a similar patch some time ago, but you didn't like the {Start,End}GraphicsExposures functions. I still think they are decent GUI abstractions :)): http://www.winehq.com/hypermail/wine-patches/2002/09/0196.html Speaking of these things, I also don't think the driver should know about the caret. I see no need for the USER driver to know anything about the caret, we can just always implement it ourselves, no? http://www.winehq.com/hypermail/wine-patches/2002/09/0174.html I think there is a bug in the above patch (IIRC, I used to get some freezing in certain situations), but the idea still stands. -- Dimi.

2 1

Re: [WINEALSA] Add Midi IN support (take 3)
by Alexandre Julliard Jan. 12, 2004

Jan. 12, 2004

Christian Costa <titan.costa(a)wanadoo.fr> writes: > +static int npfd; > +static int pfd_array_size = 0; > +static struct pollfd *pfd = NULL; This isn't thread-safe. Why don't you simply allocate the array in the function and free it when you are done? -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: shell32 patches to be usable by ReactOS Explorer
by Martin Fuchs Jan. 12, 2004

Jan. 12, 2004

On 12.01.2004 01:41:45 Alexandre Julliard wrote: > "Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > > > Mhh - could you please tell me which "ugly hacks" you are speaking of? > > From a quick look at the patch, what I noticed is mostly the ifdefs > and other various disabling/commenting out of parts of the code. We had to disable some calls to internal functions, which are only exported from WINE, no real Windows OS. > There are also a number of unneeded whitespace changes that make the > patch larger than it should be. Yes, I tried to make some functions I had to alter a bit more readable. What about running a pretty printer, for example astyle (http://astyle.sourceforge.net/) on the whole code (or at least the shell32 directory) ? Some sections are currently indented with 2, some with 4 and some with 8 spaces - even mixed in the same function. Regards, Martin

1 1

Re: [Janitorial] ResetDCA->ResetDCW
by Dmitry Timoshkov Jan. 12, 2004

Jan. 12, 2004

"Vincent Beron" <vberon(a)mecano.gme.usherb.ca> wrote: > Changelog: > Get rid of a W->A crosscall (ResetDCA->ResetDCW). > -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode ) > +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode ) > { > - return ResetDCA(hdc, (const DEVMODEA*)devmode); /* FIXME */ > + DEVMODEW *devmodeW; > + HDC ret; > + > + if (devmode) devmodeW = GdiConvertToDevmodeW(devmode); > + else devmodeW = NULL; > + > + ret = ResetDCW(hdc, (const DEVMODEW*)devmode); It would be better to pass a real, newly allocated DEVMODEW* to ResetDCW(). That way you shouldn't need to cast type of a pointer. -- Dmitry.

2 1

Re: #2 - Mdi Win16/32 Split
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 2, 2004 10:31 am, Steven Edwards wrote: > Split up the Win16/32 MDI support a bit. Any idea what the status of the Win16/32 split is? What DLLs are still not properly split? -- Dimi.

4 11

Re: shell32 patches to be usable by ReactOS Explorer
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 11, 2004 08:04 am, Martin Fuchs wrote: > This patch consists of a number of changes we implemented in the ReactOS > CVS tree in order to use Wine's shell32.dll implementation for ReactOS > explorer. Please see the following changelog lists for the individual patch > descriptions: Martin, sending a bunch of patches compressed and in one message, makes them almost unreviewable but by the most die hards readers of wine-patches. It also makes it so much more difficult for Alexandre to split them up, match the ChangeLog, review them, etc. Please stick to one-(uncompressed, inlined)-patch-per-email-messsage rule, it's so much better for everybody. Here are some relevant links: http://www.winehq.org/site/sending_patches http://www.winehq.org/site/docs/wine-devel/patches -- Dimi.

4 6

Re: [Janitorial] ResetDCA->ResetDCW
by Dimitrie O. Paun Jan. 12, 2004

Jan. 12, 2004

On January 11, 2004 03:43 pm, Vincent Béron wrote: > Dimi, do you prefer to keep track of progress on this yourself, or > should I send a patch for the janitorial page too? It would be great if you'd send the update to the janitorial page. I try to keep track, but it's so much easier if patch authors lend a hand. But please wait until Alexandre commits it. -- Dimi.

1 0

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)
by Ivan Leo Murray-Smith Jan. 11, 2004

Jan. 11, 2004

> With this change, we can use the 6.3 version of Quicktime > to see streamed video from Wineconf... This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was written in the first place), maybe you should contact the author of the patch, a proper fix would be better, why should we chose between 2 games and quicktime? It should be possible to run all these apps. Ivan.

4 4

Re: [WINEALSA] Add Midi IN support (w/o alloca)
by Eric Pouech Jan. 11, 2004

Jan. 11, 2004

Christian Costa a écrit : > + for (wDevID = 0; wDevID < MIDM_NumDevs; wDevID++) > + if ( (ev->source.client == MidiInDev[wDevID].addr.client) && (ev->source.client == MidiInDev[wDevID].addr.client) ) > + break; Why do you do twice the same test ? A+

2 1