March 2005 - Wine-Devel - list.winehq.org

Re: Resend : Implements MIIM_BITMAP state in menus
by Alexandre Julliard March 7, 2005

March 7, 2005

Maxime Bellengé <maxime.bellenge(a)wanadoo.fr> writes: > + * drawhbmbitmap : True to draw the hbmbitmap(MIIM_BITMAP)/False to draw the MF_BITMAP > */ > -static void MENU_DrawBitmapItem( HDC hdc, MENUITEM *lpitem, const RECT *rect, BOOL menuBar ) > +static void MENU_DrawBitmapItem( HDC hdc, MENUITEM *lpitem, const RECT *rect, BOOL menuBar, BOOL drawhbmbitmap ) What's the point of passing the drawhbmbitmap flag since you always set it to TRUE? > @@ -762,14 +773,15 @@ > int h = rect->bottom - rect->top; > int bmp_xoffset = 0; > int left, top; > + HBITMAP swtch = (drawhbmbitmap)?lpitem->hbmpItem:(HBITMAP)lpitem->text; That's a strange variable name for a bitmap... > + /* New style MIIM_BITMAP */ > + if (lpitem->hbmpItem) > + { > + if (lpitem->hbmpItem == HBMMENU_CALLBACK) > + { > + MEASUREITEMSTRUCT measItem; > + measItem.CtlType = ODT_MENU; > + measItem.CtlID = 0; > + measItem.itemID = lpitem->wID; > + measItem.itemWidth = lpitem->rect.right - lpitem->rect.left; > + measItem.itemHeight = lpitem->rect.bottom - lpitem->rect.top; > + measItem.itemData = lpitem->dwItemData; > + > + SendMessageW( hwndOwner, WM_MEASUREITEM, lpitem->wID, (LPARAM)&measItem); > + > + /* Keep the size of the bitmap in callback mode to be able to draw it correctly */ > + lppop->bmpSize.cx = max(lppop->bmpSize.cx, measItem.itemWidth - (lpitem->rect.right - lpitem->rect.left)); > + lppop->bmpSize.cy = max(lppop->bmpSize.cy, measItem.itemHeight - (lpitem->rect.bottom - lpitem->rect.top)); Why do you store the bitmap size in the parent popup? What if there are multiple items with bitmaps? -- Alexandre Julliard julliard(a)winehq.org

2 2

Trace from Page Plus 5
by Andrew Neil Ramage March 7, 2005

March 7, 2005

I tried to start Page Plus 5, a DTP program from Serif. I was presented with a dialog asking for me to select a printer. When I OK'ed that, with the splash screen still showing, wine crashed. Here is the trace. [andrew(a)zeus Program]$ wine pp.exe fixme:commdlg:PRINTDLG_OpenDefaultPrinter Could not open printer EPSONStylusC42?! fixme:commdlg:PRINTDLG_OpenDefaultPrinter Could not open printer EPSONStylusC42?! wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00447977). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00447977 ESP:406aeadc EBP:406aeb00 EFLAGS:00210206( - 00 - RIP1) EAX:00000000 EBX:4056c508 ECX:00000002 EDX:406ae940 ESI:40361bfe EDI:00631c67 Stack dump: 0x406aeadc: 00000000 406aec5c 00001012 00000000 0x406aeaec: 00000000 406aec58 00631c67 40361bfe 0x406aeafc: 4056c508 406aecd4 0044988c 00000000 0x406aeb0c: 406aec5c 00000003 406aec58 00631c67 0x406aeb1c: 40361bfe 4056c508 406aeb40 406aeb84 0x406aeb2c: 00000040 406aec34 40045bd3 4020b864 Backtrace: =>1 0x00447977 in pp (+0x47977) (0x406aeb00) 2 0x0044988c in pp (+0x4988c) (0x406aecd4) 3 0x004c804b in pp (+0xc804b) (0x406af370) 4 0x0048a5c6 in pp (+0x8a5c6) (0x406af390) 5 0x0048a2f5 in pp (+0x8a2f5) (0x406af7c4) 6 0x0043acff in pp (+0x3acff) (0x406afe54) 7 0x0043b32f in pp (+0x3b32f) (0x406afe98) 8 0x00631d89 EntryPoint+0x122 in pp (0x406aff2c) 9 0x404d7db8 start_process+0xc8(arg=0x0) [/home/andrew/Download/Software/wine-20050211/dlls/kernel/process.c:1046] in kernel32 (0x406afff4) 10 0x40027dcd wine_pthread_abort_thread+0x2d(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x00447977: movl 0x0(%eax),%eax Wine-dbg> -- Andrew [hackcoughsniffle] Internal Virus Database corrupt

1 0

Re: fix wrc to parse some Borland dialog resources
by Filip Navara March 7, 2005

March 7, 2005

Michael Lin wrote: > * change wrc to parse '&' and '~' when specifying style I believe the attached patch would be better solution...you can use arbitrary expressions in the style definitions with Microsoft Resource Compiler... Regards, Filip

2 1

Wine logo (the glass)
by Dimitrie O. Paun March 7, 2005

March 7, 2005

Folks, do we have an .svg version of the logo? If so, where can I get it from? -- Dimi.

2 1

winebuild changes
by Dimitrie O. Paun March 7, 2005

March 7, 2005

Hi Alexandre, Ivan found that on Windows .exe's can export functions, just like DLLs. He needs this for his work on ntoskrnl.exe. To support this, we need a bit of an interface change to winebuild. I've put together a simple patch to see if you are OK with such a change. If so, I'll finish it, and modify winegcc accordingly. So, thing will change as follows: OLD: winebuild --dll=mystuff.spec NEW: winebuild --dll -E mystuff.spec OLD: winebuild --def=mystuff.spec NEW: winebuild --def -E mystuff.spec OLD: winebuild --exe=myprog.exe NEW: winebuild --exe -F myprog.exe to build an .exe with arbitrary exports, we would do: winebuild --exe -F myprog.exe -E mystuff.spec Index: tools/winebuild/main.c =================================================================== RCS file: /var/cvs/wine/tools/winebuild/main.c,v retrieving revision 1.59 diff -u -r1.59 main.c --- tools/winebuild/main.c 7 Dec 2004 17:19:54 -0000 1.59 +++ tools/winebuild/main.c 7 Mar 2005 01:50:44 -0000 @@ -144,6 +144,7 @@ " -C --source-dir=DIR Look for source files in DIR\n" " -d --delay-lib=LIB Import the specified library in delayed mode\n" " -D SYM Ignored for C flags compatibility\n" +" -E --export=FILE Export the symbols defined in the .spec or .def file\n" " -e --entry=FUNC Set the DLL entry point function (default: DllMain)\n" " -f FLAGS Compiler flags (only -fPIC is supported)\n" " -F --filename=DLLFILE Set the DLL filename (default: from input file name)\n" @@ -165,9 +166,9 @@ " --version Print the version and exit\n" " -w --warnings Turn on warnings\n" "\nMode options:\n" -" --dll=FILE Build a .c file from a .spec or .def file\n" -" --def=FILE.SPEC Build a .def file from a spec file\n" -" --exe=NAME Build a .c file for the named executable\n" +" --dll Build a .c file from a .spec or .def file\n" +" --def Build a .def file from a spec file\n" +" --exe Build a .c file for the named executable\n" " --debug [FILES] Build a .c file with the debug channels declarations\n" " --relay16 Build the 16-bit relay assembly routines\n" " --relay32 Build the 32-bit relay assembly routines\n\n" @@ -204,6 +205,7 @@ /* aliases for short options */ { "source-dir", 1, 0, 'C' }, { "delay-lib", 1, 0, 'd' }, + { "export", 1, 0, 'E' }, { "entry", 1, 0, 'e' }, { "filename", 1, 0, 'F' }, { "help", 0, 0, 'h' }, @@ -248,6 +250,10 @@ case 'D': /* ignored */ break; + case 'E': + spec_file_name = xstrdup( optarg ); + set_dll_file_name( optarg, spec ); + break; case 'F': spec->file_name = xstrdup( optarg ); break; @@ -324,21 +330,12 @@ break; case LONG_OPT_DLL: set_exec_mode( MODE_DLL ); - spec_file_name = xstrdup( optarg ); - set_dll_file_name( optarg, spec ); break; case LONG_OPT_DEF: set_exec_mode( MODE_DEF ); - spec_file_name = xstrdup( optarg ); - set_dll_file_name( optarg, spec ); break; case LONG_OPT_EXE: set_exec_mode( MODE_EXE ); - if ((p = strrchr( optarg, '/' ))) p++; - else p = optarg; - spec->file_name = xmalloc( strlen(p) + 5 ); - strcpy( spec->file_name, p ); - if (!strchr( spec->file_name, '.' )) strcat( spec->file_name, ".exe" ); if (!spec->subsystem) spec->subsystem = IMAGE_SUBSYSTEM_WINDOWS_GUI; break; case LONG_OPT_DEBUG: -- Dimi.

2 1

Where are Wine's webserver logs?
by Scott Ritchie March 7, 2005

March 7, 2005

I'd like to do some datamining around the Wine server logs to see where people are linked to from offsite the most, where they deadend, and such. But, I don't have any logs to mine. Can someone make the past few months logs available? Thanks, Scott Ritchie

2 1

Re: Re: [x11drv] Fix X11DRV_set_wm_hints
by Maxime BELLENGE March 7, 2005

March 7, 2005

> Message du 07/03/05 06:01 > De : "Dmitry Timoshkov" <dmitry(a)baikal.ru> > A : "Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> > Copie à : wine-devel(a)winehq.com > Objet : Re: [x11drv] Fix X11DRV_set_wm_hints > > "Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> wrote: > > > I don't agree with you because, if the application don't call this with > > the HTCAPTION parameter > > > > PostMessage( WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM( point.x, > > point.y)); > > > > but with HTLEFT, HTRIGHT ... the WM must resize the window I think. > > > > I wondered first if MWM_FUNC_RESIZE should be added but I think it is > > correct. > > If WS_THICKFRAME style is not set, then a window is not supposed to be > resized by WM, that's the point. SetWindowPos still will be able to resize > a window. > > -- > Dmitry. > Ok, I've re-read the docs and you're right. Sorry to have insisted wrongly and thanks for making me notice the problem. I will resend a correct patch. Maxime

1 0

FlashFXP v 3.01 and wine + Odin
by Dietrich Teickner March 7, 2005

March 7, 2005

Currently I have tested FlashFXP v3.01 (ftp-client with ssl) with wine, after I found it chrashs in Odin with stack-overflow. And I found FlashFXP stops after the same actiom in wine. I think that is the same message-loop, that I found in odin. with SysListView 68000034 LVM_SETITEMSTATE in comctl32 and WM_NOTIFY in user32 t01 ( 4): (code=-150) t01 ( 4): USER32: GetWindowLongW 68000034 fffffff4 t01 ( 4): USER32: GetWindowLongW returned 68000034 t01 ( 4): USER32: SendMessageW 68000033 4e 68000034 12f25c t01 ( 5): SendMessageW WM_NOTIFY for 68000033 68000034 12f25c t01 ( 5): USER32: GetWindowThreadProcessId 68000034 12ee9c t01 ( 5): USER32: GetWindowThreadProcessId returned 27470001 t01 ( 5): KERNEL32: GetCurrentProcessId t01 ( 5): KERNEL32: GetCurrentProcessId returned 2747 t01 ( 5): USER32: GetPropA 68000034 f22b t01 ( 5): USER32: GetPropA returned 20035a04 t01 ( 5): USER32: SendMessageA 68000034 102b 0 12eb68 t01 ( 6): SendMessageA User Message 102B (WM_USER+3115) for 68000034 0 12eb68 t01 ( 7): USER32: GetWindowLongW 68000034 0 t01 ( 7): USER32: GetWindowLongW returned 2d45570 t01 ( 7): SysListView 68000034 LVM_SETITEMSTATE 0 12eb68 t01 ( 7): wvsnprintfA : 168D8038 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D804E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=2, t01 ( 7): lvItem={iItem=0, iSubItem=0, state=0, stateMask=2} t01 ( 7): wvsnprintfA : 168D8138 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D814E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=2, t01 ( 7): (lpLVItem={iItem=0, iSubItem=0, state=0, stateMask=2}, isW=1) t01 ( 7): () t01 ( 7): wvsnprintfA : 168D8238 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D824E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=ffffffff, t01 ( 7): wvsnprintfA : 168D826B 205 "lParam=%lx, " t01 ( 7): lParam=0, t01 ( 7): (lpLVItem={iItem=0, iSubItem=0, state=0, stateMask=ffffffff, lParam=0}, isW=1) t01 ( 7): wvsnprintfA : 168D8338 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D834E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=f00, t01 ( 7): pdi->item={iItem=0, iSubItem=0, state=0, stateMask=f00} t01 ( 7): (code=-150) the child ask the parent, this ask the child, this ask the parrennt, this..... never end, only if the stack at end. Dietrich

2 1

Re: [x11drv] Fix X11DRV_set_wm_hints
by Dmitry Timoshkov March 7, 2005

March 7, 2005

"Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> wrote: > This patch adds MWM_FUNC_MOVE | MWM_FUNC_RESIZE when WS_EX_APPWINDOW. > Now the windows are movable. I think that MWM_FUNC_RESIZE should be added only for windows with WS_THICKFRAME style set. -- Dmitry.

2 2

AUTO3STATE with BS_OWNERDRAW bug?
by Michael Lin March 6, 2005

March 6, 2005

Hi all, I am having problem with AUTO3STATE control that have BS_OWNERDRAW style set. Dialogs with this control will not show at all. For example, I have a control AUTO3STATE "Text", 103, 10, 9, 149, 47, BS_OWNERDRAW | WS_CHILD | WS_VISIBLE | WS_TABSTOP in my dialog resource and the dialog won't show when it is called. But when I change it to CONTROL "Text", 103, "BUTTON", BS_OWNERDRAW | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 10, 9, 149, 47 the dialog works fine. This seems like a bug to me, does anyone else have seen this problem? Thanks, Michael

1 0