November 2006 - Wine-Devel - list.winehq.org

Re: Regression: broken locale in 0.9.25
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

As glibc manual http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library.html says: QUOTE When you read the current locale for category LC_ALL, the value encodes the entire combination of selected locales for all categories. In this case, the value is not just a single locale name. In fact, we don't make any promises about what it looks like. But if you specify the same "locale name" with LC_ALL in a subsequent call to setlocale, it restores the same combination of locale selections. END OF QUOTE So, any calls setlocale(LC_ALL, *) with analyzing the return value should be eliminated. Moreover, variable LC_ALL may be absent (my case). Quick solution: diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c index 9a72a4c..1ac2b4c 100644 --- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c @@ -512,7 +512,10 @@ static LCID get_env_lcid( UINT *unix_cp, char *buf, *lang,*country,*charset,*dialect,*next; LCID ret = 0; - if ((lang = setlocale( category, NULL )) && *lang) + if (category == LC_ALL) lang = getenv("LC_ALL"); + else lang = setlocale(category, NULL); + if (!lang || !*lang) lang = getenv("LANG"); + if (lang && *lang) { if (!strcmp(lang,"POSIX") || !strcmp(lang,"C")) goto done;

1 0

Regression: broken locale in 0.9.25
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

Hi, all! The following patch: http://www.winehq.org/pipermail/wine-cvs/2006-November/027599.html breaks locale with wine. I get several messages: Warning: Language 'LC_CTYPE=ru_RU' was not recognized, defaulting to English. Warning: Language 'LC_CTYPE=ru_RU' was not recognized, defaulting to English. and, as result, fonts are broken too. The reason is in the following piece of patch: - if (((lang = getenv( "LC_ALL" )) && *lang) || - (env_str && (lang = getenv( env_str )) && *lang) || - ((lang = getenv( "LANG" )) && *lang) || - ((lang = user_locale) && *lang)) + if ((lang = setlocale( category, NULL )) && *lang) LC_ALL variable contains single locale, e.g. "ru_RU.KOI8-R", but function setlocale(LC_ALL, NULL) returns: LC_CTYPE=ru_RU.KOI8-R;LC_NUMERIC=ru_RU.KOI8-R;LC_TIME=ru_RU.KOI8-R;LC_COLLATE=C;LC_MONETARY=ru_RU.KOI8-R;LC_MESSAGES=ru_RU.KOI8-R;LC_PAPER=ru_RU.KOI8-R;LC_NAME=ru_RU.KOI8-R;LC_ADDRESS=ru_RU.KOI8-R;LC_TELEPHONE=ru_RU.KOI8-R;LC_MEASUREMENT=ru_RU.KOI8-R;LC_IDENTIFICATION=ru_RU.KOI8-R which is incorrectly parsed. -- Kirill K. Smirnov

1 0

What about improve D3D in wine?
by Mirek Nov. 10, 2006

Nov. 10, 2006

Hi i have found Nvidia SDK programs and demos, i can install it in wine and some D3D demos can even run, but almost all are someway broken, in Nvidia SDK there are even source codes for those demos, what about start improving Direct3D in wine with help of this demos? It should be easy to track what is wrong and what is right. Here is link: http://www.nvidia.com/object/sdk_home.html Mirek

2 1

Re: server: Avoid accessing free'd thread pointers.
by Eric Pouech Nov. 10, 2006

Nov. 10, 2006

IMO this should be fixed by rewriting correctly the _SAFE version of the list macros, which are to blame here. I have this somewhere, I'll send it later on. 2006/11/10, Mike McCormack <mike(a)codeweavers.com>: > > --- > server/process.c | 28 ++++++++++++++++++++++++---- > 1 files changed, 24 insertions(+), 4 deletions(-) > > > > > > > -- Eric Pouech

4 10

Regression: bug #6560
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

Hi! The following patch: http://www.winehq.org/pipermail/wine-cvs/2006-September/025991.html [ 106156cb7597cf6f077b6f4e9d7562d8932fd766 is first bad commit commit 106156cb7597cf6f077b6f4e9d7562d8932fd766 Author: Robert Shearman <rob(a)codeweavers.com> Date: Mon Sep 11 11:14:25 2006 +0100 ole32: Remove some assertions in the stuctured storage code by returning error codes to the caller and by handling the error condition. :040000 040000 a17e245c7e40f15678aa2a78709ec927fb456d40 e25ebc1996d61a0d34658b4c09434705e9245512 M dlls ] caused the bug #6560 I do not understand the true reasons. The reason of it lurks somewhere in installation process (installation of Office), but no reasonable messages on console. Any ideas? -- Kirill K. Smirnov

1 0

Regression in patch: OpenGL32: remove glx context
by Mirek Nov. 10, 2006

Nov. 10, 2006

This patch broke nvidia SDK opengl demos, i cant run it with this patch. Here is some small report from terminal: cvswine glsl_bump_mapping.exe err:wgl:process_attach X11DRV or GDI32 not loaded. Cannot create default context. err:module:LdrInitializeThunk "opengl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"G:\\usr\\games\\nvidiaSDK\\DEMOS\\OpenGL\\bin\\Release\\glsl_bump_mapping.exe" failed, status c0000142 Mirek Roderick Colenbrander napsal(a): > Hi, > > This patch removes creation of a GLX context at opengl32 startup. > > The old code created a GLX context at startup, so that programs could call glGet* functions like glGetString before creating an OpenGL context. The OpenGL standards don't allow this and I verified this on winxp/win98 and as expected calling glGet* before creating a context returns NULL as documented everywhere. > > The the code was originally added for a game called Homeworld which called wglGet* before creating a context. Atleast the first version of the game made this call but I haven't seen this behaviour in the source code of the game (which is public). Most likely it was a bug in the first version of the game. > > Regards, > Roderick Colenbrander > > > ------------------------------------------------------------------------ > > --- dlls/opengl32/wgl.c 2006-11-03 22:35:06.000000000 +0100 > +++ dlls/opengl32/wgl.c 2006-11-03 16:47:33.000000000 +0100 > @@ -74,9 +74,6 @@ > void (*wine_tsx11_lock_ptr)(void) = NULL; > void (*wine_tsx11_unlock_ptr)(void) = NULL; > > -static GLXContext default_cx = NULL; > -static Display *default_display; /* display to use for default context */ > - > static HMODULE opengl32_handle; > > static char internal_gl_disabled_extensions[512]; > @@ -107,17 +104,6 @@ > return; > } > > -/* retrieve the X display to use on a given DC */ > -inline static Display *get_display( HDC hdc ) > -{ > - Display *display; > - enum x11drv_escape_codes escape = X11DRV_GET_DISPLAY; > - > - if (!ExtEscape( hdc, X11DRV_ESCAPE, sizeof(escape), (LPCSTR)&escape, > - sizeof(display), (LPSTR)&display )) display = NULL; > - return display; > -} > - > /*********************************************************************** > * wglCreateLayerContext (OPENGL32.@) > */ > @@ -635,19 +621,12 @@ > creating a rendering context.... */ > static BOOL process_attach(void) > { > - XWindowAttributes win_attr; > - Visual *rootVisual; > - int num; > - XVisualInfo template; > - HDC hdc; > - XVisualInfo *vis = NULL; > - Window root = (Window)GetPropA( GetDesktopWindow(), "__wine_x11_whole_window" ); > HMODULE mod = GetModuleHandleA( "winex11.drv" ); > HMODULE mod_gdi32 = GetModuleHandleA( "gdi32.dll" ); > DWORD size = sizeof(internal_gl_disabled_extensions); > HKEY hkey = 0; > > - if (!root || !mod || !mod_gdi32) > + if (!mod || !mod_gdi32) > { > ERR("X11DRV or GDI32 not loaded. Cannot create default context.\n"); > return FALSE; > @@ -661,40 +640,6 @@ > /* Interal WGL function */ > wine_wgl.p_wglGetIntegerv = (void *)wine_wgl.p_wglGetProcAddress("wglGetIntegerv"); > > - hdc = GetDC(0); > - default_display = get_display( hdc ); > - ReleaseDC( 0, hdc ); > - if (!default_display) > - { > - ERR("X11DRV not loaded. Cannot get display for screen DC.\n"); > - return FALSE; > - } > - > - ENTER_GL(); > - > - /* Try to get the visual from the Root Window. We can't use the standard (presumably > - double buffered) X11DRV visual with the Root Window, since we don't know if the Root > - Window was created using the standard X11DRV visual, and glXMakeCurrent can't deal > - with mismatched visuals. Note that the Root Window visual may not be double > - buffered, so apps actually attempting to render this way may flicker */ > - if (XGetWindowAttributes( default_display, root, &win_attr )) > - { > - rootVisual = win_attr.visual; > - } > - else > - { > - /* Get the default visual, since we can't seem to get the attributes from the > - Root Window. Let's hope that the Root Window Visual matches the DefaultVisual */ > - rootVisual = DefaultVisual( default_display, DefaultScreen(default_display) ); > - } > - > - template.visualid = XVisualIDFromVisual(rootVisual); > - vis = XGetVisualInfo(default_display, VisualIDMask, &template, &num); > - if (vis != NULL) default_cx = glXCreateContext(default_display, vis, 0, GL_TRUE); > - if (default_cx != NULL) glXMakeCurrent(default_display, root, default_cx); > - XFree(vis); > - LEAVE_GL(); > - > internal_gl_disabled_extensions[0] = 0; > if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\OpenGL", &hkey)) { > if (!RegQueryValueExA( hkey, "DisabledExtensions", 0, NULL, (LPBYTE)internal_gl_disabled_extensions, &size)) { > @@ -703,9 +648,6 @@ > RegCloseKey(hkey); > } > > - if (default_cx == NULL) { > - ERR("Could not create default context.\n"); > - } > return TRUE; > } > > @@ -714,8 +656,6 @@ > > static void process_detach(void) > { > - glXDestroyContext(default_display, default_cx); > - > HeapFree(GetProcessHeap(), 0, internal_gl_extensions); > } > > > > ------------------------------------------------------------------------ > >

3 2

[FYI] Wiki down
by Dimi Paun Nov. 10, 2006

Nov. 10, 2006

Folks, We are experiencing some hardware problems on wiki.winehq.org. I have taken the wiki down until we work through the issues to protect the data. We are working to fix it, and to provide better failover in the future. We are hoping to have it back up by the end of the day. I am sorry about the downtime, and I apologize for any inconvenience caused by it. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 1

Qcap questions
by Andrew Talbot Nov. 9, 2006

Nov. 9, 2006

In qcap/pin.c, the function OutputPin_GetDeliveryBuffer() shows the parameters tStart and tStop as being of type const REFERENCE_TIME *. Looking at the SDK web site, I see a function called CBaseOutputPin::GetDeliveryBuffer() that has similar parameters that are non-const. May I deconstify these parameters in our function, in order to avoid some cast-qual warnings, or are they constrained? Thanks, -- Andy.

1 0

dlls/user/hook.c HOOK_CallHooks() help
by Phil Lodwick Nov. 9, 2006

Nov. 9, 2006

Hi, I have an application that is hitting the assert in HOOK_CallHooks. ------ trace:hook:HOOK_CallHooks calling hook in thread 0113 WH_CALLWNDPROC code 0 wp 0 lp 7fbef984 err:hook:HOOK_CallHooks Unknown hook id 4 wine-pthread: hook.c:381: HOOK_CallHooks: Assertion `0' failed. ------ Basically I have a call stack that looks like this: 4 0x7f886b31 HOOK_CallHooks+0x251(id=0x4, code=0x0, wparam=0x0, lparam=0x7fbef984, unicode=0x0) [dlls/user/hook.c:381] in user32 (0x7fbef944) 5 0x7f8a4e8c call_window_proc+0x9c(hwnd=0x0, msg=0x0, wparam=0x0, lparam=0x0, unicode=0x0, same_thread=0x0) [dlls/user/message.c:1512] in user32 (0x7fbef9a0) 6 0x7f8a5dca peek_message(msg=0x7fbefcd0, hwnd=0x0, first=0x0, last=0xffffffff, flags=0x1) [dlls/user/message.c:2053] in user32 (0x7fbefca8) 7 0x7f8a7a16 PeekMessageW(msg_out=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0, flags=0x1) [dlls/user/message.c:2694] in user32 (0x7fbefcfc) 8 0x7f8a7cc9 GetMessageW+0x109(msg=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0) [dlls/user/message.c:2764] in user32 (0x7fbefdb0) 9 0x7f8a7e67 GetMessageA+0x37(msg=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0) [dlls/user/message.c:2804] in user32 (0x7fbefdd0) ------------------- The WH_CALLWNDPROC is usually filtered out by the HOOK_IsHooked() call, but not in this case. I don't have source code available for the application. I was hoping somebody might have a good suggestion for the next step in debugging this problem. Right now I am going to start looking at GetMessageA and follow that code down to call_window_proc and see if I see something obvious. Thanks, Phil

2 4

mscoree: Graphical notice
by Segin Nov. 9, 2006

Nov. 9, 2006

Is it a wise idea to add a graphical warning to mscoree that Wine doesn't support running .NET applications directly yet? I was thinking about using a MessageBox() to deliver the warning. I also wanted the popup to be displayed conditionally, in which if Wine was started from the commandline, the box isn't displayed at all. Since most DEs spawn programs that, although their output reaches the tty that 'startx' was called from, they aren't attached to that tty. Evidence this by starting "tty" from within KDE or GNOME, then switch to the virtual console that you started your X session from. You should note a line near the bottom that says "not a tty". From a program's perspective, you can check for this by calling isatty(1) (file descriptor 1 is usually standard output, and I belive that POSIX mandates this behaviour) and checking if the return value is one (or not, in which display the GUI warning). Is using OS-level file descriptors in conjunction with functions such as isatty() safe programming practice with Wine? I wasn't to sure, and wanted to know. -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds

2 1