August 2006 - Wine-Devel - list.winehq.org

Re: usp10: Resend - Remove unnecessary casts in test suite
by Alexandre Julliard Aug. 15, 2006

Aug. 15, 2006

Jeff L <lats(a)yless4u.com.au> writes: > Any problems? It doesn't apply. When resending a patch please regenerate it against the current tip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10: Resend - Add funtionality for ScriptStringAnalyse
by Alexandre Julliard Aug. 15, 2006

Aug. 15, 2006

Jeff L <lats(a)yless4u.com.au> writes: > + cMaxItems = 255; /* Pick an abritary size for buffers */ > + if (!*pssa) /* Clean it out and start again */ > + ScriptStringFree(pssa); I still don't see why you want to free a NULL pointer. > + { > + prtssa(*pssa); > + analysis = * pssa; > + prtssa((SCRIPT_STRING_ANALYSIS *)analysis); Why do you print the same object twice? There seems to be a lot of confusion in your code between pointers and pointers to pointers, I think you need to define better data types to clarify this. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: XEmbed Systray Patches
by James Liggett Aug. 15, 2006

Aug. 15, 2006

Hi Everyone, First, I'd like to apologize for sending those tarballs to wine-devel, as I've just been advised on IRC that such a practice discourages reviews. I've attached a text version of the patches in the hopes that it will get some more exposure. Again, sorry for the trouble. :) James

2 1

All right, let's solve these .desktop issues forever
by Scott Ritchie Aug. 14, 2006

Aug. 14, 2006

As of right now, I'd estimate that over half of our users are using Wine from a terminal window to launch their applications, largely because their window manager doesn't put Wine's Start Menu entries into their applications menu. Wine's been making .desktop files for some time, however it seems like they're being put in the wrong place. There's supposedly a proper, standard place to put them (or there should be), and perhaps a hack can be put in at the package-maintainer level, but in any case this is a pretty big usability issue at the moment. I'm pretty confident that someone here knows the answer to how things should be, and I'm also pretty sure it's a fairly simple change to make. Either way, we need to have a discussion about it - what's the next step here? Thanks, Scott Ritchie

7 8

Re: USER: SystemParametersInfo fixes
by Alexandre Julliard Aug. 14, 2006

Aug. 14, 2006

Frank Richter <frank.richter(a)gmail.com> writes: > Subject: [PATCH] USER: Fix SPI_SETICONTITLELOGFONT to check for LOGFONTW size > [...] > Subject: [PATCH] USER: initialize size of nonclients struct in load_nonclient_metrics Please don't attach multiple patches, each patch should be a separate mail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WineD3D: add rgb24 colorkey conversion
by Alexandre Julliard Aug. 14, 2006

Aug. 14, 2006

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > + for (x = 0; x < len; x++) { > + /* Retrieve RGB24 color */ > + DWORD color = *((DWORD*)src); > + /* Store the RGB portion in dest and reserve a byte for alpha */ > + *Dest = color << 8; > + if ((color < surf->SrcBltCKey.dwColorSpaceLowValue) || > + (color > surf->SrcBltCKey.dwColorSpaceHighValue)) > + *Dest |= 0xff; > + src += 3; You should avoid unaligned DWORD accesses, this doesn't work on all platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: OpenGL x11drv rewrite (WoW fix)
by Roderick Colenbrander Aug. 14, 2006

Aug. 14, 2006

Hi, Since the WM rewrite we can only use the visual which was created by x11drv at x11drv initialization. In general this is a simple 32bit RGBA visual or when that's not available it is some 16bit visual. The problem is that the opengl code advertises more formats than this single format. The problem which this can cause is that a 'bad' format is set by SetPixelFormat. In the end when we create a context using wglCreateContext this 'bad' pixelformat is used. When some time later glXMakeCurrent is called we will get a BadMatch. (Note that in a few cases we catch the 'BadMatch' before it happens and create a new GLX Context; this is when context is NULL) The proposed patch which I attached to this email rewrites the pixel format code. First I'll give a short introduction and then I will explain my changes. The functions ChoosePixelFormat/GetPixelFormat/SetPixelFormat/DescribePixelFormat all work with a parameter 'iPixelFormat'. This variable is an index into the table of supported pixel formats. At the moment the index is a direct mapping to the FB config table exported by GLX. I have changed ChoosePixelFormat to only return the format of the main visual. Further this function needs to find a 'closest match' to the requested format, before it tried to find an exact match. I changed the function to look for a close match. Further because only 1 format is supported, the max index the function can return is 1. This kills the direct mapping of the index to the index in the GLX FB config table. All the opengl calls in x11drv got changed to only accept our single format. As I mentioned earlier the opengl calls used the specified iPixelFormat as an index in the GLX FB config table. Because the 1:1 mapping of iPixelFormat to this table got lost I have added a function to retrieve the index of the main visual. Further I had to change our wglMakeCurrent call to retrieve the pixel format to use from the main visual instead of getting it from a GetPixelFormat call. This was done because wglMakeCurrent needs an index into the GLX FB Config table and not in our 'win32 opengl format table' (which only contains 1 format). I have tested the patch in several programs. Before Halflife1 didn't work in 16bit because ChoosePixelFormat was too strict, the game works fine now. Further the patch also fixes the BadMatch error Nvidia users received in World Of Warcraft when using the OpenGL renderer. I think the patch is a correct fix for the BadMatch / ChoosePixelFormat issues. The patch isn't 100% complete yet as I haven't updated the WGL extensions for pbuffer and wglChoosePixelFormat to work with the new pixelformats yet (that's why you see a line WoW hack). I will fix that part when you guys think that the patch is correct. Regards, Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

2 1

Is anyone going to or presenting at Linuxworld?
by Scott Ritchie Aug. 14, 2006

Aug. 14, 2006

Linuxworldexpo is this week. Since no one's mentioned it yet, I'm assuming that we don't have a booth or speech planned :) http://www.linuxworldexpo.com/live/12/events/12SFO06A At any rate, perhaps we should be going to things like this. There's usually a convention like this (OSCON, etc) every couple of months, and it certainly couldn't hurt to have a Wine evangelist there talking about how powerful Wine is getting and why Wine should be considered as a bigger part of the Linux strategy. What do you think? Thanks, Scott Ritchie

2 1

Re: resend add missing glyph code to GetGlyphIndices
by Dmitry Timoshkov Aug. 14, 2006

Aug. 14, 2006

"Jeff L" <lats(a)yless4u.com.au> wrote: > -DWORD WineEngGetGlyphIndices(GdiFont font, LPCWSTR lpstr, INT count, > + * */ Strange indentation at the end of a comment. > +DWORD WineEngGetGlyphIndices(HDC hdc, GdiFont font, LPCWSTR lpstr, INT count, > LPWORD pgi, DWORD flags) > { > INT i; > - > + TEXTMETRICW textm; > for(i = 0; i < count; i++) > + { > pgi[i] = get_glyph_index(font, lpstr[i]); > - > + if (pgi[i] == 0) > + { > + if (flags & GGI_MARK_NONEXISTING_GLYPHS) > + pgi[i] = 0x001f; /* Indicate non existance */ > + else > + { > + GetTextMetricsW(hdc, &textm); > + pgi[i] = textm.tmDefaultChar; > + } > + } > + } > return count; > } I'd suggest to move GetTextMetricsW outside of the loop to not kill the performance. > + WCHAR testtext[] = {'T',0x0000,'s','t',0xffff,0}; > + WORD glyphs[(sizeof(testtext)/2)-1]; > + TEXTMETRIC textm; > + > + memset(&lf, 0, sizeof(lf)); > + strcpy(lf.lfFaceName, "Symbol"); > + lf.lfHeight = 20; > + > + hfont = CreateFontIndirectA(&lf); > + hdc = GetDC(0); > + > + ok(GetTextMetrics(hdc, &textm), "GetTextMetric failed\n"); Please set tab width to 8 instead of 4 and do not mix tabs and spaces. -- Dmitry.

3 3

Re: secur32: Fix heap error.
by Kai Blin Aug. 14, 2006

Aug. 14, 2006

On Monday 14 August 2006 11:57, Kai Blin wrote: > --- > dlls/secur32/dispatcher.c | 1 - > dlls/secur32/ntlm.c | 1 + > 2 files changed, 1 insertions(+), 1 deletions(-) Sorry, this one is obviously a typo. Sending a new one. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0