August 2006 - Wine-Devel - list.winehq.org

Re: ddraw fix for incorrect return value from wined3d take 3.
by Roderick Colenbrander Aug. 12, 2006

Aug. 12, 2006

Hi, One small comment regarding your patch make sure that you use the same indentation as the rest of the ddraw code. The ddraw code seems to use 4 spaces for a tab and I think your editor is configured to use tabs. Regards, Roderick Colenbrander > The new test cases crashes under wine but not under > windows. The fix for test cases crash is to initialize > the vertexbuffer to NULL when unsuccessful. > > This patch should be used rather then previous one. > > thx > Index: dlls/ddraw/direct3d.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/direct3d.c,v retrieving revision 1.9 diff -u -r1.9 direct3d.c --- dlls/ddraw/direct3d.c 9 Aug 2006 11:04:37 -0000 1.9 +++ dlls/ddraw/direct3d.c 11 Aug 2006 22:47:16 -0000 @@ -992,8 +992,11 @@ { ERR("(%p) IWineD3DDevice::CreateVertexBuffer failed with hr=%08lx\n", This, hr); HeapFree(GetProcessHeap(), 0, object); + *VertexBuffer = NULL; if (hr == WINED3DERR_INVALIDCALL) return DDERR_INVALIDPARAMS; + if (hr == WINED3DERR_OUTOFVIDEOMEMORY) + return D3DERR_TOOMANYVERTICES; else return hr; } -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

Re: wininet: Support http_proxy environment variable
by Augusto Arcoverde da Rocha Aug. 12, 2006

Aug. 12, 2006

Exists a opened bug report about the problem which this patch is suposed to fix: http://bugs.winehq.org/show_bug.cgi?id=5625 Can someone give some comments for what this pach wasn't applied? Thanks, Augusto Arcoverde da Rocha

5 10

Re: [UPDATE] RFC: XEmbed System Tray Patches
by Juan Lang Aug. 11, 2006

Aug. 11, 2006

Hi James, thanks for taking this up. I'd like to have nice docked system tray icons, too. Some small nits on your patches: + wine_tsx11_lock(); + /* set XEMBED protocol data on the window */ + info[0] = 0; /* protocol version */ + info[1] = 1; /* mapped = true */ + XChangeProperty( display, data->whole_window, + x11drv_atom(_XEMBED_INFO), + x11drv_atom(_XEMBED_INFO), 32, PropModeReplace, + (unsigned char*)info, 2); + + /* send the docking request message */ + ZeroMemory( &ev, sizeof(ev) ); + ev.xclient.type = ClientMessage; + ev.xclient.window = systray_window; + ev.xclient.message_type = x11drv_atom(_NET_SYSTEM_TRAY_OPCODE); + ev.xclient.format = 32; + ev.xclient.data.l[0] = CurrentTime; + ev.xclient.data.l[1] = SYSTEM_TRAY_REQUEST_DOCK; + ev.xclient.data.l[2] = data->whole_window; + ev.xclient.data.l[3] = 0; + ev.xclient.data.l[4] = 0; + XSendEvent( display, systray_window, False, NoEventMask, &ev ); + wine_tsx11_unlock(); You do more with the lock held than you need to. Initializing info and ev could both be down without holding the lock. diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index b8c8a7c..3b4bd08 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -2741,6 +2741,7 @@ struct set_window_pos_reply { struct reply_header __header; unsigned int new_style; + unsigned int ex_style; }; This diff should be against server/protocol.def, not against server_protocol.h. diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index b26e14f..69c32ef 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -400,6 +400,13 @@ static void systray_dock_window( Display ev.xclient.data.l[3] = 0; ev.xclient.data.l[4] = 0; XSendEvent( display, systray_window, False, NoEventMask, &ev ); + + /* This XSync call is needed to properly send the message to the + * systray window and is required to have icon docking work properly. + * Furthermore, an XSync is shown in an example of how to send proper + * docking messages, see the XEmbed system tray spec for more + * information. */ + XSync(display, False); Why not include this in the original patch (0005 in the series?) --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Wine and Photoshop in news
by Vijay Kiran Kamuju Aug. 11, 2006

Aug. 11, 2006

Check this link out Its about Wine and Photoshop compatibility. http://www.manilastandardtoday.com/?page=business05_aug01_2006 Can we also try to improve the photoshop compatibility with wine. Today will download the demo and try it on wine current git.

4 5

Re: [wintrust.h] Added some missing struct variables
by Paul Vriens Aug. 11, 2006

Aug. 11, 2006

On Fri, 2006-08-11 at 16:40 +0200, Paul Vriens wrote: > Hi, > > our struct was missing some variables. > > Changelog > Added some missing struct variables > > Cheers, > > Paul > --- > include/wintrust.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/wintrust.h b/include/wintrust.h > index d490ac9..0230dee 100644 > --- a/include/wintrust.h > +++ b/include/wintrust.h > @@ -254,6 +254,8 @@ typedef struct _CRYPT_PROVIDER_DATA { > HCRYPTMSG hMsg; > DWORD csSigners; > CRYPT_PROVIDER_SGNR *pasSigners; > + DWORD csProvPrivData; > + CRYPT_PROVIDER_PRIVDATA *pasProvPrivData; > DWORD dwSubjectChoice; > union { > struct _PROVDATA_SIP *pPDSip; Hi, please wait with this one. There appears to be some differences in the structure for w2k/winxp (and others?). Cheers, Paul.

1 0

Re: kernel32: redirect GetNativeSystemInfo to GetSystemInfo
by Alexandre Julliard Aug. 11, 2006

Aug. 11, 2006

Robert Reif <reif(a)earthlink.net> writes: > --- dlls/kernel/kernel32.spec 21 Jun 2006 13:03:23 -0000 1.175 > +++ dlls/kernel/kernel32.spec 11 Aug 2006 01:51:02 -0000 > @@ -546,7 +546,7 @@ > @ stdcall GetNamedPipeHandleStateA(long ptr ptr ptr ptr str long) > @ stdcall GetNamedPipeHandleStateW(long ptr ptr ptr ptr wstr long) > @ stdcall GetNamedPipeInfo(long ptr ptr ptr ptr) > -# @ stub GetNativeSystemInfo > +@ stdcall GetNativeSystemInfo(ptr) GetSystemInfo There's a bit more to it than that, so we probably want to print a FIXME for this one. -- Alexandre Julliard julliard(a)winehq.org

1 0

[wintrust.h] Added some missing struct variables
by Paul Vriens Aug. 11, 2006

Aug. 11, 2006

Hi, our struct was missing some variables. Changelog Added some missing struct variables Cheers, Paul --- include/wintrust.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/wintrust.h b/include/wintrust.h index d490ac9..0230dee 100644 --- a/include/wintrust.h +++ b/include/wintrust.h @@ -254,6 +254,8 @@ typedef struct _CRYPT_PROVIDER_DATA { HCRYPTMSG hMsg; DWORD csSigners; CRYPT_PROVIDER_SGNR *pasSigners; + DWORD csProvPrivData; + CRYPT_PROVIDER_PRIVDATA *pasProvPrivData; DWORD dwSubjectChoice; union { struct _PROVDATA_SIP *pPDSip; -- 1.4.1.1

1 0

Re: winhelp: fix LZ77 decompressor patch: what's wrong?
by HolyLich Aug. 11, 2006

Aug. 11, 2006

В сообщении от Friday 11 August 2006 17:17 вы написали: > 2006/8/11, HolyLich <lich(a)math.spbu.ru>: > > I've sent patch several times, but it has not been applied. > > Why not use memmove() instead? > Heh, this problem was discussed before http://www.winehq.org/pipermail/wine-devel/2006-August/050133.html, http://www.winehq.org/pipermail/wine-devel/2006-August/050139.html http://www.winehq.org/pipermail/wine-devel/2006-August/050141.html. memmove cannot be used because it provides other functionality - it doesn't suit LZ77 memcpy cannot be used because it's too clever (copies INTs instead of BYTEs), so doesn't suit LZ77 Solution: while (len--) *dst++=*src++; // The simplies way of memcpy Any more suggestion of bad patch? --HolyLich

2 1

winhelp: fix LZ77 decompressor patch: what's wrong?
by HolyLich Aug. 11, 2006

Aug. 11, 2006

Hi, I've sent patch several times, but it has not been applied. Patch is reasonable, MIME type is OK. patch -p0 < mbox works ;-) (as recommended at http://winehq.org/site/docs/winedev-guide/style-notes) Please, tell what I must do to this patch to be applied? Thanks a lot -- HolyLich Subject: [RESENDv2] winhelp: fix LZ77 decompressor Date: Thursday 10 August 2006 14:21 From: HolyLich <lich(a)math.spbu.ru> To: wine-patches(a)winehq.org Hi, This patch fixes a bug in LZ77 decompressor which affected only large (>0x1000) compressed embedded files, e.g. images (metafiles). I've never noticed it corrupting small images, but it may. I sent this patch before but messed with MIME. Now it's OK. ChangeLog: winhelp: Fix LZ77 decompressor -------------------------------------------------------

3 2

Rooms for Wineconf - Please act now
by Jeremy White Aug. 11, 2006

Aug. 11, 2006

Hi Folks, I know that Wineconf is still over a month away, but you'll really regret it if you don't make your accomodation selections now. If you paypal (or even arrange to mail a check) to me *now*, you'll get to hang out with all the cool people, on campus, and learn what the "Drink-making facilities on each corridor" really means, all for the low low price of about 40 pounds (okay, so the exchange rate sucks, and that's $75 US, but still...) If you *don't* get me an room request in the next few days, then I'll have to close down our room reservation, and you'll be stuck in some sleazy motel on the edge of town paying outrageous sums of of money. (Okay, they actually all look like nice places to stay, but they will be a ways away, and they all cost more :-/). Again, see this page for more details: http://www.winehq.org/site/wineconf/travel If you can't do Paypal, I can take a check in US currency as well. Cheers, Jeremy

6 9