February 2007 - Wine-Devel - list.winehq.org

Re: shell32: make sure BrowseForFolder doesn't return NULL for the Desktop folder as this means a cancel (should fix bug #5533)
by Robert Shearman Feb. 9, 2007

Feb. 9, 2007

Mikołaj Zalewski wrote: > +/************************************************************************* > + * _ILMakePidlNotNull > + * > + * A null pidl is a valid pidl that represents the Desktop. However if we don't > + * want a NULL pidl (e.g. because NULL indicates an error) this function will > + * make an explicit empty pidl if the parameter is NULL. > + */ > +HRESULT _ILMakePidlNotNull(LPITEMIDLIST *pidl) > +{ > + if (*pidl == NULL) > + *pidl = _ILCreateDesktop(); > + if (*pidl == NULL) > + return E_OUTOFMEMORY; > + return S_OK; > +} > This function is a bit ugly. It seems this policy should be made in the BrsFolder_OnCommand function, rather than in pidl.c as a file. -- Rob Shearman

2 1

Re: ntdll: Add prototypes to winnt.h for the SList functions.
by Alexandre Julliard Feb. 9, 2007

Feb. 9, 2007

Francois Gouget <fgouget(a)free.fr> writes: > Fix the implementation to match the official prototypes. > --- > > I've had trouble with the placement of 'volatile' in 'const > SLIST_HEADER* volatile'. I think putting 'volatile' last is correct > because it applies to the pointer, not to the pointed-to data like > 'const'. No, it applies to the data, it doesn't make sense to have the pointer itself be volatile. Though it's probably useless either way, and since the SDK prototypes apparently don't have it we shouldn't either. -- Alexandre Julliard julliard(a)winehq.org

1 0

Questions about gdi32:WidenPath patch sent on jan. 27
by Laurent Vromman Feb. 9, 2007

Feb. 9, 2007

Hi, I've tried to send my first patch on jan. 27. This patch is supposed to add a partial implementation of WidenPath to gdi32.dll. After two weeks, I don't have any news about the patch. Is it still pending ? Is there something wrong with it ? I am ready to improve it if necessary, but I need some advice to now what needs to be improved in it. Thank you for your help. Laurent

1 0

Re: [1/9] WineD3D: BeginScene and EndScene tests and fixes
by Alexandre Julliard Feb. 9, 2007

Feb. 9, 2007

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From 4dc1b3cd7faf9c61bc6f862f416b6af07e1e85e8 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 19 Jan 2007 19:30:09 +0100 > Subject: [PATCH] WineD3D: BeginScene and EndScene tests and fixes This causes 'make test' to fail to restore the correct display resolution, it's stuck at 800x600 on exit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winegcc: sign-compare fixes
by Joris Huizer Feb. 9, 2007

Feb. 9, 2007

I believe this one causes problems -- please do not commit yet Joris Huizer <joris_huizer(a)yahoo.com> wrote: --------------------------------- Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users.>From 8686a200bd1f1cbd934d761013c487a9ddc195c9 Mon Sep 17 00:00:00 2001 From: Joris Huizer Date: Wed, 7 Feb 2007 15:19:25 +0100 Subject: [PATCH] winegcc sign-compare fixes To: wine-patches --- tools/winegcc/utils.c | 13 +++++++------ tools/winegcc/winegcc.c | 11 ++++++----- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/tools/winegcc/utils.c b/tools/winegcc/utils.c index 1af91e9..c144077 100644 --- a/tools/winegcc/utils.c +++ b/tools/winegcc/utils.c @@ -120,14 +120,14 @@ void strarray_add(strarray* arr, const c void strarray_del(strarray* arr, int i) { - if (i < 0 || i >= arr->size) error("Invalid index i=%d", i); + if (i < 0 || (unsigned int)i >= arr->size) error("Invalid index i=%d", i); memmove(&arr->base[i], &arr->base[i + 1], (arr->size - i - 1) * sizeof(arr->base[0])); arr->size--; } void strarray_addall(strarray* arr, const strarray* from) { - int i; + unsigned int i; for (i = 0; i < from->size; i++) strarray_add(arr, from->base[i]); @@ -136,7 +136,7 @@ void strarray_addall(strarray* arr, cons strarray* strarray_dup(const strarray* arr) { strarray* dup = strarray_alloc(); - int i; + unsigned int i; for (i = 0; i < arr->size; i++) strarray_add(dup, arr->base[i]); @@ -160,7 +160,7 @@ strarray* strarray_fromstring(const char char* strarray_tostring(const strarray* arr, const char* sep) { char *str, *newstr; - int i; + unsigned int i; str = strmake("%s", arr->base[0]); for (i = 1; i < arr->size; i++) @@ -277,7 +277,7 @@ static file_type guess_lib_type(const ch file_type get_lib_type(strarray* path, const char* library, char** file) { - int i; + unsigned int i; for (i = 0; i < path->size; i++) { @@ -289,7 +289,8 @@ file_type get_lib_type(strarray* path, c void spawn(const strarray* prefix, const strarray* args, int ignore_errors) { - int i, status; + unsigned int i; + int status; strarray* arr = strarray_dup(args); const char** argv; char* prog = 0; diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index f1aa87e..f1a7bb0 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -170,7 +170,7 @@ struct options static void clean_temp_files(void) { - int i; + unsigned int i; if (keep_generated) return; @@ -239,7 +239,8 @@ static const strarray* get_translator(en static void compile(struct options* opts, const char* lang) { strarray* comp_args = strarray_alloc(); - int j, gcc_defs = 0; + unsigned int j; + int gcc_defs = 0; switch(opts->processor) { @@ -434,7 +435,7 @@ static void build(struct options* opts) const char *output_name, *spec_file, *lang; const char* winebuild = getenv("WINEBUILD"); int generate_app_loader = 1; - int j; + unsigned int j; /* NOTE: for the files array we'll use the following convention: * -axxx: xxx is an archive (.a) @@ -719,7 +720,7 @@ static int is_linker_arg(const char* arg "-static", "-static-libgcc", "-shared", "-shared-libgcc", "-symbolic", "-framework" }; - int j; + unsigned int j; switch (arg[1]) { @@ -769,7 +770,7 @@ static int is_mingw_arg(const char* arg) { "-mno-cygwin", "-mwindows", "-mconsole", "-mthreads", "-municode" }; - int j; + unsigned int j; for (j = 0; j < sizeof(mingw_switches)/sizeof(mingw_switches[0]); j++) if (strcmp(mingw_switches[j], arg) == 0) return 1; -- 1.4.4 --------------------------------- Need a quick answer? Get one in minutes from people who know. Ask your question on Yahoo! Answers.

2 4

Re: comctl32: datetime: initial tests for date and time picker
by Mike McCormack Feb. 9, 2007

Feb. 9, 2007

Kanit Therdsteerasukdi wrote: > I'm a student at UCLA taking CS130: Software Engineering. For CS130, we > are writing conformance tests for Common Controls (comctl32). I will be > working on the Date and Time Picker. Attached is an initial test, > testing the getters and setters. Looks like good work. > +#include <stdio.h> This is possibly not needed. > +static HINSTANCE g_hinst; You should be able to use NULL instead of the hinst when creating the window, which would eliminate the need for g_hinst. > + assert(hWndDateTime!=NULL); > + return hWndDateTime; Maybe it would be nicer to check hWndDateTime with an ok() macro in test_datetime_control() then use skip() if it's NULL. This way the test will fail without crashing in the case that Window creation fails, for example, when there's no X display available. When tests crash, make doesn't detect that they failed. > + return; > +} The return is redundant, and probably better off removed. > + r = SendMessage(hWndDateTime, DTM_SETRANGE, GDTR_MIN | GDTR_MAX, (LPARAM)st); > + ok(r != 0, "Expected nonzero, got %ld\n", r); MSDN does say "returns nonzero if successful", but it's probably better to check the exact value that it does return, in case there's a program out there that does the same. ie. ok(r == 1, "Expected nonzero, got %ld\n", r); Mike

1 0

DirectDrawRenderer=opengl - screen size changeable for final rendering?
by Christoph Frick Feb. 8, 2007

Feb. 8, 2007

hiho what i ever wondered but never dared to ask: i tried recently the said key with jagged alliance 2. as the game has quite a low resolution 640 or 800 it would be nice to allow higher resolutions when rendering ddraw with opengl (e.g. game wants 800 but for the final rendering use 1600). is this doable via registry or somewhere else? for the files: i run the apps in desktop-mode. -- cu

2 3

Re: [2] wineshelllink: Keep using the slash as path separator.
by Vitaliy Margolen Feb. 8, 2007

Feb. 8, 2007

Hans Leidekker wrote: > Fixes incorrect handling of paths with dashes. > And creates invalid menu entries. Did you test this patch with multi-level menu structure? When I tried your patch it created all menu entries in the top level menu, with the name like: wine-Programs-Ubi Soft-IL-2 Sturmovik Demo Instead of being a menu: wine Programs Ubi Soft IL-2 Sturmovik Demo Last one is the way it should be but now it's 2 menus: IL 2 Sturmovik Demo Vitaliy.

2 2

winealsa commit d2f29311caa8041bd992a3867d71d6311c7ff8fa
by Marcus Meissner Feb. 8, 2007

Feb. 8, 2007

Hi Marten, Your commit: http://source.winehq.org/git/wine.git/?a=commit;h=d2f29311caa8041bd992a3867… Has some regressions on Coverity. Namely Coverity complains that "areas" is used uninitializied. And yes it is: static DWORD CALLBACK DBSB_MMAPLoop(LPVOID data) { IDsDriverBufferImpl* pdbi = (IDsDriverBufferImpl*)data; WINE_WAVEDEV *wwo = &(WOutDev[pdbi->drv->wDevID]); snd_pcm_uframes_t frames, wanted, ofs; const snd_pcm_channel_area_t *areas; int state = WINE_WS_STOPPED; snd_pcm_state_t alsastate; TRACE_(waveloop)("0x%8p\n", data); TRACE("0x%8p, framelength: %lu, area: %8p\n", data, pdbi->mmap_buflen_frames, pdbi->mmap_areas); if (areas != pdbi->mmap_areas || areas->addr != pdbi->mmap_areas->addr) FIXME("Can't access sound driver's buffer directly.\n"); Please fix :) Ciao, Marcus

1 0

How to find rendering code
by Markus Feb. 8, 2007

Feb. 8, 2007

Hi, I am new to Wine development and wanted to ask on the list, whether someone could point me to the correct place where the code for issues 3 and 4 in http://bugs.winehq.org/show_bug.cgi?id=7273 might be located. It looks like the solution could be rather straightforward to implement but I have no idea how to find the respective rendering method. Any help would be greatly appreciated. Thanks. -- Markus

2 1