March 2007 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Work legalities
by Nathan Williams Dec. 11, 2007

Dec. 11, 2007

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

[msi OLE automation] Re: msi patches info pls
by Misha Koshelev May 8, 2007

May 8, 2007

On Fri, 2007-03-09 at 17:27 +0100, Alexandre Julliard wrote: > Sorry for the lack of response, I'm currently waiting for our lawyers > to determine if it's ok to use code based on an oleview dump of a > native typelib, as that situation is not clear from a copyright > POV. I'm afraid I can't do more until they come to a conclusion on > that point. > So it looks like I will have some free time soon (hopefully) and will be able to redo the "IDL" file properly (also another Vector NTI/Linux user has offered up his help). However, I wanted to double check the "proper" way to make such a file as I know this is what is important in copyright (the process, such as dirty-clean room, vs the actual end result). From http://www.winehq.org/pipermail/wine-devel/2007-March/054589.html (posted by Rob Shearman) this is what I understand the correct process to be (I would like to understand the process in detail so I don't do something wrong to "taint" the wine copyright): As one is looking at the oleview output of the native IDL file, one starts a blank document and begins to make the wine IDL file. One defines all the appropriate interfaces, etc. using the UUID's, names, etc. from the native interface. All the function names and parameter types are declared the same, as well as function attributes, but I should use different names for the parameters and try to put the attributes in a different order (although if I understand correctly the order of these attributes comes from our oleview implementation and not from the interface per se so there shouldn't be any reason to change their order??). Also, what does one do for enums? It does not seem like there is anything that can be changed in this case, so it is alright just to re-create them verbatim (without copying and pasting, and of course the indentation will be prettier)? Thank you very much for your help. Misha

5 10

Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Sasan Iman April 10, 2007

April 10, 2007

First of all, let me say that I am not a developer. But I have been interested in Wine since early 2003. The thing that has always made me scratch my head is that the Windows software that motivates me to install Wine on my linux system (i.e. MS OFfice, etc.) has never worked with wine in a reliable manner. Meanwhile, Codeweaver has always had MS Office working on Wine. Now shouldn't getting the most common windows software working on Wine in an idiot-proof (meaning I can get it to work) manner be the highest priority for Wine developers? Instead, this is left to CodeWeavers and others. I know that if you fiddle around with the stock release long enough you can get MS Office working on Wine as I have on a number of occasions, but shouldn't making this work for everyone be the highest priority for getting Wine to be adopted more widely?! Or is Wine more targeted to gamers which is mostly what I read about on WineHQ? I just can't understand why the more common application are left to a commercial company. My conspiratorial side makes me want to think this is a conspiracy but I am sure there is valid technical and logistical reasons for it so I am asking you guys. Thanks. Sasan

12 20

re: Road to 1.0
by Dan Kegel April 3, 2007

April 3, 2007

Alexandre wrote: > That's still the plan, yes. I'm mostly waiting for the games > support to stabilize; the other main areas, office apps and > installers, both seem in good enough shape at this point. I suppose it depends on your definition of "office apps". Adobe Acrobat Pro and Quicken don't work yet, and they get used in a lot of offices. > I'm also hoping we can make some progress on the x11drv > factorisation before the freeze, so that we don't need to > change the interface too much to add the quartz driver later > on, we'll see how that goes. And if we delay it a bit more > maybe we can slip in Safedisc support too... Oh, yes, please. Here's a try at a 1.0 wish list: - Safedisc support - OpenGL child window problem solved for most common cards at least - Adobe CS2/8 era apps installing and working - Dragon Naturally Speaking 9 working (I'm selfish, I need that one :-) - Quicken 2006 installing/working (including online banking that requires 128 bits) - Mono integration working for non-toy apps - At least some of Munich's VB6 and/or databasey apps working (Hans just submitted a bunch of patches to fix most of the install issues in one) - Better application regression test suite (cxtest, yawt) October is looking about right for the start of the freeze, given that huge list. And my 1.1 wish list (i.e. hard things we can let slip past 1.0): - Activation context support - Quicken 2007 (which requires activation context support?) ... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

10 11

More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)
by Vit Hrachovy April 3, 2007

April 3, 2007

Hi, according to Stefan, Direct X options regarding * Available Video Memory * Enable GLSL will be useful in winecfg / Graphics section. However there is still missing consensus to how and whether to implement user accessible way to enable/disable GLSL in winecfg. Ray Jones, Stefan and me would like this in winecfg. Please share Your opinion. According to the discussion results, I'm going to add either only Available Video Memory text input box, or both Memory and GLSL toggle checkbox to winecfg. Summary of previous discussion follows: Available Video Memory (text input box) ---------------------- User will input here the RAM size of his graphic card. According to Stefan: "There are vendor dependent ways to read it, but implementing them is pretty nasty(requires some private to winex11.drv). Altough we had that discussion a number of times already and we only agreed on a registry key so far." Enable GLSL (checkbox) ----------- GLSL should be made default in 1.0. However, according to Stefan: "some drivers(*cough* macos *cough*) have serious problems with glsl". Until there is a specification in 1.0 requirements that these issues have to be resolved prior 1.0, this checkbox would be useful even past 1.0. Stefan Dosinger with H. Verbeet pointed out that this option should be in Vertex Shader dropdown box, but after inspecting code, I've found wouldn't blend well with the rest of Vertex Shader idea. This is due to GLSL registry key differs from Vertex Shader registry key. Should they be merged into one? Ivan Gyurdiev pointed out that GLSL can be both enabled for hardware vertex shader and software vertex shader, so the idea of merging GLSL with Vertex Shader dropdown box would result in two menu options - 'GLSL with HW support' and 'GLSL with SW support'. Another stance is to make GLSL enabled by default in next Wine versions. Offscreen Rendering (dropdown box) ------------------- Default option will be 'fbo', optional is backbuffer. Stefan doesn't consider it worthy adding to winecfg. Regards Vit

3 3

Anyone working on XKB support for Wine (or any other Keyboard language detection enhancements)?
by Shachar Shemesh April 3, 2007

April 3, 2007

Hi all, The current keyboard detection and setting code is based on the traditional method of setting a keyboard in X11. It misdetects most any language that carries a US keyboard as the first group. While major work on other areas of Wine means that most programs today don't really care about that, it still confuses the $*(!@#&$ out of Word. It also has some pretty serious BiDi editing implications. I'm looking into replacing that with code based on the XKB X11 extension, today supported with any quasi reasonable X server. This should totally eliminate the guesswork done through keyboard change detection in wine today. The main question is this - is anyone today already working on this? Thanks, Shachar

3 2

Re: [PATCH 1/1] wined3d: Make 8bpp a valid depth in EnumAdapterModes
by Chris Robinson April 2, 2007

April 2, 2007

On Friday 30 March 2007 08:11:54 pm Vitaly Budovski wrote: > Make 8bpp a valid depth in EnumAdapterModes. This allows Age of Empires to > start. > --- > dlls/wined3d/directx.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) This causes the d3d8 device test to fail for me: device.c:755: Test failed: Unexpected display mode returned for mode 42: 0x29 ...all the way through to... device.c:755: Test failed: Unexpected display mode returned for mode 83: 0x29 D3D8 only supports 32-bit X8R8G8B8 and 16-bit R5G6B5 modes as far as Windows testing has shown, and passing WINED3DFMT_UNKNOWN to WineD3D for mode enumeration makes it work on D3D8 modes only. You'll probably need to wait for Stefan or Henri to respond to figure out what to do. Though, it appears DDraw can be patched to do a second enumeration loop with WINED3DFORMAT_P8 if the first was with WINED3DFMT_UNKNOWN.. whether or not this is acceptable, I'm not sure, but it's an idea I just had.

3 4

extracting info from a minidump via winedbg
by Dennis Schridde March 31, 2007

March 31, 2007

Hello Wine users! I've got a minidump from a ("real") Windows user of our game and would like to extract information from it using winedbg. The information winedbg gives me by default, is this: WineDbg starting on minidump on pid 068c warzone2100.exe was running on #1 Intel ???-0.521 CPU on Windows XP (2600) Register dump: CS:001b SS:0023 DS:0023 ES:0023 FS:003b GS:0000 EIP:0051008b ESP:0022f844 EBP:0022f858 EFLAGS:00010a87( - 00 ROISP1C) EAX:c7b054d8 EBX:19ff502e ECX:00000040 EDX:0000000f ESI:02010101 EDI:00000000 Stack dump: 0x0022f844: 00000000 00000000 00000000 3f800000 0x0022f854: 00000000 0022f8c8 0050e796 19ff502e 0x0022f864: 3f800000 00000000 00000000 00000000 0x0022f874: 00000000 00000000 00000000 ff4a4a4a 0x0022f884: 00000005 02010101 00000000 00000000 0x0022f894: 00000000 0022f8c8 00000000 00000000 Backtrace: =>1 0x0051008b (0x0022f858) 2 0x0050e796 (0x0022f8c8) 3 0x00410c3b (0x0022f948) 4 0x0041172d (0x0022f9c8) 5 0x004b2272 (0x0022f9d8) 6 0x004aa97b (0x0022f9f8) 7 0x004b615a (0x0022fab8) 8 0x004b663f (0x0022fad8) 9 0x004b67e1 (0x0022faf8) 10 0x0041e39e (0x0022fb28) 11 0x00459d3e (0x0022fb58) 12 0x0045b2ee (0x0022fca8) 13 0x0055e77b (0x0022fcf8) 14 0x0055e932 (0x0022fef8) 15 0x0055e483 (0x0022fff0) 16 0x00000000 (0x00000000) WineDbg starting on pid 068c Which is pretty rare. Via addr2line I can translate the backtrace to possibly valid locations in our sourcefiles. My questions are: - Why doesn't winedbg extract the sourcecode locations itself? - Why doesn't winedbg show me the other information included in the minidump, like the loaded modules, commandline options or version information? - How can I get the parameters to the last called function(s)? If winedbg is missing the commands/functions to achive the above, I may be able to provide it. The minidump functions seem to be documented rather good on msdn and it would just require printing it to the console. Thanks in advance, Dennis

4 7

Anyone else want to be a SoC mentor?
by Dan Kegel March 31, 2007

March 31, 2007

Hey folks, it looks like we might need a few more mentors; anyone else interested? - Dan

1 0

Submitting AppDB test results broken?
by Markus March 31, 2007

March 31, 2007

Hi, I just noticed that submitting test data to AppDB does not work. After submitting, the result page shows several e-mails sent but also an error "No test id defined!". The test data does not show up in the result list either. In addition, the .34 release is not available for selection yet. Regards, -- Markus

2 1

request to look into this bug
by Louis. Lenders March 31, 2007

March 31, 2007

Hi, while working through the test reports in the appdb, i saw users submitting crashes with applications , all similar to bug 7380, so i decided to take it here. The applications that crash are *WinMerge (newest version) *BookWorms Adventures + several other PopCap games ( i tested them) *5 other applications listed under bug 7380. So i know of at least 10 applications that crash this way. They all start fine using the "buggy pointer" patch from Rein Klazes below. However, i think it's becoming rahter strange that all these (just released!) applications pass buggy pointers, so i'm beginning to think the problem must be somewhere else. I've sent in a patch to work around this bug by an exception handler a few weeks ago, but that's likely not the way to go either then. Anyone an idea how to tackle this problem? Thanks. diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c index cec2058..4e61da4 100644 --- a/dlls/winex11.drv/dib.c +++ b/dlls/winex11.drv/dib.c @@ -3861,6 +3861,7 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph X11DRV_DIB_IMAGEBITS_DESCR descr; BITMAP bitmap; LONG width, height, tmpheight; + int nrsrcbytes, dibpitch; INT result; descr.physDev = physDev; @@ -3880,6 +3881,17 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph if (startscan + lines > height) lines = height - startscan; + + /* pointer check */ + dibpitch = ((width * descr.infoBpp + 23) &~23) / 8; + if( descr.compression) + nrsrcbytes = 1; + else { + nrsrcbytes = lines * dibpitch; + if( nrsrcbytes < 0) nrsrcbytes = - nrsrcbytes; + } + if( IsBadReadPtr( bits, nrsrcbytes)) return 0; + switch (descr.infoBpp) { case 1: @@ -3926,7 +3938,7 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph descr.width = bitmap.bmWidth; descr.height = lines; descr.useShm = FALSE; - descr.dibpitch = ((descr.infoWidth * descr.infoBpp + 31) &~31) / 8; + descr.dibpitch = dibpitch; X11DRV_DIB_Lock( physBitmap, DIB_Status_GdiMod, FALSE ); result = X11DRV_DIB_SetImageBits( &descr ); X11DRV_DIB_Unlock( physBitmap, TRUE ); --------------------------------- New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes.

2 1

DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams March 31, 2007

March 31, 2007

Sorry about the last patch, I slipped up on my bitwise operators. This should be correct to my intentions at least! (I forgot to hit reply all, agh, i should probably power off my computer now :P ) On 3/31/07, Chris Bandy <cbandy(a)jbandy.com> wrote: > > > Stefan Dösinger wrote: > >> @@ -3194,6 +3193,7 @@ static HRESULT WINAPI > >> > > IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) { > > > >> } else { > >> /* No oversize, gl rect is the full texture size */ > >> This->Flags &= ~SFLAG_OVERSIZE; > >> + This->Flags &= SFLAG_NONPOW2; > >> > > > > > > This is not correct. This removes every flag except SFLAG_NONPOW2. If you want > > to remove the SFLAG_NONPOW2 flag you have to invert the flag: > > > > This->Flags &= ~SFLAG_NONPOW2 > > > If you want to set the SFLAG_NONPOW2 flag... > > This->Flags |= SFLAG_NONPOW2 > -- Nathan -- Nathan

2 3

Re: DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams March 31, 2007

March 31, 2007

My first patch! Sorry this took so long for such a simple patch, I have just been run off my feet until now. Before I submit this to wine-patches, is anyone able to do some further testing for me, to make sure it doesn't break any currently working games? This patch fixes a bug that causes a crash for direct draw games when using opengl as the DirectDrawRenderer. I wanted to make sure this works and is safe, before I venture into making it optimized as Stefan suggested. On 3/25/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > case WINED3DFMT_P8: > { > int height = This->glRect.bottom - This->glRect.top; <--!!! > type = GL_UNSIGNED_BYTE; > fmt = GL_RGBA; > > mem = HeapAlloc(GetProcessHeap(), 0, This->resource.size * sizeof(DWORD)); > if(!mem) { > ERR("Out of memory\n"); > return; > } > memory_allocated = TRUE; > d3dfmt_convert_surface(This->resource.allocatedMemory, > ... > > > I think the int height = This->glRect.bottom - This->glRect.top is the > problem. It should use This->currentDesc.Height instead. The opengl rectangle > is a helper for surfaces which are bigger than the max size supported by > opengl If they are used for 2D blits. For example swat3 creates a 3000x32 > surface to blit text in 32x32 rectangles. In this case only the needed area > is uploaded to gl and used for blits. > > Here the gl rectangle does not apply. For the sake of optimization you may > change the code to only convert the dirty rectangle instead of the whole > surface. > > -- Nathan

3 3

Excluding a Windows version from the tests
by Paul Vriens March 31, 2007

March 31, 2007

Hi, yesterday a patch of mine was committed to test more profile stuff from kernel32. When I have a look now at test.winehq.org I see that some test(s) crash on win98 but not on others. Although I could use a if(0) construction (as is done in several other tests), I'm wondering if we should just not run specific tests on specific Windows versions. It's a shame that one OS version blocks the running of several other tests. I have no idea yet how to achieve this without building in GetVersion style things, as logic and return values don't always make a good distinction. Any ideas, thoughts? Cheers, Paul.

5 11

Release notes
by John Voltz March 30, 2007

March 30, 2007

I have a question about the Wine release notes. Do the Wine developers work from bugzilla or do they usually just work on a specific application feature? Would it require too much extra effort on the release notes to associate a specific change with a bugzilla bug-fix or specific application/feature fix? I believe IMHO that this would make the release notes more relevant and useful to the end user. I never can tell what was actually fixed in a particular release because of the obscure developer notes. I've been lurking on the wine-devel list watching how development progresses, because at some point I would like to attempt joining in on the development effort. -- John Voltz

2 1

RE: [PATCH 13/18] XCOPY: Add support for /EXCLUDELIST:file1+file2 etc
by Ann & Jason Edmeades March 30, 2007

March 30, 2007

Further investigations shows the strstr bit is right, but the string I am comparing with differs from windows. I have fixed up xcopy's output display to mirror windows, and added that as a patch on the end of the resubmitted patchset, as it is not directly related to the strstr bit Regards, Jason

1 0

Jason Edmeades : xcopy: Add support for COPYCMD override and
by Ann & Jason Edmeades March 30, 2007

March 30, 2007

>wouldn't it be nicer to use sizeof(copyCmd) here? >if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { >There are many spots like this in wcmdmain.c Yes... I'm blaming cut and paste as I didn't do all the wcmd ones :-) Once I get all my xcopy patches in I want to continue my rework of the cmd commands, finishing off some more inbuilt ones which I know are broken. I also want to extend your last patch to ensure all parts which process a command line are using the MAXSTRING length, and I'll do a patch for this while I am at it. Thanks, Jason

1 0

[PATCH 18/18] XCOPY: Add help
by Ann & Jason Edmeades March 30, 2007

March 30, 2007

Er... I have just managed to get git send-email set up and working, and it would appear to be a feature of it. I do get one question which I answered n to, perhaps I should anser yes to it and see what happens :-) Anyone else using git send-email want to comment on how to avoid this? Thanks! Jason

1 0

Re: [PATCH 13/18] XCOPY: Add support for /EXCLUDELIST:file1+file2 etc
by Alexandre Julliard March 30, 2007

March 30, 2007

Jason Edmeades <us(a)edmeades.me.uk> writes: > + /* Loop through testing each exclude line */ > + while (pos) { > + if (wcsstr(copyFromUpper, pos->name) != NULL) { > + WINE_TRACE("Skipping file as matches exclude '%s'\n", > + wine_dbgstr_w(pos->name)); wcsstr() doesn't seem the right way to compare file names. You probably want to do a wcsicmp() of the end of the name or something like that. -- Alexandre Julliard julliard(a)winehq.org

2 1

ExtTextOut with rotation and MM_ANISOTROPIC inverted coordinates
by Carl-Daniel Hailfinger March 30, 2007

March 30, 2007

Hi, I have a problem with rotated Text displayed by ExtTextOut after SetMapMode(hdc, MM_ANISOTROPIC); SetWindowExtEx(hdc, 1000, -1000, NULL); Basically, giving one negative parameter to SetWindowExtEx should reverse the direction (clockwise/counterclockwise) in which rotation is done. It works in Windows, but has no effect in wine. The patch I created uses a side effect of the WMF file I had as test case, basically it sets lfClipPrecision = CLIP_LH_ANGLES and triggers direction inversion based on that instead of checking the WindowExtEx settings. That is of course wrong, but it is available almost everywhere in the text output paths and served me nicely as "inverse rotation" flag. Instead of abusing lfClipPrecision, what should we use? The SetWindowExtEx call sets some_matrix.eM11 to a negative value if its first argument is negative and eM22 to a negative value if its second argument is negative. So checking (eM11 * eM22 < 0) && (mapmode == MM_ANISOTROPIC) should be the correct solution. Problem: You can't always check these things because the dc is not available everywhere. In case you have a GdiFont, you can check (font->font_desc.matrix.eM11 * font->font_desc.matrix.eM22 < 0) or in case you have a LOGFONT (dc->xformWorld2Vport.eM11 * dc->xformWorld2Vport.eM22 < 0) I have not tested whether the parameters of the current dc, the parameters at the time CreateFontIndirect was run or the parameters at the time SelectObject(hdc, hfont) was run are responsible for the rotation inversion. What works? With the patch, lfClipPrecision = CLIP_LH_ANGLES has the effect SetWindowExtEx(hdc, positivevalue, negativevalue, NULL) should have. Exception: The text is clipped at the border, while Windows auto-extends the borders to avoid clipping. What doesn't work? SetWindowExtEx(hdc, positivevalue, negativevalue, NULL) still has no effect on the rotation angle. Attached are: create_mf.c: Testcase in C (thanks to Dmitry Timoshkov, who created the C code from a reduced WMF testcase I sent him) create_mf_generated.wmf: WMF file output by ./create_mf file.wmf wine-fontdirection-24.diff: Preliminary patch described above If somebody can take a look at the patch and mangle it so that it does the right thing, I'd be very grateful. Regards, Carl-Daniel -- http://www.hailfinger.org/ diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index ea2e66c..40d76c4 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1944,6 +1944,10 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index f7b1220..730725a 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2675,10 +2675,10 @@ GdiFont *WineEngCreateFontInstance(DC *d if (!GetObjectW( hfont, sizeof(lf), &lf )) return NULL; can_use_bitmap = GetDeviceCaps(dc->hSelf, TEXTCAPS) & TC_RA_ABLE; - TRACE("%s, h=%d, it=%d, weight=%d, PandF=%02x, charset=%d orient %d escapement %d\n", + TRACE("%s, h=%d, it=%d, weight=%d, PandF=%02x, charset=%d orient %d escapement %d clipprecision %d\n", debugstr_w(lf.lfFaceName), lf.lfHeight, lf.lfItalic, lf.lfWeight, lf.lfPitchAndFamily, lf.lfCharSet, lf.lfOrientation, - lf.lfEscapement); + lf.lfEscapement, lf.lfClipPrecision); /* check the cache first */ if((ret = find_in_cache(hfont, &lf, &dc->xformWorld2Vport, can_use_bitmap)) != NULL) { @@ -2946,6 +2946,10 @@ found: } ret->orientation = FT_IS_SCALABLE(ret->ft_face) ? lf.lfOrientation : 0; + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + ret->orientation = FT_IS_SCALABLE(ret->ft_face) ? 3600 - (lf.lfOrientation % 3600) : 0; + } ret->name = strdupW(family->FamilyName); ret->underline = lf.lfUnderline ? 0xff : 0; ret->strikeout = lf.lfStrikeOut ? 0xff : 0; diff --git a/dlls/gdi32/path.c b/dlls/gdi32/path.c index af756b3..bc326ab 100644 --- a/dlls/gdi32/path.c +++ b/dlls/gdi32/path.c @@ -1363,6 +1363,10 @@ BOOL PATH_ExtTextOut(DC *dc, INT x, INT { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; diff --git a/dlls/wineps.drv/font.c b/dlls/wineps.drv/font.c index 9e0ae39..7bfc53c 100644 --- a/dlls/wineps.drv/font.c +++ b/dlls/wineps.drv/font.c @@ -108,6 +108,10 @@ HFONT PSDRV_SelectFont( PSDRV_PDEVICE *p } physDev->font.escapement = lf.lfEscapement; + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + physDev->font.escapement = lf.lfEscapement ? 3600 - (lf.lfEscapement % 3600) : 0; + } physDev->font.set = FALSE; if(gdiFont && !subst) { diff --git a/dlls/wineps.drv/text.c b/dlls/wineps.drv/text.c index 59ac7c7..f6bd58c 100644 --- a/dlls/wineps.drv/text.c +++ b/dlls/wineps.drv/text.c @@ -105,6 +105,10 @@ static BOOL PSDRV_Text(PSDRV_PDEVICE *ph if(lf.lfEscapement != 0) { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; sinEsc = 0; diff --git a/dlls/winex11.drv/xfont.c b/dlls/winex11.drv/xfont.c index 60bd70d..3ecd3dc 100644 --- a/dlls/winex11.drv/xfont.c +++ b/dlls/winex11.drv/xfont.c @@ -944,6 +944,10 @@ static BOOL LFD_ComposeLFD( const fontOb if (fo->lf.lfEscapement) { /* escapement is in tenths of degrees, theta is in radians */ double theta = M_PI*fo->lf.lfEscapement/1800.; + if (fo->lf.lfClipPrecision & CLIP_LH_ANGLES) + { + theta = - theta; + } LFD_AngleMatrix(h_string, h, theta); } else diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index e03540e..76d4e04 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1136,6 +1136,10 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_P if(lf.lfEscapement != 0) { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; sinEsc = 0;

1 0

Cross-Library tests, tests using multiple processes
by Stefan Dösinger March 30, 2007

March 30, 2007

Hi, Screen resolution setting in DirectX games is still a huge mess. I want to fix it properly finally. Write tests to find out what really happens in windows, then implement it. Unfortunately that fails at the tests already. Our test framework is mainly limited to test single DLLs, and all tests I have been used to so far were in one single process. I would have to test what happens if there is one process requesting exclusive ddraw access and once process requesting explusive d3d9 access at once, and maybe a third process doing a screen resolution change, etc. Is there a way to write a test accross multiple libraries? I guess it is not hard to do, but it would look a bit bad if a ddraw test started using d3d9 directly. And is there a prefered way to spawn new processes and do communication between them? (Windows IPC I guess).

1 0

Re: Hardware cursor patch that does not break 'make test'.
by Stefan Dösinger March 30, 2007

March 30, 2007

Am Freitag 30 März 2007 16:36 schrieb Andrew Riedi: > Here is the patch, opps, forgot to attach. > > On 3/30/07, Andrew Riedi <andrewriedi(a)gmail.com> wrote: > > Here is an updated patch that does not break make test. Sorry about > > sending in a bad patch, I always saw that regular make would create stuff > > in /tests dir's and thought that tested stuff. :\ Anyhow, this one > > should be fine. > > > > changelog: wined3d: Add hardware cursor support. Wouldn't you have to restore the original cursor in device::release? In general this shouldn't matter because 99% of all applications will terminate after destroying the device, but I think we should take care of that. What happens to cursorInfo.hbmMask and cursorinfo.hbmcolor after CreateIconIndirect? Is it destroyed with the cursor, or does it leak after cursorInfo, which sits on the stack, is destroyed?

1 0