March 2007 - Wine-Devel - list.winehq.org

Accessing File > 4gb problem (was: Debugging Supreme Commander)
by Stephan Rose March 21, 2007

March 21, 2007

Allright, I've got the bug nailed to the wall with all of its 6 legs. What I don't know though is what to do about it. Still trying to find the right sledgehammer to squash it with.... Problem boils down to this: Supreme Commander has a .cab file that is just under 6 gigs in size. 0x178d42fce bytes to be exact Now here are the last 5 file seek positions in order from first to last: 0x0ff697fb4 0x0ff69800b 0x0ffebc19a 0x0ffebc1f0 All those succeed fine. But #5 ... 0x1007bc160 results in NTSTATUS c000000d, Invalid Parameter. That address is well within the range of the file though. The status occurs when lseek is called in this part of NtSetInformation, don't mind my added debug fixme's =) case FilePositionInformation: if (len >= sizeof(FILE_POSITION_INFORMATION)) { const FILE_POSITION_INFORMATION *info = ptr; unsigned int* iptr = (unsigned int*)&info->CurrentByteOffset.QuadPart; FIXME( "%i, 0x%08x%08x\n", fd, *(iptr+1), *iptr); if (lseek( fd, info->CurrentByteOffset.QuadPart, SEEK_SET ) == (off_t)-1) { FIXME("Bad result from lseek"); // Above fixme triggered past 4gb io->u.Status = FILE_GetNtStatus(); } } else io->u.Status = STATUS_INVALID_PARAMETER_3; break; I checked sizeof(off_t) and it correctly reports as 8-bytes, so I am not sure what the problem is and why this is happening. Any ideas? On a bright note...I almost have my Supreme Commander CD Key memorized now...how many people can say that!!! ;) Thanks, Stephan

1 0

Re: wine opinion of a user
by Nicholas van Rheede van Oudtshoorn March 21, 2007

March 21, 2007

I imagine the Australian version would do just as well. Here's a page where you can request a download demo: http://www.sagepastel.com.au/au/form_demodownload_request.html I'd do it myself here, but this account that I'm using today is only dialup. Nicholas

1 0

last year's email
by Bill Medland March 21, 2007

March 21, 2007

Is there something wrong with the list server? I am being bombarded with last year's emails. Bill Medland

5 6

Test framework for authentication testing
by Kai Blin March 21, 2007

March 21, 2007

Hi folks, while planning my work on Kerberos and Negotiate, I realized that we need a better way to test things like network authentication, the way we're doing it right now depends on the person running the tests to have a certain setup in the test environment, and e.g. the NTLM SSP tests use an undocumented windows feature to get some of the testing done. Now, a better way to do this would be to actually get some stubbed out user database set up, add a user for testing purposes, run the tests and then delete the test user. Sort of what the Samba project is doing for their smbtorture tests, if I understood those right. Of course this has to be done in a way that will also work on windows, or the tests will be useless. Now the question that's really bugging me is, is this possible at all? Does it make sense? What I'd want to do would be the following: * add a user * set the user password [... run the tests...] * delete the user Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 3

Re: wined3d: Check for float texture formats correctly.
by Dmitry Timoshkov March 21, 2007

March 21, 2007

"Vitaly Budovski" <vbudovski(a)gmail.com> wrote: > @@ -1662,6 +1662,20 @@ static HRESULT WINAPI IWineD3DImpl_Check > case WINED3DFMT_P8: > TRACE_(d3d_caps)("[OK]\n"); > return WINED3D_OK; > + case WINED3DFMT_R16F: > + case WINED3DFMT_A16B16G16R16F: > + if (!GL_SUPPORT(ARB_HALF_FLOAT_PIXEL)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } I realize that in the original chunk of code there is no a comment /* fall through */ either, but if it's really an intent please add it. > + case WINED3DFMT_R32F: > + case WINED3DFMT_A32B32G32R32F: > + if (!GL_SUPPORT(ARB_TEXTURE_FLOAT)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } > + TRACE_(d3d_caps)("[OK]\n"); > + return WINED3D_OK; -- Dmitry.

1 0

On bugs and docs
by Tom Spear March 21, 2007

March 21, 2007

Hi all, just some quick questions. Is it just me or has anyone else noticed that the documentation for wine is kind of scattered all over the place? I mean personally I can name about 8 different places (that are affiliated with winehq) that people can go to get information, not including the mailing lists. IMHO if it were even possible to consolidate all of the information, it would still take months to do, especially with people not knowing to post to the central location. Also, is it against the rules in bugzilla to try to organize the bugs some way? IOW The very old games metabug that I created (bug 1434).. I originally opened it not realizing that if every bug related to a game was attached the page would become overloaded. So I decided a year or two ago to close it. Then I recently realized how I could reorganize it and decided to reopen it, only to have it closed again by someone else who in not so many words told me that I was spamming the bug list and that I was annoying everyone. Basically my idea was to make several tasklists to link to 1434 (bugs like dinput9, d3d8, etc), and then link individual games to each of those, so that someone working on games, and in specific on dinput9 for example could easily find bugs related to dinput 9 without having to do a query. But now I am worried that I am overstepping my bounds by trying to do so. Does anyone _else_ object to this idea? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

5 12

Re: comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392)
by James Hawkins March 20, 2007

March 20, 2007

On 3/19/07, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > As can be seen in Spy++ and by the attached tests, CreateToolbarEx sends > TB_SETBITMAPSIZE twice instead of TB_SETBITMAPSIZE and TB_SETBUTTONSIZE. > ShellExViewer depends on this bug. The patch contains also some tests > and fixes for d[xy]Button <= 0. > > From c8a84900ae5d9ca7d77d443990e935b8c268bf4c Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 19 Mar 2007 10:40:53 +0100 > Subject: [PATCH] comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392) > > --- > dlls/comctl32/commctrl.c | 13 +++++++------ > dlls/comctl32/tests/toolbar.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/commctrl.c b/dlls/comctl32/commctrl.c > index c21cae3..7e44e03 100644 > --- a/dlls/comctl32/commctrl.c > +++ b/dlls/comctl32/commctrl.c > @@ -693,12 +693,13 @@ CreateToolbarEx (HWND hwnd, DWORD style, UINT wID, INT nBitmaps, > SendMessageW (hwndTB, TB_SETBITMAPSIZE, 0, > MAKELPARAM((WORD)dxBitmap, (WORD)dyBitmap)); > > - if (dxButton <= 0) > - dxButton = 24; > - if (dyButton <= 0) > - dyButton = 22; > - SendMessageW (hwndTB, TB_SETBUTTONSIZE, 0, > - MAKELPARAM((WORD)dxButton, (WORD)dyButton)); > + if (dxButton < 0) > + dxButton = dxBitmap; > + if (dyButton < 0) > + dyButton = dyBitmap; > + /* TB_SETBUTTONSIZE -> TB_SETBITMAPSIZE bug introduced for Windows compatibility */ > + if (dxButton != 0 && dyButton != 0) > + SendMessageW(hwndTB, TB_SETBITMAPSIZE, 0, MAKELPARAM(dxButton, dyButton)); > > > /* add bitmaps */ > diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c > index 164644e..b583295 100644 > --- a/dlls/comctl32/tests/toolbar.c > +++ b/dlls/comctl32/tests/toolbar.c > @@ -869,6 +869,45 @@ static void test_sizes(void) > DestroyWindow(hToolbar); > } > > + > +static void test_createtoolbarex() > +{ > + HWND hToolbar; > + TBBUTTON btns[3]; > + ZeroMemory(&btns, sizeof(btns)); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 20, 20, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 20, 20); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x1a001b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 4, 4, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(32, 4, 4); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xa000b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 0, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 12); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x120013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, -1, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 16, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0017, "%x"); > + DestroyWindow(hToolbar); > +} > + > + > START_TEST(toolbar) > { > WNDCLASSA wc; > @@ -899,6 +938,7 @@ START_TEST(toolbar) > test_add_string(); > test_hotitem(); > test_sizes(); > + test_createtoolbarex(); > > PostQuitMessage(0); > while(GetMessageA(&msg,0,0,0)) { > -- > 1.4.4.2 > If you're testing what message is sent, why not use the message sequence testing code? -- James Hawkins

2 1

Re: wine opinion of a user
by Ann & Jason Edmeades March 20, 2007

March 20, 2007

> Sage Line 50 already has a bug filed: > http://bugs.winehq.org/show_bug.cgi?id=2956 > but we're hampered because there's no free demo for us to test. > You could register for a free trial cd? http://www.sage.co.uk/considering/TryNow.aspx?tid=213114

1 0

WineCfg and DirectX options
by Michael Lothian March 20, 2007

March 20, 2007

Hi Has anyone thought about adding the directx options to the Graphics tab in WineCfg Just now I've been testing all the work been done on the graphics layer on different games so I've been switching on and off GLSL and changing backbuffer to fbo etc using regedit Would it not be better to change these things easily instead to allow for wider testing. PS With GLSL and FBO Tomb Raider Legent Opening Level Sequence the cliffs are black With all other options the watter effect is applied the the whole screen when any water is in the screen at all. Has anyone else noticed this. Also none of the menu writing shows up in FarCry but the game works a treat I'm now just waiting for mmstream to be implemented to I can see my video's on X3 Keep up all the good work your beating Transgaming hands down Mike PS the above reports were testing with 0.9.31, 0.9.32 and the latest git

8 9

Road to 1.0
by Dave Bialac March 20, 2007

March 20, 2007

Hi All I've been following the list for about a year now, just reading and learning. Through this process, I've come to wonder about the following question -- what should be the goal for Wine 1.0? I know a lot of development is focused around getting one particular application or another to work, especially from the folks over at Code Weavers, but with version numbers approaching 1.0, should there not be a set goal of functionality? My personal thought is that Wine should head in the direction of 100% compatibility with a particular version of Windows. Anything that ran on that version should run on Wine 1.0 with no problems. Any thoughts? Dave

3 2