March 2007 - Wine-Devel - list.winehq.org

Re: MikoÅ,aj Zalewski : user32: tests:Using DefWindowProcA with RegisterClassW works under Windows.
by Dmitry Timoshkov March 19, 2007

March 19, 2007

"Alexandre Julliard" <julliard(a)wine.codeweavers.com> wrote: > Author: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Sun Mar 18 13:02:04 2007 +0100 > > user32: tests: Using DefWindowProcA with RegisterClassW works under Windows. The test doesn't pass here under XP: class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:602: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class: 590 tests executed (0 marked as todo, 12 failures), 0 skipped. -- Dmitry.

2 1

Prompts on what to do next after an install
by Tom Spear March 19, 2007

March 19, 2007

I just came across another idea that might be nice, and would be trivial to accomplish After running ./configure the configure script tells you to run make depends && make After that, there is nothing telling you what to do.. Obviously most users can figure out to run make install, but it would be nice to have a prompt to say "Now it is time to install wine by running 'make install' as root" Then after that is complete, and this is where I always forget, a prompt to run wineprefixcreate and winecfg would be nice, because that seems to cause several duplicate and unnecessary bugs to be filed. Obviously the user should read documentation, but once you have read it you generally dont tend to read it again, and might forget something. I forget to run both wineprefixcreate and winecfg nearly every time I do a clean reinstall of wine because it isnt part of a normal build routine for most linux apps to have to do this.. I could write up patches for this but I'm taking off for the weekend and wont have access to my linux machine till monday morning, and also I dont know enough about automake and autoconf to be able to write that stuff in. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

Re: [ws2_32] in some cases send should block until the entire buffer is sent
by Alexandre Julliard March 19, 2007

March 19, 2007

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + } > + else > + skip("CreateThread failed, error %d\n", GetLastError()); > + closesocket(dst); > + } > + else > + skip("accept failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("connect failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("listen failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("getsockname failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("bind failed, error %d\n", WSAGetLastError()); > + closesocket(server); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); > + closesocket(src); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); This isn't an appropriate use of skip(), these things are not supposed to fail, and if they do something is broken. You should use ok() here. And please avoid the ugly nested ifs, use return or goto end. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: netapi32: Add test for adding/deleting users.
by Robert Shearman March 19, 2007

March 19, 2007

Kai Blin wrote: > + ret = pNetUserAdd(NULL, 1, (LPBYTE)&usri, NULL); > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to add users. Skipping test.\n"); > + return; > + } > + if(ret == NERR_UserExists) > + { > + skip("User already exists, skipping test to not mess up the system\n"); > + return; > + } > + > + ok(ret == NERR_Success, "Adding user failed with error 0x%08x\n", ret); > + if(ret != NERR_Success) > + { > + skip("As adding the user failed, skip the change password and userdel " > + "tests\n"); > + return; > + } > The skip here is pointless. The test failure will already signal that something unexpected happened. > + > + ret = pNetUserChangePassword(NULL, sTestUserName, sTestUserOldPass, > + sTestUserNewPass); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to change password, skipping test.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Changing the password failed.\n"); > + } > + > + ret = pNetUserDel(NULL, sTestUserName); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Failed to delete user. You need to manually delete the user.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Deleting the user failed.\n"); > + } > +} > I think it is reasonable to assume that if the user add the rights to add a user then they will have the rights to change the password and to delete it, so the skip statements seem unnecessary. -- Rob Shearman

1 0

GSoC Idea
by Cye Stoner March 19, 2007

March 19, 2007

Hello, My name is Cye Stoner. I was considering submitting the development of a WinePluginApi (as described at http://wiki.winehq.org/WinePluginApi) to Google's Summer of Code this year. I was also hoping that anybody able to mentor me on this project would contact me regarding the proposal, so that I can have a bit of an idea what I'd be getting myself into. mike at plan99.net submitted the idea in april of 2005, but I don't know if he would still be the one most useful in the area. Thank you for your time, Cye

2 1

Re: wined3d: Fix struct size calculation in EnumTextureFormats
by Stefan Dösinger March 19, 2007

March 19, 2007

Am Samstag 17 März 2007 23:22 schrieb A C Hurst: > Fixes the calculation of a struct size in > IDirect3DDeviceImpl_2_EnumTextureFormats, and fixes bug 7061. > > >>From 3f08264567229ff6a23b2cf311a18ee013c86152 Mon Sep 17 00:00:00 2001 > > From: ahurst <ahurst(a)hurstmachine.(none)> > Date: Sat, 17 Mar 2007 22:17:18 +0000 > Subject: Fis struct size calculation in EnumTextureFormats Looks OK to me :-)

3 2

more winetricks
by Dan Kegel March 19, 2007

March 19, 2007

For the record, I consider the need for winetricks a bug in wine. Someday we'll figure out how to make apps install properly without it. In the meantime, I've uploaded a new version to http://kegel.com/wine/winetricks And, as befits such an advanced tool, I'm keeping a revision history in the highly advanced "rcs" revision control system (that's a joke, btw). Here's the history so far: revision 1.4 date: 2007/03/19 00:54:01; author: dank; state: Exp; lines: +30 -3 Add mdac2.8. Echo a message when finished. Obey WINEPREFIXCREATE. ---------------------------- revision 1.3 date: 2007/03/19 00:44:03; author: dank; state: Exp; lines: +40 -20 Bring back and shorten wsh56 variants Make -q quieter Make default a bit chattier Override odbc32 and odbccp32 when installing mdac Make error checking advisory for now Avoid bash-specific "if foo; then" ---------------------------- revision 1.2 date: 2007/03/19 00:40:38; author: dank; state: Exp; lines: +33 -9 Added error checking, gdiplus -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Failure of Wine to quit when a program ends.
by gslink March 18, 2007

March 18, 2007

Recently my customer replaced her version of Wine with the current version. One of the programs running there, DeScribe, appears to quit normally but doesn't terminate. It continues to be in the background using no cpu time. To get rid of it requires killing the program with System Monitor as there is no evidence on the screen that the program is running. This appears to be a regression in Wine which has happened in the last nine months. Has anyone else had this happen with any other program? I am trying to track the exact problem and knowing that other programs behave this way would help.

1 0

Hey all!!
by Stephan Rose March 18, 2007

March 18, 2007

Ok guys, something's gotta change. I gotta stop logging into MS Sloth to play Supreme Commander ;) So that said, what can I do, where can I help? =) To give a little info on my background, I've been programming for roughly 10 years now...everything ranging from embedded & microcontroller stuff (PIC / ARM) to high end MS Sloth Applications. Familiar with DirectX, OpenGL, C/C++, C#, x86/ARM/PIC Assembly... I am of course unfamiliar with the whole wine source code. I did look over the rather daunting to-do list and wouldn't even know where to start. =) So I figured I'd send an e-mail out and see if anyone has any good suggestions. =) I'd really love to help with this. I for one think it's a great project and XP has really got to stop taking up one of my precious hard drives... Thanks =) Stephan Rose

3 2

Thanks everyone!
by Stephan Rose March 18, 2007

March 18, 2007

Thank you very much for your e-mails and suggestions everyone, I highly appreciate it. =) I am actually playing with debugging Supreme Commander right now a little bit and one thing popped into my eyes instantly. The problem that is occurring at the moment is that the installer won't even fully go through. So I am not even at the point of trying to install it yet. It'll go very far but near the end it will die with an error 87 from Install Shield. The very first thing that popped into my eyes though when running the installer was this: fixme:process:IsWow64Process (0xffffffff 0x34d90c) stub! That gets called literally hundreds of times. That makes seeing other error messages difficult for one as it just drowns them out and also slows the installer to a crawl. What I am wondering though is this, is running under Wow64 something that is ever actually going to happen within wine? Because if it's not, then the function actually already does everything it will ever need to do as far as I can tell by reading the documentation for it on MSDN.com For the time being, I commented the fixme line out in the code so that I can actually see other messages more easily and get to the failure point of the installer much quicker. Stephan

2 1