March 2007 - Wine-Devel - list.winehq.org

Re: FDI: Constify some variables
by James Hawkins March 16, 2007

March 16, 2007

On 3/15/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > Changelog: > FDI: Constify some variables. > > diff -urN a/dlls/cabinet/cabinet_main.c b/dlls/cabinet/cabinet_main.c > --- a/dlls/cabinet/cabinet_main.c 2007-03-15 17:31:18.000000000 +0000 > +++ b/dlls/cabinet/cabinet_main.c 2007-03-15 20:16:45.000000000 +0000 > @@ -86,7 +86,7 @@ > HeapFree(GetProcessHeap(), 0, memory); > } > > -static INT_PTR fdi_open(char *pszFile, int oflag, int pmode) > +static INT_PTR fdi_open(const char *pszFile, int oflag, int pmode) > { > HANDLE handle; > DWORD dwAccess = 0; > @@ -131,7 +131,7 @@ > return 0; > } > > -static UINT fdi_write(INT_PTR hf, void *pv, UINT cb) > +static UINT fdi_write(INT_PTR hf, const void *pv, UINT cb) > { > HANDLE handle = (HANDLE) hf; > DWORD dwWritten; > diff -urN a/dlls/msi/files.c b/dlls/msi/files.c > --- a/dlls/msi/files.c 2007-02-26 17:43:07.000000000 +0000 > +++ b/dlls/msi/files.c 2007-03-15 20:56:44.000000000 +0000 > @@ -161,7 +161,7 @@ > msi_free(pv); > } > > -static INT_PTR cabinet_open(char *pszFile, int oflag, int pmode) > +static INT_PTR cabinet_open(const char *pszFile, int oflag, int pmode) > { > HANDLE handle; > DWORD dwAccess = 0; > @@ -202,7 +202,7 @@ > return 0; > } > > -static UINT cabinet_write(INT_PTR hf, void *pv, UINT cb) > +static UINT cabinet_write(INT_PTR hf, const void *pv, UINT cb) > { > HANDLE handle = (HANDLE) hf; > DWORD dwWritten; > diff -urN a/dlls/setupapi/setupcab.c b/dlls/setupapi/setupcab.c > --- a/dlls/setupapi/setupcab.c 2006-11-10 17:26:30.000000000 +0000 > +++ b/dlls/setupapi/setupcab.c 2007-03-15 20:45:39.000000000 +0000 > @@ -113,7 +113,7 @@ > HeapFree(GetProcessHeap(), 0, pv); > } > > -static INT_PTR sc_cb_open(char *pszFile, int oflag, int pmode) > +static INT_PTR sc_cb_open(const char *pszFile, int oflag, int pmode) > { > DWORD creation = 0, sharing = 0; > int ioflag = 0; > @@ -204,7 +204,7 @@ > return num_read; > } > > -static UINT sc_cb_write(INT_PTR hf, void *pv, UINT cb) > +static UINT sc_cb_write(INT_PTR hf, const void *pv, UINT cb) > { > DWORD num_written; > /* BOOL rv; */ > diff -urN a/include/fdi.h b/include/fdi.h > --- a/include/fdi.h 2006-05-23 13:49:04.000000000 +0100 > +++ b/include/fdi.h 2007-03-15 19:53:38.000000000 +0000 > @@ -205,14 +205,14 @@ > typedef void (__cdecl *PFNFREE)(void *pv); > #define FNFREE(fn) void __cdecl fn(void *pv) > > -typedef INT_PTR (__cdecl *PFNOPEN) (char *pszFile, int oflag, int pmode); > -#define FNOPEN(fn) INT_PTR __cdecl fn(char *pszFile, int oflag, int pmode) > +typedef INT_PTR (__cdecl *PFNOPEN) (const char *pszFile, int oflag, int pmode); > +#define FNOPEN(fn) INT_PTR __cdecl fn(const char *pszFile, int oflag, int pmode) > > typedef UINT (__cdecl *PFNREAD) (INT_PTR hf, void *pv, UINT cb); > #define FNREAD(fn) UINT __cdecl fn(INT_PTR hf, void *pv, UINT cb) > > -typedef UINT (__cdecl *PFNWRITE)(INT_PTR hf, void *pv, UINT cb); > -#define FNWRITE(fn) UINT __cdecl fn(INT_PTR hf, void *pv, UINT cb) > +typedef UINT (__cdecl *PFNWRITE)(INT_PTR hf, const void *pv, UINT cb); > +#define FNWRITE(fn) UINT __cdecl fn(INT_PTR hf, const void *pv, UINT cb) > > typedef int (__cdecl *PFNCLOSE)(INT_PTR hf); > #define FNCLOSE(fn) int __cdecl fn(INT_PTR hf) > Are you checking with the SDK to make sure these changes are legit? This isn't how the Windows SDK fdi.h has these defined. -- James Hawkins

2 3

Benchmark quandary
by Tom Wickline March 16, 2007

March 16, 2007

Hello All, I have some benchmarks posted here: http://wiki.winehq.org/BenchMark-0.9.5 as well as here: http://wiki.winehq.org/BenchMark-0.9.6 And I have all the Graphics test in PCMark 04 running, but the app is crashing between test, but if I run them one at a time they will complete.. The quandary is would posting the test results from each test while not run as a whole but separately be of use? and would this be unfair when comparing the results against XP??? -- Tom Wickline Respectable computing - Linux/FOSS

1 0

Want to be a Wine mentor for Google Summer of Code 2007?
by Dan Kegel March 16, 2007

March 16, 2007

I'm looking for active Wine developers to act as mentors for Google Summer of Code 2007. If you're interested, please let me know quickly; the list has to be finalized in the next half-day or so. (Sorry for the late notice; I wasn't paying attention, and the deadline snuck up on me...) - Dan

8 8

Need help with SymInitializeW
by Kapila De Silva March 15, 2007

March 15, 2007

Hi All, Im trying to debug a crash in Everquest 2, (bug 7705) and am hoping someone here can help. The crash seems to be linked to the process calling SymInitializeW a second time (its called once at the start of the process, and works ok) On the second call to the function we see an error fixme:dbghelp:SymInitializeW what to do ?? By putting some tracing in here, I noticed that when the function is called the first time, the call to process_find_by_handle(hProcess) returns null, and once the SymInitializeW function calls EnumerateLoadedModules, process_find_by_handle returns a process id. In the second call, the process_find_by_handle(hProcess) returns the same process id as before, however, when the SymInitializeW function calls EnumerateLoadedModules, process_find_by_handle returns a different process id. Should SymInitializeW be called multiple times by a process? Is it possible that a problem has already occured, and this is called as a result? Or is it possible that SymInitializeW itself is the cause of the crash? Any ideas? Thanks Below is some trace I got when I put in some extra debug. First call: fixme:dbghelp:SymInitialize Calling SymInitializeW 0xffffffff(0xffffffff L"C:\\Program Files\\Sony\\EverQuest II" 1) fixme:dbghelp:process_find_by_handle Returning process handle (nil) fixme:dbghelp:process_find_by_handle Returning process handle 0x16c5d0 Second Call: fixme:dbghelp:SymInitialize Calling SymInitializeW 0xffffffff(0xffffffff (null) 1) fixme:dbghelp:process_find_by_handle Returning process handle 0x16c5d0 fixme:dbghelp:SymInitializeW what to do ?? fixme:dbghelp:process_find_by_handle Returning process handle 0x3a8f9a0

3 5

Bug with creating an attachment
by Tom Spear March 15, 2007

March 15, 2007

I am getting an error trying to create an attachment in bugzilla. If I paste it my email will come thru as html, but if I attach, it will be a picture attachment, neither of which are allowed.. Ill just type the error: Internal Error Bugzilla has suffered an internal error. Please save this page and send it to wine-bugs(a)winehq.org with the details of what you were doing at the time this message appeared. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

Defining COM interfaces without IDL
by Felix Nawothnig March 15, 2007

March 15, 2007

Hi. The PSDK headers sometimes use IDL to define an interface, sometimes it's done by hand (or rather using macros). I don't know if there is any reason for that (someone in the channel said it's just sloppiness by MS) - so, are there any resulting differences regarding source compatibility or can we just use IDL even if MS didn't? Felix

1 0

Bug with creating an attachment (take 2)
by Tom Spear March 15, 2007

March 15, 2007

I am getting an error trying to create an attachment in bugzilla. If I paste it my email will come thru as html, but if I attach, it will be a picture attachment, neither of which are allowed.. Ill just type the error: Internal Error Bugzilla has suffered an internal error. Please save this page and send it to wine-bugs(a)winehq.org with the details of what you were doing at the time this message appeared. URL: http://bugs.winehq.org/attachment.cgi undef error - Can't find param named product at Bugzilla/Config.pm line 124. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: user32: Restore erroneously removed chunk of code
by Alexandre Julliard March 15, 2007

March 15, 2007

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > one of my recent MDI patches has caused a regression in one of applications > I'm working on. This patch should fix it by restoring apparently erroneously > removed chunk of code. > > Changelog: > user32: Restore erroneously removed chunk of code. This breaks the tests: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:2836: Test failed: ShowWindow(SW_RESTORE):invisible MDI child: the msg sequence is not complete: expected 0046 - actual 0000 msg.c:2866: Test failed: ShowWindow(SW_RESTORE):maximized MDI child: the msg sequence is not complete: expected 0046 - actual 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Delayed debug patch
by Kapila De Silva March 15, 2007

March 15, 2007

Can someone tell me how to apply this to my git copy of wine please? This would help a lot with my debugging... Thanks Kapila

2 1

Re: Romanian Wine translation
by Michael Stefaniuc March 15, 2007

March 15, 2007

Hi, Mikołaj Zalewski wrote: > I've seen you have started the Romanian translation of wine. Could you > look on the page http://wiki.winehq.org/SublangNeutral and mark if > Romanian should use SUBLANG_NEUTRAL or sublang codes? I would have done that myself long ago but I do not know that. I'll use LANG_NEUTRAL as long as somebody more knowledgeable dosn't change it. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1