September 2007 - Wine-Devel

Re: [5/5] WineD3D: Add sincos support to arb shaders
by H. Verbeet Sept. 26, 2007

Sept. 26, 2007

On 26/09/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* dst.w = src[0].w * 1 / (src.x^2 + src.y^2 + src.z^2)^(1/2) according to msdn*/ That comment looks a bit out of place for sincos. Copy-paste from nrm?

1 0

Re: RICHED20: EM_SETCHARFORMAT must return 0, not assert, on invalid struct size (try 2)
by Alexandre Julliard Sept. 26, 2007

Sept. 26, 2007

a_villacis(a)palosanto.com writes: > I considered doing this at first, but ME_ToCF2W is used in three other > places beside handling EM_SETCHARFORMAT (all in style.c), and those places > might get a null-pointer exception instead of an assert if something went > wrong. A null-pointer exception serves the same purpose as an assert, and they both result in a debugger backtrace, so there's no reason to add more asserts here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Cannot compile wine due to recent changes
by Kirill K. Smirnov Sept. 26, 2007

Sept. 26, 2007

Hi, I got the following error message during compile fresh git-current wine: gcc -c -I../../../dlls/winex11.drv -I. -I../../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o x11drv_main.o ../../../dlls/winex11.drv/x11drv_main.c In file included from ../../../dlls/winex11.drv/x11drv_main.c:52: ../../../dlls/winex11.drv/xcomposite.h:40: error: `XCompositeGetOverlayWindow' undeclared here (not in a function) ../../../dlls/winex11.drv/xcomposite.h:40: warning: type defaults to `int' in declaration of `pXCompositeGetOverlayWindow' ../../../dlls/winex11.drv/xcomposite.h:41: error: `XCompositeReleaseOverlayWindow' undeclared here (not in a function) ../../../dlls/winex11.drv/xcomposite.h:41: warning: type defaults to `int' in declaration of `pXCompositeReleaseOverlayWindow' ../../../dlls/winex11.drv/x11drv_main.c:389: warning: type defaults to `int' in declaration of `pXCompositeGetOverlayWindow' ../../../dlls/winex11.drv/x11drv_main.c:390: warning: type defaults to `int' in declaration of `pXCompositeReleaseOverlayWindow' make[2]: *** [x11drv_main.o] Ошибка 1 make[2]: Leaving directory `/home/lich/wine/wine/build/dlls/winex11.drv' make[1]: *** [winex11.drv] Ошибка 2 make[1]: Leaving directory `/home/lich/wine/wine/build/dlls' make: *** [dlls] Ошибка 2 X is Xorg 6.9.0 -- Kirill

2 1

Re: services.exe[2/8]: load services list from registry
by Alexandre Julliard Sept. 26, 2007

Sept. 26, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > + buf = HeapAlloc(GetProcessHeap(), 0, size + 4); > + if ((err = RegQueryValueExW(hKey, szValue, 0, &type, (LPBYTE)buf, &size)) != 0) > + goto failed; > + buf[size/2] = 0; > + buf[size/2 + 1] = 0; Please use sizeof(WCHAR) instead of hardcoding values like 2 and 4. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] Make ntdll I/O function to generate completion events
by Alexandre Julliard Sept. 26, 2007

Sept. 26, 2007

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > This has to be done in client because server does not > know about actual operation details (e.g. io.Information), > and moreover some operations does not use server at all. The needed information can be sent to the server along with the normal async status. We shouldn't add yet another server call for this, async I/O already requires too many server roundtrips. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] Allow completion object to be attached to a fd object
by Alexandre Julliard Sept. 26, 2007

Sept. 26, 2007

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > +struct compl_map *create_completion_map( obj_handle_t handle, unsigned long completion_key ) > +{ > + struct completion *completion; > + struct compl_map *map; > + > + if ((completion = get_completion_obj( current->process, handle, IO_COMPLETION_MODIFY_STATE )) == NULL) > + return NULL; > + if ((map = mem_alloc( sizeof(*map) )) == NULL) > + { > + release_object( completion ); > + return NULL; > + } > + map->completion = completion; > + map->completion_key = completion_key; > + return map; > +} There doesn't seem to be a need for a separate compl_map type here, you could just as well store the completion object in the fd structure directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: services.exe/advapi32[5/8]: move QueryServiceConfig to services.exe
by Robert Shearman Sept. 26, 2007

Sept. 26, 2007

Mikolaj Zalewski wrote: > My QueryServiceConfig is not compatible with Windows one - I haven't > tried hard but I couldn't tune the parameters to connect with Windows > services.exe. So I'm not trying to store the structure in the on the > server side buffer but pass it all through the RPC and put in into the > buffer in advapi32. As I understand in near future Wine will not be a > member of Windows domains so on-the-wire compatibility is not very > important. > You don't need to be a member of a domain to use remote interfaces like the one for services or the one for the registry. On-the-wire compatibility will be important once we get remote named pipe support, but getting the right architecture is the goal at the moment, and your patches are a step towards that. I believe that the QUERY_SERVICE_CONFIGW parameter should be a byte_count one, but this is not implemented yet, both in the RPC runtime and in widl. -- Rob Shearman

1 0

Re: RICHED20: EM_SETCHARFORMAT must return 0, not assert, on invalid struct size
by Alexandre Julliard Sept. 26, 2007

Sept. 26, 2007

a_villacis(a)palosanto.com writes: > Changelog: > * EM_SETCHARFORMAT must not assert on invalid structure size. Instead, it > should just fail and return 0. It would be better to do that in ME_ToCF2W since it already has to check the size, simply make it return NULL on error or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: pdh: add tests for XP variant of api call
by Hans Leidekker Sept. 26, 2007

Sept. 26, 2007

On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > This patch adds the variations to the api that XP implements. My > assumption is that these changes will, mostly, be reflected in 2003 and > Vista. I can't check them so if someone could give them a run and let > know, that would be fine. I will get on with adding the variations to pdh.c All tests succeed here on 2003 without your patch. Even if APIs return different values on different versions of Windows we should not add version checks. Instead we should accept all possible return values or remove the test altogether when it's clear that you cannot depend on specific return values. -Hans

2 5

Recent BiDi changes
by Shachar Shemesh Sept. 26, 2007

Sept. 26, 2007

Hi Maarten, Can you, please, explain the advantage of creating our own implementation of the BiDi algorithm over using existing implementations? I know ICU sucks (especially as far as linkage is concerned), but there are other implementations, major among which is fribidi, which are free, are C based, and have a compatible license. Is there any need to Wine to be aware of the inside working of the algorithm? Also, so long as you are picking up the BiDi glove I dropped oh so many years ago, it seems to me that the proper place to implement BiDi would be in unscribe, where it is for Windows. The GDI implementation Wine has is a hack that reached it's useful end the moment you realize that DrawText needs its own implementation, independent of ExtTextOut (mostly due to line breaking code). Thanks, Shachar

3 6