September 2007 - Wine-Devel

Re: [1/5] winex11: Load the XComposite extension when available
by Vitaliy Margolen Sept. 23, 2007

Sept. 23, 2007

Chris Robinson wrote: > A set of patches to replace the scissors hack with offscreen rendering and > compositing. Step one, look for and load the XComposite extension libs. > > ------------------------------------------------------------------------ > > +int usexcomposite = 1; It should be off by default until users will have enough time to test if it's working properly. Vitaliy.

2 1

Re: shdocvw: Added WebBrowser::FullScreen property implementation.
by Reece Dunn Sept. 23, 2007

Sept. 23, 2007

On 23/09/2007, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/shdocvw/shdocvw.h | 1 + > dlls/shdocvw/tests/webbrowser.c | 23 +++++++++++++++++++++++ > dlls/shdocvw/webbrowser.c | 15 +++++++++++---- > 3 files changed, 35 insertions(+), 4 deletions(-) > + hres = IWebBrowser2_get_FullScreen(wb, &b); > + ok(hres == S_OK, "get_FullScreen failed: %08x\n", hres); > + ok(b == VARIANT_TRUE, "b=%x\n", b); > + > + hres = IWebBrowser2_put_FullScreen(wb, VARIANT_FALSE); > + ok(hres == S_OK, "put_FullScreen failed: %08x\n", hres); > + > IWebBrowser2_Release(wb); This last call to put_FullScreen is missing a get_FullScreen check. Everything else looks ok. - Reece

1 0

Re: [OT] Freemail Terms Of Use [was: Wine autorunner]
by Reece Dunn Sept. 23, 2007

Sept. 23, 2007

On 23/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Sonntag, 23. September 2007 01:42:46 schrieb Computer Dude: > _________________________________________________________________ > > Connect to the next generation of MSN Messenger > > http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source= > >wlmailtagline > This is OT regarding this patch, but most people use freemailers, including > hotmail / msn. Some service providers tried to establish some > all-your-copyright-belong-to-us terms of service. Should we take care about > that in any way? Either by making sure that patches aren't sent from such > services, or to make sure that such conditions do not hold up in court? > > I am using gmx myself, and I haven't checked the TOS for changes since years, > and I only gave them a 5 secound look when signing up, so I should start with > checking that myself(I send most patches from my CW address though) Reading the current GoogleMail terms of usage, there is this: "Your Intellectual Property Rights. Google does not claim any ownership in any of the content, including any text, data, information, images, photographs, music, sound, video, or other material, that you upload, transmit or store in your Google Mail account. We will not use any of your content for any purpose except to provide you with the Service." so there is no problem there. Also, the hotmail legal statement has this: "8. Your Materials. You may be able to submit materials for use in connection with the service. Except for material that we license to you, we do not claim ownership of the materials you post or otherwise provide to us related to the service (called a "submission"). However, by posting or otherwise providing your submission, you are granting to the public free permission to: * use, copy, distribute, display, publish and modify your submission, each in connection with the service; * publish your name in connection with your submission; and * grant these permissions to other persons. This section only applies to legally permissible content and only to the extent that use and publishing of the legally permissible content does not breach the law. We will not pay you for your submission. We may refuse to publish, and may remove your submission from the service at any time. For every submission you make, you must have all rights necessary for you to grant the permissions in this section." So you should also be fine there as well, although I do find it interesting that according to this (if I have read it correctly), anything that you send via hotmail is freely usable by the public! - Reece

1 0

Re: Wine autorunner
by Stefan Dösinger Sept. 23, 2007

Sept. 23, 2007

Am Sonntag, 23. September 2007 01:42:46 schrieb Computer Dude: > Attached is the git patch for a utility to perform simple parsing of > Windows autorun.inf files, and to run the associated programs under WINE. > It will auto-detect the CD drive if not specified on the command line, > auto-detect the mount point, and attempt to mount it if it i not already > mounted. Shouldn't this be implemented in the gnome / kde autorun support? Perhaps in the form of registering a new autorun "mimetype" which tells gnome/kde about autorun.inf files, and how to use them? _________________________________________________________________ > Connect to the next generation of MSN Messenger > http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source= >wlmailtagline This is OT regarding this patch, but most people use freemailers, including hotmail / msn. Some service providers tried to establish some all-your-copyright-belong-to-us terms of service. Should we take care about that in any way? Either by making sure that patches aren't sent from such services, or to make sure that such conditions do not hold up in court? I am using gmx myself, and I haven't checked the TOS for changes since years, and I only gave them a 5 secound look when signing up, so I should start with checking that myself(I send most patches from my CW address though)

2 1

Re: Wine autorunner
by Kai Blin Sept. 23, 2007

Sept. 23, 2007

On Sunday 23 September 2007 01:42:46 Computer Dude wrote: > Attached is the git patch for a utility to perform simple parsing of > Windows autorun.inf files, and to run the associated programs under WINE. You need to provide your real name for your patch to be considered at all. Wine will not accept anonymous patches. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

WM_CHAR of Ctrl-C, Ctrl-V appear to have no effect in WinXP-SP2 riched20 control
by a_villacis＠palosanto.com Sept. 23, 2007

Sept. 23, 2007

I am trying to fix a few tests for riched20 that attempt to recover the text from the control with WM_GETTEXT and assume the text will be recovered unchanged. As demostrated in a patch I sent a few minutes ago, this assumption is not true when the text to recover contains unbalanced \r, which are converted to \r\n. However I have a strange problem. On my setup (WinXP-SP2 with cygwin), sending Ctrl-C and Ctrl-V with WM_CHAR appears to have no effect on the riched20 control used for the tests. Therefore the text buffer is not modified and the end text remains unchanged. I want to check whether this tests fails in the same way for anybody else, and if not, to receive suggestions on what might be wrong with my setup.

1 0

Re: wine.inf: add some four keys in Active Setup\Installed Components [resend]
by Robert Shearman Sept. 23, 2007

Sept. 23, 2007

Mikolaj Zalewski wrote: > +; Some apps wants at least four keys in Installed Components to run correctly > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{a2f95861-06e5-4e58-ab61-94cbdde2ff55},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{c30a0529-fcef-4b19-8e68-9527b54474ac},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{d0b883e4-af5a-45c9-bd44-deb9867c1d94},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{e84bb5b4-7fe1-469c-9f24-5a2af3402108},Version,2,"1,0,0,0" You might want to find four real components always present on Windows to add to this key. -- Rob Shearman

2 1

WineD3D patch submission
by Mitchell Wheeler Sept. 22, 2007

Sept. 22, 2007

Hi all, A week or so ago I tried to get a game working in WINE (Titan Quest), however it seems it really needs a proper DIB engine before it'll be playable. Anyways, in my attempt to get it working I fixed up some issues w/ "IWineD3DDeviceImpl_UpdateSurface.c" in dlls/wined3d, not entirely sure how you guys do things around here so I thought i'd just post my changes to the function in this mailing list and you can do with it what you want. (Note: it actually has a few different methods of doing one thing, enclosed in macro blocks to toggle between them. Technically the first one should work (i think :\) once you guys properly implement surface locking/unlocking, and it's 'simplest', but the last one is the only one that actually works properly (using standard OpenGL calls). You'll probably have to clean up the code to meet your coding standards / etc, maybe remove the custom byte size calculation of compressed images, and some other things - but the functionality is there... i also fixed the existing code that didn't actually do what it was supposed to, heh. Regards, Mitchell Wheeler static HRESULT WINAPI IWineD3DDeviceImpl_UpdateSurface(IWineD3DDevice *iface, IWineD3DSurface *pSourceSurface, CONST RECT* pSourceRect, IWineD3DSurface *pDestinationSurface, CONST POINT* pDestPoint) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; /** TODO: remove casts to IWineD3DSurfaceImpl * NOTE: move code to surface to accomplish this ****************************************/ IWineD3DSurfaceImpl *pSrcSurface = (IWineD3DSurfaceImpl *)pSourceSurface; IWineD3DSurfaceImpl *pDestSurface = (IWineD3DSurfaceImpl*)pDestinationSurface; int srcWidth, srcHeight; unsigned int srcSurfaceWidth, srcSurfaceHeight, destSurfaceWidth, destSurfaceHeight; WINED3DFORMAT destFormat, srcFormat; int srcLeft, srcTop, destLeft, destTop; WINED3DPOOL srcPool, destPool; int offset = 0; int rowoffset = 0; /* how many bytes to add onto the end of a row to wraparound to the beginning of the next */ glDescriptor *glDescription = NULL, *glSrcDescription = NULL; GLenum dummy; int bpp; UINT destByteSize = 0, srcByteSize = 0; int destPixelByteSize = 0, srcPixelByteSize = 0; CONVERT_TYPES convert = NO_CONVERSION; WINED3DSURFACE_DESC winedesc; TRACE("(%p) : Source (%p) Rect (%p) Destination (%p) Point(%p)\n", This, pSourceSurface, pSourceRect, pDestinationSurface, pDestPoint); memset(&winedesc, 0, sizeof(winedesc)); winedesc.Width = &srcSurfaceWidth; winedesc.Height = &srcSurfaceHeight; winedesc.Pool = &srcPool; winedesc.Format = &srcFormat; winedesc.Size = &srcByteSize; IWineD3DSurface_GetDesc(pSourceSurface, &winedesc); winedesc.Width = &destSurfaceWidth; winedesc.Height = &destSurfaceHeight; winedesc.Pool = &destPool; winedesc.Format = &destFormat; winedesc.Size = &destByteSize; IWineD3DSurface_GetDesc(pDestinationSurface, &winedesc); if(srcPool != WINED3DPOOL_SYSTEMMEM || destPool != WINED3DPOOL_DEFAULT){ WARN("source %p must be SYSTEMMEM and dest %p must be DEFAULT, returning WINED3DERR_INVALIDCALL\n", pSourceSurface, pDestinationSurface); return WINED3DERR_INVALIDCALL; } /* This call loads the opengl surface directly, instead of copying the surface to the * destination's sysmem copy. If surface conversion is needed, use BltFast instead to * copy in sysmem and use regular surface loading. */ d3dfmt_get_conv((IWineD3DSurfaceImpl *) pDestinationSurface, FALSE, TRUE, &dummy, &dummy, &dummy, &convert, &bpp, FALSE); if(convert != NO_CONVERSION) { return IWineD3DSurface_BltFast(pDestinationSurface, pDestPoint ? pDestPoint->x : 0, pDestPoint ? pDestPoint->y : 0, pSourceSurface, (RECT *) pSourceRect, 0); } if (destFormat == WINED3DFMT_UNKNOWN) { TRACE("(%p) : Converting destination surface from WINED3DFMT_UNKNOWN to the source format\n", This); IWineD3DSurface_SetFormat(pDestinationSurface, srcFormat); /* Get the update surface description */ IWineD3DSurface_GetDesc(pDestinationSurface, &winedesc); } ActivateContext(This, This->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); ENTER_GL(); if (GL_SUPPORT(ARB_MULTITEXTURE)) { GL_EXTCALL(glActiveTextureARB(GL_TEXTURE0_ARB)); checkGLcall("glActiveTextureARB"); } /* Make sure the surface is loaded and up to date */ IWineD3DSurface_PreLoad(pDestinationSurface); IWineD3DSurface_GetGlDesc(pDestinationSurface, &glDescription); IWineD3DSurface_GetGlDesc(pDestinationSurface, &glSrcDescription); /* this needs to be done in lines if the sourceRect != the sourceWidth */ srcWidth = pSourceRect ? pSourceRect->right - pSourceRect->left : srcSurfaceWidth; srcHeight = pSourceRect ? pSourceRect->bottom - pSourceRect->top : srcSurfaceHeight; srcLeft = pSourceRect ? pSourceRect->left : 0; srcTop = pSourceRect ? pSourceRect->top : 0; destLeft = pDestPoint ? pDestPoint->x : 0; destTop = pDestPoint ? pDestPoint->y : 0; // Calculate the rowOffset / offset values, for copying #define ISDXTFORMAT(format) \ (format == WINED3DFMT_DXT1 || format == WINED3DFMT_DXT2 || format == WINED3DFMT_DXT3 || format == WINED3DFMT_DXT4 || format == WINED3DFMT_DXT5) // Calculating this for our selves because I don't have faith in how surface->bytesPerPixel is calculated... destPixelByteSize = destByteSize / (int)(destSurfaceWidth * destSurfaceHeight); srcPixelByteSize = srcByteSize / (int)(srcSurfaceWidth * srcSurfaceHeight); if(pSourceRect != NULL) { // Irregular surface formats if (destFormat != srcFormat) { FIXME("Can not convert between surface pixel formats..."); // Would require some relatively big code restructuring for rare occurances (that shouldn't even be supported?) return WINED3DERR_INVALIDCALL; } // Uniform surface formats else { if(srcWidth != srcSurfaceWidth || srcLeft > 0) { rowoffset = srcSurfaceWidth * srcPixelByteSize; offset += (srcLeft * srcPixelByteSize); } if(srcTop > 0) offset += srcTop * srcSurfaceWidth * srcPixelByteSize; } } /* Sanity check */ if (IWineD3DSurface_GetData(pSourceSurface) == NULL) { /* need to lock the surface to get the data */ FIXME("Surfaces has no allocated memory, but should be an in memory only surface\n"); } /* TODO: Cube and volume support */ if(rowoffset != 0) { // Compressed texture if (ISDXTFORMAT(destFormat)) { if (GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { #if 0 RECT rect; rect.left = destLeft; rect.top = destTop; rect.right = destLeft + srcWidth; rect.bottom = destTop + srcHeight; // Lock source/destination regions WINED3DLOCKED_RECT destRect, srcRect; printf("Locking surfaces...\n"); if( FAILED(IWineD3DSurface_LockRect(pDestinationSurface, &destRect, &rect, 0)) || FAILED(IWineD3DSurface_LockRect(pSourceSurface, &srcRect, pSourceRect, WINED3DLOCK_READONLY))) { // How should we handle this case? Just returning an invalid call for now... return WINED3DERR_INVALIDCALL; } printf("Surfaces locked, copying contents now... "); if(destFormat == WINED3DFMT_DXT1) { printf("DXT1\n"); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 2)); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 2)); memcpy(destRect.pBits, srcRect.pBits, ceil(srcWidth/4) * ceil(srcHeight/4) * 8); } else { printf("DXT2-5\n"); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 4)); memcpy(destRect.pBits, srcRect.pBits, ceil(srcWidth/4) * ceil(srcHeight/4) * 16); } // Unlock source/destination regions IWineD3DSurface_UnlockRect(pSourceSurface); IWineD3DSurface_UnlockRect(pDestinationSurface); printf("Unlocking surfaces...\n"); #elif 0 // Get pointers to the source/destination buffers unsigned char *dest_data = (unsigned char*)IWineD3DSurface_GetData(pDestinationSurface); const unsigned char *src_data = (unsigned char*)IWineD3DSurface_GetData(pSourceSurface); // Copy subsection of source buffer, in to destination buffer. unsigned char *dest_ptr = dest_data + offset; const unsigned char *src_ptr = src_data + offset; size_t i; for(i = 0; i < srcHeight; ++i) { memcpy(dest_ptr, src_ptr, srcWidth * srcPixelByteSize); dest_ptr += rowoffset; src_ptr += rowoffset; } // Upload destination buffer to server GL_EXTCALL(glCompressedTexImage2DARB(glDescription->target, glDescription->level, glDescription->glFormatInternal, srcWidth, srcHeight, 0, destByteSize, dest_data)); checkGLcall("glCompressedTexImage2DARB"); #elif 1 int blocksize = 16; if(destFormat == WINED3DFMT_DXT1) blocksize = 8; #define max(a, b) (a > b? a : b) srcHeight = max(srcHeight, 4); srcWidth = max(srcWidth, 4); #undef max int data_size = (srcWidth / 4) * (srcHeight / 4) * blocksize; int row_size = data_size / srcHeight; int pixel_size = row_size / srcWidth; int stride = srcSurfaceWidth * pixel_size; unsigned char *temp_buffer = HeapAlloc(GetProcessHeap(), 0, data_size); unsigned char *temp_ptr = temp_buffer; // Debug info //printf(" > BytesTotal: %i | BytesPerPixel: %i | RowSize: %i\n", data_size, pixel_size, row_size); //printf(" > Source: %i -> %i, %i -> %i | Dest: %i, %i\n", srcLeft, srcWidth, srcTop, srcHeight, destLeft, destTop); //printf(" > Offset: %i\n", (int)((row_size * srcTop) + srcLeft * pixel_size)); // Get pointers to the source buffer const unsigned char *src_data = (unsigned char*)IWineD3DSurface_GetData(pSourceSurface); src_data += (stride * srcTop) + srcLeft * pixel_size; size_t i; for(i = 0; i < srcHeight; ++i) { memcpy(temp_ptr, src_data, row_size); temp_ptr += row_size; src_data += stride; } GL_EXTCALL(glCompressedTexSubImage2DARB( glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormatInternal, data_size, temp_buffer )); //checkGLcall("glCompressedTexSubImage2DARB"); HeapFree(GetProcessHeap(), 0, temp_buffer); #endif } else { FIXME("TODO: Need to update a DXT compressed texture without hardware support\n"); } } // Uncompressed texture else { /* not a whole row so we have to do it a line at a time */ int j; /* hopefully using pointer addtion will be quicker than using a point + j * rowoffset */ const unsigned char* data =((const unsigned char *)IWineD3DSurface_GetData(pSourceSurface)) + offset; for(j = destTop; j < (srcHeight + destTop); ++j) { glTexSubImage2D(glDescription->target ,glDescription->level ,destLeft ,j ,srcWidth ,1 ,glDescription->glFormat ,glDescription->glType ,data /* could be quicker using */ ); data += rowoffset; } } } else { // Compressed texture if (ISDXTFORMAT(destFormat)) { if (GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { int blocksize = 16; if(destFormat == WINED3DFMT_DXT1) blocksize = 8; #define max(a, b) (a > b? a : b) int data_size = (max(srcWidth, 4) / 4) * (max(srcHeight, 4) / 4) * blocksize; #undef max //printf(" -> S = %i | CompressedTexImage2D(?, %i, %i, %i, %i, 0, %i, ?)\n", destByteSize, glDescription->level, glDescription->glFormatInternal, srcWidth, srcHeight, data_size); GL_EXTCALL(glCompressedTexSubImage2DARB(glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormatInternal, data_size, IWineD3DSurface_GetData(pSourceSurface))); checkGLcall("glCompressedTexImage2DARB"); } else { FIXME("TODO: Need to update a DXT compressed texture without hardware support\n"); } } // Uncompressed Texture else { glTexSubImage2D( glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormat, glDescription->glType, IWineD3DSurface_GetData(pSourceSurface) ); checkGLcall("glTexSubImage2D"); } } LEAVE_GL(); ((IWineD3DSurfaceImpl *)pDestinationSurface)->Flags &= ~SFLAG_INSYSMEM; ((IWineD3DSurfaceImpl *)pDestinationSurface)->Flags |= SFLAG_INTEXTURE; IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SAMPLER(0)); return WINED3D_OK; }

5 7

Re: Minimal Background Intelligent Transfer Service (bits) implementation
by Michael Stefaniuc Sept. 22, 2007

Sept. 22, 2007

Hello Roy, Roy wrote: > This patch provides a first skeleton version of bits.dll. thanks for the patch but could you please add also a DLL_WINE_PREATTACH case in DllMain()? That way Wine can prefer to load a native bits DLL (if one is available) until the Wine one gets usable. See for example the mscoree DLL for an example (dlls/mscoree/mscoree_main.c). thanks bye michael > From 95f4728e706861f201fb2b399e7ca5db128e71b3 Mon Sep 17 00:00:00 2001 > From: Roy Shea <roy(a)cs.ucla.edu> > Date: Tue, 18 Sep 2007 14:29:14 -0700 > Subject: Minimal Background Intelligent Transfer Service (bits) implementation > > --- > dlls/bits/Makefile.in | 16 ++++++++++++++++ > dlls/bits/bits.spec | 4 ++++ > dlls/bits/bits_main.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 63 insertions(+), 0 deletions(-) > create mode 100644 dlls/bits/Makefile.in > create mode 100644 dlls/bits/bits.spec > create mode 100644 dlls/bits/bits_main.c > > diff --git a/dlls/bits/Makefile.in b/dlls/bits/Makefile.in > new file mode 100644 > index 0000000..2c9e293 > --- /dev/null > +++ b/dlls/bits/Makefile.in > @@ -0,0 +1,16 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = bits.dll > +IMPORTS = kernel32 > +EXTRALIBS = > + > +C_SRCS = \ > + bits_main.c > + > +#RC_SRCS = version.rc > + > +(a)MAKE_DLL_RULES@ > + > +(a)DEPENDENCIES@ # everything below this line is overwritten by make depend > diff --git a/dlls/bits/bits.spec b/dlls/bits/bits.spec > new file mode 100644 > index 0000000..c5fc87a > --- /dev/null > +++ b/dlls/bits/bits.spec > @@ -0,0 +1,4 @@ > +@ stub DllCanUnloadNow > +@ stub DllGetClassObject > +@ stub DllRegisterServer > +@ stub DllUnregisterServer > diff --git a/dlls/bits/bits_main.c b/dlls/bits/bits_main.c > new file mode 100644 > index 0000000..37be887 > --- /dev/null > +++ b/dlls/bits/bits_main.c > @@ -0,0 +1,43 @@ > +/* > + * Implementation of bits.dll > + * Background Intelligent Transfer Service (bits) interface > + * > + * Copyright 2007 Google (Roy Shea) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL( bits ); > + > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + DisableThreadLibraryCalls(hinstDLL); > + break; > + case DLL_PROCESS_DETACH: > + break; > + } > + > + return TRUE; > +} > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

3 2

Re: services.exe[3/3]: start a local RPC server [fixed]
by Robert Shearman Sept. 22, 2007

Sept. 22, 2007

Mikolaj Zalewski wrote: > diff --git a/dlls/advapi32/Makefile.in b/dlls/advapi32/Makefile.in > index 8f6fe33..85e9680 100644 > --- a/dlls/advapi32/Makefile.in > +++ b/dlls/advapi32/Makefile.in > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = advapi32.dll > IMPORTLIB = libadvapi32.$(IMPLIBEXT) > -IMPORTS = kernel32 ntdll > +IMPORTS = rpcrt4 kernel32 ntdll I think you should make rpcrt4 a DELAYIMPORT since it should only be needed for program that use services. Also, you have added one or two header files that don't have a copyright and LGPL statement at the top, which should probably be fixed before the final version (the exception is the one-line files to make the generated files appear in the right place). -- Rob Shearman

1 0